monban 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c994797ca1338ca8d78bb15bdfeaa5585bdf555a
-  data.tar.gz: 0ae31c41b9a1b9b08e8888a354d440051ed30eef
+  metadata.gz: 61a099fb20745246c9094ac5c9957119180cb452
+  data.tar.gz: 4f8aec070188cccfcb27c51692e2942dd67fafe6
 SHA512:
-  metadata.gz: 3d4db22086b7359a92202a55cb033f5255434146e214d655974db3ae8d4b039232188bbfc41f715eb6ce040c80c02b55295b51dc2799c6ffe77f76a4ad51ffa7
-  data.tar.gz: ccd82bf884f619b75f15b0fd4a3d91248f600d0d3aa660964c6a565a20623cf8e868eac62ac91a8bde5caae667d54693f0e11f1e2494fc3c6c49311bc8f92302
+  metadata.gz: 809a7eec54aa4327fd7c383088cd2a1a91cc53a4cc96eda43917f070a55c1b41986dce8bd58e7a6f3e0feefb42f25b119f31bf819ce4f07618693e536f0904f6
+  data.tar.gz: e7fc64a1393b18b6525962004143c3c82978c41fb4f0712c36186fccccb4da2675ec7db31a289742e33cef7ea1754c747e5ac9b9dcd26753f46dc0a78dbacc3d

data/NEWS.rdoc

@@ -1,3 +1,7 @@
+== 1.0.1
+* Wrap helper_method calls in respond_to?(:helper_method)
+* param_transformations now correctly use string keys
+
 == 1.0.0
 * Do not perform lookup if no params are passed to lookup
 * Add param transformer for sanitizing and normalizing

data/lib/monban.rb

@@ -55,6 +55,17 @@ module Monban
     config.hashing_method.call(token)
   end
 
+
+  # performs transformations on params for signing up and
+  # signing in
+  #
+  # @param params [Hash] hash of parameters to transform
+  # @see Monban::Configuration#param_transofmrations
+  # @return [Hash] hash with transformed parameters
+  def self.transform_params(params)
+    ParamTransformer.new(params, config.param_transformations).to_h
+  end
+
   # the user class
   #
   # @see Monban::Configuration#setup_class_defaults

data/lib/monban/configuration.rb

@@ -30,7 +30,7 @@ module Monban
     # @see #creation_method=
     def default_creation_method
       ->(params) do
-        updated_params = transform_params(params)
+        updated_params = Monban.transform_params(params)
         Monban.config.user_class.create(updated_params)
       end
     end
@@ -54,7 +54,7 @@ module Monban
     # @see Monban.config.user_class
     def default_find_method
       ->(params) do
-        updated_params = transform_params(params)
+        updated_params = Monban.transform_params(params)
         Monban.config.user_class.find_by(updated_params)
       end
     end
@@ -134,12 +134,8 @@ module Monban
 
     def setup_param_transformations
       @param_transformations = {
-        email: ->(value) { value.downcase }
+        "email" => ->(value) { value.downcase }
       }
     end
-
-    def transform_params(params)
-      ParamTransformer.new(params, param_transformations).to_h
-    end
   end
 end

data/lib/monban/controller_helpers.rb

@@ -7,7 +7,9 @@ module Monban
   module ControllerHelpers
     extend ActiveSupport::Concern
     included do
-      helper_method :current_user, :signed_in?
+      if respond_to?(:helper_method)
+        helper_method :current_user, :signed_in?
+      end
     end
 
     # Sign in a user
@@ -98,9 +100,9 @@ module Monban
 
     def authenticate_session session_params, field_map = nil
       token_field = Monban.config.user_token_field
-      session_params_hash = session_params.to_h.symbolize_keys
-      password = session_params_hash.fetch(token_field)
-      user = Monban.lookup(session_params_hash.except(token_field), field_map)
+      params_hash = Monban.transform_params(session_params).symbolize_keys
+      password = params_hash.fetch(token_field)
+      user = Monban.lookup(params_hash.except(token_field), field_map)
       authenticate(user, password)
     end
 

data/lib/monban/version.rb

@@ -1,4 +1,4 @@
 module Monban
-  # 1.0.0
-  VERSION = "1.0.0"
+  # 1.0.1
+  VERSION = "1.0.1"
 end

data/spec/features/user/user_signs_in_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+feature 'User signs in' do
+  scenario 'with mismatched email case' do
+    user = User.create!(email: "example@example.com", password_digest: "password")
+
+    visit sign_in_path
+    fill_in "session[email]", with: "Example@example.com"
+    fill_in "session[password]", with: "password"
+    click_button "go"
+
+    expect(current_path).to eq posts_path
+  end
+end

data/spec/features/visitor/visitor_signs_up_spec.rb

@@ -10,6 +10,15 @@ feature 'Visitor signs up' do
     expect(page.current_path).to eq(posts_path)
   end
 
+  scenario 'with uppercase email' do
+    visit sign_up_path
+    fill_in 'user_email', with: 'Email@example.com'
+    fill_in 'user_password', with: 'password'
+    click_on 'go'
+
+    expect(User.last.email).to eq('email@example.com')
+  end
+
   scenario 'multiple users' do
     visit sign_up_path
     fill_in 'user_email', with: 'email@example.com'

data/spec/spec_helper.rb

@@ -7,10 +7,16 @@ require 'warden'
 require 'monban'
 require 'capybara'
 
+Monban.test_mode!
+Warden.test_mode!
+
 RSpec.configure do |config|
   config.include Warden::Test::Helpers
   config.include Monban::Test::Helpers, type: :feature
   config.order = "random"
+  config.after :each do
+    Monban.test_reset!
+  end
 end
 
 def with_monban_config(hash, &block)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: monban
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - halogenandtoast
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-02 00:00:00.000000000 Z
+date: 2016-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -175,6 +175,7 @@ files:
 - lib/monban/version.rb
 - lib/monban/warden_setup.rb
 - monban.gemspec
+- spec/features/user/user_signs_in_spec.rb
 - spec/features/user/user_signs_in_through_back_door_spec.rb
 - spec/features/user/user_tries_to_access_constrained_routes_spec.rb
 - spec/features/user/user_tries_to_access_http_auth_page_spec.rb
@@ -260,6 +261,7 @@ signing_key:
 specification_version: 4
 summary: Making rails authentication as simple as possible
 test_files:
+- spec/features/user/user_signs_in_spec.rb
 - spec/features/user/user_signs_in_through_back_door_spec.rb
 - spec/features/user/user_tries_to_access_constrained_routes_spec.rb
 - spec/features/user/user_tries_to_access_http_auth_page_spec.rb