monban 0.3.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5c8d75fe9becef4e85c00188afc6bd4ce6cc2add
-  data.tar.gz: 0a017b45d82756152678e35a3cbb0cd5c6caf362
+  metadata.gz: c994797ca1338ca8d78bb15bdfeaa5585bdf555a
+  data.tar.gz: 0ae31c41b9a1b9b08e8888a354d440051ed30eef
 SHA512:
-  metadata.gz: 86de815a9526d7f46a6af686918164ae081319ce596e0ab1f753113aeb43106169eb8c6b3f230b28218ced996bd5099f650d06460dc8c69fc007386fff4fd37b
-  data.tar.gz: 36865675f616268e793634a71e73a7243827a152d14de39ebf7a971b580439a8bd5435f4fdf7acf7f6ea5bcd348652e183ecde6a63e3bb76cab03eb006a453bf
+  metadata.gz: 3d4db22086b7359a92202a55cb033f5255434146e214d655974db3ae8d4b039232188bbfc41f715eb6ce040c80c02b55295b51dc2799c6ffe77f76a4ad51ffa7
+  data.tar.gz: ccd82bf884f619b75f15b0fd4a3d91248f600d0d3aa660964c6a565a20623cf8e868eac62ac91a8bde5caae667d54693f0e11f1e2494fc3c6c49311bc8f92302

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    monban (0.2.1)
+    monban (1.0.0)
       bcrypt
       rails
       warden
@@ -46,8 +46,8 @@ GEM
       minitest (~> 5.1)
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    arel (6.0.0)
-    bcrypt (3.1.10)
+    arel (6.0.3)
+    bcrypt (3.1.11)
     builder (3.2.2)
     capybara (2.4.4)
       mime-types (>= 1.16)
@@ -55,16 +55,17 @@ GEM
       rack (>= 1.0.0)
       rack-test (>= 0.5.4)
       xpath (~> 2.0)
+    concurrent-ruby (1.0.2)
     diff-lcs (1.2.5)
     erubis (2.7.0)
-    globalid (0.3.5)
+    globalid (0.3.6)
       activesupport (>= 4.1.0)
     i18n (0.7.0)
     json (1.8.3)
     loofah (2.0.2)
       nokogiri (>= 1.5.9)
-    mail (2.6.3)
-      mime-types (>= 1.16, < 3)
+    mail (2.6.4)
+      mime-types (>= 1.16, < 4)
     mime-types (2.6.1)
     mini_portile (0.6.2)
     minitest (5.7.0)
@@ -119,18 +120,19 @@ GEM
       rspec-mocks (~> 3.3.0)
       rspec-support (~> 3.3.0)
     rspec-support (3.3.0)
-    sprockets (3.2.0)
-      rack (~> 1.0)
-    sprockets-rails (2.3.1)
-      actionpack (>= 3.0)
-      activesupport (>= 3.0)
-      sprockets (>= 2.8, < 4.0)
+    sprockets (3.6.0)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.0.4)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
     sqlite3 (1.3.10)
     thor (0.19.1)
     thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
-    warden (1.2.3)
+    warden (1.2.6)
       rack (>= 1.0)
     xpath (2.0.0)
       nokogiri (~> 1.3)
@@ -146,3 +148,6 @@ DEPENDENCIES
   rspec
   rspec-rails
   sqlite3
+
+BUNDLED WITH
+   1.11.2

data/NEWS.rdoc

@@ -1,3 +1,7 @@
+== 1.0.0
+* Do not perform lookup if no params are passed to lookup
+* Add param transformer for sanitizing and normalizing
+
 == 0.3.1
 * Extend private interface for services
 

data/lib/monban.rb

@@ -8,6 +8,7 @@ require "monban/failure_app"
 require "monban/back_door"
 require "monban/warden_setup"
 require "monban/field_map"
+require "monban/param_transformer"
 require "monban/strategies/password_strategy"
 require "active_support/core_ext/module/attribute_accessors"
 
@@ -73,8 +74,10 @@ module Monban
   # @return [User] if user is found
   # @return [nil] if no user is found
   def self.lookup(params, field_map)
-    fields = FieldMap.new(params, field_map).to_fields
-    self.config.find_method.call(fields)
+    if params.present?
+      fields = FieldMap.new(params, field_map).to_fields
+      self.config.find_method.call(fields)
+    end
   end
 
   # Puts monban into test mode. This will disable hashing passwords

data/lib/monban/configuration.rb

@@ -12,6 +12,7 @@ module Monban
     attr_accessor :no_login_handler, :no_login_redirect
     attr_accessor :authentication_strategy
     attr_accessor :warden_serialize_into_session, :warden_serialize_from_session
+    attr_accessor :param_transformations
 
     attr_writer :user_class
 
@@ -21,13 +22,17 @@ module Monban
       setup_notices
       setup_services
       setup_warden
+      setup_param_transformations
     end
 
     # Default creation method. Can be overriden via {Monban.configure}
     #
     # @see #creation_method=
     def default_creation_method
-      ->(params) { Monban.config.user_class.create(params) }
+      ->(params) do
+        updated_params = transform_params(params)
+        Monban.config.user_class.create(updated_params)
+      end
     end
 
     # Default hashing method. Can be overriden via {Monban.configure}
@@ -48,7 +53,10 @@ module Monban
     # @see #find_method=
     # @see Monban.config.user_class
     def default_find_method
-      ->(params) { Monban.config.user_class.find_by(params) }
+      ->(params) do
+        updated_params = transform_params(params)
+        Monban.config.user_class.find_by(updated_params)
+      end
     end
 
     # Default token comparison method. Can be overriden via {Monban.configure}
@@ -123,5 +131,15 @@ module Monban
       @warden_serialize_into_session = -> (user) { user.id }
       @warden_serialize_from_session = -> (id) { Monban.config.user_class.find_by(id: id) }
     end
+
+    def setup_param_transformations
+      @param_transformations = {
+        email: ->(value) { value.downcase }
+      }
+    end
+
+    def transform_params(params)
+      ParamTransformer.new(params, param_transformations).to_h
+    end
   end
 end

data/lib/monban/param_transformer.rb

@@ -0,0 +1,38 @@
+module Monban
+  # Parameter transformer. Sanitizes and transforms parameter values
+  # @since 1.0.0
+  class ParamTransformer
+    # Initialize parameter transformer
+    #
+    # @param params [ActionController::Parameters] parameters to be altered
+    def initialize(params, transformations)
+      @params = params
+      @transformations = transformations
+    end
+
+    # Returns the transformed parameters
+    def to_h
+      sanitized_params.each_with_object({}) do |(key, value), hash|
+        hash[key] = transform(key, value)
+      end
+    end
+
+    private
+
+    attr_reader :params, :transformations
+
+    def sanitized_params
+      params.to_h
+    end
+
+    def transform(key, value)
+      return value unless value.is_a? String
+
+      if transformations.key?(key)
+        transformations[key].call(value)
+      else
+        value
+      end
+    end
+  end
+end

data/lib/monban/services/sign_up.rb

@@ -16,7 +16,7 @@ module Monban
       # Performs the service
       # @see Monban::Configuration.default_creation_method
       def perform
-        Monban.config.creation_method.call(user_params.to_hash)
+        Monban.config.creation_method.call(user_params)
       end
 
       private

data/lib/monban/version.rb

@@ -1,4 +1,4 @@
 module Monban
-  # 0.3.1
-  VERSION = "0.3.1"
+  # 1.0.0
+  VERSION = "1.0.0"
 end

data/spec/monban_spec.rb

@@ -12,9 +12,9 @@ describe 'Monban' do
     expect(Monban.compare_token('password', 'password')).to be_truthy
   end
 
-  it "allows lookup with a field_map" do
+  it "does not lookup with empty params" do
     allow(Monban::FieldMap).to receive(:new).and_return(fake_field_map)
-    with_monban_config(find_method: -> (conditions) { true }) do
+    with_monban_config(find_method: -> (conditions) { raise }) do
       expect(-> { Monban.lookup({}, {}) }).not_to raise_exception
     end
   end

data/spec/spec_helper.rb

@@ -9,7 +9,7 @@ require 'capybara'
 
 RSpec.configure do |config|
   config.include Warden::Test::Helpers
-   config.include Monban::Test::Helpers, type: :feature
+  config.include Monban::Test::Helpers, type: :feature
   config.order = "random"
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: monban
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 1.0.0
 platform: ruby
 authors:
 - halogenandtoast
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-16 00:00:00.000000000 Z
+date: 2016-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -161,6 +161,7 @@ files:
 - lib/monban/controller_helpers.rb
 - lib/monban/failure_app.rb
 - lib/monban/field_map.rb
+- lib/monban/param_transformer.rb
 - lib/monban/railtie.rb
 - lib/monban/services.rb
 - lib/monban/services/authentication.rb
@@ -254,7 +255,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Making rails authentication as simple as possible