momocop 0.1.6 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 583e60d7747c3d18b2e39a5fe6d2f4cb4a02d9484ee21d49c3b6e06381c7db1a
-  data.tar.gz: 72139ae77375a441a56925c906be69d34993c867a3a23337dde3f7e47e257b31
+  metadata.gz: 5441b62d81c8c1015b71ffb8f1457afe3be66007280372c5d239102ab08e9382
+  data.tar.gz: 3e030584e817127a5d77d83c7ff25d87438ce11d494556d19c196067503db69a
 SHA512:
-  metadata.gz: e0fb80f1fa23509e2ace6883efd371d3aeffac8f8472f484b8e797ba2ce1347518e2b124da72116fffe86ad82610a1d7e9af557da0cc04666bc214e4228d7248
-  data.tar.gz: 125d23305c4a085e35a0f3785f5b5f3f6cb00c4cfbeb44063e838ea5138b755e3d8b183a813c2776ddd56bf566cf682081bde359fc4e5c713d28459494b124e1
+  metadata.gz: 62c93ee8fc1733bf0a7e27e3e1a4636f6e8d70016d97646bf32e7a158ceb2950657993b15a6be622e7a579f9a7341b3ca6ff8f391ef0db53cef43bccb4e24a13
+  data.tar.gz: 4f0cde02768b237df824f17e231ac8444a7d18603644873f45974f3dcdb931e6e4e7e946780e4f6eda3ebb88e9cda278b27665e6586da7043377fafa7bbd765b

data/.rubocop.yml

@@ -56,6 +56,9 @@ Style/FrozenStringLiteralComment:
 Style/IfUnlessModifier:
   Enabled: false
 
+Style/ParallelAssignment:
+  Enabled: false
+
 Style/RequireOrder:
   Enabled: true
   SafeAutoCorrect: true

data/README.ja.md

@@ -0,0 +1,53 @@
+[English](./README.md) | 日本語
+
+# momocop
+
+[![Spec](https://github.com/supermomonga/momocop/actions/workflows/spec.yml/badge.svg)](https://github.com/supermomonga/momocop/actions/workflows/spec.yml) [![Gem Version](https://badge.fury.io/rb/momocop.svg)](https://badge.fury.io/rb/momocop)
+
+Momocopは、規約ベースのOpinionatedな[RuboCop](https://github.com/rubocop/rubocop)カスタムCopを提供します。
+
+## インストール
+
+`momocop`をGemfileに追加してください。
+
+```rb
+# Gemfile
+gem 'momocop', require: false
+```
+
+## 使用方法
+
+`.rubocop.yml`を編集して、`momocop`をrequireしてください。
+
+すべてのCopはデフォルトで無効になっているため、利用したいCopを有効にしてください。
+
+```yaml
+# .rubocop.yaml
+require:
+  - momocop
+
+Momocop/FactoryBotMissingAssociations:
+  Enabled: true
+```
+
+## Cop一覧
+
+|Cop|Rails|FactoryBot|
+|---|:-:|:-:|
+|[`Momocop/FactoryBotClassExistence`](lib/rubocop/cop/momocop/factory_bot_class_existence.rb)|:white_check_mark:|:white_check_mark:|
+|[`Momocop/FactoryBotMissingAssociations`](lib/rubocop/cop/momocop/factory_bot_missing_associations.rb)|:white_check_mark:|:white_check_mark:|
+|[`Momocop/FactoryBotMissingClassOption`](lib/rubocop/cop/momocop/factory_bot_missing_class_option.rb)|:white_check_mark:|:white_check_mark:|
+|[`Momocop/FactoryBotMissingProperties`](lib/rubocop/cop/momocop/factory_bot_missing_properties.rb)|:white_check_mark:|:white_check_mark:|
+|[`Momocop/FactoryBotPropertyOrder`](lib/rubocop/cop/momocop/factory_bot_property_order.rb)|:white_check_mark:|:white_check_mark:|
+
+## 貢献
+
+GitHubの https://github.com/supermomonga/momocop でのバグ報告やプルリクエストは歓迎します。このプロジェクトは安全で、協力的な空間であることを目指しており、貢献者は[行動規範](https://github.com/supermomonga/momocop/blob/main/CODE_OF_CONDUCT.md)に従うことが求められます。
+
+## ライセンス
+
+このgemは[MITライセンス](https://opensource.org/licenses/MIT)の条件の下でオープンソースとして利用可能です。
+
+## 行動規範
+
+Momocopプロジェクトのコードベース、イシュートラッカー、チャットルーム、およびメーリングリストにおいて交流する全員は、[行動規範](https://github.com/supermomonga/momocop/blob/main/CODE_OF_CONDUCT.md)に従うことが期待されます。

data/README.ja.md.erb

@@ -0,0 +1,62 @@
+[English](./README.md) | 日本語
+
+# momocop
+
+[![Spec](https://github.com/supermomonga/momocop/actions/workflows/spec.yml/badge.svg)](https://github.com/supermomonga/momocop/actions/workflows/spec.yml) [![Gem Version](https://badge.fury.io/rb/momocop.svg)](https://badge.fury.io/rb/momocop)
+
+Momocopは、規約ベースのOpinionatedな[RuboCop](https://github.com/rubocop/rubocop)カスタムCopを提供します。
+
+## インストール
+
+`momocop`をGemfileに追加してください。
+
+```rb
+# Gemfile
+gem 'momocop', require: false
+```
+
+## 使用方法
+
+`.rubocop.yml`を編集して、`momocop`をrequireしてください。
+
+すべてのCopはデフォルトで無効になっているため、利用したいCopを有効にしてください。
+
+```yaml
+# .rubocop.yaml
+require:
+  - momocop
+
+Momocop/FactoryBotMissingAssociations:
+  Enabled: true
+```
+
+## Cop一覧
+
+|Cop|Rails|FactoryBot|
+|---|:-:|:-:|
+<%
+  files = Dir.glob('lib/rubocop/cop/momocop/*.rb').sort_by { |f| File.basename(f)}
+  files.each do |cop_file_path|
+  base_name = File.basename(cop_file_path, '.rb')
+  cop_class_name = "Momocop/#{base_name.camelize}"
+  is_factory_cop = cop_file_path.include?('factory_bot_')
+  is_rails_cop = cop_file_path.match?(/(factory_bot_|rails_)/)
+  rails_mark = is_rails_cop ? ':white_check_mark:' : ''
+  factory_bot_mark = is_factory_cop ? ':white_check_mark:' : ''
+
+  table_row = "|[`#{cop_class_name}`](#{cop_file_path})|#{rails_mark}|#{factory_bot_mark}|"
+-%>
+<%= table_row %>
+<% end -%>
+
+## 貢献
+
+GitHubの https://github.com/supermomonga/momocop でのバグ報告やプルリクエストは歓迎します。このプロジェクトは安全で、協力的な空間であることを目指しており、貢献者は[行動規範](https://github.com/supermomonga/momocop/blob/main/CODE_OF_CONDUCT.md)に従うことが求められます。
+
+## ライセンス
+
+このgemは[MITライセンス](https://opensource.org/licenses/MIT)の条件の下でオープンソースとして利用可能です。
+
+## 行動規範
+
+Momocopプロジェクトのコードベース、イシュートラッカー、チャットルーム、およびメーリングリストにおいて交流する全員は、[行動規範](https://github.com/supermomonga/momocop/blob/main/CODE_OF_CONDUCT.md)に従うことが期待されます。

data/README.md

@@ -1,3 +1,5 @@
+English | [日本語](./README.ja.md)
+
 # momocop
 
 [![Spec](https://github.com/supermomonga/momocop/actions/workflows/spec.yml/badge.svg)](https://github.com/supermomonga/momocop/actions/workflows/spec.yml) [![Gem Version](https://badge.fury.io/rb/momocop.svg)](https://badge.fury.io/rb/momocop)
@@ -24,7 +26,7 @@ All cops are disabled by default.
 require:
   - momocop
 
-Momocop/FactoryBotRailsFactoryAssociationsCoverage:
+Momocop/FactoryBotMissingAssociations:
   Enabled: true
 ```
 
@@ -32,10 +34,11 @@ Momocop/FactoryBotRailsFactoryAssociationsCoverage:
 
 |Cop|Rails|FactoryBot|
 |---|:-:|:-:|
-|[`Momocop/FactoryBotRailsClassName`](lib/rubocop/cop/momocop/factory_bot_rails_class_name.rb)|:white_check_mark:|:white_check_mark:|
-|[`Momocop/FactoryBotRailsClassOptionSpecified`](lib/rubocop/cop/momocop/factory_bot_rails_class_option_specified.rb)|:white_check_mark:|:white_check_mark:|
-|[`Momocop/FactoryBotRailsFactoryAssociationsCoverage`](lib/rubocop/cop/momocop/factory_bot_rails_factory_associations_coverage.rb)|:white_check_mark:|:white_check_mark:|
-|[`Momocop/FactoryBotRailsFactoryPropertiesCoverage`](lib/rubocop/cop/momocop/factory_bot_rails_factory_properties_coverage.rb)|:white_check_mark:|:white_check_mark:|
+|[`Momocop/FactoryBotClassExistence`](lib/rubocop/cop/momocop/factory_bot_class_existence.rb)|:white_check_mark:|:white_check_mark:|
+|[`Momocop/FactoryBotMissingAssociations`](lib/rubocop/cop/momocop/factory_bot_missing_associations.rb)|:white_check_mark:|:white_check_mark:|
+|[`Momocop/FactoryBotMissingClassOption`](lib/rubocop/cop/momocop/factory_bot_missing_class_option.rb)|:white_check_mark:|:white_check_mark:|
+|[`Momocop/FactoryBotMissingProperties`](lib/rubocop/cop/momocop/factory_bot_missing_properties.rb)|:white_check_mark:|:white_check_mark:|
+|[`Momocop/FactoryBotPropertyOrder`](lib/rubocop/cop/momocop/factory_bot_property_order.rb)|:white_check_mark:|:white_check_mark:|
 
 ## Contributing
 

data/README.md.erb

@@ -0,0 +1,62 @@
+English | [日本語](./README.ja.md)
+
+# momocop
+
+[![Spec](https://github.com/supermomonga/momocop/actions/workflows/spec.yml/badge.svg)](https://github.com/supermomonga/momocop/actions/workflows/spec.yml) [![Gem Version](https://badge.fury.io/rb/momocop.svg)](https://badge.fury.io/rb/momocop)
+
+Momocop is highly opinionated custom cops for [RuboCop](https://github.com/rubocop/rubocop).
+
+## Installation
+
+Add `momocop` to your Gemfile.
+
+```rb
+# Gemfile
+gem 'momocop', require: false
+```
+
+## Usage
+
+Edit `.rubocop.yml` to require `momocop` and enable the cops you want.
+
+All cops are disabled by default.
+
+```yaml
+# .rubocop.yaml
+require:
+  - momocop
+
+Momocop/FactoryBotMissingAssociations:
+  Enabled: true
+```
+
+## Cops
+
+|Cop|Rails|FactoryBot|
+|---|:-:|:-:|
+<%
+  files = Dir.glob('lib/rubocop/cop/momocop/*.rb').sort_by { |f| File.basename(f)}
+  files.each do |cop_file_path|
+  base_name = File.basename(cop_file_path, '.rb')
+  cop_class_name = "Momocop/#{base_name.camelize}"
+  is_factory_cop = cop_file_path.include?('factory_bot_')
+  is_rails_cop = cop_file_path.match?(/(factory_bot_|rails_)/)
+  rails_mark = is_rails_cop ? ':white_check_mark:' : ''
+  factory_bot_mark = is_factory_cop ? ':white_check_mark:' : ''
+
+  table_row = "|[`#{cop_class_name}`](#{cop_file_path})|#{rails_mark}|#{factory_bot_mark}|"
+-%>
+<%= table_row %>
+<% end -%>
+
+## Contributing
+
+Bug reports and pull requests are welcome on GitHub at https://github.com/supermomonga/momocop. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/supermomonga/momocop/blob/main/CODE_OF_CONDUCT.md).
+
+## License
+
+The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
+
+## Code of Conduct
+
+Everyone interacting in the Momocop project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/supermomonga/momocop/blob/main/CODE_OF_CONDUCT.md).

data/Rakefile

@@ -10,3 +10,24 @@ require 'rubocop/rake_task'
 RuboCop::RakeTask.new
 
 task default: %i[spec rubocop]
+
+require 'active_support/core_ext/string/inflections'
+require 'erb'
+
+desc 'Update README.md from README.md.erb'
+task 'readme:update' do
+  files = Dir.glob(File.join(__dir__, 'README.*.erb'))
+  files.each do |src_path|
+    dst_path = src_path.sub(/\.erb\z/, '')
+    # ERBテンプレートの読み込み
+    template = File.read(src_path)
+
+    # ERBテンプレートのレンダリング
+    renderer = ERB.new(template, trim_mode: '-')
+    output = renderer.result
+
+    # README.mdへの書き込み
+    File.write(dst_path, output)
+    puts "#{dst_path} has been successfully updated."
+  end
+end

data/lib/momocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Momocop
-  VERSION = '0.1.6'
+  VERSION = '0.1.8'
 end

data/lib/momocop.rb

@@ -8,6 +8,9 @@ require 'rubocop/cop/mixin/active_record_helper'
 require 'rubocop/rails/schema_loader'
 require 'rubocop/rails/schema_loader/schema'
 
+# sevencop
+require 'sevencop/cop_concerns'
+
 # Momocop
 require_relative 'momocop/association_extractor'
 require_relative 'momocop/config_injector'

data/lib/rubocop/cop/momocop/factory_bot_class_existence.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Momocop
+      # Ensures that FactoryBot factories has a valid class option.
+      #
+      # @example
+      #   # bad (if 'app/models/user.rb' does not exist)
+      #   factory :user, class: 'User' do
+      #   end
+      #
+      #   # good (if 'app/models/admin.rb' exists)
+      #   factory :user, class: 'Admin' do
+      #   end
+      class FactoryBotClassExistence < RuboCop::Cop::Base
+        extend AutoCorrector
+
+        MSG = 'Specified class does not exist. Please make sure that the class exists.'
+
+        RESTRICT_ON_SEND = %i[factory].freeze
+
+        def_node_matcher :factory_class_option_symbol?, <<~PATTERN
+          (send nil? :factory _ (hash <(pair (sym :class) $(sym _)) ...>))
+        PATTERN
+
+        def_node_matcher :factory_class_option_string?, <<~PATTERN
+          (send nil? :factory _ (hash <(pair (sym :class) $(str _)) ...>))
+        PATTERN
+
+        def on_send(node)
+          return unless inside_factory_bot_define?(node)
+
+          class_node = factory_class_option_symbol?(node) || factory_class_option_string?(node)
+
+          return unless class_node
+
+          class_name = class_node.value.to_s
+          puts class_name
+
+          return if class_exists?(class_name)
+
+          add_offense(class_node)
+        end
+
+        private def model_file_path(class_name)
+          "app/models/#{class_name.underscore}.rb"
+        end
+
+        private def class_exists?(class_name)
+          File.exist?(model_file_path(class_name))
+        end
+
+        private def inside_factory_bot_define?(node)
+          ancestors = node.each_ancestor(:block).to_a
+          ancestors.any? { |ancestor| ancestor.method_name == :define && ancestor.receiver&.const_name == 'FactoryBot' }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/momocop/{factory_bot_rails_factory_associations_coverage.rb → factory_bot_missing_associations.rb}

@@ -23,24 +23,34 @@ module RuboCop
       #       association(:account)
       #     end
       #   end
-      class FactoryBotRailsFactoryAssociationsCoverage < RuboCop::Cop::Base
+      class FactoryBotMissingAssociations < RuboCop::Cop::Base
         include RuboCop::Cop::ActiveRecordHelper
         extend AutoCorrector
 
         MSG = 'Ensure all associations of the model class are defined in the factory.'
 
+        RESTRICT_ON_SEND = %i[factory].freeze
+
         def_node_search :association_definitions, <<~PATTERN
           (send nil? :association ...)
         PATTERN
 
         def on_send(node)
-          return unless factory_bot_define_block_with_class_option?(node)
+          return unless inside_factory_bot_define?(node)
 
           class_name = get_class_name(node)
           return unless class_name
 
           block_node = node.block_node
 
+          # Add block if it's missing
+          unless block_node
+            add_offense(node, message: MSG) do |corrector|
+              indentation = ' ' * node.loc.column
+              corrector.insert_after(node.source_range.end, " do\n#{indentation}end")
+            end
+          end
+
           # Check missing associations
           defined_associations = get_defined_association_names(block_node)
           model_associations = get_model_association_names(class_name)
@@ -50,8 +60,6 @@ module RuboCop
           return unless missing_associations.any?
 
           add_offense(node, message: MSG) do |corrector|
-            next unless block_node
-
             # Add newline before closing block if it's a one-liner
             if one_line_block?(block_node)
               indentation = ' ' * node.loc.column
@@ -64,6 +72,8 @@ module RuboCop
 
               # TODO: calculate indentation size
               indentation = ' ' * (node.loc.column + 2)
+
+              # use send node if blockless
               corrector.insert_after(block_node.loc.begin, "\n#{indentation}#{definition}")
             end
           end
@@ -74,6 +84,8 @@ module RuboCop
         end
 
         private def one_line_block?(block_node)
+          return false if block_node.nil?
+
           block_node.loc.begin.line == block_node.loc.end.line
         end
 
@@ -104,14 +116,6 @@ module RuboCop
           "association(:#{property})"
         end
 
-        private def factory_bot_define_block_with_class_option?(node)
-          factory_method_call?(node) && inside_factory_bot_define?(node)
-        end
-
-        private def factory_method_call?(node)
-          node.method_name == :factory
-        end
-
         private def inside_factory_bot_define?(node)
           ancestors = node.each_ancestor(:block).to_a
           ancestors.any? { |ancestor| ancestor.method_name == :define && ancestor.receiver&.const_name == 'FactoryBot' }

data/lib/rubocop/cop/momocop/{factory_bot_rails_class_option_specified.rb → factory_bot_missing_class_option.rb}

@@ -13,22 +13,20 @@ module RuboCop
       #   # good
       #   factory :user, class: 'User' do
       #   end
-      class FactoryBotRailsClassOptionSpecified < RuboCop::Cop::Base
+      class FactoryBotMissingClassOption < RuboCop::Cop::Base
         extend AutoCorrector
 
         MSG = 'Specify a class option explicitly in FactoryBot factory.'
 
-        def_node_matcher :factory_call?, <<~PATTERN
-          (send nil? :factory ...)
-        PATTERN
+        RESTRICT_ON_SEND = %i[factory].freeze
 
         def on_send(node)
-          return unless factory_call?(node)
+          return unless inside_factory_bot_define?(node)
 
           # `factory`メソッドの呼び出しで、ハッシュ引数に`:class`キーが含まれているかを調べる
-          class_option_specified = node.arguments.any? do |arg|
+          class_option_specified = node.arguments.any? { |arg|
             arg.hash_type? && arg.pairs.any? { |pair| pair.key.sym_type? && pair.key.children.first == :class }
-          end
+          }
           return if class_option_specified
 
           add_offense(node.loc.selector) do |corrector|
@@ -39,6 +37,11 @@ module RuboCop
             corrector.insert_after(node.first_argument.loc.expression, ", class: '#{class_name}'")
           end
         end
+
+        private def inside_factory_bot_define?(node)
+          ancestors = node.each_ancestor(:block).to_a
+          ancestors.any? { |ancestor| ancestor.method_name == :define && ancestor.receiver&.const_name == 'FactoryBot' }
+        end
       end
     end
   end

data/lib/rubocop/cop/momocop/{factory_bot_rails_factory_properties_coverage.rb → factory_bot_missing_properties.rb}

@@ -26,12 +26,14 @@ module RuboCop
       #       name { 'John Doe' }
       #     end
       #   end
-      class FactoryBotRailsFactoryPropertiesCoverage < RuboCop::Cop::Base
+      class FactoryBotMissingProperties < RuboCop::Cop::Base
         include RuboCop::Cop::ActiveRecordHelper
         extend AutoCorrector
 
         MSG = 'Ensure all properties of the model class are defined in the factory.'
 
+        RESTRICT_ON_SEND = %i[factory].freeze
+
         def_node_search :sequence_definitions, <<~PATTERN
           (send nil? :sequence ...)
         PATTERN
@@ -41,13 +43,21 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return unless factory_bot_define_block_with_class_option?(node)
+          return unless inside_factory_bot_define?(node)
 
           class_name = get_class_name(node)
           return unless class_name
 
           block_node = node.block_node
 
+          # Add block if it's missing
+          unless block_node
+            add_offense(node, message: MSG) do |corrector|
+              indentation = ' ' * node.loc.column
+              corrector.insert_after(node.source_range.end, " do\n#{indentation}end")
+            end
+          end
+
           # Check missing associations
 
           # Exclude defined sequences
@@ -188,14 +198,6 @@ module RuboCop
           return property_names
         end
 
-        private def factory_bot_define_block_with_class_option?(node)
-          factory_method_call?(node) && inside_factory_bot_define?(node)
-        end
-
-        private def factory_method_call?(node)
-          node.method_name == :factory
-        end
-
         private def inside_factory_bot_define?(node)
           ancestors = node.each_ancestor(:block).to_a
           ancestors.any? { |ancestor| ancestor.method_name == :define && ancestor.receiver&.const_name == 'FactoryBot' }

data/lib/rubocop/cop/momocop/factory_bot_property_order.rb

@@ -0,0 +1,126 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Momocop
+      # Ensures that FactoryBot factories has ordered property definitions.
+      # 1. Associations should be defined before other properties.
+      # 2. Associations and properties should be defined in alphabetical order.
+      #
+      # @example
+      #   # bad
+      #   factory :user, class: 'User' do
+      #     address { '123 Main St' }
+      #     association :profile
+      #   end
+      #
+      #   # good
+      #   factory :user, class: 'User' do
+      #     association :profile
+      #     address { '123 Main St' }
+      #   end
+      #
+      #   # bad
+      #   factory :user, class: 'User' do
+      #     association :profile
+      #     association :account
+      #     zipcode { '111-1111' }
+      #     address { '123 Main St' }
+      #   end
+      #
+      #   # good
+      #   factory :user, class: 'User' do
+      #     association :account
+      #     association :profile
+      #     address { '123 Main St' }
+      #     zipcode { '111-1111' }
+      #   end
+      class FactoryBotPropertyOrder < RuboCop::Cop::Base
+        extend AutoCorrector
+        include RangeHelp
+
+        include ::Sevencop::CopConcerns::Ordered
+
+        MSG = 'Sort properties and associations alphabetically.'
+
+        RESTRICT_ON_SEND = %i[factory].freeze
+
+        def on_send(node)
+          return unless inside_factory_bot_define?(node)
+
+          block_node = node.block_node
+          return unless block_node
+
+          entire_definitions = defined_properties(block_node)
+
+          sections =
+            entire_definitions
+            .slice_when { |a, b| b.loc.last_line - a.loc.last_line > 1 }
+            .select { |definitions| definitions.size >= 2 }
+
+          sections.each do |definitions|
+            add_offense(definitions.last) do |corrector|
+              (a, b) =
+                definitions
+                .lazy
+                .each_cons(2)
+                .find { |a, b| (order(a) <=> order(b)) == 1 }
+
+              break unless a && b
+
+              swap(
+                range_with_comments_and_lines(a),
+                range_with_comments_and_lines(b),
+                corrector:
+              )
+            end
+          end
+        end
+
+        private def order(node)
+          group = definition_type(node) == :association ? 0 : 1
+          index = definition_name(node)
+          [group, index]
+        end
+
+        private def defined_properties(block_node)
+          body_node = block_node&.children&.last
+          body_node&.children&.select { |node| definition_node?(node) } || []
+        end
+
+        private def definition_node?(node)
+          if node.send_type?
+            return node.method_name != :trait
+          elsif node.block_type? && node.children.first.send_type?
+            return node.children.first.method_name != :trait
+          end
+
+          return false
+        end
+
+        private def definition_type(node)
+          send_node = node.send_type? ? node : node.children.first
+          if %i[association sequence].include? send_node.method_name
+            send_node.method_name
+          else
+            :property
+          end
+        end
+
+        private def definition_name(node)
+          send_node = node.send_type? ? node : node.children.first
+          if %i[association sequence].include? send_node.method_name
+            send_node.arguments.first.value
+          else
+            send_node.method_name.to_sym
+          end
+        end
+
+        private def inside_factory_bot_define?(node)
+          ancestors = node.each_ancestor(:block).to_a
+          ancestors.any? { |ancestor| ancestor.method_name == :define && ancestor.receiver&.const_name == 'FactoryBot' }
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: momocop
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.8
 platform: ruby
 authors:
 - supermomonga
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-02-18 00:00:00.000000000 Z
+date: 2024-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sevencop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Convention focused opinionated custom cops for RuboCop.
 email:
 - hi@supermomonga.com
@@ -66,7 +80,10 @@ files:
 - CODEOWNERS
 - CODE_OF_CONDUCT.md
 - LICENSE.txt
+- README.ja.md
+- README.ja.md.erb
 - README.md
+- README.md.erb
 - Rakefile
 - config/default.yml
 - lib/momocop.rb
@@ -74,10 +91,11 @@ files:
 - lib/momocop/config_injector.rb
 - lib/momocop/enum_extractor.rb
 - lib/momocop/version.rb
-- lib/rubocop/cop/momocop/factory_bot_rails_class_name.rb
-- lib/rubocop/cop/momocop/factory_bot_rails_class_option_specified.rb
-- lib/rubocop/cop/momocop/factory_bot_rails_factory_associations_coverage.rb
-- lib/rubocop/cop/momocop/factory_bot_rails_factory_properties_coverage.rb
+- lib/rubocop/cop/momocop/factory_bot_class_existence.rb
+- lib/rubocop/cop/momocop/factory_bot_missing_associations.rb
+- lib/rubocop/cop/momocop/factory_bot_missing_class_option.rb
+- lib/rubocop/cop/momocop/factory_bot_missing_properties.rb
+- lib/rubocop/cop/momocop/factory_bot_property_order.rb
 - sig/momocop.rbs
 homepage: https://github.com/supermomonga/momocop
 licenses:

data/lib/rubocop/cop/momocop/factory_bot_rails_class_name.rb

@@ -1,69 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Momocop
-      # Ensures that FactoryBot factories use `ClassName.name` for the class option instead of symbol or string literals.
-      #
-      # @example
-      #   # bad
-      #   factory :user, class: :User do
-      #   end
-      #
-      #   factory :admin, class: 'Admin' do
-      #   end
-      #
-      #   factory :moderator, class: Moderator.to_s do
-      #   end
-      #
-      #   # good
-      #   factory :user, class: User.name do
-      #   end
-      #
-      #   factory :admin, class: Admin.name do
-      #   end
-      #
-      #   factory :moderator, class: Moderator.name do
-      #   end
-      class FactoryBotRailsClassName < RuboCop::Cop::Base
-        extend AutoCorrector
-
-        MSG = 'Use `ClassName.name` for the class option instead of a symbol, string literal, or `ClassName.to_s`.'
-
-        def_node_matcher :factory_class_option_symbol?, <<~PATTERN
-          (send nil? :factory _ (hash <(pair (sym :class) $(sym _)) ...>))
-        PATTERN
-
-        def_node_matcher :factory_class_option_string?, <<~PATTERN
-          (send nil? :factory _ (hash <(pair (sym :class) $(str _)) ...>))
-        PATTERN
-
-        def_node_matcher :factory_class_option_to_s?, <<~PATTERN
-          (send nil? :factory _ (hash <(pair (sym :class) $(send _ :to_s)) ...>))
-        PATTERN
-
-        def on_send(node)
-          factory_class_option_symbol?(node) do |class_option|
-            add_offense(class_option) do |corrector|
-              corrector.replace(class_option, "#{class_option.value.capitalize}.name")
-            end
-          end
-
-          factory_class_option_string?(node) do |class_option|
-            class_name = class_option.value.delete_prefix("'").delete_suffix("'").capitalize
-            add_offense(class_option) do |corrector|
-              corrector.replace(class_option, "#{class_name}.name")
-            end
-          end
-
-          factory_class_option_to_s?(node) do |class_option|
-            class_name = class_option.receiver.const_name
-            add_offense(class_option) do |corrector|
-              corrector.replace(class_option, "#{class_name}.name")
-            end
-          end
-        end
-      end
-    end
-  end
-end