momocop 0.1.4 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7bbeea4b66a57e0dd2768cd593c653501cc745e73439d254dfa6ff56d26ad7a
-  data.tar.gz: 3181561d6c590050106bcf13a1c6b6cec2f22179e2b1c8bcbb5b126630fd27d5
+  metadata.gz: 583e60d7747c3d18b2e39a5fe6d2f4cb4a02d9484ee21d49c3b6e06381c7db1a
+  data.tar.gz: 72139ae77375a441a56925c906be69d34993c867a3a23337dde3f7e47e257b31
 SHA512:
-  metadata.gz: 19113cb5c6945b125d1688553deb24933b111ebe9d43521212fad4b38ca495676635c3047250e07a8a4b784c68f4d9b51a76ae8b0f56a167f5dc60d60939a78d
-  data.tar.gz: c9841b2375bdd3e81682e73da8dd42f45174de77c27c265b10e7a7f7750bd8424c804bb2bea1e3f02f287d52926cd4895670988dac7d19f6d3b5d72c6a3a7314
+  metadata.gz: e0fb80f1fa23509e2ace6883efd371d3aeffac8f8472f484b8e797ba2ce1347518e2b124da72116fffe86ad82610a1d7e9af557da0cc04666bc214e4228d7248
+  data.tar.gz: 125d23305c4a085e35a0f3785f5b5f3f6cb00c4cfbeb44063e838ea5138b755e3d8b183a813c2776ddd56bf566cf682081bde359fc4e5c713d28459494b124e1

data/.rubocop.yml

@@ -41,6 +41,10 @@ Security:
 Style:
   Enabled: true
 
+Style/BlockDelimiters:
+  EnforcedStyle: semantic
+  AllowBracesOnProceduralOneLiners: false
+
 Style/Documentation:
   Enabled: false
 
@@ -49,6 +53,9 @@ Style/FrozenStringLiteralComment:
   EnforcedStyle: always_true
   SafeAutoCorrect: true
 
+Style/IfUnlessModifier:
+  Enabled: false
+
 Style/RequireOrder:
   Enabled: true
   SafeAutoCorrect: true

data/lib/momocop/association_extractor.rb

@@ -22,9 +22,23 @@ module Momocop
     end
 
     private def extract_associations(node, associations = [])
-      if node.type == :send && ASSOCIATION_METHODS.include?(node.children[1])
-        association_name = node.children[2].type == :sym ? node.children[2].children[0] : node.children[2]
-        associations << { type: node.children[1], name: association_name }
+      association_type = node.children[1]
+      options = {}
+      if node.type == :send && ASSOCIATION_METHODS.include?(association_type)
+        association_name = node.children[2].children[0].to_sym
+
+        # Extract some options
+        if association_type == :belongs_to
+          option_hash = node.children[3]
+          option_hash&.children&.each do |option|
+            key_node, value_node = option.children
+            if value_node.type == :sym || value_node.type == :str
+              options[key_node.children[0]] = value_node.children[0]
+            end
+          end
+        end
+
+        associations << { type: association_type, name: association_name, options: }
       elsif node.children.is_a? Array
         node.children.each do |child|
           extract_associations(child, associations) if child.is_a? Parser::AST::Node

data/lib/momocop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Momocop
-  VERSION = '0.1.4'
+  VERSION = '0.1.6'
 end

data/lib/rubocop/cop/momocop/factory_bot_rails_factory_properties_coverage.rb

@@ -49,11 +49,24 @@ module RuboCop
           block_node = node.block_node
 
           # Check missing associations
+
+          # Exclude defined sequences
           defined_sequences = get_defined_sequence_names(block_node)
+          # Exclude defined properties
           defined_properties = get_defined_property_names(block_node)
+          # Exclude foreign keys
+          model_foreign_keys = get_model_foreign_key_column_names(class_name)
+          # All available properties
           model_properties = get_model_property_names(class_name)
+          # Calc missing properties
+          missing_properties = (
+            model_properties -
+            (defined_sequences + defined_properties) -
+            model_foreign_keys
+          ).sort
+
+          # for definition block generation
           model_enum_properties = get_model_enum_property_names(class_name)
-          missing_properties = (model_properties - (defined_sequences + defined_properties)).sort
 
           # Add offense for missing properties
           return unless missing_properties.any?
@@ -101,8 +114,31 @@ module RuboCop
           return [] unless source
 
           extractor = ::Momocop::EnumExtractor.new
+          enums = extractor.extract(source)
+          return enums.map(&:to_sym)
+        end
+
+        private def get_model_foreign_key_column_names(class_name)
+          source = model_file_source(class_name)
+          return [] unless source
+
+          extractor = ::Momocop::AssociationExtractor.new
           associations = extractor.extract(source)
-          return associations.map(&:to_sym)
+          foreign_key_names =
+            associations
+            .select { _1[:type] == :belongs_to }
+            .map { |association|
+              options = association[:options]
+              if options[:foreign_key]
+                options[:foreign_key]
+              elsif options[:class_name]
+                foreign_key_name(options[:class_name])
+              else
+                "#{association[:name]}_id"
+              end
+            }
+            .compact
+          return foreign_key_names.map(&:to_sym)
         end
 
         RESTRICTED_COLUMNS = %w[created_at updated_at].freeze
@@ -123,6 +159,14 @@ module RuboCop
           class_name.tableize.gsub('/', '_')
         end
 
+        # e.g.)
+        # 'User' -> ['users']
+        # 'Admin::User' -> ['admin_users', 'users']
+        private def foreign_key_name(class_name)
+          # TODO: parse model class file and try to get table_name_prefix and table_name_suffix
+          "#{class_name.underscore.gsub('/', '_')}_id"
+        end
+
         private def get_defined_sequence_names(block_node)
           body_node = block_node&.children&.last
           return [] unless body_node

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: momocop
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.6
 platform: ruby
 authors:
 - supermomonga