momm 0.0.7 → 1.0.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: b393642dc01d810177a7c39e8bc94c27afaf6434
+  data.tar.gz: b52ae25cd3c12b17bb8698d2495d2f9460af49a4
+SHA512:
+  metadata.gz: 3e3b3d1d6aed617daee7e5da579cc96fcd490266dabe84ae83def102668a85580bc10dcc8af400b5f44a684d889168a15812a3a5e4949d06cf3aef1e574d6fcb
+  data.tar.gz: de240f07aae21d6dce48949dd79f16bd520a7561ff4428f7197daeebec0fcb00caad16ddf866722c20d7d847465214a7ffafafed75d6ff8398021e74554418d7

data/.rspec

@@ -0,0 +1 @@
+--color

data/README.md

@@ -28,9 +28,7 @@ Money on My Mind - An awesome gem for currency exchange.
 ## Requirement
 
 
-Ensure that [Memcached](http://memcached.org/) or [Redis](http://redis.io/) is installed on your local machine or server or provided by some other cloud service providers. Those are for exchange rate storage, which ensure your fast queries.
-
-Local storage is not provided, because it might not safe for work on Cloud Platforms such as Heroku.
+Ensure that either [Memcached](http://memcached.org/) or [Redis](http://redis.io/) is installed on the machines/servers for exchange rate store
 
 ## Installation
 
@@ -56,7 +54,7 @@ Or install it yourself as:
 #### Command Line Tool
 
 
-After the gem is installed, momm provide you a command line tool. The storage engine by default is Memcached, ensure it is opened.
+After the gem is installed, momm provide you a command line tool. The storage engine by default is Memcached. Make sure that its running in the background. Also make sure that you got the `dalli` gem installed
 
 ```
   $ momm rate GBP CNY                  # Exchange rate by default is today.
@@ -68,6 +66,7 @@ After the gem is installed, momm provide you a command line tool. The storage en
 
 
 ``` ruby
+  require 'dalli' # Make sure that dalli is required before momm
   require 'momm'
 
   Momm.exchange_rate 'GBP', 'USD' # By default Today
@@ -86,7 +85,7 @@ After the gem is installed, momm provide you a command line tool. The storage en
 
 
 ``` ruby
-  Momm.store :redis_store # Use redis as the default storage
+  Momm.store :redis_store # Use redis as the default storage. Ensure 'redis' & 'redis-namespace is installed'
 
   Momm.fed :ECB # Use ECB as the default currency exchange feeds
 
@@ -104,7 +103,7 @@ Web service is provided by Momm on Rails, however you need to install sinatra si
 
 ``` ruby
   # routes.rb
-
+  require 'dalli'
   require 'momm/web'
 
   Myapp::Application.routes.draw do
@@ -112,11 +111,15 @@ Web service is provided by Momm on Rails, however you need to install sinatra si
   end
 ```
 
-The default Storage is Memcached, if you want to switch to Redis, you can create an initialzer like:
+If you want to switch to Redis, you can create an initialzer like:
 
 ``` ruby
+  # Gemfile
+  gem 'redis'
+  gem 'redis-namespace'
 
   # momm_initialzer.rb
+
   Momm.setup do
     store :redis_store, host: "127.0.0.1", namespace: "green_tea"
   end
@@ -161,7 +164,7 @@ Widget of [SLIM](http://slim-lang.com/) template looks like below. Currenly only
 
 ``` ruby
   # config.ru
-
+  require 'dalli' # again make sure that dalli is required beforehand!!!
   require 'momm/web'
   run Momm::Web
 ```

data/bin/momm

@@ -2,6 +2,8 @@
 $LOAD_PATH << File.dirname(__FILE__) + "/../lib" if $0 == __FILE__
 
 require 'optparse'
+
+require 'dalli'
 require 'momm'
 
 OPERATIONS = %w{rate exchange update}
@@ -71,4 +73,4 @@ if OPERATIONS.include?(op)
   end
 else
   puts option_parser.help
-end
+end

data/examples/rack_app/Gemfile

@@ -1,5 +1,6 @@
 source 'https://rubygems.org'
 
+gem 'dalli'
 gem 'momm', path: '../..'
 
 # Momm::Web dependency

data/examples/rack_app/config.ru

@@ -1,2 +1,4 @@
+require 'dalli'
 require 'momm/web'
-run Momm::Web
+
+run Momm::Web

data/lib/momm/memcached.rb

@@ -1,5 +1,3 @@
-require 'dalli'
-
 module Momm
   class Memcached < Storage
 
@@ -18,5 +16,15 @@ module Momm
     def client
       @client ||= Dalli::Client.new connection, options
     end
-  end
-end
+
+    def set_rate(currency, rate, date = Date.today)
+      date = Date.parse(date) if date.is_a? String
+      client.set "#{date}#{currency}", rate
+    end
+
+    def get_rate(currency, date = Date.today)
+      date = Date.parse(date) if date.is_a? String
+      client.get("#{date}#{currency}").to_f
+    end
+  end if defined?(::Dalli)
+end

data/lib/momm/redis_store.rb

@@ -1,5 +1,3 @@
-require 'redis'
-
 module Momm
   class RedisStore < Storage
     DEFAULT_OPTIONS = { host: "localhost", port: 6379, namespace: "momm"}
@@ -20,5 +18,15 @@ module Momm
         Redis::Namespace.new(ns, :redis => native_client)
       end
     end
-  end
-end
+
+    def set_rate(currency, rate, date = Date.today)
+      date = Date.parse(date) if date.is_a? String
+      client.set "#{date}#{currency}", rate
+    end
+
+    def get_rate(currency, date = Date.today)
+      date = Date.parse(date) if date.is_a? String
+      client.get("#{date}#{currency}").to_f
+    end
+  end if defined?(::Redis)
+end

data/lib/momm/storage.rb

@@ -27,8 +27,7 @@ module Momm
     # nil
     #
     def set_rate(currency, rate, date = Date.today)
-      date = Date.parse(date) if date.is_a? String
-      client.set "#{date}#{currency}", rate
+      raise NotImplementedError
     end
 
     # Fetch the currency rate from client
@@ -43,8 +42,7 @@ module Momm
     # the currency rate
     #
     def get_rate(currency, date = Date.today)
-      date = Date.parse(date) if date.is_a? String
-      client.get("#{date}#{currency}").to_f
+      raise NotImplementedError
     end
 
     # update the data to storage
@@ -62,7 +60,5 @@ module Momm
       end
       "OK"
     end
-
-    NotImplementedError = Class.new(StandardError)
   end
-end
+end

data/lib/momm/version.rb

@@ -1,3 +1,3 @@
 module Momm
-  VERSION = "0.0.7"
+  VERSION = "1.0.0"
 end

data/lib/momm/web.rb

@@ -55,4 +55,4 @@ module Momm
       "#{env['SCRIPT_NAME']}"
     end
   end
-end
+end

data/momm.gemspec

@@ -18,14 +18,14 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "redis", ">= 3.0.6"
-  spec.add_dependency "redis-namespace", ">= 1.3.2"
-  spec.add_dependency "dalli", ">= 2.7.0"
   spec.add_dependency "httparty", ">= 0.12.0"
   spec.add_dependency "json"
 
+  spec.add_development_dependency "redis"
+  spec.add_development_dependency "dalli"
+  spec.add_development_dependency "redis-namespace"
   spec.add_development_dependency "rack-test"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "sinatra"
-  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rspec", "3.4.0"
 end

data/spec/momm/bridge_spec.rb

@@ -5,8 +5,8 @@ describe Momm::Bridge do
     it 'should have default' do
       bridge = Momm::Bridge.new
 
-      bridge.storage.should be_a(Momm::Memcached)
-      bridge.feed.should be_a(Momm::Feeds::ECB)
+      expect(bridge.storage).to be_a(Momm::Memcached)
+      expect(bridge.feed).to be_a(Momm::Feeds::ECB)
     end
   end
 
@@ -15,12 +15,12 @@ describe Momm::Bridge do
 
     it 'should change the storage' do
       bridge.store :redis_store
-      bridge.storage.should be_a(Momm::RedisStore)
+      expect(bridge.storage).to be_a(Momm::RedisStore)
     end
 
     it 'should change the ECB' do
       bridge.source :ECB
-      bridge.feed.should be_a(Momm::Feeds::ECB)
+      expect(bridge.feed).to be_a(Momm::Feeds::ECB)
     end
   end
-end
+end

data/spec/momm/calculator_spec.rb

@@ -6,27 +6,27 @@ describe Momm::Calculator do
     let(:calc) { calc = Momm::Calculator.new Momm::RedisStore.new }
 
     it 'should response to client' do
-      calc.should respond_to :client
+      expect(calc).to respond_to :client
     end
 
     it 'should response to set_rate' do
-      calc.should respond_to :set_rate
+      expect(calc).to respond_to :set_rate
     end
 
     it 'should response to get_rate_origin' do
-      calc.should respond_to :get_rate_origin
+      expect(calc).to respond_to :get_rate_origin
     end
 
     it 'should response to get_rate' do
-      calc.should respond_to :get_rate
+      expect(calc).to respond_to :get_rate
     end
 
     it 'should response to exchange_rate' do
-      calc.should respond_to :exchange_rate
+      expect(calc).to respond_to :exchange_rate
     end
 
     it 'should response to exchange' do
-      calc.should respond_to :exchange
+      expect(calc).to respond_to :exchange
     end
   end
 
@@ -34,42 +34,42 @@ describe Momm::Calculator do
     let(:calc) { Momm::Calculator.new }
 
     it 'should response to client' do
-      calc.should respond_to :client
+      expect(calc).to respond_to :client
     end
 
     it 'should response to update!' do
-      calc.should respond_to :update!
+      expect(calc).to respond_to :update!
     end
 
     it 'should response to set_rate' do
-      calc.should respond_to :set_rate
+      expect(calc).to respond_to :set_rate
     end
 
     it 'should response to get_rate_origin' do
-      calc.should respond_to :get_rate_origin
+      expect(calc).to respond_to :get_rate_origin
     end
 
     it 'should response to get_rate' do
-      calc.should respond_to :get_rate
+      expect(calc).to respond_to :get_rate
     end
 
     it 'should response to exchange_rate' do
-      calc.should respond_to :exchange_rate
+      expect(calc).to respond_to :exchange_rate
     end
 
     it 'should response to exchange' do
-      calc.should respond_to :exchange
+      expect(calc).to respond_to :exchange
     end
 
     it 'should response to currencies' do
-      calc.should respond_to :currencies
+      expect(calc).to respond_to :currencies
     end
   end
 
   context 'feeds' do
     it 'should not be nil' do
       calc = Momm::Calculator.new
-      calc.feed.should_not be_nil
+      expect(calc.feed).not_to be_nil
     end
   end
-end
+end

data/spec/momm/feeds/ecb_spec.rb

@@ -5,44 +5,44 @@ describe Momm::Feeds::ECB do
     it "cannot call new method do" do
       expect{
         Momm::Feeds::ECB.new
-      }.to raise_error
+      }.to raise_error NoMethodError
     end
 
     it "should eager loading the ECB instance" do
       instance1 = Momm::Feeds::ECB.instance
       instance2 = Momm::Feeds::ECB.instance
-      instance1.object_id.should == instance2.object_id
+      expect(instance1.object_id).to eq instance2.object_id
     end
   end
 
   describe ".currencies" do
     it 'should not be nil' do
-      Momm::Feeds::ECB.instance.currencies.should be_a(Array)
+      expect(Momm::Feeds::ECB.instance.currencies).to be_a(Array)
     end
   end
 
   describe "#fetching_url" do
     it 'should not be nil' do
-      Momm::Feeds::ECB.instance.fetching_url.should be_a String
+      expect(Momm::Feeds::ECB.instance.fetching_url).to be_a String
     end
   end
 
   describe "#currency_rates" do
     let(:rates) { Momm::Feeds::ECB.instance.currency_rates }
     it 'should be an array' do
-      rates.should be_a Array
+      expect(rates).to be_a Array
     end
 
     it 'should contain several elements' do
-      rates.length.should > 0
+      expect(rates.length > 0).to eq true
     end
 
     it 'should contain :date, :currency and :rates' do
-      rates.all?{
+      expect(rates.all?{
         |rate| rate.has_key?(:date) &&
         rate.has_key?(:currency) &&
         rate.has_key?(:rate)
-      }.should be_true
+      }).to eq true
     end
   end
-end
+end

data/spec/momm/memcached_spec.rb

@@ -4,19 +4,23 @@ describe Momm::Memcached do
   context 'default configurations' do
 
     it 'default options should be correct' do
-      Momm::Memcached::DEFAULT_OPTIONS.should == { connection: "localhost:11211", namespace: "momm", compress: true }
+      expect(Momm::Memcached::DEFAULT_OPTIONS).to eq({
+        connection: "localhost:11211",
+        namespace: "momm",
+        compress: true
+      })
     end
   end
 
   context '#initialize' do
     it 'can be initialized without params passed in' do
         momm = Momm::Memcached.new
-        momm.client.should be_a(Dalli::Client)
+        expect(momm.client).to be_a(Dalli::Client)
     end
 
     it 'can be initialized' do
       momm = Momm::Memcached.new connection: '127.0.0.1:12345'
-      momm.client.should be_a(Dalli::Client)
+      expect(momm.client).to be_a(Dalli::Client)
     end
   end
 
@@ -26,9 +30,9 @@ describe Momm::Memcached do
 
       money = rand(20)
       momm.set_rate :USD, money
-      momm.get_rate(:USD).should == money
+      expect(momm.get_rate(:USD)).to eq money
 
       Momm.update!
     end
   end
-end
+end

data/spec/momm/momm_spec.rb

@@ -3,36 +3,36 @@ require 'spec_helper'
 describe Momm do
   context "Calculator delegation" do
     it "should respond to exchange_rate" do
-      Momm.should respond_to :exchange_rate
+      expect(Momm).to respond_to :exchange_rate
     end
 
     it "should respond to exchange" do
-      Momm.should respond_to :exchange
+      expect(Momm).to respond_to :exchange
     end
 
     it "should respond to exchange_from_gbp_to_usd" do
-      Momm.should respond_to :exchange_from_gbp_to_usd
+      expect(Momm).to respond_to :exchange_from_gbp_to_usd
     end
 
     it "should respond to exchange_rate_from_gbp_to_usd" do
-      Momm.should respond_to :exchange_rate_from_gbp_to_usd
+      expect(Momm).to respond_to :exchange_rate_from_gbp_to_usd
     end
 
     it "should respond to update!" do
-      Momm.should respond_to :update!
+      expect(Momm).to respond_to :update!
     end
   end
 
   describe "bridge delegation" do
     it "should be successfully switch to redis store halfway" do
       Momm.store :redis_store
-      Momm.send(:calculator).storage.client.should be_a(Redis::Namespace)
+      expect(Momm.send(:calculator).storage.client).to be_a(Redis::Namespace)
       Momm.store :memcached
     end
 
     it "should be successfully switch to ECB halfway" do
       Momm.source :ECB
-      Momm.send(:calculator).feed.should be_a(Momm::Feeds::ECB)
+      expect(Momm.send(:calculator).feed).to be_a(Momm::Feeds::ECB)
     end
   end
 
@@ -42,10 +42,10 @@ describe Momm do
         store :redis_store
       end
 
-      Momm.send(:calculator).storage.should be_a(Momm::RedisStore)
-      Momm.send(:calculator).feed.should be_a(Momm::Feeds::ECB)
+      expect(Momm.send(:calculator).storage).to be_a(Momm::RedisStore)
+      expect(Momm.send(:calculator).feed).to be_a(Momm::Feeds::ECB)
 
       Momm.store :memcached
     end
   end
-end
+end