mollie-ruby 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9f2ddd5345adc0e656b61334bdf89dabf46ae80a
-  data.tar.gz: 0730c68b44c3378e2286cf000eb884d1d1c1cef1
+  metadata.gz: b0fddf0df04e01df0ad52f53a615bc01fc93ad9f
+  data.tar.gz: 5a2f2996bf5a52d6d1b2a67c601e25663fcf8a5a
 SHA512:
-  metadata.gz: adbe66a522ce7f2a62d7be0c298209c01ddd0697b0375cb4d8bcd9a88d28f7bfc101da9547ca4836af3ffeab8cffff3a3793c6999295469314d1f6983c1ae42a
-  data.tar.gz: 51b17c14446d239917126b96af0c142c66613a4932148d6471e60aa976a4084a071b8858d56e85f7c20f6e3e392a8f12bfca4318f4e0028857f75d8047362be4
+  metadata.gz: 92c98f3eff7f02df5069a5ac470209490e653c74005a9c60872df877dfc834bf92a0968d98d205a7b5470f6dbf05917c72bdb57d847f65bb8c18684f7111eb90
+  data.tar.gz: d8487caafe1a2de0ec2467a43d454f5c128591b5e62033d0d5e2ddeda84f92d59940115a029523797edae946e05dc674d295bdadaacfca58d6145253179a2633

data/Gemfile

@@ -1,4 +1,5 @@
 source 'https://rubygems.org'
 
+gem "codeclimate-test-reporter", group: :test, require: nil
 # Specify your gem's dependencies in mollie.gemspec
 gemspec

data/README.md

@@ -1,6 +1,9 @@
 # Mollie API client for Ruby
 
 [![wercker status](https://app.wercker.com/status/a8cb5d924bf5a477b7e7b0b971a51470/m/master "wercker status")](https://app.wercker.com/project/bykey/a8cb5d924bf5a477b7e7b0b971a51470)
+[![Gem Version](https://badge.fury.io/rb/mollie-ruby.svg)](http://badge.fury.io/rb/mollie-ruby)
+[![Code Climate](https://codeclimate.com/github/pero-ict-solutions/mollie-ruby/badges/gpa.svg)](https://codeclimate.com/github/pero-ict-solutions/mollie-ruby)
+[![Test Coverage](https://codeclimate.com/github/pero-ict-solutions/mollie-ruby/badges/coverage.svg)](https://codeclimate.com/github/pero-ict-solutions/mollie-ruby)
 
 Accepting [iDEAL](https://www.mollie.nl/betaaldiensten/ideal/), [Mister Cash](https://www.mollie.nl/betaaldiensten/mistercash/), [Creditcard](https://www.mollie.nl/betaaldiensten/creditcard/), and [paysafecard](https://www.mollie.nl/betaaldiensten/paysafecard/) online payments without fixed monthly costs or any punishing registration procedures. Just use the Mollie API to receive payments directly on your website.
 
@@ -16,12 +19,18 @@ To use the Mollie API client, the following things are required:
 
 Add this line to your application's Gemfile:
 
-    gem 'mollie-ruby', github: 'pero-ict-solutions/mollie-ruby', require: 'mollie'
+    gem 'mollie-ruby', require: 'mollie'
 
 And then execute:
 
     $ bundle
 
+### Using from github source
+
+If you want to use the latest 'edge' code, you can use this line in your Gemfile:
+
+    gem 'mollie-ruby', github: 'pero-ict-solutions/mollie-ruby', require: 'mollie'
+
 ## Usage
 
 the most basic way of getting paid is to prepare the payment on the Mollie server and then redirect the user to the provided `paymentUrl`. Make sure you store the payment `id` for further references. When the user makes a payment, Mollie will call the provided `redirect_url` webhook with the `id` as the POST parameter.

data/lib/mollie/client.rb

@@ -16,14 +16,15 @@ module Mollie
       "Bearer " + self.api_key
     end
 
-    def prepare_payment(amount, description, redirect_url, metadata = {})
+    def prepare_payment(amount, description, redirect_url, metadata = {}, method=nil, method_params = {})
       response = self.class.post('/payments',
         :body => {
           :amount => amount,
           :description => description,
           :redirectUrl => redirect_url,
-          :metadata => metadata
-        },
+          :metadata => metadata,
+          :method => method
+        }.merge(method_params),
         :headers => {
           'Authorization' => auth_token
         }
@@ -31,6 +32,16 @@ module Mollie
       JSON.parse(response.body)
     end
 
+    def issuers
+      response = self.class.get("/issuers",
+        :headers => {
+          'Authorization' => auth_token
+        }
+      )
+      response = JSON.parse(response.body)
+      response["data"].map {|issuer| {id: issuer["id"], name: issuer["name"]} }
+    end
+
     def payment_status(payment_id)
       response = self.class.get("/payments/#{payment_id}",
         :headers => {

data/lib/mollie/version.rb

@@ -1,3 +1,3 @@
 module Mollie
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/mollie.gemspec

@@ -25,5 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'vcr'
   spec.add_development_dependency 'webmock'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'codeclimate-test-reporter'
 end

data/spec/mollie/client_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe Mollie::Client do
 
-  let(:api_key) { "test_6zjmE6z9SRyzUs7hRbl7AY6MU5jFoW" }
+  let(:api_key) { "test_4drFuX5HdjBaFxdXoaABYD8yO4HjuT" }
 
   context '#prepare' do
 
@@ -29,6 +29,17 @@ describe Mollie::Client do
     end
   end
 
+  context "issuers" do
+    it "returns a hash with the iDeal issuers" do
+      VCR.use_cassette('get_issuers_list') do
+        client = Mollie::Client.new(api_key)
+        response = client.issuers
+        expect(response.first[:id]).to eql "ideal_TESTNL99"
+        expect(response.first[:name]).to eql "TBM Bank"
+      end
+    end
+  end
+
   context 'status' do
     context 'when payment is paid' do
       it "returns the paid status" do
@@ -51,4 +62,14 @@ describe Mollie::Client do
     end
   end
 
+  context "error response" do
+    it "will raise an Exception" do
+      VCR.use_cassette('invalid_key') do
+        client = Mollie::Client.new(api_key << "foo")
+        response = client.refund_payment("tr_8NQDMOE7EC")
+        expect(response["error"]).to_not be nil
+      end
+    end
+  end
+
 end

data/spec/spec_helper.rb

@@ -1,8 +1,9 @@
-require 'simplecov'
-SimpleCov.start
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
 
 require 'mollie'
 require 'vcr'
+require 'pry'
 
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
@@ -24,4 +25,5 @@ end
 VCR.configure do |c|
   c.cassette_library_dir = 'spec/vcr_cassettes'
   c.hook_into :webmock # or :fakeweb
+  c.ignore_hosts 'codeclimate.com'
 end

data/spec/vcr_cassettes/get_issuers_list.yml

@@ -0,0 +1,43 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://api.mollie.nl/v1/issuers
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Authorization:
+      - Bearer test_4drFuX5HdjBaFxdXoaABYD8yO4HjuT
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Wed, 08 Oct 2014 20:21:37 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Content-Length:
+      - '105'
+      Connection:
+      - keep-alive
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Methods:
+      - GET, POST, HEAD, OPTIONS, DELETE
+      Access-Control-Max-Age:
+      - '300'
+      Strict-Transport-Security:
+      - max-age=31556926; includeSubDomains
+      X-Whom:
+      - dc1-web-1
+    body:
+      encoding: UTF-8
+      string: '{"totalCount":1,"offset":0,"count":1,"data":[{"id":"ideal_TESTNL99","name":"TBM
+        Bank","method":"ideal"}]}'
+    http_version: 
+  recorded_at: Wed, 08 Oct 2014 20:21:37 GMT
+recorded_with: VCR 2.9.3

data/spec/vcr_cassettes/get_status_paid.yml

@@ -8,7 +8,7 @@ http_interactions:
       string: ''
     headers:
       Authorization:
-      - Bearer test_6zjmE6z9SRyzUs7hRbl7AY6MU5jFoW
+      - Bearer test_4drFuX5HdjBaFxdXoaABYD8yO4HjuT
   response:
     status:
       code: 200
@@ -39,6 +39,6 @@ http_interactions:
       string: '{"id":"tr_8NQDMOE7EC","mode":"test","createdDatetime":"2014-08-12T12:27:26.0Z","status":"paid","paidDatetime":"2014-08-12T12:33:23.0Z","amount":"99.99","description":"My
         fantastic product","method":"ideal","metadata":null,"details":{"consumerName":"T.
         TEST","consumerAccount":"NL17RABO0213698412","consumerBic":"TESTNL99"},"locale":"nl","links":{"redirectUrl":"http://localhost:3000/payments/1/update"}}'
-    http_version: 
+    http_version:
   recorded_at: Tue, 12 Aug 2014 12:33:39 GMT
 recorded_with: VCR 2.9.2

data/spec/vcr_cassettes/invalid_key.yml

@@ -0,0 +1,42 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://api.mollie.nl/v1/payments/tr_8NQDMOE7EC/refunds
+    body:
+      encoding: UTF-8
+      string: ''
+    headers:
+      Authorization:
+      - Bearer test_4drFuX5HdjBaFxdXoaABYD8yO4HjuTfoo
+  response:
+    status:
+      code: 401
+      message: Authorization Required
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Wed, 08 Oct 2014 20:27:36 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Content-Length:
+      - '121'
+      Connection:
+      - keep-alive
+      Access-Control-Allow-Credentials:
+      - 'true'
+      Access-Control-Allow-Methods:
+      - GET, POST, HEAD, OPTIONS, DELETE
+      Access-Control-Max-Age:
+      - '300'
+      Strict-Transport-Security:
+      - max-age=31556926; includeSubDomains
+      Www-Authenticate:
+      - Basic realm="Mollie API Key"
+    body:
+      encoding: UTF-8
+      string: '{"error":{"type":"request","message":"Unauthorized request","links":{"documentation":"https://www.mollie.nl/api/docs/"}}}'
+    http_version: 
+  recorded_at: Wed, 08 Oct 2014 20:27:36 GMT
+recorded_with: VCR 2.9.3

data/spec/vcr_cassettes/prepare_payment.yml

@@ -5,10 +5,10 @@ http_interactions:
     uri: https://api.mollie.nl/v1/payments
     body:
       encoding: UTF-8
-      string: amount=99.99&description=My%20fantastic%20product&redirectUrl=http%3A%2F%2Flocalhost%3A3000%2Fpayments%2F1%2Fupdate&metadata[order_id]=R232454365
+      string: amount=99.99&description=My%20fantastic%20product&redirectUrl=http%3A%2F%2Flocalhost%3A3000%2Fpayments%2F1%2Fupdate&metadata[order_id]=R232454365&method=
     headers:
       Authorization:
-      - Bearer test_6zjmE6z9SRyzUs7hRbl7AY6MU5jFoW
+      - Bearer test_4drFuX5HdjBaFxdXoaABYD8yO4HjuT
   response:
     status:
       code: 201
@@ -17,7 +17,7 @@ http_interactions:
       Server:
       - nginx
       Date:
-      - Tue, 12 Aug 2014 14:16:33 GMT
+      - Wed, 08 Oct 2014 08:40:18 GMT
       Content-Type:
       - application/json; charset=utf-8
       Content-Length:
@@ -33,11 +33,11 @@ http_interactions:
       Strict-Transport-Security:
       - max-age=31556926; includeSubDomains
       X-Whom:
-      - dc1-web-1
+      - dc1-web-2
     body:
       encoding: UTF-8
-      string: '{"id":"tr_ALc7B2h9UM","mode":"test","createdDatetime":"2014-08-12T14:16:33.0Z","status":"open","expiryPeriod":"PT15M","amount":"99.99","description":"My
+      string: '{"id":"tr_ALc7B2h9UM","mode":"test","createdDatetime":"2014-10-08T08:40:18.0Z","status":"open","expiryPeriod":"PT15M","amount":"99.99","description":"My
         fantastic product","method":null,"metadata":{"order_id":"R232454365"},"details":null,"links":{"paymentUrl":"https://www.mollie.nl/payscreen/pay/ALc7B2h9UM","redirectUrl":"http://localhost:3000/payments/1/update"}}'
-    http_version: 
-  recorded_at: Tue, 12 Aug 2014 14:16:34 GMT
-recorded_with: VCR 2.9.2
+    http_version:
+  recorded_at: Wed, 08 Oct 2014 08:40:17 GMT
+recorded_with: VCR 2.9.3

data/spec/vcr_cassettes/refund_payment.yml

@@ -8,7 +8,7 @@ http_interactions:
       string: ''
     headers:
       Authorization:
-      - Bearer test_6zjmE6z9SRyzUs7hRbl7AY6MU5jFoW
+      - Bearer test_4drFuX5HdjBaFxdXoaABYD8yO4HjuT
   response:
     status:
       code: 201
@@ -39,6 +39,6 @@ http_interactions:
       string: '{"id":"re_O5sCpw4kwb","payment":{"id":"tr_8NQDMOE7EC","mode":"test","createdDatetime":"2014-08-12T12:27:26.0Z","status":"refunded","expiryPeriod":"PT","amount":"99.99","description":"My
         fantastic product","method":"ideal","metadata":null,"details":{"consumerName":"T.
         TEST","consumerAccount":"NL17RABO0213698412","consumerBic":"TESTNL99"},"locale":"nl","links":{"redirectUrl":"http://localhost:3000/payments/1/update"}},"amountRefunded":"99.99","amountRemaining":"0.00","refundedDatetime":"2014-08-12T14:11:32.0Z"}'
-    http_version: 
+    http_version:
   recorded_at: Tue, 12 Aug 2014 14:11:32 GMT
 recorded_with: VCR 2.9.2

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mollie-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Peter Berkenbosch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-08 00:00:00.000000000 Z
+date: 2014-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -95,7 +95,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -127,7 +141,9 @@ files:
 - mollie.gemspec
 - spec/mollie/client_spec.rb
 - spec/spec_helper.rb
+- spec/vcr_cassettes/get_issuers_list.yml
 - spec/vcr_cassettes/get_status_paid.yml
+- spec/vcr_cassettes/invalid_key.yml
 - spec/vcr_cassettes/prepare_payment.yml
 - spec/vcr_cassettes/refund_payment.yml
 - wercker.yml
@@ -158,6 +174,8 @@ summary: Ruby API Client for Mollie
 test_files:
 - spec/mollie/client_spec.rb
 - spec/spec_helper.rb
+- spec/vcr_cassettes/get_issuers_list.yml
 - spec/vcr_cassettes/get_status_paid.yml
+- spec/vcr_cassettes/invalid_key.yml
 - spec/vcr_cassettes/prepare_payment.yml
 - spec/vcr_cassettes/refund_payment.yml