mollie-bank 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 447a33be843cdf4f114a7ff497b7bbd8b65b2644
-  data.tar.gz: 32288ae9b7b745babb662e74bdcccc1bc6e70a63
+  metadata.gz: 5e462fc0f3743651dd3d3f49d4910cfc1a7af94b
+  data.tar.gz: f1fdf9a28e7da8c14724c71967576111258a2d84
 SHA512:
-  metadata.gz: c27098173e74b9efca5bdfe74fcb455075723dea6dfb514a05150e2b677c8b0ae068476d1833bc9551577034c957f5dd373d609685937b0c04d53dbbb6684fa8
-  data.tar.gz: 1c66daea1abc9f0e93458f5c22911fd2ca65fe71c27958fd3d348afd412a91f0d5f2bd9a53b5c62aad2b77b4f5df6eaf7fbe52d686afeab002880f5244621ac6
+  metadata.gz: 1f1063f3e1df266b53bdde17ab41ad16f5dda6ef8d12c87652ed33f4d21747dbc05d13aa4931e92f3520f1d9bd2e187cb470b4cc400b545c831e332abb6f6fb5
+  data.tar.gz: 109587dd68addbaead2181d7b9f5fa202559d21f0d4ee68a6b329fc461f90d1fd83fcbe3ca1d8b30ee5946d865c3dc605094dfa8b155efe241919cbd07c89eeb

data/.ruby-gemset

@@ -0,0 +1 @@
+mollie-bank

data/.ruby-version

@@ -0,0 +1 @@
+2.0.0

data/CHANGELOG.md

@@ -1,9 +1,17 @@
 # Changelog
 
+- **14 May 2013**: version 0.0.4
+  - Fixed issue #5: Support both GET and POST requests for `/xml/ideal`
+  - Upgraded dependencies
+
+- **14 May 2013**: version 0.0.3
+  - Added coveralls
+  - Upgraded dependencies
+
 - **23 February 2012**: version 0.0.2
-    - New way for storing transactions
-    - Fully tested
-    - Documented
+  - New way for storing transactions
+  - Fully tested
+  - Documented
 
 - **16 February 2012**: version 0.0.1
-    - Initial release
+  - Initial release

data/lib/mollie-bank/application/app.rb

@@ -12,6 +12,11 @@ module MollieBank
 
     set :storage, MollieBank::Storage
 
+    def self.get_or_post(path, opts={}, &block)
+      get(path, opts, &block)
+      post(path, opts, &block)
+    end
+
     # Displays a information page of the Mollie-Bank gem
     get '/' do
       haml :info
@@ -69,7 +74,7 @@ module MollieBank
 
         begin
           reporturl = URI("#{reporturl}?transaction_id=#{transaction_id}")
-          res = Net::HTTP.get(reporturl)
+          Net::HTTP.get(reporturl)
         rescue
         end
 
@@ -94,7 +99,7 @@ module MollieBank
     # @example
     #   # checks if a order was paid
     #   http://localhost:4567/xml/ideal?a=check
-    post '/xml/ideal', '/xml/ideal/' do
+    get_or_post '/xml/ideal', '/xml/ideal/' do
       content_type 'text/xml'
       case params[:a]
       when "banklist"
@@ -108,12 +113,10 @@ module MollieBank
         return error(-14) unless params[:amount].to_i > 118
         return error(-6) unless params.has_key?("bank_id")
 
-        partnerid = params[:partnerid]
         description = params[:description]
         reporturl = params[:reporturl]
         returnurl = params[:returnurl]
         amount = params[:amount]
-        bank_id = params[:bank_id]
 
         transaction_id = UUID.new.generate.gsub('-', '')
 

data/lib/mollie-bank/version.rb

@@ -1,4 +1,4 @@
 module MollieBank
   # Version number of MollieBank
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/mollie-bank.gemspec

@@ -28,9 +28,9 @@ Gem::Specification.new do |s|
   s.add_development_dependency "simplecov"
   s.add_development_dependency "coveralls"
 
-  s.add_dependency "rake", "> 0.9.0"
-  s.add_dependency "uuid", "> 1.0"
-  s.add_dependency "haml", "> 3.0"
+  s.add_dependency "rake", "~> 10.1.0"
+  s.add_dependency "uuid", "~> 2.3.7"
+  s.add_dependency "haml", "~> 4.0.4"
   s.add_dependency "sinatra", "~> 1.4.0"
   s.add_dependency "sinatra-contrib", "~> 1.4.0"
 end

data/spec/backend_spec.rb

@@ -1,6 +1,12 @@
 require 'spec_helper'
 
 describe "backend" do
+  it "should support GET requests to the /xml/ideal endpoint" do
+    get '/xml/ideal', {
+      :a => 'banklist'
+    }
+    last_response.should be_ok
+  end
   it "should return the Mollie Bank when requesting /xml/ideal?a=banklist" do
     post '/xml/ideal', {
       :a => 'banklist'
@@ -8,8 +14,8 @@ describe "backend" do
 
     last_response.should be_ok
     xml = Nokogiri::Slop(last_response.body)
-    xml.response.bank.bank_id.content.should == "0001"
-    xml.response.bank.bank_name.content.should == "Mollie Bank"
+    xml.response.bank.bank_id.content.should eq "0001"
+    xml.response.bank.bank_name.content.should eq "Mollie Bank"
   end
   it "should also return the Mollie bank when requesting /xml/ideal/?a=banklist" do
     post '/xml/ideal/', {
@@ -18,8 +24,8 @@ describe "backend" do
 
     last_response.should be_ok
     xml = Nokogiri::Slop(last_response.body)
-    xml.response.bank.bank_id.content.should == "0001"
-    xml.response.bank.bank_name.content.should == "Mollie Bank"
+    xml.response.bank.bank_id.content.should eq "0001"
+    xml.response.bank.bank_name.content.should eq "Mollie Bank"
   end
   it "should return the correct xml for /xml/ideal?a=fetch" do
     post '/xml/ideal', {
@@ -35,10 +41,10 @@ describe "backend" do
 
     xml = Nokogiri::Slop(last_response.body)
     xml.response.order.transaction_id.content.should_not be_blank
-    xml.response.order.amount.content.should == "1000"
-    xml.response.order.currency.content.should == "EUR"
+    xml.response.order.amount.content.should eq "1000"
+    xml.response.order.currency.content.should eq "EUR"
     xml.response.order.URL.content.should contain "http://example.org:4567/ideal?transaction_id="
-    xml.response.order.message.content.should == "Your iDEAL-payment has successfully been setup. Your customer should visit the given URL to make the payment"
+    xml.response.order.message.content.should eq "Your iDEAL-payment has successfully been setup. Your customer should visit the given URL to make the payment"
   end
   it "should return the true if paid" do
     MollieBank::Storage.set('987654', {
@@ -52,7 +58,7 @@ describe "backend" do
 
     last_response.should be_ok
     xml = Nokogiri::Slop(last_response.body)
-    xml.response.order.payed.content.should == "true"
+    xml.response.order.payed.content.should eq "true"
   end
   it "should return the false not paid" do
     MollieBank::Storage.set('987654', {
@@ -66,6 +72,6 @@ describe "backend" do
 
     last_response.should be_ok
     xml = Nokogiri::Slop(last_response.body)
-    xml.response.order.payed.content.should == "false"
+    xml.response.order.payed.content.should eq "false"
   end
 end

data/spec/errors_spec.rb

@@ -7,10 +7,10 @@ describe "errors" do
         :a => 'unknown'
       }
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-1"
-      xml.response.item.message.content.should == "Did not receive a proper input value."
+      xml.response.item.errorcode.content.should eq "-1"
+      xml.response.item.message.content.should eq "Did not receive a proper input value."
     end
   end
   describe "/xml/ideal?a=fetch" do
@@ -25,10 +25,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-2"
-      xml.response.item.message.content.should == "A fetch was issued without specification of 'partnerid'."
+      xml.response.item.errorcode.content.should eq "-2"
+      xml.response.item.message.content.should eq "A fetch was issued without specification of 'partnerid'."
     end
     it "should return error -7  if description isn't provided" do
       post '/xml/ideal', {
@@ -41,10 +41,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-7"
-      xml.response.item.message.content.should == "A fetch was issued without specification of 'description'."
+      xml.response.item.errorcode.content.should eq "-7"
+      xml.response.item.message.content.should eq "A fetch was issued without specification of 'description'."
     end
     it "should return error -3  if reporturl isn't provided" do
       post '/xml/ideal', {
@@ -57,10 +57,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-3"
-      xml.response.item.message.content.should == "A fetch was issued without (proper) specification of 'reporturl'."
+      xml.response.item.errorcode.content.should eq "-3"
+      xml.response.item.message.content.should eq "A fetch was issued without (proper) specification of 'reporturl'."
     end
     it "should return error -12 if returnurl isn't provided" do
       post '/xml/ideal', {
@@ -73,10 +73,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-12"
-      xml.response.item.message.content.should == "A fetch was issued without (proper) specification of 'returnurl'."
+      xml.response.item.errorcode.content.should eq "-12"
+      xml.response.item.message.content.should eq "A fetch was issued without (proper) specification of 'returnurl'."
     end
     it "should return error -4  if amount isn't provided" do
       post '/xml/ideal', {
@@ -89,10 +89,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-4"
-      xml.response.item.message.content.should == "A fetch was issued without specification of 'amount'."
+      xml.response.item.errorcode.content.should eq "-4"
+      xml.response.item.message.content.should eq "A fetch was issued without specification of 'amount'."
     end
     it "should return error -14 if amount is to low" do
       post '/xml/ideal', {
@@ -106,10 +106,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-14"
-      xml.response.item.message.content.should == "Minimum amount for an ideal transaction is 1,18 EUR."
+      xml.response.item.errorcode.content.should eq "-14"
+      xml.response.item.message.content.should eq "Minimum amount for an ideal transaction is 1,18 EUR."
     end
     it "should return error -6  if bank_id isn't provided" do
       post '/xml/ideal', {
@@ -122,10 +122,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-6"
-      xml.response.item.message.content.should == "A fetch was issues without specification of a known 'bank_id'."
+      xml.response.item.errorcode.content.should eq "-6"
+      xml.response.item.message.content.should eq "A fetch was issues without specification of a known 'bank_id'."
     end
   end
   describe "/xml/ideal?a=check" do
@@ -136,10 +136,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-11"
-      xml.response.item.message.content.should == "A check was issued without specification of your partner_id."
+      xml.response.item.errorcode.content.should eq "-11"
+      xml.response.item.message.content.should eq "A check was issued without specification of your partner_id."
     end
     it "should return error -8  if transaction_id isn't provided" do
       post '/xml/ideal', {
@@ -148,10 +148,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-8"
-      xml.response.item.message.content.should == "A check was issued without specification of transaction_id."
+      xml.response.item.errorcode.content.should eq "-8"
+      xml.response.item.message.content.should eq "A check was issued without specification of transaction_id."
     end
     it "should return error -10 if transaction_id is unknown" do
       post '/xml/ideal', {
@@ -161,10 +161,10 @@ describe "errors" do
       }
       last_response.should be_ok
       xml = Nokogiri::Slop(last_response.body)
-      xml.response.item["type"].should == "error"
+      xml.response.item["type"].should eq "error"
 
-      xml.response.item.errorcode.content.should == "-10"
-      xml.response.item.message.content.should == "This is an unknown order."
+      xml.response.item.errorcode.content.should eq "-10"
+      xml.response.item.message.content.should eq "This is an unknown order."
     end
   end
 end

data/spec/frontend_spec.rb

@@ -57,6 +57,6 @@ describe "frontend" do
 
     last_response.should be_redirect
     follow_redirect!
-    last_request.url.should == 'http://example.org/return.html?transaction_id=987654'
+    last_request.url.should eq 'http://example.org/return.html?transaction_id=987654'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mollie-bank
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Manuel van Rijn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-14 00:00:00.000000000 Z
+date: 2014-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -126,44 +126,44 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 10.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 10.1.0
 - !ruby/object:Gem::Dependency
   name: uuid
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.3.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.3.7
 - !ruby/object:Gem::Dependency
   name: haml
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 4.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 4.0.4
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
@@ -204,7 +204,8 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
-- .rvmrc
+- .ruby-gemset
+- .ruby-version
 - .travis.yml
 - .yardopts
 - CHANGELOG.md
@@ -259,7 +260,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: mollie-bank
-rubygems_version: 2.0.0
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Mollie Bank server to make Mollie iDeal payments on your local machine

data/.rvmrc

@@ -1,48 +0,0 @@
-#!/usr/bin/env bash
-
-# This is an RVM Project .rvmrc file, used to automatically load the ruby
-# development environment upon cd'ing into the directory
-
-# First we specify our desired <ruby>[@<gemset>], the @gemset name is optional,
-# Only full ruby name is supported here, for short names use:
-#     echo "rvm use 1.9.3" > .rvmrc
-environment_id="ruby-1.9.3-p125@mollie-bank"
-
-# Uncomment the following lines if you want to verify rvm version per project
-# rvmrc_rvm_version="1.10.3" # 1.10.1 seams as a safe start
-# eval "$(echo ${rvm_version}.${rvmrc_rvm_version} | awk -F. '{print "[[ "$1*65536+$2*256+$3" -ge "$4*65536+$5*256+$6" ]]"}' )" || {
-#   echo "This .rvmrc file requires at least RVM ${rvmrc_rvm_version}, aborting loading."
-#   return 1
-# }
-
-# First we attempt to load the desired environment directly from the environment
-# file. This is very fast and efficient compared to running through the entire
-# CLI and selector. If you want feedback on which environment was used then
-# insert the word 'use' after --create as this triggers verbose mode.
-if [[ -d "${rvm_path:-$HOME/.rvm}/environments"
-  && -s "${rvm_path:-$HOME/.rvm}/environments/$environment_id" ]]
-then
-  \. "${rvm_path:-$HOME/.rvm}/environments/$environment_id"
-  [[ -s "${rvm_path:-$HOME/.rvm}/hooks/after_use" ]] &&
-    \. "${rvm_path:-$HOME/.rvm}/hooks/after_use" || true
-else
-  # If the environment file has not yet been created, use the RVM CLI to select.
-  rvm --create  "$environment_id" || {
-    echo "Failed to create RVM environment '${environment_id}'."
-    return 1
-  }
-fi
-
-# If you use bundler, this might be useful to you:
-# if [[ -s Gemfile ]] && {
-#   ! builtin command -v bundle >/dev/null ||
-#   builtin command -v bundle | grep $rvm_path/bin/bundle >/dev/null
-# }
-# then
-#   printf "%b" "The rubygem 'bundler' is not installed. Installing it now.\n"
-#   gem install bundler
-# fi
-# if [[ -s Gemfile ]] && builtin command -v bundle >/dev/null
-# then
-#   bundle install | grep -vE '^Using|Your bundle is complete'
-# fi