mojo_magick 0.5.7 → 0.6.0

data/lib/initializers/hash.rb

@@ -2,10 +2,10 @@ class Hash
   def symbolize_keys!
     keys.each do |key|
       self[begin
-             key.to_sym
-           rescue StandardError
-             key
-           end || key] = delete(key)
+        key.to_sym
+      rescue StandardError
+        key
+      end || key] = delete(key)
     end
     self
   end

data/lib/mojo_magick.rb

@@ -1,15 +1,14 @@
 cwd = File.dirname(__FILE__)
-require 'open3'
-initializers_dir = File.expand_path(File.join(cwd, 'initializers'))
-Dir.glob(File.join(initializers_dir, '*.rb')).each { |f| require f }
-require File.join(cwd, 'mojo_magick/util/parser')
-require File.join(cwd, 'mojo_magick/errors')
-require File.join(cwd, 'mojo_magick/command_status')
-require File.join(cwd, 'image_magick/resource_limits')
-require File.join(cwd, 'image_magick/fonts')
-require File.join(cwd, 'mojo_magick/opt_builder')
-require File.join(cwd, 'mojo_magick/font')
-require 'tempfile'
+require "open3"
+initializers_dir = File.expand_path(File.join(cwd, "initializers"))
+Dir.glob(File.join(initializers_dir, "*.rb")).sort.each { |f| require f }
+require File.join(cwd, "mojo_magick/util/parser")
+require File.join(cwd, "mojo_magick/errors")
+require File.join(cwd, "mojo_magick/command_status")
+require File.join(cwd, "image_magick/fonts")
+require File.join(cwd, "mojo_magick/opt_builder")
+require File.join(cwd, "mojo_magick/font")
+require "tempfile"
 
 # MojoMagick is a stateless set of module methods which present a convient interface
 # for accessing common tasks for ImageMagick command line library.
@@ -35,7 +34,8 @@ require 'tempfile'
 #
 # Equivalent to:
 #
-#   MojoMagick::raw_command('convert', 'source.jpg -crop 250x250+0+0 +repage -strip -set comment "my favorite file" dest.jpg')
+#   MojoMagick::raw_command('convert', 'source.jpg -crop 250x250+0+0\
+#         +repage -strip -set comment "my favorite file" dest.jpg')
 #
 # Example #mogrify usage:
 #
@@ -61,32 +61,27 @@ require 'tempfile'
 # instead of '-' versions.
 #
 module MojoMagick
-  # enable resource limiting functionality
-  extend ImageMagick::ResourceLimits
   extend ImageMagick::Fonts
 
   def self.windows?
     !(RUBY_PLATFORM =~ /win32/).nil?
   end
 
-  def self.execute(command, args, _options = {})
-    # this suppress error messages to the console
-    # err_pipe = windows? ? "2>nul" : "2>/dev/null"
-
-    execute = "#{command} #{get_limits_as_params} #{args}"
-    out, outerr, status = Open3.capture3(execute)
+  def self.execute(command, *args)
+    execute = "#{command} #{args}"
+    out, outerr, status = Open3.capture3(command, *args.map(&:to_s))
     CommandStatus.new execute, out, outerr, status
   rescue Exception => e
     raise MojoError, "#{e.class}: #{e.message}"
   end
 
-  def self.execute!(command, args, options = {})
-    # this suppress error messages to the console
-    # err_pipe = windows? ? "2>nul" : "2>/dev/null"
-    status = execute(command, args, options)
+  def self.execute!(command, *args)
+    status = execute(command, *args)
     unless status.success?
-      err_msg = options[:err_msg] || "MojoMagick command failed: #{command}."
-      raise(MojoFailed, "#{err_msg} (Exit status: #{status.exit_code})\n  Command: #{status.command}\n  Error: #{status.error}")
+      err_msg = "MojoMagick command failed: #{command}."
+      raise(MojoFailed, "#{err_msg} (Exit status: #{status.exit_code})\n" +
+            "  Command: #{status.command}\n" +
+            "  Error: #{status.error}")
     end
     status.return_value
   end
@@ -114,10 +109,10 @@ module MojoMagick
   #   :percent => scale image to this percentage (do not specify :width/:height in this case)
   def self.resize(source_file, dest_file, options)
     scale_options = []
-    scale_options << '>' unless options[:shrink_only].nil?
-    scale_options << '<' unless options[:expand_only].nil?
-    scale_options << '!' unless options[:absolute_aspect].nil?
-    scale_options << '^' unless options[:fill].nil?
+    scale_options << ">" unless options[:shrink_only].nil?
+    scale_options << "<" unless options[:expand_only].nil?
+    scale_options << "!" unless options[:absolute_aspect].nil?
+    scale_options << "^" unless options[:fill].nil?
     scale_options = scale_options.join
 
     extras = []
@@ -129,10 +124,15 @@ module MojoMagick
       raise MojoMagickError, "Unknown options for method resize: #{options.inspect}"
     end
     if !options[:fill].nil? && !options[:crop].nil?
-      extras << '-gravity Center'
-      extras << "-extent #{geometry}"
+      extras << "-gravity"
+      extras << "Center"
+      extras << "-extent"
+      extras << geometry.to_s
     end
-    raw_command('convert', "\"#{source_file}\" -resize \"#{geometry}#{scale_options}\" #{extras.join(' ')} \"#{dest_file}\"")
+    raw_command("convert",
+                source_file,
+                "-resize", "#{geometry}#{scale_options}",
+                *extras, dest_file)
     dest_file
   end
 
@@ -142,14 +142,14 @@ module MojoMagick
   end
 
   def self.get_format(source_file, format_string)
-    raw_command('identify', "-format \"#{format_string}\" \"#{source_file}\"")
+    raw_command("identify", "-format", format_string, source_file)
   end
 
   # returns an empty hash or a hash with :width and :height set (e.g. {:width => INT, :height => INT})
   # raises MojoFailed when results are indeterminate (width and height could not be determined)
   def self.get_image_size(source_file)
     # returns width, height of image if available, nil if not
-    retval = get_format(source_file, 'w:%w h:%h')
+    retval = get_format(source_file, "w:%w h:%h")
     return {} unless retval
 
     width = retval.match(/w:([0-9]+) /)
@@ -166,25 +166,26 @@ module MojoMagick
     opts.file source if source
     yield opts
     opts.file dest if dest
-    raw_command('convert', opts.to_s)
+
+    raw_command("convert", *opts.to_a)
   end
 
   def self.mogrify(dest = nil)
     opts = OptBuilder.new
     yield opts
     opts.file dest if dest
-    raw_command('mogrify', opts.to_s)
+    raw_command("mogrify", *opts.to_a)
   end
 
   def self.tempfile(*opts)
     data = opts[0]
     rest = opts[1]
     ext = rest && rest[:format]
-    file = Tempfile.new(['mojo', ext ? '.' + ext.to_s : ''])
+    file = Tempfile.new(["mojo", ext ? ".#{ext}" : ""])
     file.binmode
     file.write(data)
     file.path
   ensure
     file.close
   end
-end # MojoMagick
+end

data/lib/mojo_magick/command_status.rb

@@ -5,7 +5,7 @@ module MojoMagick
     end
 
     def exit_code
-      system_status.exitstatus || 'unknown'
+      system_status.exitstatus || "unknown"
     end
   end
 end

data/lib/mojo_magick/opt_builder.rb

@@ -17,9 +17,7 @@ module MojoMagick
 
     # Add files to command line, formatted if necessary
     def file(*args)
-      args.each do |arg|
-        add_formatted arg
-      end
+      @opts << args
       self
     end
     alias files file
@@ -30,20 +28,16 @@ module MojoMagick
 
     # annotate takes non-standard args
     def annotate(*args)
-      @opts << '-annotate'
+      @opts << "-annotate"
       arguments = args.join.split
-      arguments.unshift '0' if arguments.length == 1
-      arguments.each do |arg|
-        add_formatted arg
-      end
+      arguments.unshift "0" if arguments.length == 1
+      @opts << arguments
     end
 
     # Create a temporary file for the given image and add to command line
     def format(*args)
-      @opts << '-format'
-      args.each do |arg|
-        add_formatted arg
-      end
+      @opts << "-format"
+      @opts << args
     end
 
     def blob(*args)
@@ -65,32 +59,29 @@ module MojoMagick
 
     # Generic commands. Arguments will be formatted if necessary
     def method_missing(command, *args)
-      @opts << if command.to_s[-1, 1] == '!'
+      @opts << if command.to_s[-1, 1] == "!"
                  "+#{command.to_s.chop}"
                else
                  "-#{command}"
                end
-      args.each do |arg|
-        add_formatted arg
-      end
+      @opts << args
       self
     end
 
     def to_s
-      @opts.join ' '
+      to_a.join " "
     end
 
-    protected
-
-    def add_formatted(arg)
-      # Quote anything that would cause problems on *nix or windows
-      @opts << quoted_arg(arg)
+    def to_a
+      @opts.flatten
     end
 
+    protected
+
     def quoted_arg(arg)
-      return arg unless arg =~ /[#'<>^|&();` ]/
+      return arg unless /[#'<>^|&();` ]/.match?(arg)
 
-      ['"', arg.gsub('"', '\"').gsub("'", "\'"), '"'].join
+      ['"', arg.gsub('"', '\"').tr("'", "\'"), '"'].join
     end
   end
 end

data/lib/mojo_magick/util/parser.rb

@@ -1,3 +1,4 @@
+# rubocop:disable Lint/AssignmentInCondition
 module MojoMagick
   module Util
     class Parser
@@ -10,9 +11,10 @@ module MojoMagick
         while begin; line = enumerator.next; rescue StopIteration; line = nil; end
           line.chomp!
           line = enumerator.next if line.nil? || line.empty? || (/^\s+$/ =~ line)
-          if m = /^\s*Font:\s+(.*)$/.match(line)
+          m = /^\s*Font:\s+(.*)$/.match(line)
+          if m
             name = m[1].strip
-            fonts[name] = {name: name}
+            fonts[name] = { name: name }
           else
             key_val = line.split(/:/).map(&:strip)
             k = key_val[0].downcase.to_sym
@@ -20,46 +22,7 @@ module MojoMagick
             fonts[name][k] = v if k && name
           end
         end
-        fonts.values.map { |f| MojoMagick::Font.new f}
-      end
-
-      def parse_limits(raw_limits)
-        row_limits = raw_limits.split("\n")
-        header = row_limits[0].chomp
-        data = row_limits[2].chomp
-        resources = header.strip.split
-        limits = data.strip.split
-
-        actual_values = {}
-        readable_values = {}
-
-        resources.each_index do |i|
-          resource = resources[i].downcase.to_sym
-          scale = limits[i].match(/[a-z]+$/) || []
-          value = limits[i].match(/^[0-9]+/)
-          unscaled_value = value ? value[0].to_i : -1
-          scaled_value = case scale[0]
-                         when 'eb'
-                           unscaled_value * (2**60)
-                         when 'pb'
-                           unscaled_value * (2**50)
-                         when 'tb'
-                           unscaled_value * (2**40)
-                         when 'gb'
-                           unscaled_value * (2**30)
-                         when 'mb'
-                           unscaled_value * (2**20)
-                         when 'kb'
-                           unscaled_value * (2**10)
-                         when 'b'
-                           unscaled_value
-                         else
-                           unscaled_value
-                         end
-          actual_values[resource] = scaled_value
-          readable_values[resource] = limits[i]
-        end
-        [actual_values, readable_values]
+        fonts.values.map { |f| MojoMagick::Font.new f }
       end
     end
   end

data/lib/mojo_magick/version.rb

@@ -1,3 +1,3 @@
 module MojoMagick
-  VERSION = '0.5.7'.freeze
+  VERSION = "0.6.0"
 end

data/mojo_magick.gemspec

@@ -1,7 +1,7 @@
-$:.push File.expand_path('lib', __dir__)
-require 'mojo_magick/version'
+$LOAD_PATH.push File.expand_path("lib", __dir__)
+require "mojo_magick/version"
 
-post_install_message = <<~EOF
+post_install_message = <<~EOPOST_INSTALL
 
   Thanks for installing MojoMagick - keepin it simple!
 
@@ -10,29 +10,33 @@ post_install_message = <<~EOF
   If you plan to build images with text (using the "label" method) you'll need freetype and ghostscript as well.
   Check out http://www.freetype.org and http://ghostscript.com respectively for installation info.
 
-EOF
+EOPOST_INSTALL
 
 Gem::Specification.new do |s|
-  s.name = 'mojo_magick'
-  s.license = 'MIT'
+  s.name = "mojo_magick"
+  s.license = "MIT"
   s.version     = MojoMagick::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.authors     = ['Steve Midgley', 'Elliot Nelson', 'Jon Rogers']
-  s.email       = ['science@misuse.org', 'jon@rcode5.com']
-  s.homepage    = 'http://github.com/rcode5/mojo_magick'
+  s.authors     = ["Steve Midgley", "Elliot Nelson", "Jon Rogers"]
+  s.email       = ["science@misuse.org", "jon@rcode5.com"]
+  s.homepage    = "http://github.com/rcode5/mojo_magick"
   s.summary     = "mojo_magick-#{MojoMagick::VERSION}"
-  s.description = 'Simple Ruby stateless module interface to imagemagick.'
+  s.description = "Simple Ruby stateless module interface to imagemagick."
+  s.required_ruby_version = ">= 2.6.0"
 
-  s.rubyforge_project = 'mojo_magick'
+  s.rubyforge_project = "mojo_magick"
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
-  s.require_paths = ['lib']
-  s.add_development_dependency('minitest')
-  s.add_development_dependency('rake')
-  s.add_development_dependency('rspec-expectations')
-  s.add_development_dependency('simplecov')
+  s.require_paths = ["lib"]
+  s.add_development_dependency("bundler")
+  s.add_development_dependency("bundle-audit")
+  s.add_development_dependency("minitest")
+  s.add_development_dependency("rake")
+  s.add_development_dependency("rspec-expectations")
+  s.add_development_dependency("rubocop")
+  s.add_development_dependency("rubocop-performance")
 
   s.post_install_message = post_install_message
 end

data/test/font_test.rb

@@ -1,6 +1,6 @@
-require File.join(File.dirname(__FILE__), 'test_helper')
+require_relative "test_helper"
 
-IDENTIFY_FONT_RESPONSE = <<~EOF.freeze
+IDENTIFY_FONT_RESPONSE = <<~EO_FONTS
   Font: Zapf-Dingbats
       family: Zapf Dingbats
       style: Normal
@@ -13,7 +13,7 @@ IDENTIFY_FONT_RESPONSE = <<~EOF.freeze
       stretch: Normal
       weight: 400
       glyphs: /Library/Fonts/Zapfino.ttf
-EOF
+EO_FONTS
 
 class FontTest < MiniTest::Test
   def test_font
@@ -21,8 +21,8 @@ class FontTest < MiniTest::Test
     assert_nil f.name
     assert_equal f.valid?, false
 
-    f = MojoMagick::Font.new(name: 'Zapfino', weight: 400)
-    assert_equal f.name, 'Zapfino'
+    f = MojoMagick::Font.new(name: "Zapfino", weight: 400)
+    assert_equal f.name, "Zapfino"
     assert_equal f.valid?, true
     assert_equal f.weight, 400
   end

data/test/fonts_test.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), 'test_helper')
+require_relative "test_helper"
 
 class FontsTest < MiniTest::Test
   def test_get_fonts

data/test/mojo_magick_test.rb

@@ -1,20 +1,20 @@
-require File.join(File.dirname(__FILE__), 'test_helper')
+require_relative "test_helper"
 
 class MojoMagickTest < MiniTest::Test
   # we keep a fixtures path and a working path so that we can easily test image
   # manipulation routines without tainting the original images
   def setup
-    @fixtures_path = File.expand_path(File.join(File.dirname(__FILE__), 'fixtures'))
-    @working_path = File.join(@fixtures_path, 'tmp')
+    @fixtures_path = File.expand_path(File.join(File.dirname(__FILE__), "fixtures"))
+    @working_path = File.join(@fixtures_path, "tmp")
   end
 
   def reset_images
     FileUtils.rm_r(@working_path) if File.exist?(@working_path)
     FileUtils.mkdir(@working_path)
-    Dir.glob(File.join(@fixtures_path, '*')).each do |file|
+    Dir.glob(File.join(@fixtures_path, "*")).each do |file|
       FileUtils.cp(file, @working_path) if File.file?(file)
     end
-    @test_image = File.join(@working_path, '5742.jpg')
+    @test_image = File.join(@working_path, "5742.jpg")
   end
 
   def test_get_image_size
@@ -30,9 +30,9 @@ class MojoMagickTest < MiniTest::Test
     # test basic resizing
     reset_images
     orig_image_size = File.size(@test_image)
-    size_test_temp = Tempfile.new('mojo_test')
+    size_test_temp = Tempfile.new("mojo_test")
     size_test = size_test_temp.path
-    retval = MojoMagick.resize(@test_image, size_test, {width: 100, height: 100})
+    retval = MojoMagick.resize(@test_image, size_test, { width: 100, height: 100 })
     assert_equal size_test, retval
     assert_equal orig_image_size, File.size(@test_image)
     assert_equal retval, size_test
@@ -41,7 +41,7 @@ class MojoMagickTest < MiniTest::Test
     assert_equal 67, new_dimensions[:width]
 
     # we should be able to resize image right over itself
-    retval = MojoMagick.resize(@test_image, @test_image, {width: 100, height: 100})
+    retval = MojoMagick.resize(@test_image, @test_image, { width: 100, height: 100 })
     assert_equal @test_image, retval
     refute_equal orig_image_size, File.size(@test_image)
     new_dimensions = MojoMagick.get_image_size(@test_image)
@@ -52,7 +52,7 @@ class MojoMagickTest < MiniTest::Test
   def test_image_resize_with_percentage
     reset_images
     original_size = MojoMagick.get_image_size(@test_image)
-    retval = MojoMagick.resize(@test_image, @test_image, {percent: 50})
+    retval = MojoMagick.resize(@test_image, @test_image, { percent: 50 })
     assert_equal @test_image, retval
     new_dimensions = MojoMagick.get_image_size(@test_image)
     %i[height width].each do |dim|
@@ -63,9 +63,9 @@ class MojoMagickTest < MiniTest::Test
   def test_shrink_with_big_dimensions
     # image shouldn't resize if we specify very large dimensions and specify "shrink_only"
     reset_images
-    size_test_temp = Tempfile.new('mojo_test')
+    size_test_temp = Tempfile.new("mojo_test")
     size_test = size_test_temp.path
-    retval = MojoMagick.shrink(@test_image, size_test, {width: 1000, height: 1000})
+    retval = MojoMagick.shrink(@test_image, size_test, { width: 1000, height: 1000 })
     assert_equal size_test, retval
     new_dimensions = MojoMagick.get_image_size(@test_image)
     assert_equal 500, new_dimensions[:height]
@@ -75,7 +75,7 @@ class MojoMagickTest < MiniTest::Test
   def test_shrink
     reset_images
     # image should resize if we specify small dimensions and shrink_only
-    retval = MojoMagick.shrink(@test_image, @test_image, {width: 1000, height: 100})
+    retval = MojoMagick.shrink(@test_image, @test_image, { width: 1000, height: 100 })
     assert_equal @test_image, retval
     new_dimensions = MojoMagick.get_image_size(@test_image)
     assert_equal 100, new_dimensions[:height]
@@ -85,7 +85,7 @@ class MojoMagickTest < MiniTest::Test
   def test_resize_with_shrink_only_options
     reset_images
     # image should resize if we specify small dimensions and shrink_only
-    retval = MojoMagick.resize(@test_image, @test_image, {shrink_only: true, width: 400, height: 400})
+    retval = MojoMagick.resize(@test_image, @test_image, { shrink_only: true, width: 400, height: 400 })
     assert_equal @test_image, retval
     new_dimensions = MojoMagick.get_image_size(@test_image)
     assert_equal 400, new_dimensions[:height]
@@ -95,7 +95,8 @@ class MojoMagickTest < MiniTest::Test
   def test_expand_with_small_dim
     # image shouldn't resize if we specify small dimensions and expand_only
     reset_images
-    retval = MojoMagick.expand(@test_image, @test_image, {width: 10, height: 10})
+    _orig_image_size = File.size(@test_image)
+    retval = MojoMagick.expand(@test_image, @test_image, { width: 10, height: 10 })
     assert_equal @test_image, retval
     new_dimensions = MojoMagick.get_image_size(@test_image)
     assert_equal 500, new_dimensions[:height]
@@ -105,7 +106,7 @@ class MojoMagickTest < MiniTest::Test
   def test_expand
     reset_images
     # image should resize if we specify large dimensions and expand_only
-    retval = MojoMagick.expand(@test_image, @test_image, {width: 1000, height: 1000})
+    retval = MojoMagick.expand(@test_image, @test_image, { width: 1000, height: 1000 })
     assert_equal @test_image, retval
     new_dimensions = MojoMagick.get_image_size(@test_image)
     assert_equal 1000, new_dimensions[:height]
@@ -114,17 +115,19 @@ class MojoMagickTest < MiniTest::Test
 
   def test_invalid_images
     # test bad images
-    bad_image = File.join(@working_path, 'not_an_image.jpg')
-    zero_image = File.join(@working_path, 'zero_byte_image.jpg')
-    assert_raises(MojoMagick::MojoFailed) {MojoMagick.get_image_size(bad_image)}
-    assert_raises(MojoMagick::MojoFailed) {MojoMagick.get_image_size(zero_image)}
-    assert_raises(MojoMagick::MojoFailed) {MojoMagick.get_image_size('/file_does_not_exist_here_ok.jpg')}
+    bad_image = File.join(@working_path, "not_an_image.jpg")
+    zero_image = File.join(@working_path, "zero_byte_image.jpg")
+    assert_raises(MojoMagick::MojoFailed) { MojoMagick.get_image_size(bad_image) }
+    assert_raises(MojoMagick::MojoFailed) { MojoMagick.get_image_size(zero_image) }
+    assert_raises(MojoMagick::MojoFailed) do
+      MojoMagick.get_image_size("/file_does_not_exist_here_ok.jpg")
+    end
   end
 
   def test_resize_with_fill
     reset_images
-    @test_image = File.join(@working_path, '5742.jpg')
-    MojoMagick.resize(@test_image, @test_image, {fill: true, width: 100, height: 100})
+    @test_image = File.join(@working_path, "5742.jpg")
+    MojoMagick.resize(@test_image, @test_image, { fill: true, width: 100, height: 100 })
     dim = MojoMagick.get_image_size(@test_image)
     assert_equal 100, dim[:width]
     assert_equal 150, dim[:height]
@@ -132,8 +135,8 @@ class MojoMagickTest < MiniTest::Test
 
   def test_resize_with_fill_and_crop
     reset_images
-    @test_image = File.join(@working_path, '5742.jpg')
-    MojoMagick.resize(@test_image, @test_image, {fill: true, crop: true, width: 150, height: 120})
+    @test_image = File.join(@working_path, "5742.jpg")
+    MojoMagick.resize(@test_image, @test_image, { fill: true, crop: true, width: 150, height: 120 })
     dim = MojoMagick.get_image_size(@test_image)
     assert_equal 150, dim[:width]
     assert_equal 120, dim[:height]
@@ -141,25 +144,25 @@ class MojoMagickTest < MiniTest::Test
 
   def test_tempfile
     # Create a tempfile and return the path
-    filename = MojoMagick.tempfile('binary data')
-    File.open(filename, 'rb') do |f|
-      assert_equal f.read, 'binary data'
+    filename = MojoMagick.tempfile("binary data")
+    File.open(filename, "rb") do |f|
+      assert_equal f.read, "binary data"
     end
   end
 
   def test_label
     reset_images
-    out_image = File.join(@working_path, 'label_test.png')
+    out_image = File.join(@working_path, "label_test.png")
 
     MojoMagick.convert do |c|
-      c.label 'rock the house'
+      c.label "rock the house"
       c.file out_image
     end
   end
 
   def test_label_with_quote
     reset_images
-    out_image = File.join(@working_path, 'label_test.png')
+    out_image = File.join(@working_path, "label_test.png")
 
     MojoMagick.convert do |c|
       c.label 'rock "the house'
@@ -169,17 +172,17 @@ class MojoMagickTest < MiniTest::Test
 
   def test_label_with_apostrophe
     reset_images
-    out_image = File.join(@working_path, 'label_test.png')
+    out_image = File.join(@working_path, "label_test.png")
 
     MojoMagick.convert do |c|
-      c.label 'rock \'the house'
+      c.label "rock 'the house"
       c.file out_image
     end
   end
 
   def test_label_with_quotes
     reset_images
-    out_image = File.join(@working_path, 'label_test.png')
+    out_image = File.join(@working_path, "label_test.png")
 
     MojoMagick.convert do |c|
       c.label 'this is "it!"'
@@ -189,23 +192,25 @@ class MojoMagickTest < MiniTest::Test
 
   def test_bad_command
     MojoMagick.convert do |c|
-      c.unknown_option 'fail'
-      c.file 'boogabooga.whatever'
+      c.unknown_option "fail"
+      c.file "boogabooga.whatever"
     end
   rescue MojoMagick::MojoFailed => e
-    assert e.message.include?('unrecognized option'), 'Unable to find ImageMagick commandline error in the message'
-    assert e.message.include?('convert.c/ConvertImageCommand'), 'Unable to find ImageMagick commandline error in the message'
+    assert e.message.include?("unrecognized option"),
+           "Unable to find ImageMagick commandline error in the message"
+    assert e.message.include?("convert.c/ConvertImageCommand"),
+           "Unable to find ImageMagick commandline error in the message"
   end
 
   def test_blob
     reset_images
 
     # RGB8 test
-    data = (16.times.map { [rand > 0.5 ? 0 : 255] * 3 }).flatten
-    bdata = data.pack 'C' * data.size
-    out = 'out.png'
+    data = (Array.new(16) { [rand > 0.5 ? 0 : 255] * 3 }).flatten
+    bdata = data.pack "C" * data.size
+    out = "out.png"
     MojoMagick.convert(nil, "png:#{out}") do |c|
-      c.blob bdata, format: :rgb, depth: 8, size: '4x4'
+      c.blob bdata, format: :rgb, depth: 8, size: "4x4"
     end
     r = MojoMagick.get_image_size(out)
     assert r[:height] == 4
@@ -214,13 +219,13 @@ class MojoMagickTest < MiniTest::Test
 
   def test_command_helpers
     reset_images
-    test_image = File.join(@working_path, '5742.jpg')
-    out_image = File.join(@working_path, 'out1.jpg')
+    test_image = File.join(@working_path, "5742.jpg")
+    out_image = File.join(@working_path, "out1.jpg")
 
     # Simple convert test
     MojoMagick.convert do |c|
       c.file test_image
-      c.crop '92x64+0+0'
+      c.crop "92x64+0+0"
       c.repage!
       c.file out_image
     end
@@ -230,7 +235,7 @@ class MojoMagickTest < MiniTest::Test
 
     # Simple mogrify test
     MojoMagick.mogrify do |m|
-      m.crop '32x32+0+0'
+      m.crop "32x32+0+0"
       m.repage!
       m.file out_image
     end
@@ -240,7 +245,7 @@ class MojoMagickTest < MiniTest::Test
 
     # Convert test, using file shortcuts
     MojoMagick.convert(test_image, out_image) do |c|
-      c.crop '100x100+0+0'
+      c.crop "100x100+0+0"
       c.repage!
     end
     retval = MojoMagick.get_image_size(out_image)
@@ -248,26 +253,26 @@ class MojoMagickTest < MiniTest::Test
     assert_equal 100, retval[:height]
 
     # Mogrify test, using file shortcut
-    MojoMagick.mogrify(out_image) { |m| m.shave('25x25').repage! }
+    MojoMagick.mogrify(out_image) { |m| m.shave("25x25").repage! }
     retval = MojoMagick.get_image_size(out_image)
     assert_equal 50, retval[:width]
     assert_equal 50, retval[:height]
 
     # RGB8 test
-    bdata = 'aaaaaabbbbbbccc'
-    out = 'out.png'
+    bdata = "aaaaaabbbbbbccc"
+    out = "out.png"
     MojoMagick.convert do |c|
-      c.blob bdata, format: :rgb, depth: 8, size: '5x1'
+      c.blob bdata, format: :rgb, depth: 8, size: "5x1"
       c.file out
     end
     r = MojoMagick.get_image_size(out)
     assert r[:height] == 1
     assert r[:width] == 5
 
-    bdata = '1111222233334444'
-    out = 'out.png'
+    bdata = "1111222233334444"
+    out = "out.png"
     MojoMagick.convert do |c|
-      c.blob bdata, format: :rgba, depth: 8, size: '4x1'
+      c.blob bdata, format: :rgba, depth: 8, size: "4x1"
       c.file out
     end
     r = MojoMagick.get_image_size(out)