mojfile-uploader-api-client 0.4 → 0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d79a32a36f71f6ebdd71a92068f08488b38c1bc5
-  data.tar.gz: 8adf54c66f79831bc875985659f9c90d07133fc2
+  metadata.gz: f0198b271e429f4657e7a7d850e448b2b9b88b2a
+  data.tar.gz: 4a159a3c4c6c550a3d1bbd8b72ec73ccf4189383
 SHA512:
-  metadata.gz: 1f5092786df273f8575cb5db00efe609d1c3140fda204d14cb9336c310355885514dfafe8b324c77eb8eda66867302e954a5fb607b1578bb17ce436c22feee60
-  data.tar.gz: 19aa2bf089f5ffbdf110833f421592e332113b766b4d383ba14d346a493ad293d8f0ceea6e70004b46443ad4a85d130d7fcd5ea47bada01383b2b3e5d11aa597
+  metadata.gz: '015208cbdd25303db59d402d79efa0f4546ac5e4159e2738f8b9c12d79441866b8696e0b4f631b9ee322efed0a1e8c668cf7b4fc4e8061600bd4eadf76aafcdb'
+  data.tar.gz: 04fc4660751d8bc150af1d108a0d82e1d92e71db62cb05b5f28d87d8452f828da70154806a2b6790a0d7b14240f4086a13f71967296271ce8188d75ceaf048e7

data/.rubocop.yml

@@ -711,7 +711,7 @@ Style/LineEndConcatenation:
                  line end.
   Enabled: false
 
-Style/MethodCallParentheses:
+Style/MethodCallWithoutArgsParentheses:
   Description: 'Do not use parentheses for method calls with no arguments.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-args-no-parens'
   Enabled: false

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mojfile-uploader-api-client (0.4)
+    mojfile-uploader-api-client (0.5)
       rest-client (~> 2.0.0)
 
 GEM
@@ -79,7 +79,7 @@ GEM
     pry-byebug (3.4.1)
       byebug (~> 9.0)
       pry (~> 0.10)
-    rainbow (2.1.0)
+    rainbow (2.2.1)
     rake (10.5.0)
     regexp_parser (0.3.6)
     rest-client (2.0.0)
@@ -99,8 +99,8 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
-    rubocop (0.45.0)
-      parser (>= 2.3.1.1, < 3.0)
+    rubocop (0.47.1)
+      parser (>= 2.3.3.1, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.7)
@@ -116,7 +116,7 @@ GEM
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.2)
-    unicode-display_width (1.1.1)
+    unicode-display_width (1.1.3)
     unparser (0.2.5)
       abstract_type (~> 0.0.7)
       adamantium (~> 0.2.0)

data/lib/mojfile_uploader_api_client.rb

@@ -1,6 +1,7 @@
 require 'json'
 require 'rest-client'
 require 'mojfile_uploader_api_client/version'
+require 'mojfile_uploader_api_client/errors'
 require 'mojfile_uploader_api_client/response'
 require 'mojfile_uploader_api_client/http_client'
 require 'mojfile_uploader_api_client/file_reference'
@@ -13,11 +14,6 @@ module MojFileUploaderApiClient
   INFECTED_FILE_RESPONSE_CODE = 400
   NOT_FOUND_RESPONSE_CODE = 404
 
-  class Unavailable < StandardError; end
-  class RequestError < StandardError; end
-  class InfectedFileError < StandardError; end
-  class NotFoundError < StandardError; end
-
   def self.add_file(params)
     response = AddFile.new(params).call
 
@@ -26,14 +22,14 @@ module MojFileUploaderApiClient
     elsif response.code.equal?(INFECTED_FILE_RESPONSE_CODE)
       raise InfectedFileError
     else
-      raise RequestError
+      raise RequestError.new('Could not add file', response.code, response.body)
     end
   end
 
   def self.delete_file(params)
     response = DeleteFile.new(params).call
 
-    raise RequestError unless response.success?
+    raise RequestError.new('Could not delete file', response.code, response.body) unless response.success?
     response.body
   end
 
@@ -45,7 +41,7 @@ module MojFileUploaderApiClient
     elsif response.code.equal?(NOT_FOUND_RESPONSE_CODE)
       raise NotFoundError
     else
-      raise RequestError
+      raise RequestError.new('Could not list files', response.code, response.body)
     end
   end
 end

data/lib/mojfile_uploader_api_client/errors.rb

@@ -0,0 +1,23 @@
+module MojFileUploaderApiClient
+  class RequestError < StandardError
+    attr_reader :code, :body
+
+    def initialize(message, code, body)
+      super(message)
+      @code = code
+      @body = body
+    end
+  end
+
+  class UnparsableResponseError < RuntimeError
+    attr_reader :raw_body
+
+    def initialize(message, raw_body)
+      super(message)
+      @raw_body = raw_body
+    end
+  end
+
+  class InfectedFileError < StandardError; end
+  class NotFoundError < StandardError; end
+end

data/lib/mojfile_uploader_api_client/response.rb

@@ -1,8 +1,6 @@
 module MojFileUploaderApiClient
   class Response
-    class UnparsableResponseError < RuntimeError; end
-
-    attr_accessor :code
+    attr_accessor :code, :raw_body
 
     def initialize(code:, body:)
       @code = code
@@ -24,10 +22,10 @@ module MojFileUploaderApiClient
     private
 
     def parse_body
-      return if @raw_body.nil? || @raw_body.empty?
-      JSON.parse(@raw_body, symbolize_names: true)
+      return if raw_body.nil? || raw_body.empty?
+      JSON.parse(raw_body, symbolize_names: true)
     rescue JSON::ParserError
-      raise UnparsableResponseError
+      raise UnparsableResponseError.new('Invalid JSON response', raw_body)
     end
   end
 end

data/lib/mojfile_uploader_api_client/version.rb

@@ -1,3 +1,3 @@
 module MojFileUploaderApiClient
-  VERSION = '0.4'
+  VERSION = '0.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mojfile-uploader-api-client
 version: !ruby/object:Gem::Version
-  version: '0.4'
+  version: '0.5'
 platform: ruby
 authors:
 - Jesus Laiz
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-27 00:00:00.000000000 Z
+date: 2017-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -144,6 +144,7 @@ files:
 - lib/mojfile_uploader_api_client.rb
 - lib/mojfile_uploader_api_client/add_file.rb
 - lib/mojfile_uploader_api_client/delete_file.rb
+- lib/mojfile_uploader_api_client/errors.rb
 - lib/mojfile_uploader_api_client/file_reference.rb
 - lib/mojfile_uploader_api_client/http_client.rb
 - lib/mojfile_uploader_api_client/list_files.rb