modulr-api 0.0.27 → 0.0.28

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a8dc5b6d30c7a03695474663299d7144939699e1c02a95d2a7cf99137142912
-  data.tar.gz: 92f676165aff5e801db76c001da6373a56454a97dbd18901dd53a07ac0656ef3
+  metadata.gz: 0d095d43ccee60d099ae8d7ac57d86cd8104259577ff908fb5cfcd6f33d260a5
+  data.tar.gz: a5a1e05cda5006f6397baa5460e67b7986ef537d742f9a2eeae7b4d69869e087
 SHA512:
-  metadata.gz: 93df6c1115b144cf48b6483873a336deb266698067b7cb2bb68934757bf8a81cb4ff44f67af0447fd5039708f93b1da7899989e6243d26e158bfb12aadebecb1
-  data.tar.gz: 684f71d53386979cfb5840d468b9d461e8f373960a06a76e961fcaa3f052d72bc4a2626c28c345e0fd30e4938b33b4de35ff3c475ac49ad217626f668519c989
+  metadata.gz: 9befecbaa71d544887fefab95c0d677fa4134abdf2964fee2a275c006ac534d929dd55ccf37c783624ad646b93a888ff03fe9ae93314f2db037533eb9ed6661a
+  data.tar.gz: 9cd97815ad18668bba5fc12d72721c46d742466086afaf95cb26cc81eb05e54caa1c9498a31d0e6476eb5690e81a63d1e77317d090e00cddaabaa9b17d2a24b6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    modulr-api (0.0.27)
+    modulr-api (0.0.28)
       faraday (~> 1.0)
       faraday_middleware (~> 1.0)
 

data/lib/modulr/api/payments_service.rb

@@ -3,10 +3,10 @@
 module Modulr
   module API
     class PaymentsService < Service
-      def find(id:)
+      def find(id:, **opts)
         response = client.get("/payments", { id: id })
         payment_attributes = response.body[:content]&.first
-        raise NotFoundError, "Payment #{id} not found" unless payment_attributes
+        payment_attributes_with_type(id, payment_attributes) if include_transaction?(opts)
 
         Resources::Payments::Payment.new(response.env[:raw_body], payment_attributes)
       end
@@ -15,7 +15,15 @@ module Modulr
         return find(id: opts[:id]) if opts[:id]
 
         response = client.get("/payments", build_query_params(opts))
-        Resources::Payments::Collection.new(response.env[:raw_body], response.body[:content])
+        payments_attributes = response.body[:content]
+
+        if include_transaction?(opts)
+          payments_attributes.each do |payment_attributes|
+            payment_attributes_with_type(payment_attributes[:id], payment_attributes)
+          end
+        end
+
+        Resources::Payments::Collection.new(response.env[:raw_body], payments_attributes)
       end
 
       # rubocop:disable Metrics/ParameterLists
@@ -52,6 +60,47 @@ module Modulr
         end
       end
       # rubocop:enable Metrics/AbcSize
+
+      private def include_transaction?(opts)
+        return true if opts[:include_transaction].nil?
+
+        opts[:include_transaction]
+      end
+
+      private def payment_attributes_with_type(id, attrs)
+        raise NotFoundError, "Payment #{id} not found" unless attrs
+
+        @details = attrs[:details]
+        type = if outgoing && !internal
+                 fetch_transaction_type
+               elsif incoming
+                 @details[:type]
+               elsif internal
+                 @details[:destinationType]
+               end
+
+        attrs[:type] = type
+        attrs
+      end
+
+      private def fetch_transaction_type
+        client.transactions.list(
+          account_id: @details[:sourceAccountId],
+          source_id: @details[:id]
+        )&.first&.type
+      end
+
+      private def incoming
+        @details[:sourceAccountId].nil?
+      end
+
+      private def internal
+        @details[:sourceAccountId] && @details[:destinationId]
+      end
+
+      private def outgoing
+        !@details[:sourceAccountId].nil? && @details[:destinationId].nil?
+      end
     end
   end
 end

data/lib/modulr/api/services.rb

@@ -1,9 +1,6 @@
 # frozen_string_literal: true
 
 require_relative "service"
-require_relative "accounts_service"
-require_relative "payments_service"
-require_relative "transactions_service"
 
 module Modulr
   module API

data/lib/modulr/resources/payments/payment.rb

@@ -4,7 +4,7 @@ module Modulr
   module Resources
     module Payments
       class Payment < Base
-        attr_reader :details, :end_to_end_id
+        attr_reader :details, :end_to_end_id, :network, :scheme
 
         map :id, [:id, :payment_reference_id]
         map :status
@@ -13,10 +13,11 @@ module Modulr
         map :createdDate, :created_at
         map :approvalStatus, :approval_status
         map :message, :message
+        map :type
 
         def initialize(raw_response, attributes = {})
           super(raw_response, attributes)
-          @details = parse_details(attributes)
+          parse_attributes(attributes)
           @end_to_end_id = if incoming_sepa?(attributes)
                              sepa_end_to_end_id(attributes)
                            elsif incoming_faster_payments?(attributes)
@@ -51,18 +52,71 @@ module Modulr
           attributes[:details].dig(:details, :fpsTransaction, :paymentInfo, :endToEndId)
         end
 
+        private def parse_attributes(attributes)
+          parse_details(attributes)
+          parse_scheme if type
+        end
+
         private def parse_details(attributes)
           details = attributes[:details]
+          detail_type = details&.dig(:type) || details&.dig(:destinationType)
 
-          case details&.dig(:type) || details&.dig(:destinationType)
+          case detail_type
           when "PI_SECT", "PI_SEPA_INST", "PI_FAST", "PI_REV"
-            Details::Incoming::General.new(nil, details)
+            incoming_detail(details)
           when "ACCOUNT"
-            Details::Incoming::Internal.new(nil, details)
+            incoming_internal_details(details)
+          else
+            outgoing_detail(details)
+          end
+        end
+
+        private def parse_scheme
+          case type
+          when "PI_SECT", "PO_SECT"
+            sepa_regular
+          when "PI_SEPA_INST", "PO_SEPA_INST"
+            sepa_instant
+          when "PI_FAST", "PO_FAST"
+            faster_payments
+          when "ACCOUNT", "INT_INTERC"
+            internal
           else
-            Details::Outgoing::General.new(nil, details)
+            raise "Unable to find network and scheme for payment with ID: #{id} and Type: #{type}"
           end
         end
+
+        private def sepa_regular
+          @network = "SEPA"
+          @scheme = "SEPA Credit Transfers"
+        end
+
+        private def sepa_instant
+          @network = "SEPA"
+          @scheme = "SEPA Instant Credit Transfers"
+        end
+
+        private def faster_payments
+          @network = "FPS"
+          @scheme = "Faster Payments"
+        end
+
+        private def internal
+          @network = "INTERNAL"
+          @scheme = "INTERNAL"
+        end
+
+        private def incoming_detail(details)
+          @details = Details::Incoming::General.new(nil, details)
+        end
+
+        private def outgoing_detail(details)
+          @details = Details::Outgoing::General.new(nil, details)
+        end
+
+        private def incoming_internal_details(details)
+          @details = Details::Incoming::Internal.new(nil, details)
+        end
       end
     end
   end

data/lib/modulr/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Modulr
-  VERSION = "0.0.27"
+  VERSION = "0.0.28"
 end

data/lib/modulr.rb

@@ -8,8 +8,9 @@ require_relative "modulr/api/service"
 require_relative "modulr/api/services"
 require_relative "modulr/api/accounts_service"
 require_relative "modulr/api/customers_service"
-require_relative "modulr/api/payments_service"
 require_relative "modulr/api/notifications_service"
+require_relative "modulr/api/payments_service"
+require_relative "modulr/api/transactions_service"
 
 require_relative "modulr/resources/base"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: modulr-api
 version: !ruby/object:Gem::Version
-  version: 0.0.27
+  version: 0.0.28
 platform: ruby
 authors:
 - Aitor García Rey
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-23 00:00:00.000000000 Z
+date: 2023-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday