modulorails 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1be41ee3e5898a6e283359c6df4525cd77cec83e6a37d255996316a305511722
-  data.tar.gz: dec467bed1e055a3c0d11c948563eaa6eead755be40e6b7185cbb2678f54e180
+  metadata.gz: 32e635cab679e5afa08f8ab3ef42f5370502098330178492b1bd067d6b842fc7
+  data.tar.gz: eec6c93a7a28f5b8552a8e94cba08a3ed826867ad3fb8eef63b9318c3eff68b7
 SHA512:
-  metadata.gz: a69ef3ab27fd2e422e5bc7ce588bfa46ca273281ca2e43de7336048b038c1328b22a970066856bd7320df0b144e637348e7d1139cce614c2d068083247d3f666
-  data.tar.gz: 7952e968f9bdf475bfe2806933e7e5e5114e8418891dc4dc09809438eb20c804e48a1d85bca8ed558636db64c1b0eca501ea57da5ae03b0eaf4b943a0c466478
+  metadata.gz: 3ccabc6e05b83b6980df9ef747a5961445e2cb6d882bbdde2114697364caad9496c2900d581db3e1b1729e3bf02ed069cb3b2266ee0f74be1ebdf9b2b6fde087
+  data.tar.gz: f9233dfdbb1c7512550036d27dcb7329fedd15b78e07e439bba42a54a6f333e46d4ecc48046bda8e9325e5723f91600bd4b19ed9733c09028fd8efe87bfc379c

data/CHANGELOG.md

@@ -4,6 +4,16 @@ This file is used to list changes made in each version of the gem.
 
 # Unreleased
 
+# 1.7.1
+
+The boot-resilience release. Hardens the gem against several boot-time crash paths so that information gathering and configuration generation can never prevent the host application from starting.
+
+## Fixes
+
+- Fix `initialize_from_database` when the database is unreachable on Rails 7.1+. Connections are now established lazily at query time, so errors surface from `select_value` as `ActiveRecord::StatementInvalid` or adapter-level errors (e.g. `PG::ConnectionBad`) that don't inherit from `ActiveRecordError`. The rescue is broadened to `StandardError` so that DB metadata collection never prevents the application from booting (e.g. running `bin/rails db:create` on a fresh checkout).
+- Guard `Modulorails::Data#initialize_from_configuration` against a missing `config.name`: fall back to the Rails application class name and use safe navigation when deriving `@environment_name`, so a forgotten `config.name '...'` no longer crashes the boot with `NoMethodError: undefined method 'parameterize' for nil`.
+- Move the body construction in `Modulorails.send_data` inside its `begin`/`rescue` block so that an unexpected failure in `Modulorails::Data.new` (e.g. a malformed configuration) is caught instead of bubbling out of `after_initialize` and breaking Rails boot.
+
 # 1.7.0
 
 ## Improvements

data/lib/modulorails/data.rb

@@ -74,12 +74,16 @@ module Modulorails
       # Get the gem's configuration to get the application's usual name, main dev and PM
       configuration = Modulorails.configuration
 
-      # The data written by the user in the configuration
-      # The name is the usual name of the project, the one used in conversations at Modulotech
-      @name = configuration.name
+      # The data written by the user in the configuration.
+      # The name is the usual name of the project, the one used in conversations at Modulotech.
+      # Fall back to the Rails application class name if the user forgot to call `config.name`,
+      # so the gem does not crash the host application's boot.
+      @name = configuration.name || @rails_name
 
-      # A version of the name suitable to name environment variables
-      @environment_name = @name.parameterize.gsub('-', '_').gsub(/\b(\d)/, 'MT_\1').upcase
+      # A version of the name suitable to name environment variables.
+      # Use safe navigation so a fully unnamed application (no configuration name *and* no
+      # detectable Rails class name) leaves @environment_name as nil rather than raising.
+      @environment_name = @name&.parameterize&.gsub('-', '_')&.gsub(/\b(\d)/, 'MT_\1')&.upcase
 
       # The main developer, the lead developer, in short the developer to call when something's
       # wrong with the application ;)
@@ -116,7 +120,11 @@ module Modulorails
       # The version of the database engine; this request works only on MySQL and PostgreSQL
       # It should not be a problem since those are the sole database engines used at Modulotech
       @db_version = db_connection.select_value('SELECT version()')
-    rescue ActiveRecord::NoDatabaseError, ActiveRecord::ConnectionNotEstablished => e
+      # Rescue broadly: on Rails 7.1+ the connection is established lazily at query time, so the
+      # error class can be ActiveRecord::StatementInvalid or even an adapter-level error like
+      # PG::ConnectionBad that does not inherit from ActiveRecordError. Collecting DB metadata
+      # must never prevent the application from booting.
+    rescue StandardError => e
       warn("[Modulorails] Error: #{e.message}")
     end
 

data/lib/modulorails/version.rb

@@ -1,6 +1,6 @@
 module Modulorails
 
-  VERSION = '1.7.0'.freeze
+  VERSION = '1.7.1'.freeze
 
   # Useful to compare the current Ruby version
   COMPARABLE_RUBY_VERSION = Gem::Version.new(RUBY_VERSION)

data/lib/modulorails.rb

@@ -86,11 +86,13 @@ module Modulorails
         'Content-Type' => 'application/json', 'X-MODULORAILS-TOKEN' => configuration.api_key
       }
 
-      # Define the JSON body of the request
-      body = data.to_params.to_json
-
-      # Prevent HTTParty to raise error and crash the server in dev
+      # Prevent HTTParty *and* data collection failures from crashing the server in dev.
+      # `data` lazily instantiates `Modulorails::Data`, which gathers DB/git/gem metadata; any
+      # unexpected failure there must not propagate out of `send_data`.
       begin
+        # Build the JSON body of the request
+        body = data.to_params.to_json
+
         # Post to the configured endpoint on the Intranet
         response = HTTParty.post(configuration.endpoint, headers: headers, body: body)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: modulorails
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Matthieu Ciappara