modulesync 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc930ee899499173ce75a299885bee85d967c158b6cfc7cc4113a73b6b7c82bf
-  data.tar.gz: 86575cd8683f4c89035d0f5018838bd3690d6a625e15480b7683fdd34e966e07
+  metadata.gz: bb584b8ba14d3c54ae9cf5ca91f24e8d1a087e73e45d98e45e79a29f6bbf2578
+  data.tar.gz: c7fcf27f5bd05249da092a80a92b03430909a400b65c8be53671e2ae4a020459
 SHA512:
-  metadata.gz: 6759dc5e250c03c3bf157dfee1a4890dcbd1c986ab735bb01e996cb4e181aa0b901c91f7b5138129915496ed8f514a66e902a0fae44eb466bf125992ef44e03d
-  data.tar.gz: a13a5de75f58baae2a9ad16f958553bc158a9a045b88b2982348f921e3d084aca8f0df575395a8390ed8d7d8ba65c204c06911a8288e55a76ae664c02d4f9f74
+  metadata.gz: b41beb1d73df97a4e006749788f0c6415f8d87c8e7d69cb07a7f74d202bfda4cf238558060d04044080c9b83b71633d182db506820634b92f86887329169b212
+  data.tar.gz: 38f81a8fe37ff9b30f01f59299deb6de1d47ea03c89ea0d0d6df89b83b19f323b1ecaeab349ca7697bff37d9b9b4c7984c1f63083e22c2d721925a93c0d29559

data/.config/cucumber.yml

@@ -0,0 +1 @@
+default: --publish-quiet

data/.rubocop.yml

@@ -1,7 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.0
+  TargetRubyVersion: 2.4
   Exclude:
     - 'vendor/**/*'
     - 'tmp/**/*'
@@ -25,3 +25,8 @@ Layout/IndentHeredoc:
 # sane line length
 Metrics/LineLength:
   Max: 120
+  Exclude:
+    - 'features/**/*'
+
+Style/FrozenStringLiteralComment:
+  Enabled: false

data/CHANGELOG.md

@@ -2,6 +2,28 @@
 
 All notable changes to this project will be documented in this file.
 
+## [2.0.2](https://github.com/voxpupuli/modulesync/tree/2.0.2) (2021-04-03)
+
+[Full Changelog](https://github.com/voxpupuli/modulesync/compare/2.0.1...2.0.2)
+
+**Fixed bugs:**
+
+- Fix language-dependent Git output handling [\#200](https://github.com/voxpupuli/modulesync/pull/200) ([neomilium](https://github.com/neomilium))
+
+**Closed issues:**
+
+- Add linting \(rubocop\) to Travis CI configuration [\#153](https://github.com/voxpupuli/modulesync/issues/153)
+- Language sensitive GIT handling [\#85](https://github.com/voxpupuli/modulesync/issues/85)
+
+**Merged pull requests:**
+
+- Fix spelling of PR CLI option \(kebab-case\) [\#209](https://github.com/voxpupuli/modulesync/pull/209) ([bittner](https://github.com/bittner))
+- Correctly state which config file to update [\#208](https://github.com/voxpupuli/modulesync/pull/208) ([bittner](https://github.com/bittner))
+- Fix exit status code on failures [\#204](https://github.com/voxpupuli/modulesync/pull/204) ([neomilium](https://github.com/neomilium))
+- Remove monkey patches [\#203](https://github.com/voxpupuli/modulesync/pull/203) ([neomilium](https://github.com/neomilium))
+- Improve tests capabilities by using local/fake remote repositories [\#202](https://github.com/voxpupuli/modulesync/pull/202) ([neomilium](https://github.com/neomilium))
+- Minor modernization and cosmetic fix [\#201](https://github.com/voxpupuli/modulesync/pull/201) ([neomilium](https://github.com/neomilium))
+
 ## [2.0.1](https://github.com/voxpupuli/modulesync/tree/2.0.1) (2020-10-06)
 
 [Full Changelog](https://github.com/voxpupuli/modulesync/compare/2.0.0...2.0.1)

data/Gemfile

@@ -2,9 +2,9 @@ source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 
 gemspec
 
-gem 'cucumber', '< 3.0' if RUBY_VERSION < '2.1'
+gem 'cucumber'
 gem 'octokit', '~> 4.9'
 
 group :release do
-  gem 'github_changelog_generator', :require => false, :git => 'https://github.com/voxpupuli/github-changelog-generator', :branch => 'voxpupuli_essential_fixes'
+  gem 'github_changelog_generator', :require => false
 end

data/README.md

@@ -169,7 +169,7 @@ msync hook activate
 ```
 
 If you have activated the hook but want to make changes to the configuration
-directory (such as changes to managed_modules.yml or modulesync.yml) without
+directory (such as changes to `managed_modules.yml` or `modulesync.yml`) without
 touching the modules, you can deactivate the hook.
 
 ```
@@ -191,8 +191,8 @@ or set them per repository in `managed_modules.yml`, using the `github` or
 `gitlab` keys respectively.
 
 For GitHub Enterprise and self-hosted GitLab instances you also need to set the
-`GITHUB_BASE_URL` or `GITLAB_BASE_URL` environment variables, or use the
-`base_url` parameter in `managed_modules.yml`:
+`GITHUB_BASE_URL` or `GITLAB_BASE_URL` environment variables, or specify the
+`base_url` parameter in `modulesync.yml`:
 
 ```yaml
 ---
@@ -214,7 +214,7 @@ Then:
 * Assign labels to the PR/MR with `--pr-labels` or in `modulesync.yml` with
   the `pr_labels` attribute. **NOTE:** `pr_labels` should be a list. When
   using the `--pr-labels` CLI option, you should use a comma separated list.
-* Set the target branch with `--pr_target_branch` or in `modulesync.yml` with
+* Set the target branch with `--pr-target-branch` or in `modulesync.yml` with
   the `pr_target_branch` attribute.
 
 More details for GitHub:

data/features/cli.feature

@@ -4,21 +4,26 @@ Feature: CLI
   Scenario: When passing no arguments to the msync command
     When I run `msync`
     And the output should match /Commands:/
+    Then the exit status should be 1
 
   Scenario: When passing invalid arguments to the msync update command
     When I run `msync update`
     And the output should match /No value provided for required option/
+    Then the exit status should be 1
 
   Scenario: When passing invalid arguments to the msync hook command
     When I run `msync hook`
     And the output should match /Commands:/
+    Then the exit status should be 1
 
-  Scenario: When running the help subcommand
+  Scenario: When running the help command
     When I run `msync help`
     And the output should match /Commands:/
+    Then the exit status should be 0
 
   Scenario: When overriding a setting from the config file on the command line
-    Given a file named "managed_modules.yml" with:
+    Given a puppet module "puppet-test" from "fakenamespace"
+    And a file named "managed_modules.yml" with:
       """
       ---
         - puppet-test
@@ -26,10 +31,10 @@ Feature: CLI
     And a file named "modulesync.yml" with:
       """
       ---
-        namespace: maestrodev
-        git_base: 'git@github.com:'
+      namespace: default
       """
+    And a git_base option appended to "modulesync.yml" for local tests
     And a directory named "moduleroot"
-    When I run `msync update --noop --git-base https://github.com/`
+    When I run `msync update --noop --namespace fakenamespace`
     Then the exit status should be 0
-    And the output should not match /git@github.com:/
+    And the output should match /Syncing fakenamespace/

data/features/hook.feature

@@ -5,8 +5,7 @@ Feature: hook
     Given a directory named ".git/hooks"
     When I run `msync hook activate`
     Then the exit status should be 0
-    Given I run `cat .git/hooks/pre-push`
-    Then the output should contain "bash"
+    And the file named ".git/hooks/pre-push" should contain "bash"
 
   Scenario: Deactivating a hook
     Given a file named ".git/hooks/pre-push" with:
@@ -21,8 +20,7 @@ Feature: hook
     Given a directory named ".git/hooks"
     When I run `msync hook activate -a '--foo bar --baz quux' -b master`
     Then the exit status should be 0
-    Given I run `cat .git/hooks/pre-push`
-    Then the output should match:
+    And the file named ".git/hooks/pre-push" should contain:
       """
-      "\$message" -n puppetlabs -b master --foo bar --baz quux
+      "$message" -n puppetlabs -b master --foo bar --baz quux
       """

data/features/step_definitions/git_steps.rb

@@ -1,47 +1,75 @@
-Given 'a mocked git configuration' do
-  steps %(
-    Given a mocked home directory
-    And I run `git config --global user.name Test`
-    And I run `git config --global user.email test@example.com`
-  )
-end
+require_relative '../../spec/helpers/faker/puppet_module_remote_repo'
 
-Given 'a remote module repository' do
+Given 'a basic setup with a puppet module {string} from {string}' do |name, namespace|
   steps %(
-    Given a directory named "sources"
-    And I run `git clone https://github.com/maestrodev/puppet-test sources/puppet-test`
+    Given a mocked git configuration
+    And a puppet module "#{name}" from "#{namespace}"
     And a file named "managed_modules.yml" with:
       """
       ---
-        - puppet-test
+        - #{name}
       """
+    And a file named "modulesync.yml" with:
+      """
+      ---
+      namespace: #{namespace}
+      """
+    And a git_base option appended to "modulesync.yml" for local tests
   )
-  write_file('modulesync.yml', <<-CONFIG)
----
-  namespace: sources
-  git_base: file://#{expand_path('.')}/
-  CONFIG
 end
 
-Given Regexp.new(/a remote module repository with "(.+?)" as the default branch/) do |branch|
+Given 'a mocked git configuration' do
   steps %(
-    Given a directory named "sources"
-    And I run `git clone --mirror https://github.com/maestrodev/puppet-test sources/puppet-test`
-    And a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
+    Given a mocked home directory
+    And I run `git config --global user.name Aruba`
+    And I run `git config --global user.email aruba@example.com`
   )
-  write_file('modulesync.yml', <<-CONFIG)
----
-  namespace: sources
-  git_base: file://#{expand_path('.')}/
-  CONFIG
-  cd('sources/puppet-test') do
-    steps %(
-      And I run `git branch -M master #{branch}`
-      And I run `git symbolic-ref HEAD refs/heads/#{branch}`
-    )
-  end
+end
+
+Given 'a puppet module {string} from {string}' do |name, namespace|
+  pmrr = ModuleSync::Faker::PuppetModuleRemoteRepo.new(name, namespace)
+  pmrr.populate
+end
+
+Given 'a git_base option appended to "modulesync.yml" for local tests' do
+  File.write "#{Aruba.config.working_directory}/modulesync.yml", "\ngit_base: #{ModuleSync::Faker::PuppetModuleRemoteRepo.git_base}", mode: 'a'
+end
+
+Given 'the puppet module {string} from {string} is read-only' do |name, namespace|
+  pmrr = ModuleSync::Faker::PuppetModuleRemoteRepo.new(name, namespace)
+  pmrr.read_only = true
+end
+
+Then 'the puppet module {string} from {string} should have no commits between {string} and {string}' do |name, namespace, commit1, commit2|
+  pmrr = ModuleSync::Faker::PuppetModuleRemoteRepo.new(name, namespace)
+  expect(pmrr.commit_count_between(commit1, commit2)).to eq 0
+end
+
+Then 'the puppet module {string} from {string} should have( only) {int} commit(s) made by {string}' do |name, namespace, commit_count, author|
+  pmrr = ModuleSync::Faker::PuppetModuleRemoteRepo.new(name, namespace)
+  expect(pmrr.commit_count_by(author)).to eq commit_count
+end
+
+Then 'the puppet module {string} from {string} should have( only) {int} commit(s) made by {string} in branch {string}' do |name, namespace, commit_count, author, branch|
+  pmrr = ModuleSync::Faker::PuppetModuleRemoteRepo.new(name, namespace)
+  expect(pmrr.commit_count_by(author, branch)).to eq commit_count
+end
+
+Then 'the puppet module {string} from {string} should have no commits made by {string}' do |name, namespace, author|
+  step "the puppet module \"#{name}\" from \"#{namespace}\" should have 0 commits made by \"#{author}\""
+end
+
+Given 'the puppet module {string} from {string} has a file named {string} with:' do |name, namespace, filename, content|
+  pmrr = ModuleSync::Faker::PuppetModuleRemoteRepo.new(name, namespace)
+  pmrr.add_file(filename, content)
+end
+
+Then 'the puppet module {string} from {string} should have a branch {string} with a file named {string} which contains:' do |name, namespace, branch, filename, content|
+  pmrr = ModuleSync::Faker::PuppetModuleRemoteRepo.new(name, namespace)
+  expect(pmrr.read_file(filename, branch)).to include(content)
+end
+
+Given 'the puppet module {string} from {string} has the default branch named {string}' do |name, namespace, default_branch|
+  pmrr = ModuleSync::Faker::PuppetModuleRemoteRepo.new(name, namespace)
+  pmrr.default_branch = default_branch
 end

data/features/support/env.rb

@@ -1,5 +1,9 @@
 require 'aruba/cucumber'
 
+require_relative '../../spec/helpers/faker'
+
+ModuleSync::Faker.working_directory = File.expand_path('faker', Aruba.config.working_directory)
+
 Before do
   @aruba_timeout_seconds = 5
 end

data/features/update.feature

@@ -2,17 +2,7 @@ Feature: update
   ModuleSync needs to update module boilerplate
 
   Scenario: Adding a new file
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -31,21 +21,11 @@ Feature: update
       Files added:
       test
       """
-    Given I run `cat modules/maestrodev/puppet-test/test`
-    Then the output should contain "aruba"
+    And the file named "modules/fakenamespace/puppet-test/test" should contain "aruba"
 
   Scenario: Using skip_broken option and adding a new file to repo without write access
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: 'git@github.com:'
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
+    And the puppet module "puppet-test" from "fakenamespace" is read-only
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -59,19 +39,11 @@ Feature: update
       """
     When I run `msync update -s -m "Add test"`
     Then the exit status should be 0
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Adding a new file to repo without write access
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: 'git@github.com:'
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
+    And the puppet module "puppet-test" from "fakenamespace" is read-only
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -85,19 +57,10 @@ Feature: update
       """
     When I run `msync update -m "Add test" -r`
     Then the exit status should be 1
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Adding a new file, without the .erb suffix
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -120,21 +83,11 @@ Feature: update
       Files added:
       test
       """
-    Given I run `cat modules/maestrodev/puppet-test/test`
-    Then the output should contain "aruba"
+    And the file named "modules/fakenamespace/puppet-test/test" should contain "aruba"
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Adding a new file using global values
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -153,21 +106,11 @@ Feature: update
       Files added:
       test
       """
-    Given I run `cat modules/maestrodev/puppet-test/test`
-    Then the output should contain "aruba"
+    And the file named "modules/fakenamespace/puppet-test/test" should contain "aruba"
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Adding a new file overriding global values
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -189,21 +132,11 @@ Feature: update
       Files added:
       test
       """
-    Given I run `cat modules/maestrodev/puppet-test/test`
-    Then the output should contain "aruba"
+    And the file named "modules/fakenamespace/puppet-test/test" should contain "aruba"
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Adding a new file ignoring global values
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -225,21 +158,11 @@ Feature: update
       Files added:
       test
       """
-    Given I run `cat modules/maestrodev/puppet-test/test`
-    Then the output should contain "aruba"
+    And the file named "modules/fakenamespace/puppet-test/test" should contain "aruba"
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Adding a file that ERB can't parse
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -255,19 +178,10 @@ Feature: update
       """
     When I run `msync update --noop`
     Then the exit status should be 1
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Using skip_broken option with invalid files
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -283,19 +197,10 @@ Feature: update
       """
     When I run `msync update --noop -s`
     Then the exit status should be 0
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Using skip_broken and fail_on_warnings options with invalid files
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -311,18 +216,13 @@ Feature: update
       """
     When I run `msync update --noop --skip_broken --fail_on_warnings`
     Then the exit status should be 1
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Modifying an existing file
-    Given a file named "managed_modules.yml" with:
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
+    And the puppet module "puppet-test" from "fakenamespace" has a file named "Gemfile" with:
       """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
+      source 'https://example.com'
       """
     And a file named "config_defaults.yml" with:
       """
@@ -342,15 +242,18 @@ Feature: update
       Files changed:
       +diff --git a/Gemfile b/Gemfile
       """
-    Given I run `cat modules/maestrodev/puppet-test/Gemfile`
-    Then the output should contain:
+    And the file named "modules/fakenamespace/puppet-test/Gemfile" should contain:
       """
       source 'https://somehost.com'
       """
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Modifying an existing file and committing the change
-    Given a mocked git configuration
-    And a remote module repository
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
+    And the puppet module "puppet-test" from "fakenamespace" has a file named "Gemfile" with:
+      """
+      source 'https://example.com'
+      """
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -364,30 +267,25 @@ Feature: update
       """
     When I run `msync update -m "Update Gemfile" -r test`
     Then the exit status should be 0
-    Given I cd to "sources/puppet-test"
-    And I run `git checkout test`
-    Then the file "Gemfile" should contain:
+    And the puppet module "puppet-test" from "fakenamespace" should have only 1 commit made by "Aruba"
+    And the puppet module "puppet-test" from "fakenamespace" should have 1 commit made by "Aruba" in branch "test"
+    And the puppet module "puppet-test" from "fakenamespace" should have a branch "test" with a file named "Gemfile" which contains:
       """
       source 'https://somehost.com'
       """
 
   Scenario: Setting an existing file to unmanaged
-    Given a file named "managed_modules.yml" with:
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
+    And the puppet module "puppet-test" from "fakenamespace" has a file named "Gemfile" with:
       """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
+      source 'https://rubygems.org'
       """
     And a file named "config_defaults.yml" with:
       """
       ---
       Gemfile:
         unmanaged: true
+        gem_source: https://somehost.com
       """
     And a directory named "moduleroot"
     And a file named "moduleroot/Gemfile.erb" with:
@@ -405,24 +303,14 @@ Feature: update
       Not managing Gemfile in puppet-test
       """
     And the exit status should be 0
-    Given I run `cat modules/maestrodev/puppet-test/Gemfile`
-    Then the output should contain:
+    And the file named "modules/fakenamespace/puppet-test/Gemfile" should contain:
       """
       source 'https://rubygems.org'
       """
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Setting an existing file to deleted
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -434,6 +322,10 @@ Feature: update
       """
       source '<%= @configs['gem_source'] %>'
       """
+    And the puppet module "puppet-test" from "fakenamespace" has a file named "Gemfile" with:
+      """
+      source 'https://rubygems.org'
+      """
     When I run `msync update --noop`
     Then the output should match:
       """
@@ -442,19 +334,10 @@ Feature: update
       deleted file mode 100644
       """
     And the exit status should be 0
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Setting a non-existent file to deleted
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -464,19 +347,10 @@ Feature: update
     And a directory named "moduleroot"
     When I run `msync update -m 'deletes a file that doesnt exist!' -f puppet-test`
     And the exit status should be 0
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Setting a directory to unmanaged
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppetlabs-apache
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: puppetlabs
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-apache" from "puppetlabs"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -488,36 +362,26 @@ Feature: update
       """
       some spec_helper fud
       """
-    And a directory named "modules/puppetlabs/puppetlabs-apache/spec"
-    And a file named "modules/puppetlabs/puppetlabs-apache/spec/spec_helper.rb" with:
+    And a directory named "modules/puppetlabs/puppet-apache/spec"
+    And a file named "modules/puppetlabs/puppet-apache/spec/spec_helper.rb" with:
       """
       This is a fake spec_helper!
       """
     When I run `msync update --offline`
     Then the output should contain:
       """
-      Not managing spec/spec_helper.rb in puppetlabs-apache
+      Not managing spec/spec_helper.rb in puppet-apache
       """
     And the exit status should be 0
-    Given I run `cat modules/puppetlabs/puppetlabs-apache/spec/spec_helper.rb`
-    Then the output should contain:
+    And the file named "modules/puppetlabs/puppet-apache/spec/spec_helper.rb" should contain:
       """
       This is a fake spec_helper!
       """
     And the exit status should be 0
+    And the puppet module "puppet-apache" from "puppetlabs" should have no commits made by "Aruba"
 
   Scenario: Adding a new file in a new subdirectory
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -538,24 +402,14 @@ Feature: update
       Files added:
       spec/spec_helper.rb
       """
-    Given I run `cat modules/maestrodev/puppet-test/spec/spec_helper.rb`
-    Then the output should contain:
+    And the file named "modules/fakenamespace/puppet-test/spec/spec_helper.rb" should contain:
       """
       require 'puppetlabs_spec_helper/module_helper'
       """
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Updating offline
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -572,19 +426,15 @@ Feature: update
     When I run `msync update --offline`
     Then the exit status should be 0
     And the output should not match /Files (changed|added|deleted):/
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Pulling a module that already exists in the modules directory
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - maestrodev/puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        git_base: https://github.com/
-      """
-    And a file named "config_defaults.yml" with:
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
+    And a directory named "moduleroot"
+    When I run `msync update --message "First update run"`
+    Then the exit status should be 0
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
+    Given a file named "config_defaults.yml" with:
       """
       ---
       spec/spec_helper.rb:
@@ -597,20 +447,6 @@ Feature: update
         require '<%= required %>'
       <% end %>
       """
-    Given I run `git init modules/maestrodev/puppet-test`
-    Given a file named "modules/maestrodev/puppet-test/.git/config" with:
-      """
-      [core]
-          repositoryformatversion = 0
-          filemode = true
-          bare = false
-          logallrefupdates = true
-          ignorecase = true
-          precomposeunicode = true
-      [remote "origin"]
-          url = https://github.com/maestrodev/puppet-test.git
-          fetch = +refs/heads/*:refs/remotes/origin/*
-      """
     When I run `msync update --noop`
     Then the exit status should be 0
     And the output should match:
@@ -618,37 +454,23 @@ Feature: update
       Files added:
       spec/spec_helper.rb
       """
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
-  Scenario: When running update with no changes
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+  Scenario: When running update without changes
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a directory named "moduleroot"
-    When I run `msync update --noop`
+    When I run `msync update --message "Running without changes"`
     Then the exit status should be 0
-    And the output should not match /diff/
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: When specifying configurations in managed_modules.yml
-    Given a file named "managed_modules.yml" with:
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
+    And a file named "managed_modules.yml" with:
       """
       ---
         puppet-test:
           module_name: test
       """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -667,11 +489,14 @@ Feature: update
       Files added:
       test
       """
-    Given I run `cat modules/maestrodev/puppet-test/test`
-    Then the output should contain "aruba"
+    And the file named "modules/fakenamespace/puppet-test/test" should contain "aruba"
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: When specifying configurations in managed_modules.yml and using a filter
-    Given a file named "managed_modules.yml" with:
+    Given a mocked git configuration
+    And a puppet module "puppet-test" from "fakenamespace"
+    And a puppet module "puppet-blacksmith" from "fakenamespace"
+    And a file named "managed_modules.yml" with:
       """
       ---
         puppet-blacksmith:
@@ -681,9 +506,9 @@ Feature: update
     And a file named "modulesync.yml" with:
       """
       ---
-        namespace: maestrodev
-        git_base: https://github.com/
+      namespace: fakenamespace
       """
+    And a git_base option appended to "modulesync.yml" for local tests
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -702,12 +527,15 @@ Feature: update
       Files added:
       test
       """
-    Given I run `cat modules/maestrodev/puppet-test/test`
-    Then the output should contain "aruba"
-    And a directory named "modules/maestrodev/puppet-blacksmith" should not exist
+    And the file named "modules/fakenamespace/puppet-test/test" should contain "aruba"
+    And a directory named "modules/fakenamespace/puppet-blacksmith" should not exist
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: When specifying configurations in managed_modules.yml and using a negative filter
-    Given a file named "managed_modules.yml" with:
+    Given a mocked git configuration
+    And a puppet module "puppet-test" from "fakenamespace"
+    And a puppet module "puppet-blacksmith" from "fakenamespace"
+    And a file named "managed_modules.yml" with:
       """
       ---
         puppet-blacksmith:
@@ -717,9 +545,9 @@ Feature: update
     And a file named "modulesync.yml" with:
       """
       ---
-        namespace: maestrodev
-        git_base: https://github.com/
+      namespace: fakenamespace
       """
+    And a git_base option appended to "modulesync.yml" for local tests
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -738,21 +566,12 @@ Feature: update
       Files added:
       test
       """
-    Given I run `cat modules/maestrodev/puppet-test/test`
-    Then the output should contain "aruba"
-    And a directory named "modules/maestrodev/puppet-blacksmith" should not exist
+    And the file named "modules/fakenamespace/puppet-test/test" should contain "aruba"
+    And a directory named "modules/fakenamespace/puppet-blacksmith" should not exist
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Updating a module with a .sync.yml file
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - maestrodev/puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -775,21 +594,7 @@ Feature: update
       <%= @configs['global-to-overwrite'] %>
       <%= @configs['module-default'] %>
       """
-    Given I run `git init modules/maestrodev/puppet-test`
-    Given a file named "modules/maestrodev/puppet-test/.git/config" with:
-      """
-      [core]
-          repositoryformatversion = 0
-          filemode = true
-          bare = false
-          logallrefupdates = true
-          ignorecase = true
-          precomposeunicode = true
-      [remote "origin"]
-          url = https://github.com/maestrodev/puppet-test.git
-          fetch = +refs/heads/*:refs/remotes/origin/*
-      """
-    Given a file named "modules/maestrodev/puppet-test/.sync.yml" with:
+    And the puppet module "puppet-test" from "fakenamespace" has a file named ".sync.yml" with:
       """
       ---
       :global:
@@ -804,16 +609,19 @@ Feature: update
       """
       Not managing spec/spec_helper.rb in puppet-test
       """
-    Given I run `cat modules/maestrodev/puppet-test/global-test.md`
-    Then the output should match:
+    And the file named "modules/fakenamespace/puppet-test/global-test.md" should contain:
       """
       some-default
       it-is-overwritten
       some-value
       """
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Module with custom namespace
-    Given a file named "managed_modules.yml" with:
+    Given a mocked git configuration
+    And a puppet module "puppet-test" from "fakenamespace"
+    And a puppet module "puppet-lib-file_concat" from "electrical"
+    And a file named "managed_modules.yml" with:
       """
       ---
         - puppet-test
@@ -822,9 +630,9 @@ Feature: update
     And a file named "modulesync.yml" with:
       """
       ---
-        namespace: maestrodev
-        git_base: https://github.com/
+      namespace: fakenamespace
       """
+    And a git_base option appended to "modulesync.yml" for local tests
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -843,23 +651,13 @@ Feature: update
       Files added:
       test
       """
-    Given I run `cat modules/maestrodev/puppet-test/.git/config`
-    Then the output should contain "url = https://github.com/maestrodev/puppet-test.git"
-    Given I run `cat modules/electrical/puppet-lib-file_concat/.git/config`
-    Then the output should contain "url = https://github.com/electrical/puppet-lib-file_concat.git"
+    And the file named "modules/fakenamespace/puppet-test/.git/config" should match /^\s+url = .*fakenamespace.puppet-test$/
+    And the file named "modules/electrical/puppet-lib-file_concat/.git/config" should match /^\s+url = .*electrical.puppet-lib-file_concat$/
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
+    And the puppet module "puppet-lib-file_concat" from "electrical" should have no commits made by "Aruba"
 
   Scenario: Modifying an existing file with values exposed by the module
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -868,7 +666,12 @@ Feature: update
     And a directory named "moduleroot"
     And a file named "moduleroot/README.md.erb" with:
       """
-      echo '<%= @configs[:git_base] + @configs[:namespace] %>'
+      module: <%= @configs[:puppet_module] %>
+      namespace: <%= @configs[:namespace] %>
+      """
+    And the puppet module "puppet-test" from "fakenamespace" has a file named "README.md" with:
+      """
+      Hello world!
       """
     When I run `msync update --noop`
     Then the exit status should be 0
@@ -877,15 +680,15 @@ Feature: update
       Files changed:
       +diff --git a/README.md b/README.md
       """
-    Given I run `cat modules/maestrodev/puppet-test/README.md`
-    Then the output should contain:
+    And the file named "modules/fakenamespace/puppet-test/README.md" should contain:
       """
-      echo 'https://github.com/maestrodev'
+      module: puppet-test
+      namespace: fakenamespace
       """
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Running the same update twice and pushing to a remote branch
-    Given a mocked git configuration
-    And a remote module repository
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -899,15 +702,18 @@ Feature: update
       """
     When I run `msync update -m "Update Gemfile" -r test`
     Then the exit status should be 0
+    And the puppet module "puppet-test" from "fakenamespace" should have only 1 commit made by "Aruba"
+    And the puppet module "puppet-test" from "fakenamespace" should have 1 commit made by "Aruba" in branch "test"
     Given I remove the directory "modules"
     When I run `msync update -m "Update Gemfile" -r test`
     Then the exit status should be 0
     Then the output should not contain "error"
     Then the output should not contain "rejected"
+    And the puppet module "puppet-test" from "fakenamespace" should have only 1 commit made by "Aruba"
+    And the puppet module "puppet-test" from "fakenamespace" should have 1 commit made by "Aruba" in branch "test"
 
   Scenario: Creating a GitHub PR with an update
-    Given a mocked git configuration
-    And a remote module repository
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a directory named "moduleroot"
     And I set the environment variables to:
       | variable     | value  |
@@ -915,10 +721,10 @@ Feature: update
     When I run `msync update --noop --branch managed_update --pr`
     Then the output should contain "Would submit PR "
     And the exit status should be 0
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Creating a GitLab MR with an update
-    Given a mocked git configuration
-    And a remote module repository
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a directory named "moduleroot"
     And I set the environment variables to:
       | variable     | value  |
@@ -926,10 +732,11 @@ Feature: update
     When I run `msync update --noop --branch managed_update --pr`
     Then the output should contain "Would submit MR "
     And the exit status should be 0
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"
 
   Scenario: Repository with a default branch other than master
-    Given a mocked git configuration
-    And a remote module repository with "develop" as the default branch
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
+    And the puppet module "puppet-test" from "fakenamespace" has the default branch named "develop"
     And a file named "config_defaults.yml" with:
       """
       ---
@@ -943,24 +750,16 @@ Feature: update
       """
     When I run `msync update -m "Update Gemfile"`
     Then the exit status should be 0
-    Then the output should contain "Using repository's default branch: develop"
+    And the output should contain "Using repository's default branch: develop"
+    And the puppet module "puppet-test" from "fakenamespace" should have only 1 commit made by "Aruba"
+    And the puppet module "puppet-test" from "fakenamespace" should have 1 commit made by "Aruba" in branch "develop"
 
-  Scenario: Adding a new file from a template using meta data
+  Scenario: Adding a new file from a template using metadata
+    Given a basic setup with a puppet module "puppet-test" from "fakenamespace"
     And a file named "config_defaults.yml" with:
       """
       ---
       """
-    Given a file named "managed_modules.yml" with:
-      """
-      ---
-        - puppet-test
-      """
-    And a file named "modulesync.yml" with:
-      """
-      ---
-        namespace: maestrodev
-        git_base: https://github.com/
-      """
     And a directory named "moduleroot"
     And a file named "moduleroot/test.erb" with:
       """
@@ -970,10 +769,10 @@ Feature: update
       """
     When I run `msync update --noop`
     Then the exit status should be 0
-    Given I run `cat modules/maestrodev/puppet-test/test`
-    Then the output should contain:
+    And the file named "modules/fakenamespace/puppet-test/test" should contain:
       """
       module: puppet-test
-      target: modules/maestrodev/puppet-test/test
-      workdir: modules/maestrodev/puppet-test
+      target: modules/fakenamespace/puppet-test/test
+      workdir: modules/fakenamespace/puppet-test
       """
+    And the puppet module "puppet-test" from "fakenamespace" should have no commits made by "Aruba"