modular_tree 0.11.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0947ea53f44cfdfdf8c615c26217fc7bfd86b9fae98f6c234519ace576f911d
-  data.tar.gz: 6dc9685845668b34db4724828f777e80d1e808557c1e8b63988f23a82fdccccf
+  metadata.gz: a78d523f964aaf9e819f8620dbaafbad5facc1848f1baa511bf3e71625a1b0c9
+  data.tar.gz: 59e201fe0e71be312e3f1b2545b1dbcfbccb72c7fa04465d33d6da6ed8c14acb
 SHA512:
-  metadata.gz: e18eeb61df2ec711d51501175409ce1b085dc86d01c65ae3863f9abf4c72ff2e051dfc070541652acfdc6515859a2b7e0cf9c11ea665c5d1f9146c83ad881701
-  data.tar.gz: b7f8dfbd482c7c64dd8f52f52d17d2ad2b4e82ee5e0604adbc790aa576ade55c0e26456df207938656ef5314fd4601809797669c11a488ba89d861e020bee905
+  metadata.gz: 55c87a6034b013fe0f424dee4d7b2192eb1cd863c9d96085beebfbfbace4efcdaf4ac1137dcd8a1941679479502e4ef3f6b29f2d26ced05aa82f872a28c568cd
+  data.tar.gz: f34c14d5cfc770cd2ad502370e17411396fc290aef2988bcccdeb931456add73819a8d7d7a1c5b75565c3565549859e2cbcaeae28960353a2a567bd843841cbf

data/lib/modular_tree/algorithms.rb

@@ -69,11 +69,18 @@ module Tree
 
     # Implementation of Enumerable#select extended with a single filter. As
     # #each, the block is called with value, key, and parent arguments
-    def select(filter = nil, this: true, &block)
+    #
+    # The match expression can also be a list of classes (instead of an array of classes)
+    #
+    def select(*expr, this: true, &block)
+      !block_given? || expr.empty? or raise ArgumentError, "Can't use both match expression and block"
       if block_given?
-        each(block, true, this: this).to_a
+        each.select { |branch| yield branch }
+      elsif !expr.empty?
+        matcher = Matcher.new(*expr, &block)
+        each.select { |branch| matcher.match? branch }
       else
-        each(filter || true, true, this: this)
+        each
       end
     end
 
@@ -83,14 +90,15 @@ module Tree
     # The match expression can also be a list of classes (instead of an array of classes)
     #
     # TODO: Maybe make #children an Array extended with filtering
-    def choose(*args, &block)
-      matcher = Matcher.new(*args, &block)
+    def choose(*expr, &block)
+      !block_given? || expr.empty? or raise ArgumentError, "Can't use both match expression and block"
       if block_given?
-        a = []
-        each_branch { |branch, key| a << branch if matcher.match? branch }
-        a
+        each_branch.select { |branch| yield branch }
+      elsif !expr.empty?
+        matcher = Matcher.new(*expr, &block)
+        each_branch.select { |branch| matcher.match? branch }
       else
-        Enumerator.new { |enum| each_branch { |branch, key| enum << branch if matcher.match? branch } }
+        each
       end
     end
 
@@ -104,10 +112,14 @@ module Tree
     # Post-order enumerator of selected nodes
     def postorder(*filter, this: true) = common_each(*filter, :node_value, :each_postorder, this)
 
+    # TODO IDEA: 
+    #   edges -> parent/child nodes
+    #   pairs -> parent/.../descendant nodes
+
     # Enumerator of edges in the tree. Edges are [previous-matching-node,
     # matching-node] tuples. Top-level nodes have previous-matching-node set to
-    # nil. If the filter matches all nodes the value is an edge-representation
-    # of the tree
+    # nil (the result is a forrest). If the filter matches all nodes the value
+    # is an edge-representation of the tree
     def edges(*filter, this: true, &block)
       if block_given?
         each(*filter, this: this) { |node, _, parent| yield parent, node }
@@ -117,7 +129,7 @@ module Tree
     end
 
     # Return array of [previous-matching-node, matching-node] tuples. Returns
-    # the empty array ff there is no matching set of nodes
+    # the empty array iff there is no matching set of nodes
     def pairs(first_match_expr, second_match_expr, this: true)
       first_matcher = Matcher.new(first_match_expr)
       second_matcher = Matcher.new(second_match_expr)

data/lib/modular_tree/implementations.rb

@@ -159,6 +159,9 @@ module Tree
     attr_writer :next_sibling
   end
 
+  # TODO: A ChildrenArrayImplementation that defines #insert and #append and
+  # adds an optional index argument to #attach
+
   module InternalChildrenArrayImplementation
     include InternalChildrenImplementation
 
@@ -183,6 +186,8 @@ module Tree
     # index or an object
     #
     # TODO: Rename #attach. #insert & #append are Enumerable operations
+    #
+    # TODO: Default where argument - insert: 0, append: -1
     def insert(where, child) = insert_append(:insert, where, child)
     def append(where, child) = insert_append(:append, where, child)
 

data/lib/modular_tree/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Tree
-  VERSION = "0.11.0"
+  VERSION = "0.12.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: modular_tree
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.0
 platform: ruby
 authors:
 - Claus Rasmussen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-23 00:00:00.000000000 Z
+date: 2023-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: constrain