modular_forms 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e77e70af5b9ca9fa2bcc7543c8eaa45ac1603bf168d0fd2c9fa73aa639836de
-  data.tar.gz: 2df87ac5d2f7c6c950fb5312226422dc146a180e250ca3ce2e31abbb100a18d2
+  metadata.gz: 3db834376767beecfe9ac15dba1a8ac97e3e9d845db19729668bbd32d511278d
+  data.tar.gz: d12f3d74498c06a7a16f264ab2d659b372e5629d2688470a4f39d2c3ad71883d
 SHA512:
-  metadata.gz: 90ec48ab7fad347c8ab257bdc65f71d21f34c2dfc50822695d178f6babc624358477d448bb947fc681e6767ece07a8b1cb8c168fe0f6ca364a2a33a03d288b59
-  data.tar.gz: ee4e8a42d6b2953c8de928d6582d487447364847e455f7ae74a2a5e3a1d96d597fdc95cb8e7bcdba4121cf9decca5c1ee0e960528fa5173ece1dba0f5a474235
+  metadata.gz: a599f05653f0abea5792617200ffba19726ee0abe421de1e04b13a4beb92e3f1911e61688ee05b55aae7aa8d8114fa63378e188fceb91a568160e20307c77232
+  data.tar.gz: bddeae428139325379f8172ebac90d324da39c633470823b40fbebbd0211358c7805dcb4db0c464e1e5156619e59a912d988a28006a9fbc9e08af29cbc4ee856

data/README.md

@@ -3,32 +3,31 @@
 A creative toolkit for exploring modular forms and elliptic curves through [Sonic Pi](https://sonic-pi.net/).
 
 <p align="center">
-  <img src="https://img.shields.io/gem/v/modular_forms" alt="Gem Version">
-  <img src="https://img.shields.io/gem/dt/modular_forms" alt="Gem Total Downloads">
-  <img src="https://img.shields.io/github/stars/edelveart/modular_forms" alt="GitHub Repo stars">
-  <img src="https://img.shields.io/github/license/edelveart/modular_forms" alt="GitHub License">
+  <img src="https://img.shields.io/gem/v/modular_forms" alt="Gem Version" />
+  <img src="https://img.shields.io/gem/dt/modular_forms" alt="Gem Total Downloads" />
+  <img src="https://img.shields.io/github/stars/edelveart/modular_forms" alt="GitHub Repo stars" />
 </p>
 
-[![Modular Forms - Image](https://raw.githubusercontent.com/edelveart/modular_forms/main/modular_forms.png)](https://rubygems.org/gems/modular_forms)
+<p align="center">
+  <img src="https://raw.githubusercontent.com/edelveart/modular_forms/main/modular_forms.png" width="400" alt="Modular Forms Image" />
+</p>
 
-## ⚙️ Project Status
+## Project Status
 
-This is a pre-alpha release of `modular_forms`. At this stage, only a subset of core mathematical definitions and operations is implemented.
+This is a **pre-alpha** release of `modular_forms`. At this stage, only a subset of core mathematical definitions and operations is implemented.
 
-Future updates might include a DSL, depending on how the library is used and the interest from the community. A key challenge lies in creating musical mappings that stay true to the underlying mathematics while also sounding intentional, expressive, and naturally fitting within a musical structure.
+Future updates might include a **DSL**, depending on how the library is used and the interest from the community. A key challenge is turning mathematical ideas into music that feels deliberate, expressive, and naturally musical.
 
-## 🧊 Features
+## Features
 
 - **Accessible to both musicians and coders**: No math expertise required. Create musical patterns, rhythms, timbres, and harmonies by experimenting with mathematical ideas and turning them into sound and effects intuitively.
 - **Interactive Educational Resource**: Use **Sonic Pi** to discover introductory number theory in a hands-on, immersive way, gaining insights into abstract concepts through math in action.
 
-## 💡 Purpose and Scope
-
-### Overview
+##  Scope
 
 Given the vastness of the field, this tool intentionally focuses on a limited subset of definitions, without covering all aspects of each.
 
-- 🧩 List of implemented modules:
+- List of implemented modules:
   - [Eisenstein Series](#eisenstein-series)
   - [Eta Functions and Eta Quotients](#eta-functions-and-eta-quotients)
   - [Theta Functions](#theta-functions)
@@ -46,13 +45,10 @@ Given the vastness of the field, this tool intentionally focuses on a limited su
 
 ### Not Optimized for Computational Efficiency
 
-This library is designed for creative exploration rather than maximum computational efficiency. It is **not intended** to replace specialized mathematical software optimized for heavy or large-scale computations. Instead, it draws inspiration from tools like **SageMath**, **Pari/GP**, and the **LMFDB database**.
-
-### Goal
+> This library is designed for creative exploration rather than maximum computational efficiency. It is **not intended** to replace specialized mathematical software optimized for heavy or large-scale computations. Instead, it draws inspiration from tools like **SageMath**, **Pari/GP**, and the **LMFDB database**.
 
-The goal is simple: to provide an accessible and creative starting point for those who wish to explore, learn, and uncover new ideas, regardless of their mathematical background.
 
-## 💎 Installation
+## Installation
 
 You can install the `modular_forms` gem directly from **RubyGems** or clone it from GitHub.
 
@@ -77,9 +73,9 @@ Then require the file like this:
 require "<PATH>/modular_forms.rb"
 ```
 
-## 🧰 How to use?
+## How to use?
 
-### 🎶 Explore Fermat’s Last Theorem in Sonic Pi
+### Explore Fermat’s Last Theorem in Sonic Pi
 
 The Taniyama–Shimura Conjecture (now the Modularity Theorem), proven for semistable cases by Andrew Wiles, connects elliptic curves over the rationals to modular forms. This profound result was crucial in proving **Fermat’s Last Theorem**.
 
@@ -116,7 +112,7 @@ live_loop :modularity_music do
 end
 ```
 
-### 🎶 Merging Machine and Organism - Warp Up
+### Merging Machine and Organism - Warp Up
 
 Unlike the structured Fermat example, this finite loop explores more abstract territory, using multiple concepts to create a sonic landscape that, while grounded in mathematical principles, goes beyond conventional musical forms.
 
@@ -165,7 +161,7 @@ end
 end
 ```
 
-## 🧩 Implemented Modular Forms, Elliptic Curves, and Related Definitions
+## Implemented Modular Forms, Elliptic Curves, and Related Definitions
 
 ### Eisenstein Series
 
@@ -222,45 +218,46 @@ end
 27. `ModularForms.discriminant_q(curve)`
 28. `ModularForms.j_invariant_q(curve)`
 29. `ModularForms.point_on_curve_q?(curve, point)`
-30. `ModularForms.point_addition_q(curve, p, q)`
-31. `ModularForms.scalar_mul_point_q(curve, n, point)`
-32. `ModularForms.isogeny_2deg_q(curve, point_2tor)`
-33. `ModularForms.isogeny_ndeg_q(curve, point_ntor, order)`
-34. `ModularForms.weil_height(x_point)`
-35. `ModularForms.canonical_height(curve, point, prec = 64)`
+30. `ModularForms.negate_p(point)`
+31. `ModularForms.point_addition_q(curve, p, q)`
+32. `ModularForms.scalar_mul_point_q(curve, n, point)`
+33. `ModularForms.isogeny_2deg_q(curve, point_2tor)`
+34. `ModularForms.isogeny_ndeg_q(curve, point_ntor, order)`
+35. `ModularForms.weil_height(x_point)`
+36. `ModularForms.canonical_height(curve, point, prec = 64)`
 
 ### Elliptic Curves over Finite Fields
 
-36. `ModularForms.elliptic_curve_fp(p, coefs)`
-37. `ModularForms.point_on_curve_modp?(curve, point)`
-38. `ModularForms.discriminant_modp(curve)`
-39. `ModularForms.j_invariant_modp(curve)`
-40. `ModularForms.point_addition_modp(curve, p_point, q_point)`
-41. `ModularForms.scalar_mul_point_modp(curve, n, point)`
-42. `ModularForms.points_fp(curve, point_at_infinity = false)`
-43. `ModularForms.cardinality_fp(curve)`
-44. `ModularForms.quadratic_twist_fp(curve)`
+37. `ModularForms.elliptic_curve_fp(p, coefs)`
+38. `ModularForms.point_on_curve_modp?(curve, point)`
+39. `ModularForms.discriminant_modp(curve)`
+40. `ModularForms.j_invariant_modp(curve)`
+41. `ModularForms.point_addition_modp(curve, p_point, q_point)`
+42. `ModularForms.scalar_mul_point_modp(curve, n, point)`
+43. `ModularForms.points_fp(curve, point_at_infinity = false)`
+44. `ModularForms.cardinality_fp(curve)`
+45. `ModularForms.quadratic_twist_fp(curve)`
 
 ### Newform Invariants
 
-45. `ModularForms.analytic_conductor(level_n, weight_k)`
+46. `ModularForms.analytic_conductor(level_n, weight_k)`
 
 ### L-functions
 
-46. `ModularForms.a_p(p, cardinality)`
+47. `ModularForms.a_p(p, cardinality)`
 
 ### p-adic Fields
 
-47. `ModularForms.padic_valuation(num_b10, p)`
-48. `ModularForms.padic_norm(num_b10, p)`
-49. `ModularForms.padic_expansion(num_b10, p, prec = 11, reverse_trim = false)`
-50. `ModularForms.def_pol_2deg(p = 2, c = 0, num = 1)`
+48. `ModularForms.padic_valuation(num_b10, p)`
+49. `ModularForms.padic_norm(num_b10, p)`
+50. `ModularForms.padic_expansion(num_b10, p, prec = 11, reverse_trim = false)`
+51. `ModularForms.def_pol_2deg(p = 2, c = 0, num = 1)`
 
 ### Number Fields
 
-51. `ModularForms.zeta_coeffs_deg2(dirichlet_char_group, n)`
+52. `ModularForms.zeta_coeffs_deg2(dirichlet_char_group, n)`
 
-## 🧪 Testing
+## Testing
 
 Install dependencies first:
 

data/lib/modular_forms/core/elliptic_curves_fp.rb

@@ -13,7 +13,7 @@ module ModularForms
         ((n % modp) + modp) % modp
       end
 
-      def self.elliptic_curve_fp(p, coefs)
+      def self.elliptic_curve_fp(p, coefs) # rubocop:disable Metrics/MethodLength
         a, b = coefs
         raise "#{p} is not a prime number" if NumericHelpers.prime_number?(p) == false
 
@@ -21,9 +21,13 @@ module ModularForms
 
         a_modp = reduction_modp(a, p)
         b_modp = reduction_modp(b, p)
-        raise "y^2=x^3 #{a_modp}x #{b_modp} defines a singular curve" if d == 0 # rubocop:disable Style/NumericPredicate
 
-        puts "y^2 = x^3 #{a_modp}x #{b_modp} over Finite Field #{p}"
+        if d.zero?
+          raise "#{EllipticCurvesQ.show_curve_equation(a_modp,
+                                                       b_modp)} defines a singular curve over F_#{p}"
+        end
+
+        puts "#{EllipticCurvesQ.show_curve_equation(a_modp, b_modp)} over Finite Field #{p}"
         { a: a, b: b, p: p }
       end
 

data/lib/modular_forms/core/elliptic_curves_q.rb

@@ -7,16 +7,35 @@ module ModularForms
     # ModularForms::Core::EllipticCurves
     #
     # This module provides methods for generating points on Elliptic Curves (short Weierstrass form) over Q
-    module EllipticCurvesQ
+    module EllipticCurvesQ # rubocop:disable Metrics/ModuleLength
       def self.discriminant(a, b)
         -16 * (4 * a**3 + 27 * b**2)
       end
 
+      def self.show_curve_equation(a, b) # rubocop:disable Metrics/MethodLength,Lint/RedundantCopDisableDirective
+        eq = 'y^2 = x^3'
+        eq += a != 0 ? " #{a > 0 ? '+' : '-'} #{a.abs}x" : '' # rubocop:disable Style/NestedTernaryOperator,Style/NumericPredicate
+        eq += b != 0 ? " #{b > 0 ? '+' : '-'} #{b.abs}" : '' # rubocop:disable Style/NestedTernaryOperator,Style/NumericPredicate
+        eq
+      end
+
+      def self.singular?(a, b)
+        delta = discriminant(a, b)
+        return unless delta.zero?
+
+        type = begin
+          x_s = a.zero? ? 0 : Math.sqrt(-a / 3) rescue 0 # rubocop:disable Style/RescueModifier
+          x_s.zero? ? 'cusp' : 'node'
+        end
+
+        # Concatenar la ecuación directamente en el mensaje
+        raise "#{show_curve_equation(a, b)} defines a singular curve (#{type})"
+      end
+
       def self.elliptic_curve_q(coefs)
         a, b = coefs
-        raise "y^2=x^3 #{a}x #{b} defines a singular curve" if discriminant(a, b) == 0 # rubocop:disable Style/NumericPredicate
-
-        puts "y^2 = x^3 #{a}x #{b}"
+        singular?(a, b)
+        puts show_curve_equation(a, b)
         { a: a, b: b }
       end
 
@@ -126,3 +145,6 @@ module ModularForms
     end
   end
 end
+# # [-1, 2],
+# ModularForms::Core::EllipticCurvesQ.elliptic_curve_q([-27, 54])
+# # ModularForms::Core::EllipticCurvesQ.show_curve_equation([-0, 0])

data/lib/modular_forms/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ModularForms
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: modular_forms
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Edgar Armando Delgado Vega