modspec 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 925062f2457c7aa978de3d2eabc679f4a33b9177e8ba2f3a80494c46377ff0b8
-  data.tar.gz: '083c357ffd578b297ae28753e48dccacd08a10d202f336299b037d1d6b08fe9a'
+  metadata.gz: 74bb2806f9ebad2c91453ba473103f5e581c76b78223d9eeba79f4580e8858db
+  data.tar.gz: cb2903e0b33726419f118c65f64ad5463a2bef0b385643f877de977bc447f8d9
 SHA512:
-  metadata.gz: ce9246f0f6b4ce811bf498d52a59c25949ad0016b024ab215c332ce7e1e34fa311c2a78267a3a1b07cb1a2f0f468559c1aeaedb638c4552e9500016ad8a3235b
-  data.tar.gz: 7132a3d0194c87222d077752784d1d1d7197481d1db1ae356c9f959d8cccd8163f3ef268a2e4e6b75812095768e133ab6da81c629fd3d33b0122f7f2789079fe
+  metadata.gz: d31ab6413761a379a95aa692e94471538daa63cb507ecfcf25ab6e4b3bc34cdfc22d8234ca4239e0159921bdd203ce4e8bec8bec3e4d99323222c34d49d59ac0
+  data.tar.gz: 615225d2adf7b489e0d627147b3a3dbdd43009ed0c96df174f690b9ebeec6c7c752eb5a684505f6822af40d7ee9710ef2a165e9aa601ba6144d82b52a2192a38

data/.rubocop.yml

@@ -17,3 +17,6 @@ plugins:
 
 AllCops:
   TargetRubyVersion: 3.0
+
+RSpec/ExampleLength:
+  Max: 30

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2026-05-05 14:09:35 UTC using RuboCop version 1.86.1.
+# on 2026-05-06 00:19:18 UTC using RuboCop version 1.86.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -11,7 +11,48 @@ Gemspec/RequiredRubyVersion:
   Exclude:
     - 'modspec.gemspec'
 
-# Offense count: 33
+# Offense count: 7
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: with_first_argument, with_fixed_indentation
+Layout/ArgumentAlignment:
+  Exclude:
+    - 'lib/modspec/suite.rb'
+    - 'spec/modspec/suite_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleAlignWith.
+# SupportedStylesAlignWith: either, start_of_block, start_of_line
+Layout/BlockAlignment:
+  Exclude:
+    - 'lib/modspec/suite.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Layout/BlockEndNewline:
+  Exclude:
+    - 'lib/modspec/suite.rb'
+
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'spec/modspec/suite_spec.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Width, EnforcedStyleAlignWith, AllowedPatterns.
+# SupportedStylesAlignWith: start_of_line, relative_to_receiver
+Layout/IndentationWidth:
+  Exclude:
+    - 'lib/modspec/suite.rb'
+
+# Offense count: 36
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
@@ -19,7 +60,6 @@ Layout/LineLength:
   Exclude:
     - 'lib/modspec/conformance_class.rb'
     - 'lib/modspec/conformance_test.rb'
-    - 'lib/modspec/normative_statement.rb'
     - 'lib/modspec/normative_statements_class.rb'
     - 'lib/modspec/suite.rb'
     - 'spec/modspec/conformance_class_spec.rb'
@@ -29,21 +69,14 @@ Layout/LineLength:
     - 'spec/modspec/suite_spec.rb'
 
 # Offense count: 4
-# Configuration parameters: AllowComments, AllowEmptyLambdas.
-Lint/EmptyBlock:
-  Exclude:
-    - 'spec/modspec/conformance_class_spec.rb'
-    - 'spec/modspec/suite_spec.rb'
-
-# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions.
-# NotImplementedExceptions: NotImplementedError
-Lint/UnusedMethodArgument:
+# Configuration parameters: AllowInHeredoc.
+Layout/TrailingWhitespace:
   Exclude:
-    - 'lib/modspec/normative_statement.rb'
+    - 'lib/modspec/suite.rb'
+    - 'spec/modspec/suite_spec.rb'
 
-# Offense count: 7
+# Offense count: 5
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Exclude:
@@ -58,25 +91,20 @@ Metrics/CyclomaticComplexity:
 # Offense count: 9
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 21
+  Max: 19
 
-# Offense count: 3
+# Offense count: 2
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/PerceivedComplexity:
   Exclude:
     - 'lib/modspec/suite.rb'
 
-# Offense count: 1
+# Offense count: 2
 # Configuration parameters: MinSize.
 Performance/CollectionLiteralInLoop:
   Exclude:
     - 'lib/modspec/suite.rb'
 
-# Offense count: 5
-# Configuration parameters: CountAsOne.
-RSpec/ExampleLength:
-  Max: 15
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/ExpectActual:
@@ -90,7 +118,7 @@ RSpec/IndexedLet:
     - 'spec/modspec/normative_statements_class_spec.rb'
     - 'spec/modspec/suite_spec.rb'
 
-# Offense count: 7
+# Offense count: 8
 RSpec/MultipleExpectations:
   Max: 9
 
@@ -103,3 +131,20 @@ RSpec/MultipleMemoizedHelpers:
 RSpec/RepeatedExample:
   Exclude:
     - 'spec/modspec_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# AllowedMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+    - 'lib/modspec/suite.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Style/MultilineIfModifier:
+  Exclude:
+    - 'lib/modspec/suite.rb'

data/lib/modspec/conformance_class.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "conformance_test"
-require_relative "identifier"
 
 module Modspec
   class ConformanceClass < Lutaml::Model::Serializable

data/lib/modspec/conformance_test.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "identifier"
 
 module Modspec
   class ConformanceTest < Lutaml::Model::Serializable

data/lib/modspec/identifier.rb

@@ -4,6 +4,5 @@ require "lutaml/model"
 
 module Modspec
   class Identifier < Lutaml::Model::Type::String
-    # attribute :identifier, :string
   end
 end

data/lib/modspec/normative_statement.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "identifier"
 
 module Modspec
   class NormativeStatementPart < Lutaml::Model::Serializable
@@ -46,43 +45,8 @@ module Modspec
       map_element "parts", to: :parts
     end
 
-    def validate(suite = nil, register: Lutaml::Model::Config.default_register)
-      errors = super()
-      errors.concat(validate_dependencies(suite)) if suite
-      errors.concat(validate_nested_requirement)
-      errors
-    end
-
-    private
-
-    def all_dependencies
-      (
-        (dependencies || []) +
-        (indirect_dependency || []) +
-        (implements || [])
-      ).flatten.compact
-    end
-
-    def validate_dependencies(suite)
-      errors = []
-      all_identifiers = suite.all_identifiers.map(&:to_s)
-      all_dependencies.each do |dep|
-        errors << "Requirement #{identifier} has an invalid dependency: #{dep}" unless all_identifiers.include?(dep)
-      end
-      errors
-    end
-
-    def validate_nested_requirement
-      if has_parent_requirement?
-        ["Nested requirement detected: #{identifier}"]
-      else
-        []
-      end
-    end
-
-    def has_parent_requirement?
-      # Implementation depends on how you determine if a requirement is nested
-      false
+    def validate(_suite = nil, register: Lutaml::Model::Config.default_register)
+      super(register: register)
     end
   end
 end

data/lib/modspec/normative_statements_class.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 require "lutaml/model"
-require_relative "normative_statement"
-require_relative "identifier"
 
 module Modspec
   class NormativeStatementsClass < Lutaml::Model::Serializable

data/lib/modspec/suite.rb

@@ -95,18 +95,17 @@ module Modspec
     end
 
     def setup_relationships
-      all_requirements = if normative_statements_classes
-                           normative_statements_classes.flat_map(&:normative_statements)
-                         else
-                           []
-                         end
+      return unless normative_statements_classes && conformance_classes
 
-      return unless conformance_classes
+      req_index = normative_statements_classes
+        .flat_map(&:normative_statements)
+        .to_h { |r| [r.identifier.to_s, r] }
 
       conformance_classes.each do |cc|
         cc.tests.each do |ct|
-          ct.corresponding_requirements = all_requirements.select do |r|
-            Array(ct.targets).map(&:to_s).include?(r.identifier.to_s)
+          targets = Array(ct.targets).map(&:to_s)
+          ct.corresponding_requirements = targets.filter_map do |t|
+            req_index[t]
           end
           ct.parent_class = cc
         end
@@ -171,15 +170,14 @@ module Modspec
 
       all_statements.each do |statement|
         id = statement.identifier.to_s
-        graph[id] = Set.new
+        deps = Set.new
 
-        # Define all dependency-like properties to check
-        dependency_properties = %i[dependencies indirect_dependency implements
-                                   targets]
-
-        dependency_properties.each do |property|
-          graph[id].merge(statement.send(property).map(&:to_s)) if statement.respond_to?(property) && !statement.send(property).nil?
+        %i[dependencies indirect_dependency implements targets].each do |prop|
+          refs = statement.send(prop) if statement.respond_to?(prop)
+          deps.merge(refs.map(&:to_s)) if refs
         end
+
+        graph[id] = deps
       end
 
       graph
@@ -205,20 +203,14 @@ module Modspec
       recursion_stack.add(node)
       path.push(node)
 
-      # Check if the node exists in the graph and has dependencies
-      if graph[node]
-        graph[node].each do |neighbor|
-          if !visited.include?(neighbor)
-            cycle = detect_cycle_util(neighbor, graph, visited,
-                                      recursion_stack, path)
-            return cycle if cycle
-          elsif recursion_stack.include?(neighbor)
-            return path[path.index(neighbor)..] + [neighbor]
-          end
+      graph[node]&.each do |neighbor|
+        if !visited.include?(neighbor)
+          cycle = detect_cycle_util(neighbor, graph, visited,
+                                    recursion_stack, path)
+          return cycle if cycle
+        elsif recursion_stack.include?(neighbor)
+          return path[path.index(neighbor)..] + [neighbor]
         end
-      else
-        # If the node doesn't exist in the graph, log a warning
-        puts "Warning: Node #{node} referenced but not found in the graph"
       end
 
       path.pop
@@ -240,20 +232,24 @@ module Modspec
     end
 
     def validate_dependencies
-      all_identifiers = collect_all_identifiers
+      all_ids = collect_all_identifiers
 
       errors = []
       normative_statements_classes&.each do |nsc|
-        errors.concat(validate_class_dependencies(nsc, all_identifiers))
+        errors.concat(validate_refs(nsc, all_ids, :dependencies))
+        errors.concat(validate_refs(nsc, all_ids, :implements))
         nsc.normative_statements.each do |ns|
-          errors.concat(validate_statement_dependencies(ns, all_identifiers))
+          errors.concat(validate_refs(ns, all_ids, :dependencies))
+          errors.concat(validate_refs(ns, all_ids, :indirect_dependency))
+          errors.concat(validate_refs(ns, all_ids, :implements))
         end
       end
 
       conformance_classes&.each do |cc|
-        errors.concat(validate_class_dependencies(cc, all_identifiers))
+        errors.concat(validate_refs(cc, all_ids, :dependencies))
         cc.tests.each do |ct|
-          errors.concat(validate_test_targets(ct, all_identifiers))
+          errors.concat(validate_refs(ct, all_ids, :dependencies))
+          errors.concat(validate_refs(ct, all_ids, :targets))
         end
       end
 
@@ -280,28 +276,16 @@ module Modspec
       identifiers
     end
 
-    def validate_class_dependencies(klass, all_identifiers)
-      errors = []
-      klass.dependencies&.each do |dep|
-        errors << "Invalid dependency #{dep} in #{klass.identifier}" unless all_identifiers.key?(dep.to_s)
-      end
-      errors
-    end
+    def validate_refs(obj, all_ids, property)
+      refs = obj.send(property)
+      return [] unless refs
 
-    def validate_statement_dependencies(statement, all_identifiers)
-      errors = []
-      statement.dependencies&.each do |dep|
-        errors << "Invalid dependency #{dep} in #{statement.identifier}" unless all_identifiers.key?(dep.to_s)
-      end
-      errors
-    end
-
-    def validate_test_targets(test, all_identifiers)
-      errors = []
-      test.targets&.each do |target|
-        errors << "Invalid target #{target} in #{test.identifier}" unless all_identifiers.key?(target.to_s)
+      refs.filter_map do |ref|
+        unless all_ids.key?(ref.to_s)
+          "Invalid #{property.to_s.tr('_',
+                                      ' ')} #{ref} in #{obj.identifier}"
+        end
       end
-      errors
     end
   end
 end

data/lib/modspec/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Modspec
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/lib/modspec.rb

@@ -5,14 +5,11 @@ require "lutaml/model"
 require "set"
 
 module Modspec
-  class Error < StandardError; end
-
-  # Your code goes here...
+  autoload :Identifier, "modspec/identifier"
+  autoload :NormativeStatement, "modspec/normative_statement"
+  autoload :NormativeStatementPart, "modspec/normative_statement"
+  autoload :NormativeStatementsClass, "modspec/normative_statements_class"
+  autoload :ConformanceTest, "modspec/conformance_test"
+  autoload :ConformanceClass, "modspec/conformance_class"
+  autoload :Suite, "modspec/suite"
 end
-
-require_relative "modspec/identifier"
-require_relative "modspec/normative_statement"
-require_relative "modspec/normative_statements_class"
-require_relative "modspec/conformance_test"
-require_relative "modspec/conformance_class"
-require_relative "modspec/suite"

data/spec/modspec/conformance_class_spec.rb

@@ -11,12 +11,12 @@ RSpec.describe Modspec::ConformanceClass do
         Modspec::NormativeStatement.new(
           identifier: "/req/basic-ypr/position",
           name: "Expression of outer frame",
-          statement: "The `Basic_YPR.position` attribute shall represent the outer frame, specified by an implicit WGS-84 CRS and an implicit EPSG 4461-CS (LTP-ENU) coordinate system and explicit parameters to define the tangent point.",
+          statement: "The `Basic_YPR.position` attribute shall represent the outer frame.",
         ),
         Modspec::NormativeStatement.new(
           identifier: "/req/basic-ypr/angles",
           name: "Expression of inner frame",
-          statement: "The `Basic_YPR.angles` attribute shall represent the inner frame, which is a rotation-only transformation with Yaw, Pitch, and Roll (YPR) angles.",
+          statement: "The `Basic_YPR.angles` attribute shall represent the inner frame.",
         ),
       ],
     )
@@ -35,7 +35,7 @@ RSpec.describe Modspec::ConformanceClass do
           identifier: "/conf/basic-ypr/position",
           name: "Verify expression of outer frame",
           targets: ["/req/basic-ypr/position"],
-          description: "To confirm that an implementation of a Basic-YPR consists of an Outer Frame specified by an implicit WGS-84 CRS and an implicit EPSG 4461-CS (LTP-ENU) coordinate system and explicit parameters to define the tangent point.",
+          description: "To confirm outer frame.",
           purpose: "Verify that this requirement is satisfied.",
           test_method: "Inspection",
         ),
@@ -43,7 +43,7 @@ RSpec.describe Modspec::ConformanceClass do
           identifier: "/conf/basic-ypr/angles",
           name: "Verify expression of inner frame",
           targets: ["/req/basic-ypr/angles"],
-          description: "To confirm that the Inner Frame is expressed as a rotation-only transformation using Yaw, Pitch, and Roll angles.",
+          description: "To confirm inner frame.",
           purpose: "Verify that this requirement is satisfied.",
           test_method: "Inspection",
         ),
@@ -88,7 +88,7 @@ RSpec.describe Modspec::ConformanceClass do
           identifier: "/conf/global/sdu",
           name: "Verify SDU conformance",
           targets: ["/req/global/sdu"],
-          description: "To confirm that an implementation of an SDU conforms to the logical model.",
+          description: "To confirm SDU conformance.",
           purpose: "Verify that this requirement is satisfied.",
           test_method: "Inspection",
         ),
@@ -105,11 +105,10 @@ RSpec.describe Modspec::ConformanceClass do
           identifier: "/conf/tangent-point/height",
           name: "Verify tangent point height",
           targets: ["/req/tangent-point/height"],
-          description: "To confirm that an implementation of a Tangent Point specifies the height of the Tangent Point.",
+          description: "To confirm tangent point height.",
           purpose: "Verify that this requirement is satisfied.",
           test_method: "Inspection",
         ),
-
       ],
     )
   end
@@ -140,17 +139,25 @@ RSpec.describe Modspec::ConformanceClass do
   describe "#validate" do
     it "returns no errors for a valid conformance class" do
       errors = suite.validate
-      if errors.any?
-
-        errors.each { |error| }
-      end
       expect(errors).to be_empty
     end
 
     it "returns errors if there are no conformance tests" do
       conformance_class.tests = []
       errors = conformance_class.validate
-      expect(errors).not_to be_empty
+      expect(errors).to include(a_string_matching(/no child conformance tests/))
+    end
+
+    it "returns errors if test identifier does not share prefix" do
+      conformance_class.tests = [
+        Modspec::ConformanceTest.new(
+          identifier: "/conf/other/test",
+          name: "Mismatched test",
+          targets: ["/req/basic-ypr/position"],
+        ),
+      ]
+      errors = conformance_class.validate
+      expect(errors).to include(a_string_matching(/does not share the expected prefix/))
     end
   end
 end

data/spec/modspec/conformance_test_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Modspec::ConformanceTest do
     Modspec::NormativeStatement.new(
       identifier: "/req/basic-ypr/position",
       name: "Expression of outer frame",
-      statement: "The `Basic_YPR.position` attribute shall represent the outer frame, specified by an implicit WGS-84 CRS and an implicit EPSG 4461-CS (LTP-ENU) coordinate system and explicit parameters to define the tangent point.",
+      statement: "The `Basic_YPR.position` attribute shall represent the outer frame.",
     )
   end
 
@@ -22,7 +22,7 @@ RSpec.describe Modspec::ConformanceTest do
       identifier: "/conf/basic-ypr/position",
       name: "Verify expression of outer frame",
       targets: ["/req/basic-ypr/position"],
-      description: "To confirm that an implementation of a Basic-YPR consists of an Outer Frame specified by an implicit WGS-84 CRS and an implicit EPSG 4461-CS (LTP-ENU) coordinate system and explicit parameters to define the tangent point.",
+      description: "To confirm outer frame.",
       purpose: "Verify that this requirement is satisfied.",
       test_method: "Inspection",
     )
@@ -45,7 +45,7 @@ RSpec.describe Modspec::ConformanceTest do
   end
 
   before do
-    suite # Ensure the suite is created and relationships are set up
+    suite
   end
 
   it "has an identifier" do
@@ -65,6 +65,24 @@ RSpec.describe Modspec::ConformanceTest do
       errors = conformance_test.validate
       expect(errors).to be_empty
     end
+
+    it "returns errors when corresponding_requirements is nil" do
+      conformance_test.corresponding_requirements = nil
+      errors = conformance_test.validate
+      expect(errors).to include(a_string_matching(/no corresponding requirements/))
+    end
+
+    it "returns errors when corresponding_requirements is empty" do
+      conformance_test.corresponding_requirements = []
+      errors = conformance_test.validate
+      expect(errors).to include(a_string_matching(/no corresponding requirements/))
+    end
+
+    it "returns errors when parent_class is nil" do
+      conformance_test.parent_class = nil
+      errors = conformance_test.validate
+      expect(errors).to include(a_string_matching(/does not belong to its parent class/))
+    end
   end
 
   it "has a corresponding requirement" do

data/spec/modspec/normative_statements_class_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Modspec::NormativeStatementsClass do
     Modspec::NormativeStatement.new(
       identifier: "/req/basic-ypr/position",
       name: "Expression of outer frame",
-      statement: "The `Basic_YPR.position` attribute shall represent the outer frame, specified by an implicit WGS-84 CRS and an implicit EPSG 4461-CS (LTP-ENU) coordinate system and explicit parameters to define the tangent point.",
+      statement: "The `Basic_YPR.position` attribute shall represent the outer frame.",
     )
   end
 
@@ -13,7 +13,7 @@ RSpec.describe Modspec::NormativeStatementsClass do
     Modspec::NormativeStatement.new(
       identifier: "/req/basic-ypr/angles",
       name: "Expression of inner frame",
-      statement: "The `Basic_YPR.angles` attribute shall represent the inner frame, which is a rotation-only transformation with Yaw, Pitch, and Roll (YPR) angles.",
+      statement: "The `Basic_YPR.angles` attribute shall represent the inner frame.",
     )
   end
 
@@ -21,7 +21,7 @@ RSpec.describe Modspec::NormativeStatementsClass do
     described_class.new(
       identifier: "/req/basic-ypr",
       name: "Basic-YPR logical model SDU",
-      description: "The Basic-YPR Target has a simple structure with no options. Position is specified as a point in an LTP-ENU frame and rotation is specified by yaw, pitch, and roll angles specified in decimal degrees.",
+      description: "The Basic-YPR Target has a simple structure.",
       dependencies: ["/req/global", "/req/tangent-point"],
       normative_statements: [normative_statement1, normative_statement2],
     )
@@ -55,7 +55,19 @@ RSpec.describe Modspec::NormativeStatementsClass do
     it "returns errors if there are no normative statements" do
       normative_statements_class.normative_statements = []
       errors = normative_statements_class.validate
-      expect(errors).not_to be_empty
+      expect(errors).to include(a_string_matching(/no child requirements/))
+    end
+
+    it "returns errors if statement identifier does not share prefix" do
+      normative_statements_class.normative_statements = [
+        Modspec::NormativeStatement.new(
+          identifier: "/req/other/mismatch",
+          name: "Mismatched",
+          statement: "stmt",
+        ),
+      ]
+      errors = normative_statements_class.validate
+      expect(errors).to include(a_string_matching(/does not share the expected prefix/))
     end
   end
 end

data/spec/modspec/suite_spec.rb

@@ -38,12 +38,174 @@ RSpec.describe Modspec::Suite do
         .combine(frame_spec_suite)
 
       errors = combined_suite.validate
-      if errors.any?
-
-        errors.each { |error| }
-      end
       expect(errors).to be_empty
     end
+
+    it "detects duplicate identifiers" do
+      suite = described_class.new(
+        identifier: "/suite",
+        name: "Test",
+        normative_statements_classes: [
+          Modspec::NormativeStatementsClass.new(
+            identifier: "/req/test",
+            normative_statements: [
+              Modspec::NormativeStatement.new(identifier: "/req/test/a",
+                                              name: "A", statement: "a"),
+              Modspec::NormativeStatement.new(identifier: "/req/test/a",
+                                              name: "A2", statement: "a2"),
+            ],
+          ),
+        ],
+        conformance_classes: [],
+      )
+
+      errors = suite.validate
+      expect(errors).to include(a_string_matching(/Duplicate identifier/))
+    end
+
+    it "detects dependency cycles" do
+      ns_a = Modspec::NormativeStatement.new(
+        identifier: "/req/test/a", name: "A", statement: "a",
+        dependencies: ["/req/test/b"]
+      )
+      ns_b = Modspec::NormativeStatement.new(
+        identifier: "/req/test/b", name: "B", statement: "b",
+        dependencies: ["/req/test/a"]
+      )
+
+      suite = described_class.new(
+        identifier: "/suite",
+        name: "Test",
+        normative_statements_classes: [
+          Modspec::NormativeStatementsClass.new(
+            identifier: "/req/test",
+            normative_statements: [ns_a, ns_b],
+          ),
+        ],
+        conformance_classes: [],
+      )
+
+      errors = suite.validate
+      expect(errors).to include(a_string_matching(/Cycle detected/))
+    end
+
+    it "detects invalid dependencies" do
+      suite = described_class.new(
+        identifier: "/suite",
+        name: "Test",
+        normative_statements_classes: [
+          Modspec::NormativeStatementsClass.new(
+            identifier: "/req/test",
+            dependencies: ["/req/nonexistent"],
+            normative_statements: [
+              Modspec::NormativeStatement.new(
+                identifier: "/req/test/a", name: "A", statement: "a",
+                dependencies: ["/req/missing"]
+              ),
+            ],
+          ),
+        ],
+        conformance_classes: [],
+      )
+
+      errors = suite.validate
+      expect(errors).to include(a_string_matching(/Invalid dependencies .* in \/req\/test\b/))
+      expect(errors).to include(a_string_matching(/Invalid dependencies .* in \/req\/test\/a/))
+    end
+
+    it "detects invalid conformance test targets" do
+      suite = described_class.new(
+        identifier: "/suite",
+        name: "Test",
+        normative_statements_classes: [
+          Modspec::NormativeStatementsClass.new(
+            identifier: "/req/test",
+            normative_statements: [
+              Modspec::NormativeStatement.new(identifier: "/req/test/a",
+                                              name: "A", statement: "a"),
+            ],
+          ),
+        ],
+        conformance_classes: [
+          Modspec::ConformanceClass.new(
+            identifier: "/conf/test",
+            tests: [
+              Modspec::ConformanceTest.new(
+                identifier: "/conf/test/a",
+                name: "CT-A",
+                targets: ["/req/nonexistent"],
+              ),
+            ],
+          ),
+        ],
+      )
+
+      errors = suite.validate
+      expect(errors).to include(a_string_matching(/Invalid targets .* in \/conf\/test\/a/))
+    end
+
+    it "detects invalid indirect_dependency references" do
+      suite = described_class.new(
+        identifier: "/suite",
+        name: "Test",
+        normative_statements_classes: [
+          Modspec::NormativeStatementsClass.new(
+            identifier: "/req/test",
+            normative_statements: [
+              Modspec::NormativeStatement.new(
+                identifier: "/req/test/a", name: "A", statement: "a",
+                indirect_dependency: ["/req/ghost"]
+              ),
+            ],
+          ),
+        ],
+        conformance_classes: [],
+      )
+
+      errors = suite.validate
+      expect(errors).to include(a_string_matching(/indirect dependency.*in \/req\/test\/a/))
+    end
+
+    it "detects invalid implements references" do
+      suite = described_class.new(
+        identifier: "/suite",
+        name: "Test",
+        normative_statements_classes: [
+          Modspec::NormativeStatementsClass.new(
+            identifier: "/req/test",
+            implements: ["/req/phantom"],
+            normative_statements: [],
+          ),
+        ],
+        conformance_classes: [],
+      )
+
+      errors = suite.validate
+      expect(errors).to include(a_string_matching(/implements.*in \/req\/test/))
+    end
+
+    it "detects invalid conformance test dependencies" do
+      suite = described_class.new(
+        identifier: "/suite",
+        name: "Test",
+        normative_statements_classes: [],
+        conformance_classes: [
+          Modspec::ConformanceClass.new(
+            identifier: "/conf/test",
+            tests: [
+              Modspec::ConformanceTest.new(
+                identifier: "/conf/test/a",
+                name: "CT-A",
+                dependencies: ["/conf/nonexistent"],
+              ),
+            ],
+          ),
+        ],
+      )
+
+      errors = suite.validate
+      expect(errors).to include(a_string_matching(/Invalid dependencies .* in \/conf\/test\/a/))
+    end
   end
 
   describe "#combine" do
@@ -63,6 +225,16 @@ RSpec.describe Modspec::Suite do
       )
     end
 
+    it "raises ArgumentError for non-Suite argument" do
+      expect { suite1.combine("not a suite") }.to raise_error(ArgumentError)
+    end
+
+    it "deduplicates by identifier" do
+      combined = suite1.combine(suite1)
+      nsc_count = combined.normative_statements_classes.count
+      expect(nsc_count).to eq(suite1.normative_statements_classes.count)
+    end
+
     it "resolves conflicts when combining suites" do
       combined_suite = suite1
         .combine(suite2)
@@ -72,10 +244,6 @@ RSpec.describe Modspec::Suite do
         .combine(frame_spec_suite)
 
       errors = combined_suite.validate
-      if errors.any?
-
-        errors.each { |error|  }
-      end
       expect(errors).to be_empty
     end
   end
@@ -89,24 +257,13 @@ RSpec.describe Modspec::Suite do
       expect(combined_suite).to be_a(described_class)
       expect(combined_suite.name).to eq("Combined Suite")
 
-      # Ensure the combined suite has content
       expect(combined_suite.normative_statements_classes).not_to be_empty
       expect(combined_suite.conformance_classes).not_to be_empty
 
-      # Validate the combined suite
       errors = combined_suite.validate
-
-      if errors.any?
-
-        errors.each { |error|  }
-      end
-
-      # Check for specific error types
-      expect(errors).not_to include(a_string_matching(/Conformance test .* has no corresponding requirement/))
+      expect(errors).not_to include(a_string_matching(/has no corresponding requirement/))
       expect(errors).not_to include(a_string_matching(/Cycle detected/))
-      expect(errors).not_to include(a_string_matching(/Requirement .* has an invalid dependency/))
-
-      # If there are still errors, they should be of a different nature
+      expect(errors).not_to include(a_string_matching(/has an invalid dependency/))
       expect(errors).to be_empty
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: modspec
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Ribose
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-05-05 00:00:00.000000000 Z
+date: 2026-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lutaml-model