mods_display 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 696af737773d1dc801bfd3d700ebb694cc831f52
-  data.tar.gz: a884d43c1640681aa477cf3f7de28159b7de68f5
+  metadata.gz: bde2a7d4b0e1265aa8e7c8995c208dcbe2aae03a
+  data.tar.gz: e74a4364e4dd51b66f69c24a0a62258d4c053a4b
 SHA512:
-  metadata.gz: 647c86e5eebc05550a32e3f4cc258eb3e9c9eb0c106ec0a5a7c40c84792942a490f52006c53663f54ed0c3fdea7919a58c748c5468d97e24d88bed352e6785b8
-  data.tar.gz: 532ce43cc00f02d1ae6202bc5e1d2d8afa315d674f0baa7e09b867c58e10998f02bd1da6b682a9524acc7f95d9d461aeae9b2c57ef40f9ef46e05631cf3834b7
+  metadata.gz: f781baf89a8b7b455df415f3df0a3f5db0deca36e41f6e3dd31e5a7c2f288306936a6c062da0d11d0ea7b3b5037316786ff922f9f8b96eb153c1b417bcab91b3
+  data.tar.gz: 96fe552b5de3c62eb0629108a297209b946164b05b5f71676c7a2deb16c7669b0f29f52bb9e33a552e7d5c95b9ded860474a93ce0add2e7cb5bffd74ac87c9d7

data/.rubocop.yml

@@ -0,0 +1,16 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  Exclude:
+    - '*.gemspec'
+    - 'bin/**/*'
+    - 'db/**/*'
+    - 'spec/fixtures/**/*'
+    - 'vendor/**/*'
+
+Metrics/LineLength:
+  Max: 120
+
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: single_quotes

data/.rubocop_todo.yml

@@ -0,0 +1,60 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2015-11-06 16:51:15 -0800 using RuboCop version 0.34.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+Lint/NestedMethodDefinition:
+  Exclude:
+    - 'lib/mods_display/controller_extension.rb'
+    - 'lib/mods_display/model_extension.rb'
+
+# Offense count: 29
+Metrics/AbcSize:
+  Max: 55
+
+# Offense count: 5
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 263
+
+# Offense count: 12
+Metrics/CyclomaticComplexity:
+  Max: 11
+
+# Offense count: 30
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 378
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 380
+
+# Offense count: 12
+Metrics/PerceivedComplexity:
+  Max: 15
+
+# Offense count: 42
+# Configuration parameters: Exclude.
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 8
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/MethodName:
+  Enabled: false
+
+# Offense count: 1
+Style/MultilineBlockChain:
+  Exclude:
+    - 'lib/mods_display/fields/imprint.rb'
+
+# Offense count: 8
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/VariableName:
+  Enabled: false

data/.travis.yml

@@ -1,6 +1,6 @@
 notifications:
   email: false
 rvm:
-  - 2.1.0
-  - 2.0.0
+  - 2.2.3
+  - 2.1.7
   - 1.9.3

data/Rakefile

@@ -1,5 +1,13 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
+RuboCop::RakeTask.new
 RSpec::Core::RakeTask.new(:spec)
-task :default => :spec
+
+task :ci do
+  Rake::Task['rubocop'].invoke
+  Rake::Task['spec'].invoke
+end
+
+task default: :ci

data/lib/mods_display.rb

@@ -1,48 +1,48 @@
-require "mods_display/version"
-require "mods_display/controller_extension"
-require "mods_display/html"
-require "mods_display/model_extension"
-require "mods_display/country_codes"
-require "mods_display/relator_codes"
-require "mods_display/configuration"
-require "mods_display/configuration/base"
-require "mods_display/configuration/access_condition"
-require "mods_display/configuration/imprint"
-require "mods_display/configuration/format"
-require "mods_display/configuration/genre"
-require "mods_display/configuration/name"
-require "mods_display/configuration/note"
-require "mods_display/configuration/related_item"
-require "mods_display/configuration/subject"
-require "mods_display/configuration/title"
-require "mods_display/fields/field"
-require "mods_display/fields/abstract"
-require "mods_display/fields/access_condition"
-require "mods_display/fields/audience"
-require "mods_display/fields/collection"
-require "mods_display/fields/contact"
-require "mods_display/fields/contents"
-require "mods_display/fields/cartographics"
-require "mods_display/fields/description"
-require "mods_display/fields/format"
-require "mods_display/fields/genre"
-require "mods_display/fields/identifier"
-require "mods_display/fields/imprint"
-require "mods_display/fields/language"
-require "mods_display/fields/location"
-require "mods_display/fields/name"
-require "mods_display/fields/note"
-require "mods_display/fields/related_item"
-require "mods_display/fields/resource_type"
-require "mods_display/fields/subject"
-require "mods_display/fields/sub_title"
-require "mods_display/fields/title"
-require "mods_display/fields/values"
+require 'mods_display/version'
+require 'mods_display/controller_extension'
+require 'mods_display/html'
+require 'mods_display/model_extension'
+require 'mods_display/country_codes'
+require 'mods_display/relator_codes'
+require 'mods_display/configuration'
+require 'mods_display/configuration/base'
+require 'mods_display/configuration/access_condition'
+require 'mods_display/configuration/imprint'
+require 'mods_display/configuration/format'
+require 'mods_display/configuration/genre'
+require 'mods_display/configuration/name'
+require 'mods_display/configuration/note'
+require 'mods_display/configuration/related_item'
+require 'mods_display/configuration/subject'
+require 'mods_display/configuration/title'
+require 'mods_display/fields/field'
+require 'mods_display/fields/abstract'
+require 'mods_display/fields/access_condition'
+require 'mods_display/fields/audience'
+require 'mods_display/fields/collection'
+require 'mods_display/fields/contact'
+require 'mods_display/fields/contents'
+require 'mods_display/fields/cartographics'
+require 'mods_display/fields/description'
+require 'mods_display/fields/format'
+require 'mods_display/fields/genre'
+require 'mods_display/fields/identifier'
+require 'mods_display/fields/imprint'
+require 'mods_display/fields/language'
+require 'mods_display/fields/location'
+require 'mods_display/fields/name'
+require 'mods_display/fields/note'
+require 'mods_display/fields/related_item'
+require 'mods_display/fields/resource_type'
+require 'mods_display/fields/subject'
+require 'mods_display/fields/sub_title'
+require 'mods_display/fields/title'
+require 'mods_display/fields/values'
 
 require 'stanford-mods'
 
-require "i18n"
-require "i18n/backend/fallbacks" 
+require 'i18n'
+require 'i18n/backend/fallbacks'
 I18n::Backend::Simple.send(:include, I18n::Backend::Fallbacks)
 I18n.load_path += Dir["#{File.expand_path('../..', __FILE__)}/config/locales/*.yml"]
 I18n.backend.load_translations

data/lib/mods_display/configuration.rb

@@ -1,91 +1,93 @@
 # We can probably do something smarter here using const_get to assign
 # special coniguration classes then fall back on the base config class
-class ModsDisplay::Configuration
-  def initialize &config
-    instance_eval &config
-  end
+module ModsDisplay
+  class Configuration
+    def initialize(&config)
+      instance_eval(&config)
+    end
 
-  def title &title
-    @title ||= ModsDisplay::Configuration::Title.new(&title || Proc.new{})
-  end
+    def title(&title)
+      @title ||= ModsDisplay::Configuration::Title.new(&title || proc {})
+    end
 
-  def sub_title &sub_title
-    @sub_title ||= ModsDisplay::Configuration::Title.new(&sub_title || Proc.new{})
-  end
+    def sub_title(&sub_title)
+      @sub_title ||= ModsDisplay::Configuration::Title.new(&sub_title || proc {})
+    end
 
-  def name &name
-    @name ||= ModsDisplay::Configuration::Name.new(&name || Proc.new{})
-  end
+    def name(&name)
+      @name ||= ModsDisplay::Configuration::Name.new(&name || proc {})
+    end
 
-  def resource_type &resource_type
-    @type_of_resource ||= ModsDisplay::Configuration::Base.new(&resource_type || Proc.new{})
-  end
+    def resource_type(&resource_type)
+      @type_of_resource ||= ModsDisplay::Configuration::Base.new(&resource_type || proc {})
+    end
 
-  def genre &genre
-    @genre ||= ModsDisplay::Configuration::Genre.new(&genre || Proc.new{})
-  end
+    def genre(&genre)
+      @genre ||= ModsDisplay::Configuration::Genre.new(&genre || proc {})
+    end
 
-  def format &format
-    @format ||= ModsDisplay::Configuration::Format.new(&format || Proc.new{})
-  end
+    def format(&format)
+      @format ||= ModsDisplay::Configuration::Format.new(&format || proc {})
+    end
 
-  def imprint &imprint
-    @imprint ||= ModsDisplay::Configuration::Imprint.new(&imprint || Proc.new{})
-  end
+    def imprint(&imprint)
+      @imprint ||= ModsDisplay::Configuration::Imprint.new(&imprint || proc {})
+    end
 
-  def language &language
-    @language ||= ModsDisplay::Configuration::Base.new(&language || Proc.new{})
-  end
+    def language(&language)
+      @language ||= ModsDisplay::Configuration::Base.new(&language || proc {})
+    end
 
-  def description &description
-    @description ||= ModsDisplay::Configuration::Base.new(&description || Proc.new{})
-  end
+    def description(&description)
+      @description ||= ModsDisplay::Configuration::Base.new(&description || proc {})
+    end
 
-  def cartographics &cartographics
-    @cartographics ||= ModsDisplay::Configuration::Base.new(&cartographics || Proc.new{})
-  end
+    def cartographics(&cartographics)
+      @cartographics ||= ModsDisplay::Configuration::Base.new(&cartographics || proc {})
+    end
 
-  def abstract &abstract
-    @abstract ||= ModsDisplay::Configuration::Base.new(&abstract || Proc.new{})
-  end
+    def abstract(&abstract)
+      @abstract ||= ModsDisplay::Configuration::Base.new(&abstract || proc {})
+    end
 
-  def contents &contents
-    @contents ||= ModsDisplay::Configuration::Base.new(&contents || Proc.new{})
-  end
+    def contents(&contents)
+      @contents ||= ModsDisplay::Configuration::Base.new(&contents || proc {})
+    end
 
-  def audience &audience
-    @audience ||= ModsDisplay::Configuration::Base.new(&audience || Proc.new{})
-  end
+    def audience(&audience)
+      @audience ||= ModsDisplay::Configuration::Base.new(&audience || proc {})
+    end
 
-  def note &note
-    @note ||= ModsDisplay::Configuration::Note.new(&note || Proc.new{})
-  end
+    def note(&note)
+      @note ||= ModsDisplay::Configuration::Note.new(&note || proc {})
+    end
 
-  def contact &contact
-    @contact ||= ModsDisplay::Configuration::Base.new(&contact || Proc.new{})
-  end
+    def contact(&contact)
+      @contact ||= ModsDisplay::Configuration::Base.new(&contact || proc {})
+    end
 
-  def collection &collection
-    @collection ||= ModsDisplay::Configuration::Base.new(&collection || Proc.new{})
-  end
+    def collection(&collection)
+      @collection ||= ModsDisplay::Configuration::Base.new(&collection || proc {})
+    end
 
-  def related_item &related_item
-    @related_item ||= ModsDisplay::Configuration::RelatedItem.new(&related_item || Proc.new{})
-  end
+    def related_item(&related_item)
+      @related_item ||= ModsDisplay::Configuration::RelatedItem.new(&related_item || proc {})
+    end
 
-  def subject &subject
-    @subject ||= ModsDisplay::Configuration::Subject.new(&subject || Proc.new{})
-  end
+    def subject(&subject)
+      @subject ||= ModsDisplay::Configuration::Subject.new(&subject || proc {})
+    end
 
-  def identifier &identifier
-    @identifier ||= ModsDisplay::Configuration::Base.new(&identifier || Proc.new{})
-  end
+    def identifier(&identifier)
+      @identifier ||= ModsDisplay::Configuration::Base.new(&identifier || proc {})
+    end
 
-  def location &location
-    @location ||= ModsDisplay::Configuration::Base.new(&location || Proc.new{})
-  end
+    def location(&location)
+      @location ||= ModsDisplay::Configuration::Base.new(&location || proc {})
+    end
 
-  def access_condition &access_condition
-    @access_condition ||= ModsDisplay::Configuration::AccessCondition.new(&access_condition || Proc.new{})
+    def access_condition(&access_condition)
+      @access_condition ||= ModsDisplay::Configuration::AccessCondition.new(&access_condition || proc {})
+    end
   end
-end
+end

data/lib/mods_display/configuration/access_condition.rb

@@ -1,17 +1,21 @@
-class ModsDisplay::Configuration::AccessCondition < ModsDisplay::Configuration::Base
-  def delimiter delimiter="<br/>"
-    @delimiter ||= delimiter
-  end
+module ModsDisplay
+  class Configuration
+    class AccessCondition < Base
+      def delimiter(delimiter = '<br/>')
+        @delimiter ||= delimiter
+      end
 
-  def ignore?
-    @ignore.nil? ? true : @ignore
-  end
+      def ignore?
+        @ignore.nil? ? true : @ignore
+      end
 
-  def display!
-    @ignore = false
-  end
+      def display!
+        @ignore = false
+      end
 
-  def cc_license_version cc_license_version="3.0"
-    @cc_license_version ||= cc_license_version
+      def cc_license_version(cc_license_version = '3.0')
+        @cc_license_version ||= cc_license_version
+      end
+    end
   end
-end
+end

data/lib/mods_display/configuration/base.rb

@@ -1,31 +1,34 @@
-class ModsDisplay::Configuration::Base
-  def initialize &config
-    instance_eval &config if block_given?
-  end
+module ModsDisplay
+  class Configuration
+    class Base
+      def initialize(&config)
+        instance_eval(&config) if block_given?
+      end
 
-  def label_class label_class=""
-    @label_class ||= label_class
-  end
+      def label_class(label_class = '')
+        @label_class ||= label_class
+      end
 
-  def value_class value_class=""
-    @value_class ||= value_class
-  end
+      def value_class(value_class = '')
+        @value_class ||= value_class
+      end
 
-  def delimiter delimiter=", "
-    @delimiter ||= delimiter
-  end
+      def delimiter(delimiter = ', ')
+        @delimiter ||= delimiter
+      end
 
-  def link method_name="", args={}
-    return @link if method_name == ""
-    @link ||= [method_name, args]
-  end
+      def link(method_name = '', args = {})
+        return @link if method_name == ''
+        @link ||= [method_name, args]
+      end
 
-  def ignore!
-    @ignore = true
-  end
+      def ignore!
+        @ignore = true
+      end
 
-  def ignore?
-    @ignore || false
+      def ignore?
+        @ignore || false
+      end
+    end
   end
-
-end
+end