mods_display 0.3.3 → 0.3.4

data/spec/fixtures/related_item_fixtures.rb

@@ -0,0 +1,107 @@
+module RelatedItemFixtures
+  def basic_related_item_fixture
+    <<-XML
+      <mods>
+        <relatedItem>
+          <titleInfo>A Related Item</titleInfo>
+        </relatedItem>
+      </mods>
+    XML
+  end
+
+  def linked_related_item_fixture
+    <<-XML
+      <mods>
+        <relatedItem>
+          <titleInfo>A Related Item</titleInfo>
+          <location>
+            <url>http://library.stanford.edu/</url>
+          </location>
+        </relatedItem>
+      </mods>
+    XML
+  end
+
+  def related_item_collection_fixture
+    <<-XML
+      <mods>
+        <relatedItem>
+          <titleInfo>This is a Collection</titleInfo>
+          <typeOfResource collection='yes' />
+        </relatedItem>
+      </mods>
+    XML
+  end
+
+  def related_item_display_label_fixture
+    <<-XML
+      <mods>
+        <relatedItem displayLabel='Special Item'>
+          <titleInfo>A Related Item</titleInfo>
+        </relatedItem>
+      </mods>
+    XML
+  end
+
+  def related_item_location_fixture
+    <<-XML
+      <mods>
+        <relatedItem>
+          <location>The Location</location>
+        </relatedItem>
+      </mods>
+    XML
+  end
+
+  def related_item_reference_fixture
+    <<-XML
+      <mods>
+        <relatedItem type='isReferencedBy'>
+          <titleInfo>The title</titleInfo>
+          <note>124</note>
+          <originInfo>
+            <dateOther>DATE</dateOther>
+          </originInfo>
+        </relatedItem>
+      </mods>
+    XML
+  end
+
+  def blank_related_item_fixture
+    <<-XML
+      <mods>
+        <relatedItem>
+          <titleInfo>
+            <title></title>
+          </titleInfo>
+          <location>
+            <url></url>
+          </location>
+        </relatedItem>
+      </mods>
+    XML
+  end
+
+  def multi_related_item_fixture
+    <<-XML
+      <mods>
+        <relatedItem>
+          <titleInfo>
+            <title>Library</title>
+          </titleInfo>
+          <location>
+            <url>http://library.stanford.edu</url>
+          </location>
+        </relatedItem>
+        <relatedItem>
+          <titleInfo>
+            <title>SDR</title>
+          </titleInfo>
+          <location>
+            <url>http://purl.stanford.edu</url>
+          </location>
+        </relatedItem>
+      </mods>
+    XML
+  end
+end

data/spec/fixtures/subjects_fixtures.rb

@@ -10,7 +10,7 @@ module SubjectsFixtures
       </mods>
     XML
   end
-  
+
   def blank_subject
     <<-XML
       <mods>
@@ -61,6 +61,18 @@ module SubjectsFixtures
     XML
   end
 
+  def blank_name_subject
+    <<-XML
+      <mods>
+        <subject>
+          <name>
+            <namePart />
+          </name>
+        </subject>
+      </mods>
+    XML
+  end
+
   def complex_subjects
     <<-XML
       <mods>
@@ -76,6 +88,7 @@ module SubjectsFixtures
       </mods>
     XML
   end
+
   def display_label_subjects
     <<-XML
       <mods>
@@ -99,4 +112,4 @@ module SubjectsFixtures
       </mods>
     XML
   end
-end
+end

data/spec/fixtures/title_fixtures.rb

@@ -0,0 +1,101 @@
+module TitleFixtures
+  def simple_title_fixture
+    <<-XML
+      <mods>
+        <titleInfo><title>Title</title></titleInfo>
+      </mods>
+    XML
+  end
+
+  def title_parts_fixture
+    <<-XML
+      <mods>
+        <titleInfo>
+          <nonSort>The</nonSort>
+          <title>Title</title>
+          <subTitle>For</subTitle>
+          <partName>Something</partName>
+          <partNumber>Part 62</partNumber>
+        </titleInfo>
+      </mods>
+    XML
+  end
+
+  def reverse_title_parts_fixture
+    <<-XML
+      <mods>
+        <titleInfo>
+          <nonSort>The</nonSort>
+          <title>Title : </title>
+          <subTitle>For</subTitle>
+          <partNumber>Part 62</partNumber>
+          <partName>Something</partName>
+        </titleInfo>
+      </mods>
+    XML
+  end
+
+  def display_label_fixture
+    <<-XML
+      <mods>
+        <titleInfo displayLabel='MyTitle'>
+          <title>Title</title>
+        </titleInfo>
+      </mods>
+    XML
+  end
+
+  def display_form_fixture
+    <<-XML
+      <mods>
+        <titleInfo>
+          <title>Title</title>
+          <displayForm>The Title of This Item</displayForm>
+        </titleInfo>
+      </mods>
+    XML
+  end
+
+  def multi_label_fixture
+    <<-XML
+      <mods>
+        <titleInfo>
+          <title>Main Title</title>
+        </titleInfo>
+        <titleInfo type='alternative'>
+          <title>Alt Title</title>
+        </titleInfo>
+        <titleInfo type='uniform'>
+          <title>Uniform Title</title>
+        </titleInfo>
+        <titleInfo type='alternative'>
+          <title>Another Alt Title</title>
+        </titleInfo>
+        <titleInfo type='alternative'>
+          <title>Yet Another Alt Title</title>
+        </titleInfo>
+      </mods>
+    XML
+  end
+
+  def alt_title_fixture
+    <<-XML
+      <mods>
+        <titleInfo type='alternative'>
+          <title>Title</title>
+        </titleInfo>
+      </mods>
+    XML
+  end
+
+  def title_puncutation_fixture
+    <<-XML
+      <mods>
+        <titleInfo>
+          <title>A title that ends in punctuation.</title>
+          <partNumber>2015</partNumber>
+        </titleInfo>
+      </mods>
+    XML
+  end
+end

data/spec/integration/configuration_spec.rb

@@ -1,4 +1,4 @@
-require "spec_helper"
+require 'spec_helper'
 
 class TestNoConfigController
   include ModsDisplay::ControllerExtension
@@ -6,49 +6,52 @@ end
 
 class TestConfigController
   include ModsDisplay::ControllerExtension
-  
+
   configure_mods_display do
     title do
       label_class 'label-class'
       value_class 'value-class'
-      link :link_to_title, "%value%"
+      link :link_to_title, '%value%'
     end
     contact do
       ignore!
     end
   end
-  
+
   def link_to_title(title)
     "/path/to/title?#{title}"
   end
 end
 
-describe "Configuration" do
+describe 'Configuration' do
   before(:all) do
-    xml = "<mods><titleInfo><title>The Title of this Item</title></titleInfo><note type='contact'>jdoe@example.com</note></mods>"
+    xml = "<mods>
+      <titleInfo><title>The Title of this Item</title></titleInfo>
+      <note type='contact'>jdoe@example.com</note>
+    </mods>"
     model = TestModel.new
     model.modsxml = xml
     @no_config_controller = TestNoConfigController.new
     @config_controller = TestConfigController.new
     @html = @config_controller.render_mods_display(model)
   end
-  it "should apply the label class" do
-    @html.should match(/<dt class='label-class' title=/)
+  it 'should apply the label class' do
+    expect(@html).to match(/<dt class='label-class' title=/)
   end
-  it "should apply the value class" do
-    @html.scan(/<dd class='value-class'>/).length.should == 1
+  it 'should apply the value class' do
+    expect(@html.scan(/<dd class='value-class'>/).length).to eq(1)
   end
-  it "should apply the link" do
-    @html.scan(/<a href='\/path\/to\/title\?The Title of this Item'>The Title of this Item<\a>/)
+  it 'should apply the link' do
+    @html.scan(%r{<a href='/path/to/title\?The Title of this Item'>The Title of this Item</a>})
   end
-  it "should ignore fields if requested" do
-    @html.scan(/jdoe@example\.com/).length.should == 0
+  it 'should ignore fields if requested' do
+    expect(@html.scan(/jdoe@example\.com/).length).to eq(0)
   end
-  it "should get overriden configurations" do
-    @no_config_controller.mods_display_config.contact.ignore?.should be_false
-    @config_controller.mods_display_config.contact.ignore?.should be_true
+  it 'should get overriden configurations' do
+    expect(@no_config_controller.mods_display_config.contact.ignore?).to be false
+    expect(@config_controller.mods_display_config.contact.ignore?).to be true
   end
-  it "should get default configurations when no controller configuration is supplied" do
-    @no_config_controller.mods_display_config.note.delimiter.should == "<br/>"
+  it 'should get default configurations when no controller configuration is supplied' do
+    expect(@no_config_controller.mods_display_config.note.delimiter).to eq('<br/>')
   end
-end
+end

data/spec/integration/html_spec.rb

@@ -1,16 +1,27 @@
 # encoding: UTF-8
-require "spec_helper"
+require 'spec_helper'
 
-def html_from_mods(xml, locale=nil)
+def html_from_mods(xml, locale = nil)
   model = TestModel.new
   model.modsxml = xml
   I18n.locale = locale if locale
   TestController.new.render_mods_display(model)
 end
 
-describe "HTML Output" do
+describe 'HTML Output' do
   before(:all) do
-    @multiple_titles = html_from_mods("<mods><titleInfo><title>Main Title</title></titleInfo><titleInfo type='alternative'><title>Alternate Title</title></titleInfo></mods>")
+    @multiple_titles = html_from_mods(
+      <<-MODS
+        <mods>
+          <titleInfo>
+            <title>Main Title</title>
+          </titleInfo>
+          <titleInfo type='alternative'>
+            <title>Alternate Title</title>
+          </titleInfo>
+        </mods>
+      MODS
+    )
     @abstract = html_from_mods("<mods><abstract>Hey. I'm an abstract.</abstract></mods>")
     mods = "<mods><titleInfo><title>Main Title</title></titleInfo><abstract>Hey. I'm an abstract.</abstract></mods>"
     @mods = html_from_mods(mods)
@@ -19,44 +30,44 @@ describe "HTML Output" do
   after(:all) do
     I18n.locale = :en
   end
-  describe "i18n" do
-    it "should get the default english translations" do
-      expect(@mods.to_html).to match(/<dt title='Title'>Title:<\/dt>/)
+  describe 'i18n' do
+    it 'should get the default english translations' do
+      expect(@mods.to_html).to match(%r{<dt title='Title'>Title:</dt>})
     end
-    it "should internationalize the labels when translations are available" do
-      expect(@fr_mods.to_html).to match(/<dt title='Résumé'>Résumé :<\/dt>/)
+    it 'should internationalize the labels when translations are available' do
+      expect(@fr_mods.to_html).to match(%r{<dt title='Résumé'>Résumé :</dt>})
     end
-    it "should get fallback to the default english translations if a translation is missing" do
-      expect(@fr_mods.to_html).to match(/<dt title='Title'>Title:<\/dt>/)
+    it 'should get fallback to the default english translations if a translation is missing' do
+      expect(@fr_mods.to_html).to match(%r{<dt title='Title'>Title:</dt>})
     end
   end
-  describe "titles" do
-    it "should include both titles it regular display" do
-      @multiple_titles.to_html.should include("<dd>Main Title</dd>")
-      @multiple_titles.to_html.should include("<dd>Alternate Title</dd>")
+  describe 'titles' do
+    it 'should include both titles it regular display' do
+      expect(@multiple_titles.to_html).to include('<dd>Main Title</dd>')
+      expect(@multiple_titles.to_html).to include('<dd>Alternate Title</dd>')
     end
-    it "should return just the first title in the #title method" do
-      @multiple_titles.title.should == ["Main Title"]
+    it 'should return just the first title in the #title method' do
+      expect(@multiple_titles.title).to eq(['Main Title'])
     end
-    it "should omit the first title and return any remaining titles in the #body" do
-      @multiple_titles.body.should_not include("<dd>Main Title</dd>")
-      @multiple_titles.body.should     include("<dd>Alternate Title</dd>")
+    it 'should omit the first title and return any remaining titles in the #body' do
+      expect(@multiple_titles.body).not_to include('<dd>Main Title</dd>')
+      expect(@multiple_titles.body).to include('<dd>Alternate Title</dd>')
     end
   end
-  describe "individual fields" do
-    it "should return ModsDispaly::Values for the specefied field" do
+  describe 'individual fields' do
+    it 'should return ModsDispaly::Values for the specefied field' do
       fields = @abstract.abstract
       fields.each do |field|
-        field.should be_a ModsDisplay::Values
+        expect(field).to be_a ModsDisplay::Values
       end
-      fields.length.should eq 1
-      fields.first.values.should eq ["Hey. I'm an abstract."]
+      expect(fields.length).to eq 1
+      expect(fields.first.values).to eq ["Hey. I'm an abstract."]
     end
-    it "should return a blank array if no data is available for a specific field" do
-      @abstract.genre.should eq []
+    it 'should return a blank array if no data is available for a specific field' do
+      expect(@abstract.genre).to eq []
     end
     it "should not return a field that doesn't exist (and isn't a string)" do
-      -> {@abstract.not_a_real_field}.should raise_error NoMethodError
+      expect { @abstract.not_a_real_field }.to raise_error NoMethodError
     end
   end
-end
+end

data/spec/integration/installation_spec.rb

@@ -1,26 +1,26 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Installation" do
+describe 'Installation' do
   before(:all) do
     @pieces_of_data = 1
-    title_xml = "<mods><titleInfo><title>The Title of this Item</title></titleInfo></mods>"
+    title_xml = '<mods><titleInfo><title>The Title of this Item</title></titleInfo></mods>'
     model = TestModel.new
     model.modsxml = title_xml
     controller = TestController.new
     @html = controller.render_mods_display(model)
   end
-  it "should return a single <dl>" do
-    @html.scan(/<dl>/).length.should == 1
-    @html.scan(/<\/dl>/).length.should == 1
+  it 'should return a single <dl>' do
+    expect(@html.scan(/<dl>/).length).to eq(1)
+    expect(@html.scan(%r{</dl>}).length).to eq(1)
   end
-  it "should return a dt/dd pair for each piece of metadata in the mods" do
-    @html.scan(/<dt/).length.should == @pieces_of_data
-    @html.scan(/<dd>/).length.should == @pieces_of_data
+  it 'should return a dt/dd pair for each piece of metadata in the mods' do
+    expect(@html.scan(/<dt/).length).to eq(@pieces_of_data)
+    expect(@html.scan(/<dd>/).length).to eq(@pieces_of_data)
   end
-  it "should return a proper label" do
-    @html.scan(/<dt title='Title'>Title:<\/dt>/).length.should == 1
+  it 'should return a proper label' do
+    expect(@html.scan(%r{<dt title='Title'>Title:</dt>}).length).to eq(1)
   end
-  it "should return a proper value" do
-    @html.scan(/<dd>The Title of this Item<\/dd>/).length.should == 1
+  it 'should return a proper value' do
+    expect(@html.scan(%r{<dd>The Title of this Item</dd>}).length).to eq(1)
   end
-end
+end