mods_display 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e56a492203162fcc4977642c25ae1480279abb98addbb8b37fc89c5d508ec1b
-  data.tar.gz: f2b56fb5a9273fc3ae27aac611737d80adc0d825c29aada98377468697912c17
+  metadata.gz: a3c2bc98c15b659a075bccc6e3dea41e55f757f3318ad4d1e34109c314d10792
+  data.tar.gz: 3fc189b77cd0088578718fa5f1645e5390c0442825faacc51e7ec9de92f568c7
 SHA512:
-  metadata.gz: 52c2b74b30ddf95a6c04ec094ff3c9f064c7282898030f0d81507bebbf8eb45babc9f80edd9e4ef3e0149a1ae730519cb45eff174b6f39cae2f06768c9fe893c
-  data.tar.gz: b5ddfbde80b819cf3eed221e9d338e1526ca42ebc4289125cdfb34a07632da0e28a71920690e17f7c25c766997730deb24b50b5a03a0a206ab101781917119cb
+  metadata.gz: 2a35e824baad68b451eb64f126a3eea9eb61c0fd190c767933c4f6946336034d5f604fa8f81a24c1060ab9e29ed7c9d72c941f526b7bf42288870e51862d60fc
+  data.tar.gz: 9fbd968fe4409450090e9f3285a19f9eb86f3834ddf36061e6d4b5d5c617efaeb2996cdc88a8363a6cb29e79525403578e62266b0873423266d85ea484c461ed

data/Gemfile

@@ -3,6 +3,7 @@
 source 'https://rubygems.org'
 
 gem 'rubocop-rspec', require: false
+gem 'debug'
 
 # Specify your gem's dependencies in mods_display.gemspec
 gemspec

data/lib/mods_display/fields/title.rb

@@ -3,9 +3,8 @@
 module ModsDisplay
   class Title < Field
     def fields
-      return_values = []
-      @values&.each do |value|
-        return_values << ModsDisplay::Values.new(
+      return_values = sorted_values.map do |value|
+        ModsDisplay::Values.new(
           label: displayLabel(value) || title_label(value),
           values: [assemble_title(value)]
         )
@@ -15,6 +14,11 @@ module ModsDisplay
 
     private
 
+    # If there is a node with usage="primary", then it should come first.
+    def sorted_values
+      Array(@values).sort_by { |node| node['usage'] == 'primary' ? 0 : 1 }
+    end
+
     def delimiter
       '<br />'.html_safe
     end

data/lib/mods_display/html.rb

@@ -35,9 +35,8 @@ module ModsDisplay
     end
 
     def title
-      return mods_field(:title).fields.first.values unless mods_field(:title).fields.empty?
-
-      ''
+      title_fields = mods_field(:title).fields
+      title_fields.empty? ? '' : title_fields.first.values
     end
 
     def render_in(view_context)
@@ -45,7 +44,7 @@ module ModsDisplay
     end
 
     # Need to figure out how to get the 1st title out of the list.
-    # Maybe have a separate class that will omit the first tite natively
+    # Maybe have a separate class that will omit the first title natively
     # and replace the first key in the the fields list with that.
     def body(view_context = ApplicationController.renderer)
       view_context.render ModsDisplay::RecordComponent.new(record: self), layout: false

data/lib/mods_display/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ModsDisplay
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

data/mods_display.gemspec

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+require_relative "lib/mods_display/version"
+
+Gem::Specification.new do |gem|
+  gem.name          = 'mods_display'
+  gem.version       = ModsDisplay::VERSION
+  gem.authors       = ['Jessie Keck']
+  gem.email         = ['jessie.keck@gmail.com']
+  gem.description   = 'MODS Display is a gem to centralize the display logic of MODS metadata.'
+  gem.summary       = 'The MODS Display gem allows implementers to configure a customized display of MODS metadata.  This display implements the specifications defined at Stanford for how to display MODS.'
+  gem.homepage      = 'https://github.com/sul-dlss/mods_display'
+
+  # Specify which files should be added to the gem when it is released.
+  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
+  gem.files = Dir.chdir(File.expand_path(__dir__)) do
+    `git ls-files -z`.split("\x0").reject do |f|
+      (f == __FILE__) || f.match(%r{\A(?:(?:test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
+    end
+  end
+  gem.bindir = "exe"
+  gem.executables = gem.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
+  gem.require_paths = ["lib"]
+
+  gem.add_dependency 'stanford-mods', '~> 3.3'
+  gem.add_dependency 'i18n'
+  gem.add_dependency 'view_component'
+
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec', '~> 3.0'
+  gem.add_development_dependency 'rspec-rails'
+  gem.add_development_dependency 'rubocop'
+  gem.add_development_dependency 'capybara'
+  gem.add_development_dependency 'rails', ENV['RAILS_VERSION'] || '~> 6.0'
+  gem.add_development_dependency 'combustion', '~> 1.3'
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mods_display
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Jessie Keck
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-02-15 00:00:00.000000000 Z
+date: 2023-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: stanford-mods
@@ -122,20 +122,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -164,7 +150,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
-description: MODS Display is a gem to centralize the display logic of MODS medadata.
+description: MODS Display is a gem to centralize the display logic of MODS metadata.
 email:
 - jessie.keck@gmail.com
 executables: []
@@ -220,6 +206,7 @@ files:
 - lib/mods_display/related_item_concerns.rb
 - lib/mods_display/relator_codes.rb
 - lib/mods_display/version.rb
+- mods_display.gemspec
 homepage: https://github.com/sul-dlss/mods_display
 licenses: []
 metadata: {}
@@ -238,7 +225,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.4.6
 signing_key:
 specification_version: 4
 summary: The MODS Display gem allows implementers to configure a customized display