mods_display 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 53261106f9194d4a55bfa879bed5de2456ec8cda
-  data.tar.gz: a337bd0562de9d50a6361f571bdc87ff48809b38
+SHA256:
+  metadata.gz: c2d5c102f64b65d4313c4aad186328f17edf6475908f360762591ec4ded1f044
+  data.tar.gz: fefe5bd0aa2a29fe4cb60ad94e40840a3a1fe4a12b30ffccfc08b32361d04a5b
 SHA512:
-  metadata.gz: a41f34b9565c81f5ab3ce15c08e43bdedf5793021cef6e6f65526c13174f798288b0636ff8ce0332fbcfd5b69137caa2e3a015b6ba61e9417b62ced3d618e171
-  data.tar.gz: adaccbdda2e72b8eebadf19b18d1628c799efa300d63c0813dfc9112c1656eee3f583acd2309619dc1fbe97f0c90ee153e4898cab2cbf700bbb6dcc04a5a2eeb
+  metadata.gz: 5230f9bda246de22ebaaab5d01f3dc8a6d02f7a92f56a6caa1aa8e7d39039d8cb2d2fd8f39e8797d0757fb49dea269e680191ba9d495ae45ddf20cdfbfb3ae55
+  data.tar.gz: 5d5144f39760608dcb3a628022d1e8335e54b23a0c6e2b172c7705c68bd1a2fc12fa8b3155635c77bae9c74842bb3aeefc61639ea3c717f0495df7860faf6853

data/.travis.yml

@@ -3,4 +3,3 @@ notifications:
 rvm:
   - 2.4.1
   - 2.3.4
-  - 2.2.8

data/Gemfile

@@ -3,5 +3,3 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in mods_display.gemspec
 gemspec
 
-# Pin to activesupport 4.x for older versions of ruby
-gem 'activesupport', '~> 4.2' if RUBY_VERSION < '2.2.2'

data/lib/mods_display/fields/extent.rb

@@ -13,7 +13,7 @@ module ModsDisplay
     private
 
     def extent_fields
-      @values.map(&:extent)
+      @values.map(&:extent).flatten
     end
   end
 end

data/lib/mods_display/fields/form.rb

@@ -5,7 +5,7 @@ module ModsDisplay
       [
         ModsDisplay::Values.new(
           label: I18n.t('mods_display.form'),
-          values: form_fields.map(&:text)
+          values: form_fields.map(&:text).uniq { |x| x.downcase.gsub(/\s/, '').gsub(/[[:punct:]]/, '') }
         )
       ]
     end
@@ -13,7 +13,7 @@ module ModsDisplay
     private
 
     def form_fields
-      @values.map(&:form)
+      @values.map(&:form).flatten
     end
   end
 end

data/lib/mods_display/html.rb

@@ -40,7 +40,7 @@ module ModsDisplay
     def method_missing(method_name, *args, &block)
       if to_s.respond_to?(method_name)
         to_html.send(method_name, *args, &block)
-      elsif mods_display_fields.include?(method_name)
+      elsif method_name == :subTitle || mods_display_fields.include?(method_name)
         mods_field(@xml, method_name).fields
       else
         super

data/lib/mods_display/version.rb

@@ -1,3 +1,3 @@
 module ModsDisplay
-  VERSION = '0.5.1'
+  VERSION = '0.6.0'
 end

data/spec/fields/extent_spec.rb

@@ -6,6 +6,7 @@ describe ModsDisplay::Extent do
       <mods>
         <physicalDescription>
           <extent>Extent Value</extent>
+          <extent>Extent Value 2</extent>
         </physicalDescription>
       </mods>
     XML
@@ -24,7 +25,7 @@ describe ModsDisplay::Extent do
 
   describe 'values' do
     it 'returns the text of the extent element' do
-      expect(subject.first.values).to eq ['Extent Value']
+      expect(subject.first.values).to eq ['Extent Value', 'Extent Value 2']
     end
   end
 end

data/spec/fields/form_spec.rb

@@ -6,6 +6,7 @@ describe ModsDisplay::Form do
       <mods>
         <physicalDescription>
           <form>Form Value</form>
+          <form>Form Value 2</form>
         </physicalDescription>
       </mods>
     XML
@@ -24,7 +25,25 @@ describe ModsDisplay::Form do
 
   describe 'values' do
     it 'returns the text of the form element' do
-      expect(subject.first.values).to eq ['Form Value']
+      expect(subject.first.values).to eq ['Form Value', 'Form Value 2']
+    end
+
+    context 'duplicated data' do
+      let(:mods) do
+        <<-XML
+          <mods>
+            <physicalDescription>
+              <form authority="gmd">electronic resource.</form>
+              <form authority="zxy">electronicresource!</form>
+              <form authority="marccategory">electronic Resource</form>
+            </physicalDescription>
+          </mods>
+        XML
+      end
+
+      it 'uses only unique form values, ignore differences in case, punctuation or whitespace' do
+        expect(subject.first.values).to match_array ['electronic resource.']
+      end
     end
   end
 end

data/spec/integration/html_spec.rb

@@ -5,6 +5,7 @@ def html_from_mods(xml, locale = nil)
   model = TestModel.new
   model.modsxml = xml
   I18n.locale = locale if locale
+  I18n.fallbacks[:fr] = [:fr, :en]
   TestController.new.render_mods_display(model)
 end
 
@@ -53,6 +54,14 @@ describe 'HTML Output' do
       expect(@multiple_titles.body).not_to include('<dd>Main Title</dd>')
       expect(@multiple_titles.body).to include('<dd>Alternate Title</dd>')
     end
+
+    it 'should allow access to the subTitle independently from the title (for use with #body or fields)' do
+      sub_title = @multiple_titles.subTitle
+      expect(sub_title.length).to eq 1
+      expect(sub_title.first).to be_a ModsDisplay::Values
+      expect(sub_title.first.label).to match(/^Alternative title/i)
+      expect(sub_title.first.values).to eq(['Alternate Title'])
+    end
   end
   describe 'individual fields' do
     it 'should return ModsDispaly::Values for the specefied field' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mods_display
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Jessie Keck
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-07 00:00:00.000000000 Z
+date: 2018-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: stanford-mods
@@ -227,7 +227,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: The MODS Display gem allows implementers to configure a customized display