modis 4.2.0 → 4.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f75b1f2591f788a511391d33f34ee1700d4c5aac164d46b7c41c0022afe1c6c8
-  data.tar.gz: 36ae08b35f2cc34166322ff2933d42717fd826779501eb135e815fccfaddecd5
+  metadata.gz: 4490e45322b9ae24bb78a01190616971ff18fd0ee14030493a2cb76f1496d8ac
+  data.tar.gz: 135acda908b954b448aff439a4fd6663f06297da29b7bc8ce936c2f153696e05
 SHA512:
-  metadata.gz: ff27792407942c2b3618ae6751e0397ba7c510d7852a758eb9e21219c8d111ebf3b0f28c2be3db40ec846de20bda4a9dc53d65051e1ad15d5ccfe6b6f3588118
-  data.tar.gz: 9ec6aaf991906929d9101ebf502bfd0f4d669af5c70df4b04b835ea714cc6602497a291aeb03f84ca436785aa0b0601a0404f1c44e79e147fe457f372f8527a7
+  metadata.gz: 656b9746bb1381ae3eee2cec837e3a1adebcd505eea7cb3289f660d8bfa17371e4defabb567898000b4e1a5a49775205deff1081a00299422e125360a3a186b2
+  data.tar.gz: 49c2d453ca3079306ee51fc9d97bda1330d10871a205a57b22ca70260dc746b8d8c589fc66750bb09b8af7aa6421faf8fa1e3fb79ae2035411c32033fd328bb3

data/.github/workflows/test.yml

@@ -26,6 +26,7 @@ jobs:
           - 6379:6379
 
     strategy:
+      fail-fast: false
       matrix:
         gemfile: ['rails_5.2', 'rails_6.0', 'rails_6.1', 'rails_7.0']
 
@@ -55,7 +56,7 @@ jobs:
       BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
 
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1

data/.github_changelog_generator

@@ -1,3 +1,3 @@
 user=rpush
 project=modis
-future-release=v4.1.0
+future-release=v4.3.1

data/CHANGELOG.md

@@ -1,8 +1,29 @@
 # Changelog
 
-## [v4.1.0](https://github.com/rpush/modis/tree/v4.1.0) (2023-08-01)
+## [v4.3.1](https://github.com/rpush/modis/tree/v4.3.1) (2024-08-01)
 
-[Full Changelog](https://github.com/rpush/modis/compare/v4.1.0...v4.1.0)
+[Full Changelog](https://github.com/rpush/modis/compare/v4.3.0...v4.3.1)
+
+**Closed issues:**
+
+- Release 4.3.0 breaks the Rpush initialization [\#50](https://github.com/rpush/modis/issues/50)
+
+**Merged pull requests:**
+
+- Restore backwards compatibility broken in 4.3.0 [\#51](https://github.com/rpush/modis/pull/51) ([benlangfeld](https://github.com/benlangfeld))
+
+## [v4.3.0](https://github.com/rpush/modis/tree/v4.3.0) (2024-07-31)
+
+[Full Changelog](https://github.com/rpush/modis/compare/v4.2.0...v4.3.0)
+
+**Merged pull requests:**
+
+- Add support for multiple redis connections [\#49](https://github.com/rpush/modis/pull/49) ([SxDx](https://github.com/SxDx))
+- Fix deprecation warning [\#48](https://github.com/rpush/modis/pull/48) ([SxDx](https://github.com/SxDx))
+
+## [v4.2.0](https://github.com/rpush/modis/tree/v4.2.0) (2023-08-01)
+
+[Full Changelog](https://github.com/rpush/modis/compare/v4.1.0...v4.2.0)
 
 **Merged pull requests:**
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    modis (4.2.0)
+    modis (4.3.1)
       activemodel (>= 5.2)
       activesupport (>= 5.2)
       connection_pool (>= 2)
@@ -48,8 +48,8 @@ GEM
       parallel
     codeclimate-test-reporter (1.0.7)
       simplecov
-    concurrent-ruby (1.2.0)
-    connection_pool (2.3.0)
+    concurrent-ruby (1.2.2)
+    connection_pool (2.4.1)
     console (1.16.2)
       fiber-local
     diff-lcs (1.4.4)
@@ -71,12 +71,12 @@ GEM
       rainbow (>= 2.2.1)
       rake (>= 10.0)
     hiredis (0.6.3)
-    i18n (1.12.0)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     io-event (1.1.6)
     jaro_winkler (1.5.4)
-    minitest (5.17.0)
-    msgpack (1.6.0)
+    minitest (5.19.0)
+    msgpack (1.7.2)
     multi_json (1.15.0)
     octokit (4.25.1)
       faraday (>= 1, < 3)
@@ -94,9 +94,9 @@ GEM
     public_suffix (5.0.1)
     rainbow (3.0.0)
     rake (13.0.1)
-    redis (5.0.6)
-      redis-client (>= 0.9.0)
-    redis-client (0.12.1)
+    redis (5.2.0)
+      redis-client (>= 0.22.0)
+    redis-client (0.22.2)
       connection_pool
     rexml (3.2.5)
     rspec (3.9.0)

data/lib/modis/configuration.rb

@@ -9,8 +9,8 @@ module Modis
   end
 
   class << self
-    attr_reader :config
+    def config
+      @config ||= Configuration.new
+    end
   end
-
-  @config = Configuration.new
 end

data/lib/modis/deprecator.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Modis
+  def self.deprecator
+    @deprecator ||= ActiveSupport::Deprecation.new('5.0', 'modis')
+  end
+end

data/lib/modis/finder.rb

@@ -18,7 +18,7 @@ module Modis
             "because you disabled all index. See :enable_all_index for more."
         end
 
-        records = Modis.with_connection do |redis|
+        records = Modis.with_connection(modis_connection) do |redis|
           ids = redis.smembers(key_for(:all))
           redis.pipelined do |pipeline|
             ids.map { |id| record_for(pipeline, id) }
@@ -41,7 +41,7 @@ module Modis
       def find_all(ids)
         raise RecordNotFound, "Couldn't find #{name} without an ID" if ids.empty?
 
-        records = Modis.with_connection do |redis|
+        records = Modis.with_connection(modis_connection) do |redis|
           if ids.count == 1
             ids.map { |id| record_for(redis, id) }
           else

data/lib/modis/index.rb

@@ -36,7 +36,7 @@ module Modis
       end
 
       def index_for(attribute, value)
-        Modis.with_connection do |redis|
+        Modis.with_connection(modis_connection) do |redis|
           key = index_key(attribute, value)
           redis.smembers(key).map(&:to_i)
         end

data/lib/modis/model.rb

@@ -21,6 +21,8 @@ module Modis
         include Modis::Index
 
         base.extend(ClassMethods)
+        base.class_attribute :modis_connection
+        base.modis_connection = :default
       end
     end
 

data/lib/modis/persistence.rb

@@ -150,7 +150,7 @@ module Modis
     end
 
     def reload
-      new_attributes = Modis.with_connection { |redis| self.class.attributes_for(redis, id) }
+      new_attributes = Modis.with_connection(modis_connection) { |redis| self.class.attributes_for(redis, id) }
       initialize(new_attributes)
       self
     end
@@ -166,7 +166,7 @@ module Modis
     end
 
     alias update_attributes update
-    deprecate update_attributes: 'please, use update instead'
+    deprecate update_attributes: 'please, use update instead', deprecator: Modis.deprecator
 
     def update!(attrs)
       assign_attributes(attrs)
@@ -174,7 +174,7 @@ module Modis
     end
 
     alias update_attributes! update!
-    deprecate update_attributes!: 'please, use update! instead'
+    deprecate update_attributes!: 'please, use update! instead', deprecator: Modis.deprecator
 
     private
 
@@ -253,7 +253,7 @@ module Modis
 
     def set_id
       namespace = self.class.sti_child? ? self.class.sti_base_absolute_namespace : self.class.absolute_namespace
-      Modis.with_connection do |redis|
+      Modis.with_connection(modis_connection) do |redis|
         self.id = redis.incr("#{namespace}_id_seq")
       end
     end

data/lib/modis/transaction.rb

@@ -8,7 +8,7 @@ module Modis
 
     module ClassMethods
       def transaction
-        Modis.with_connection { |redis| redis.multi { |transaction| yield(transaction) } }
+        Modis.with_connection(modis_connection) { |redis| redis.multi { |transaction| yield(transaction) } }
       end
     end
   end

data/lib/modis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Modis
-  VERSION = '4.2.0'
+  VERSION = '4.3.1'
 end

data/lib/modis.rb

@@ -7,6 +7,7 @@ require 'active_support/all'
 require 'msgpack'
 
 require 'modis/version'
+require 'modis/deprecator'
 require 'modis/configuration'
 require 'modis/attribute'
 require 'modis/errors'
@@ -17,14 +18,37 @@ require 'modis/index'
 require 'modis/model'
 
 module Modis
-  @mutex = Mutex.new
-
   class << self
-    attr_writer :redis_options, :connection_pool_size, :connection_pool_timeout,
-                :connection_pool
+    attr_writer :connection_pool_size, :connection_pool_timeout,
+                :connection_pools
+
+    def mutex
+      @mutex ||= Mutex.new
+    end
 
     def redis_options
-      @redis_options ||= {}
+      @redis_options ||= { default: {} }
+    end
+
+    def redis_options=(options)
+      if options.is_a?(Hash) && options.values.first.is_a?(Hash)
+        @redis_options = options.transform_values(&:dup)
+      else
+        redis_options[:default] = options
+      end
+    end
+
+    def reset!
+      connection_pools.each do |key, _|
+        with_connection(key) do |connection|
+          keys = connection.keys "#{config.namespace}:*"
+          connection.del(*keys) unless keys.empty?
+        end
+      end
+      instance_variables.each do |var|
+        instance_variable_set(var, nil)
+        remove_instance_variable(var)
+      end
     end
 
     def connection_pool_size
@@ -35,17 +59,25 @@ module Modis
       @connection_pool_timeout ||= 5
     end
 
-    def connection_pool
-      return @connection_pool if @connection_pool
+    def connection_pools
+      @connection_pools ||= {}
+    end
 
-      @mutex.synchronize do
-        options = { size: connection_pool_size, timeout: connection_pool_timeout }
-        @connection_pool = ConnectionPool.new(options) { Redis.new(redis_options) }
+    def connection_pool(pool_name = :default)
+      connection_pools[pool_name] ||= begin
+        mutex.synchronize do
+          ConnectionPool.new(
+            size: connection_pool_size,
+            timeout: connection_pool_timeout
+          ) do
+            Redis.new(redis_options[pool_name])
+          end
+        end
       end
     end
 
-    def with_connection
-      connection_pool.with { |connection| yield(connection) }
+    def with_connection(pool_name = :default)
+      connection_pool(pool_name).with { |connection| yield(connection) }
     end
   end
 end

data/spec/multi_redis_spec.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+module MultiRedisSpec
+  class DefaultUserModel
+    include Modis::Model
+
+    attribute :name, :string
+  end
+
+  class CustomUserModel
+    include Modis::Model
+    self.modis_connection = :custom
+
+    attribute :name, :string
+  end
+end
+
+describe 'Multiple redis support' do
+  before do
+    Modis.redis_options = {
+      default: { url: 'redis://localhost:6379/0' },
+      custom: { url: 'redis://localhost:6379/1' }
+    }
+  end
+
+  it 'uses the default redis connection' do
+    expect(Modis).to receive(:with_connection).with(:default).at_least(3).times.and_call_original
+    user = MultiRedisSpec::DefaultUserModel.create!(name: 'Ian')
+
+    expect(Modis).to receive(:with_connection).with(:default).at_least(3).times.and_call_original
+    MultiRedisSpec::DefaultUserModel.find(user.id)
+  end
+
+  it 'uses the specified redis connection when set up' do
+    expect(Modis).to receive(:with_connection).with(:custom).at_least(3).times.and_call_original
+    user = MultiRedisSpec::CustomUserModel.create!(name: 'Tanya')
+
+    expect(Modis).to receive(:with_connection).with(:custom).at_least(3).times.and_call_original
+    MultiRedisSpec::CustomUserModel.find(user.id)
+  end
+end
+
+describe 'backwards compatibility' do
+  before do
+    Modis.redis_options = {
+      url: 'redis://localhost:6379/0'
+    }
+  end
+
+  it 'uses the default redis connection' do
+    expect(Modis).to receive(:with_connection).with(:default).at_least(3).times.and_call_original
+    MultiRedisSpec::DefaultUserModel.create!(name: 'Ian')
+  end
+end

data/spec/spec_helper.rb

@@ -14,15 +14,12 @@ require 'modis'
 
 Redis.raise_deprecations = true if Gem.loaded_specs['redis'].version >= Gem::Version.new('4.6.0')
 
-Modis.configure do |config|
-  config.namespace = 'modis'
-end
-
 RSpec.configure do |config|
   config.after :each do
-    Modis.with_connection do |connection|
-      keys = connection.keys "#{Modis.config.namespace}:*"
-      connection.del(*keys) unless keys.empty?
+    RSpec::Mocks.space.proxy_for(Modis).reset
+    Modis.reset!
+    Modis.configure do |modis_config|
+      modis_config.namespace = 'modis'
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: modis
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.3.1
 platform: ruby
 authors:
 - Ian Leitch
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-01 00:00:00.000000000 Z
+date: 2024-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -236,6 +236,7 @@ files:
 - lib/modis.rb
 - lib/modis/attribute.rb
 - lib/modis/configuration.rb
+- lib/modis/deprecator.rb
 - lib/modis/errors.rb
 - lib/modis/finder.rb
 - lib/modis/index.rb
@@ -249,6 +250,7 @@ files:
 - spec/errors_spec.rb
 - spec/finder_spec.rb
 - spec/index_spec.rb
+- spec/multi_redis_spec.rb
 - spec/persistence_spec.rb
 - spec/spec_helper.rb
 - spec/support/simplecov_helper.rb
@@ -283,6 +285,7 @@ test_files:
 - spec/errors_spec.rb
 - spec/finder_spec.rb
 - spec/index_spec.rb
+- spec/multi_redis_spec.rb
 - spec/persistence_spec.rb
 - spec/spec_helper.rb
 - spec/support/simplecov_helper.rb