modis 2.1.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bb24ac739595677e1200448641dc4e7c35a26f1d
-  data.tar.gz: 428715902d2b7e335e16d7ee2b65aa58c3864b52
+SHA256:
+  metadata.gz: 62a6abe9671e399409e452a290c360fcd0aadfbdceccca9aa364d6f232b2df49
+  data.tar.gz: d8468a3f54bf0587f8d89ff2b353a5c48ea0798a4c067bd291ef5ed471448a01
 SHA512:
-  metadata.gz: 7f34d83dd16b16bd113a116d060523c8f832593f604e318077be24d279d8a9f06ce269f86a3935f5fbe8e1a70d815075a54f69c9ee3f4d45eaa0fafc211a461e
-  data.tar.gz: a3451db68ba6943d667fb11470c9635dfb0c74ac9449b330125ffe7be4d9b0c3e94df459d8a2acb8ab0069a6fa80fadf4c83a8630898ef26c023857f34cfa473
+  metadata.gz: a382d676431ed8bd7fd79dde5dbff275c19687b42ce9de52980ce35898ea91eb447a1a7349b8f09bc56606841e7f6cada8f882bc23f5eb8d9f5483b109805d61
+  data.tar.gz: 499687970a4a33a573e16ea8f1b70749e85d2650b2092a37ce26cdd9452cc6c3a3c539e9e59dcfa9d5db0ed2d9ccf19c961122e22d0e8dfd3e41afda080c925d

data/.gitignore

@@ -14,4 +14,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
-Gemfile.lock
+*.gemfile.lock

data/.rubocop.yml

@@ -2,6 +2,7 @@ AllCops:
   Exclude:
     - modis.gemspec
     - vendor/**/*
+    - gemfiles/**/*
 
 LineLength:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.4.1
+2.6.5

data/.travis.yml

@@ -1,12 +1,42 @@
-sudo: false
-services:
-- redis-server
 language: ruby
+
+dist: bionic
+
+cache: bundler
+
+services:
+  - redis-server
+
 rvm:
-- 2.2.4
-- 2.3.0
-- 2.4.0
-- jruby-9.1.9.0
+  - 2.3
+  - 2.4
+  - 2.5
+  - 2.6
+  - 2.7
+  - 3.0
+  - jruby-9.2.17.0
+
+gemfile:
+  - gemfiles/rails_5.2.gemfile
+  - gemfiles/rails_6.0.gemfile
+  - gemfiles/rails_6.1.gemfile
+
+matrix:
+  fast_finish: true
+  exclude:
+    # Rails 6 requires Ruby 2.5 or higher
+    - gemfile: gemfiles/rails_6.0.gemfile
+      rvm: 2.3
+    - gemfile: gemfiles/rails_6.1.gemfile
+      rvm: 2.3
+    - gemfile: gemfiles/rails_6.0.gemfile
+      rvm: 2.4
+    - gemfile: gemfiles/rails_6.1.gemfile
+      rvm: 2.4
+    # Rails 5.2 isn't compatible with Ruby 3.0 or higher
+    - gemfile: gemfiles/rails_5.2.gemfile
+      rvm: 3.0
+
 env:
   global:
     secure: LrTz0Pq2ibNZuKDhdzcrvEUSNxUpPopEq9aJeCxy3UpV0v4vpHBtWV0S6zofvf98g/RkZ6cGI1u+0H578dHgE6pWTo+iR8LAwqPKofrFIWRkeo+M77Vs5swahb3mQyPOcig1hfVWDm25MsojePYm70eBIcBU55NWImtdePXfiU0=

data/Appraisals

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+appraise 'rails-4.2' do
+  gem 'activemodel', '~> 4.2.0'
+  gem 'activesupport', '~> 4.2.0'
+end
+
+appraise 'rails-5.0' do
+  gem 'activemodel', '~> 5.0.0'
+  gem 'activesupport', '~> 5.0.0'
+end
+
+appraise 'rails-5.1' do
+  gem 'activemodel', '~> 5.1.0'
+  gem 'activesupport', '~> 5.1.0'
+end
+
+appraise 'rails-5.2' do
+  gem 'activemodel', '~> 5.2.0'
+  gem 'activesupport', '~> 5.2.0'
+end
+
+appraise 'rails-6.0' do
+  gem 'activemodel', '~> 6.0.0'
+  gem 'activesupport', '~> 6.0.0'
+end

data/CHANGELOG.md

@@ -0,0 +1,38 @@
+## Unreleased
+
+## v4.0.0 - 2021-04-28
+
+**Breaking:**
+
+- Drop support for Rails 4.2, 5.0, 5.1.
+- Removed `hiredis` as a dependency and made it a development dependency.
+  For details, see [#31](https://github.com/rpush/modis/pull/31) by [@fdoxyz](https://github.com/fdoxyz).
+
+## v3.3.0 - 2020-07-07
+
+- Fix deprecation warnings when using Ruby >= 2.7, `activemodel` >= 6.0.3, or `redis` >= 4.2.0. [#30](https://github.com/rpush/modis/pull/30) by [@rofreg](https://github.com/rofreg).
+
+## v3.2.0 - 2019-12-12
+
+- Add missing `#update` and `#update!`. [#27](https://github.com/rpush/modis/pull/27) by [@dsantosmerino](https://github.com/dsantosmerino).
+
+## v3.1.0 - 2019-10-18
+
+- Test with Rails 6
+- Drop i18n dependency (credit goes to [@jas14](https://github.com/jas14) in [#23](https://github.com/rpush/modis/pull/23))
+
+## v3.0.0 - 2018-12-20
+
+- Drop support for any Ruby < 2.3 and Rails < 4.2.
+- Add support for Rails 5.2
+- Resolve Rubocop lint violations
+- Test combinations of Ruby and Rails versions in CI
+
+## v2.1.0
+
+- Add `enable_all_index` option to allow disabling the `all` keys. [#7](https://github.com/rpush/modis/pull/7)
+
+## v2.0.0
+
+- Support MRI 2.2.2+ and JRuby 9k+ [#5](https://github.com/rpush/modis/pull/5)
+- Remove YAML (de)serialization support [#5](https://github.com/rpush/modis/pull/5)

data/Gemfile

@@ -2,18 +2,4 @@
 
 source 'https://rubygems.org'
 
-gem 'rake'
-gem 'rspec'
-
-platform :mri do
-  gem 'cane'
-  gem 'codeclimate-test-reporter', require: nil
-  gem 'rubocop', require: false
-  gem 'simplecov', require: false
-end
-
-platform :mri_21 do
-  gem 'stackprof'
-end
-
 gemspec

data/Gemfile.lock

@@ -0,0 +1,96 @@
+PATH
+  remote: .
+  specs:
+    modis (4.0.0)
+      activemodel (>= 5.2)
+      activesupport (>= 5.2)
+      connection_pool (>= 2)
+      msgpack (>= 0.5)
+      redis (>= 3.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (6.0.3.4)
+      activesupport (= 6.0.3.4)
+    activesupport (6.0.3.4)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    appraisal (2.3.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    ast (2.4.1)
+    cane (3.0.0)
+      parallel
+    codeclimate-test-reporter (1.0.7)
+      simplecov
+    concurrent-ruby (1.1.7)
+    connection_pool (2.2.3)
+    diff-lcs (1.4.4)
+    docile (1.3.2)
+    hiredis (0.6.3)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
+    jaro_winkler (1.5.4)
+    minitest (5.14.2)
+    msgpack (1.3.3)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
+    powerpack (0.1.2)
+    rainbow (3.0.0)
+    rake (13.0.1)
+    redis (4.2.1)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
+    rubocop (0.61.1)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.5, != 2.5.1.1)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.4.0)
+    ruby-progressbar (1.10.1)
+    simplecov (0.18.5)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+    simplecov-html (0.12.2)
+    thor (1.0.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.4.1)
+    zeitwerk (2.4.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  cane
+  codeclimate-test-reporter
+  hiredis (>= 0.5)
+  modis!
+  rake
+  rspec
+  rubocop (= 0.61.1)
+  simplecov
+
+BUNDLED WITH
+   2.1.4

data/README.md

@@ -1,4 +1,4 @@
-[![Build Status](https://secure.travis-ci.org/ileitch/modis.png?branch=master)](http://travis-ci.org/ileitch/modis)
+[![Build Status](https://travis-ci.org/rpush/modis.svg?branch=master)](https://travis-ci.org/rpush/modis)
 [![Code Climate](https://codeclimate.com/github/ileitch/modis/badges/gpa.svg)](https://codeclimate.com/github/ileitch/modis)
 [![Test Coverage](https://codeclimate.com/github/ileitch/modis/badges/coverage.svg)](https://codeclimate.com/github/ileitch/modis)
 
@@ -8,32 +8,40 @@ ActiveModel + Redis with the aim to mimic ActiveRecord where possible.
 
 ## Requirements
 
-Modis supports CRuby 2.2.2+ and jRuby 9k+
+Modis 4.0+ supports Rails 5.2 and higher, including Rails 6.1, as well as Ruby 2.3 and above, including Ruby 3.0. Tests are also being run with JRuby. For details please check the current CI setup.
+
+For releases supporting older Rails versions such as 4.2-5.1 please check out the 3.x releases.
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'modis'
+```ruby
+gem 'modis'
+```
 
 And then execute:
 
-    $ bundle
+```console
+$ bundle
+```
 
 Or install it yourself as:
 
-    $ gem install modis
+```console
+$ gem install modis
+```
 
 ## Usage
 
 ```ruby
 class MyModel
-  include Modis::Models
-  attribute :name, String
-  attribute :age, Integer
+  include Modis::Model
+  attribute :name, :string
+  attribute :age, :integer
 end
 
-MyModel.create!(:name => 'Ian', :age => 28)
+MyModel.create!(name: 'Ian', age: 28)
 ```
 
 ### all index
@@ -41,13 +49,13 @@ MyModel.create!(:name => 'Ian', :age => 28)
 Modis, by default, creates an `all` index in redis in which it stores all the IDs for records created. As a result, a large amount of memory will be consumed if many ids are stored. The `all` index functionality can be turned off by using `enable_all_index`
 
 ```ruby
-  class MyModel
-    include Modis::Model
-    enable_all_index false
-  end
+class MyModel
+  include Modis::Model
+  enable_all_index false
+end
 ```
 
-By disabling the `all` index functionality, the IDs of each record created won't be saved. As a side effect, using `all` finder method will raise a `IndexError` exception as we would not have enough information to fetch all records. See https://github.com/ileitch/modis/pull/7 for more context.
+By disabling the `all` index functionality, the IDs of each record created won't be saved. As a side effect, using `all` finder method will raise a `IndexError` exception as we would not have enough information to fetch all records. See https://github.com/rpush/modis/pull/7 for more context.
 
 ## Supported Features
 

data/benchmark/persistence.rb

@@ -62,7 +62,7 @@ Bench.run do |b|
   b.report(:update_without_changes) do
     user = create_user
     n.times do
-      user.update_attributes!(name: user.name, age: user.age)
+      user.update!(name: user.name, age: user.age)
     end
   end
 

data/gemfiles/rails_5.2.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activemodel", "~> 5.2.0"
+gem "activesupport", "~> 5.2.0"
+
+gemspec path: "../"

data/gemfiles/rails_6.0.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activemodel", "~> 6.0.0"
+gem "activesupport", "~> 6.0.0"
+
+gemspec path: "../"

data/gemfiles/rails_6.1.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activemodel", "~> 6.1.0"
+gem "activesupport", "~> 6.1.0"
+
+gemspec path: "../"

data/lib/modis.rb

@@ -20,23 +20,32 @@ module Modis
   @mutex = Mutex.new
 
   class << self
-    attr_accessor :connection_pool, :redis_options, :connection_pool_size,
-                  :connection_pool_timeout
-  end
+    attr_writer :redis_options, :connection_pool_size, :connection_pool_timeout,
+                :connection_pool
 
-  self.redis_options = { driver: :hiredis }
-  self.connection_pool_size = 5
-  self.connection_pool_timeout = 5
+    def redis_options
+      @redis_options ||= {}
+    end
 
-  def self.connection_pool
-    return @connection_pool if @connection_pool
-    @mutex.synchronize do
-      options = { size: connection_pool_size, timeout: connection_pool_timeout }
-      @connection_pool = ConnectionPool.new(options) { Redis.new(redis_options) }
+    def connection_pool_size
+      @connection_pool_size ||= 5
+    end
+
+    def connection_pool_timeout
+      @connection_pool_timeout ||= 5
     end
-  end
 
-  def self.with_connection
-    connection_pool.with { |connection| yield(connection) }
+    def connection_pool
+      return @connection_pool if @connection_pool
+
+      @mutex.synchronize do
+        options = { size: connection_pool_size, timeout: connection_pool_timeout }
+        @connection_pool = ConnectionPool.new(options) { Redis.new(redis_options) }
+      end
+    end
+
+    def with_connection
+      connection_pool.with { |connection| yield(connection) }
+    end
   end
 end

data/lib/modis/attribute.rb

@@ -19,8 +19,6 @@ module Modis
 
     module ClassMethods
       def bootstrap_attributes(parent = nil)
-        attr_reader :attributes
-
         class << self
           attr_accessor :attributes, :attributes_with_defaults
         end
@@ -37,6 +35,7 @@ module Modis
 
         type_classes = Array(type).map do |t|
           raise UnsupportedAttributeType, t unless TYPES.key?(t)
+
           TYPES[t]
         end.flatten
 
@@ -53,7 +52,7 @@ module Modis
         end
         RUBY
 
-        class_eval <<-RUBY, __FILE__, __LINE__
+        class_eval <<-RUBY, __FILE__, __LINE__ + 1
           def #{name}
             attributes['#{name}']
           end
@@ -72,6 +71,10 @@ module Modis
       end
     end
 
+    def attributes
+      @modis_attributes
+    end
+
     def assign_attributes(hash)
       hash.each do |k, v|
         setter = "#{k}="
@@ -91,15 +94,12 @@ module Modis
 
     def set_sti_type
       return unless self.class.sti_child?
-      write_attribute(:type, self.class.name)
-    end
 
-    def reset_changes
-      @changed_attributes = nil
+      write_attribute(:type, self.class.name)
     end
 
     def apply_defaults
-      @attributes = Hash[self.class.attributes_with_defaults]
+      @modis_attributes = Hash[self.class.attributes_with_defaults]
     end
   end
 end

data/lib/modis/finder.rb

@@ -33,9 +33,7 @@ module Modis
 
         attributes = deserialize(record_for(redis, id))
 
-        unless attributes['id'].present?
-          raise RecordNotFound, "Couldn't find #{name} with id=#{id}"
-        end
+        raise RecordNotFound, "Couldn't find #{name} with id=#{id}" unless attributes['id'].present?
 
         attributes
       end
@@ -69,6 +67,7 @@ module Modis
       def model_for(attributes)
         cls = model_class(attributes)
         return unless cls == self || cls < self
+
         cls.new(attributes, new_record: false)
       end
 
@@ -79,6 +78,7 @@ module Modis
 
       def model_class(record)
         return self if record["type"].blank?
+
         record["type"].constantize
       end
     end

data/lib/modis/index.rb

@@ -21,14 +21,17 @@ module Modis
       def index(attribute)
         attribute = attribute.to_s
         raise IndexError, "No such attribute '#{attribute}'" unless attributes.key?(attribute)
+
         indexed_attributes << attribute
       end
 
       def where(query)
         raise IndexError, 'Queries using multiple indexes is not currently supported.' if query.keys.size > 1
+
         attribute, value = query.first
         ids = index_for(attribute, value)
         return [] if ids.empty?
+
         find_all(ids)
       end
 

data/lib/modis/model.rb

@@ -35,9 +35,10 @@ module Modis
       apply_defaults
       set_sti_type
       assign_attributes(record) if record
-      reset_changes
+      changes_applied
 
       return unless options.key?(:new_record)
+
       instance_variable_set('@new_record', options[:new_record])
     end
 

data/lib/modis/persistence.rb

@@ -97,13 +97,13 @@ module Modis
 
       private
 
-      def msgpack_array_header(n)
-        if n < 16
-          [0x90 | n].pack("C")
-        elsif n < 65536
-          [0xDC, n].pack("Cn")
+      def msgpack_array_header(values_size)
+        if values_size < 16
+          [0x90 | values_size].pack("C")
+        elsif values_size < 65536
+          [0xDC, values_size].pack("Cn")
         else
-          [0xDD, n].pack("CN")
+          [0xDD, values_size].pack("CN")
         end.force_encoding(Encoding::UTF_8)
       end
     end
@@ -114,6 +114,7 @@ module Modis
 
     def key
       return nil if new_record?
+
       self.class.sti_child? ? self.class.sti_base_key_for(id) : self.class.key_for(id)
     end
 
@@ -157,16 +158,22 @@ module Modis
       save(validate: false)
     end
 
-    def update_attributes(attrs)
+    def update(attrs)
       assign_attributes(attrs)
       save
     end
 
-    def update_attributes!(attrs)
+    alias update_attributes update
+    deprecate update_attributes: 'please, use update instead'
+
+    def update!(attrs)
       assign_attributes(attrs)
       save!
     end
 
+    alias update_attributes! update!
+    deprecate update_attributes!: 'please, use update! instead'
+
     private
 
     def coerce_for_persistence(value)
@@ -178,8 +185,8 @@ module Modis
       validate(args)
       future = persist
 
-      if future && (future == :unchanged || future.value == 'OK')
-        reset_changes
+      if future && ((future.is_a?(Symbol) && future == :unchanged) || future.value == 'OK')
+        changes_applied
         @new_record = false
         true
       else
@@ -190,6 +197,7 @@ module Modis
     def validate(args)
       skip_validate = args.key?(:validate) && args[:validate] == false
       return if skip_validate || valid?
+
       raise Modis::RecordInvalid, errors.full_messages.join(', ')
     end
 
@@ -223,19 +231,18 @@ module Modis
 
       future
     end
+    # rubocop:enable Metrics/AbcSize, Metrics/PerceivedComplexity
 
     def coerced_attributes
       attrs = []
 
       if new_record?
         attributes.each do |k, v|
-          if (self.class.attributes[k][:default] || nil) != v
-            attrs << k << coerce_for_persistence(v)
-          end
+          attrs << k << coerce_for_persistence(v) if (self.class.attributes[k][:default] || nil) != v
         end
       else
-        changed_attributes.each do |k, _|
-          attrs << k << coerce_for_persistence(attributes[k])
+        changed_attributes.each_key do |key|
+          attrs << key << coerce_for_persistence(attributes[key])
         end
       end
 

data/lib/modis/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Modis
-  VERSION = '2.1.0'
+  VERSION = '4.0.0'
 end

data/modis.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |gem|
   gem.email         = ["port001@gmail.com"]
   gem.description   = "ActiveModel + Redis"
   gem.summary       = "ActiveModel + Redis"
-  gem.homepage      = "https://github.com/ileitch/modis"
+  gem.homepage      = "https://github.com/rpush/modis"
   gem.license       = "MIT"
 
   gem.files         = `git ls-files`.split($/)
@@ -18,10 +18,11 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_runtime_dependency 'activemodel', '>= 3.0'
-  gem.add_runtime_dependency 'activesupport', '>= 3.0'
+  gem.required_ruby_version = ">= 2.3.0"
+
+  gem.add_runtime_dependency 'activemodel', '>= 5.2'
+  gem.add_runtime_dependency 'activesupport', '>= 5.2'
   gem.add_runtime_dependency 'redis', '>= 3.0'
-  gem.add_runtime_dependency 'hiredis', '>= 0.5'
   gem.add_runtime_dependency 'connection_pool', '>= 2'
 
   if defined? JRUBY_VERSION
@@ -30,4 +31,13 @@ Gem::Specification.new do |gem|
   else
     gem.add_runtime_dependency 'msgpack', '>= 0.5'
   end
+
+  gem.add_development_dependency "appraisal"
+  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'codeclimate-test-reporter'
+  gem.add_development_dependency 'cane'
+  gem.add_development_dependency 'rubocop', '0.61.1'
+  gem.add_development_dependency 'simplecov'
+  gem.add_development_dependency 'hiredis', '>= 0.5'
 end

data/spec/persistence_spec.rb

@@ -249,7 +249,36 @@ describe Modis::Persistence do
     end
   end
 
+  describe 'update!' do
+    it 'updates the given attributes' do
+      model.update!(name: 'Derp', age: 29)
+      model.reload
+      expect(model.name).to eq 'Derp'
+      expect(model.age).to eq 29
+    end
+
+    it 'invokes callbacks' do
+      model.update!(name: 'Derp')
+      expect(model.called_callbacks).to_not be_empty
+    end
+
+    it 'updates all dirty attributes' do
+      model.age = 29
+      model.update!(name: 'Derp')
+      model.reload
+      expect(model.age).to eq 29
+    end
+
+    it 'raises an error if the model is invalid' do
+      expect do
+        model.update!(name: nil).to be false
+      end.to raise_error(Modis::RecordInvalid)
+    end
+  end
+
   describe 'update_attributes!' do
+    around(:each) { |example| ActiveSupport::Deprecation.silence { example.run } }
+
     it 'updates the given attributes' do
       model.update_attributes!(name: 'Derp', age: 29)
       model.reload
@@ -276,7 +305,34 @@ describe Modis::Persistence do
     end
   end
 
+  describe 'update' do
+    it 'updates the given attributes' do
+      model.update(name: 'Derp', age: 29)
+      model.reload
+      expect(model.name).to eq('Derp')
+      expect(model.age).to eq(29)
+    end
+
+    it 'invokes callbacks' do
+      model.update(name: 'Derp')
+      expect(model.called_callbacks).to_not be_empty
+    end
+
+    it 'updates all dirty attributes' do
+      model.age = 29
+      model.update(name: 'Derp')
+      model.reload
+      expect(model.age).to eq(29)
+    end
+
+    it 'returns false if the model is invalid' do
+      expect(model.update(name: nil)).to be false
+    end
+  end
+
   describe 'update_attributes' do
+    around(:each) { |example| ActiveSupport::Deprecation.silence { example.run } }
+
     it 'updates the given attributes' do
       model.update_attributes(name: 'Derp', age: 29)
       model.reload

data/spec/spec_helper.rb

@@ -3,7 +3,7 @@
 unless ENV['TRAVIS']
   begin
     require './spec/support/simplecov_helper'
-    include SimpleCovHelper
+    include SimpleCovHelper # rubocop:disable Style/MixinUsage
     start_simple_cov('unit')
   rescue LoadError
     puts "Coverage disabled."

data/spec/support/simplecov_helper.rb

@@ -14,9 +14,7 @@ module SimpleCovHelper
       if ENV['TRAVIS']
         require 'codeclimate-test-reporter'
 
-        if CodeClimate::TestReporter.run?
-          formatters << CodeClimate::TestReporter::Formatter
-        end
+        formatters << CodeClimate::TestReporter::Formatter if CodeClimate::TestReporter.run?
       end
 
       formatter SimpleCov::Formatter::MultiFormatter.new(*formatters)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: modis
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 4.0.0
 platform: ruby
 authors:
 - Ian Leitch
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-06-24 00:00:00.000000000 Z
+date: 2021-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
@@ -53,7 +53,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: hiredis
+  name: connection_pool
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2'
+- !ruby/object:Gem::Dependency
+  name: msgpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,27 +81,111 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.5'
 - !ruby/object:Gem::Dependency
-  name: connection_pool
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2'
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: msgpack
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cane
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.61.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.61.1
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: hiredis
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0.5'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -103,10 +201,12 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rubocop.yml"
-- ".ruby-gemset"
 - ".ruby-version"
 - ".travis.yml"
+- Appraisals
+- CHANGELOG.md
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -114,6 +214,9 @@ files:
 - benchmark/find.rb
 - benchmark/persistence.rb
 - benchmark/redis/connection/fakedis.rb
+- gemfiles/rails_5.2.gemfile
+- gemfiles/rails_6.0.gemfile
+- gemfiles/rails_6.1.gemfile
 - lib/modis.rb
 - lib/modis/attribute.rb
 - lib/modis/configuration.rb
@@ -136,11 +239,11 @@ files:
 - spec/support/simplecov_quality_formatter.rb
 - spec/transaction_spec.rb
 - spec/validations_spec.rb
-homepage: https://github.com/ileitch/modis
+homepage: https://github.com/rpush/modis
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -148,16 +251,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: ActiveModel + Redis
 test_files:

data/.ruby-gemset

@@ -1 +0,0 @@
-modis