modern_treasury 0.1.0.pre.alpha.18 → 0.1.0.pre.alpha.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b3943d01cdc8c201df2448d6a46bf5620e94cffd46801ff2b737d9e4b7c50f4
-  data.tar.gz: 65030953f4f68d7adc5c494c36392e9f16d01f7968e40bf8bb916cfd5c607894
+  metadata.gz: 6adbdcc70b1ca7abcb20e29b504195c29d0367e3cc1f06b45a92078d8ee0d2df
+  data.tar.gz: 56381f0bd27eeac0802ea845012bb837b243a33105e8f38e82c91f5ef24c1308
 SHA512:
-  metadata.gz: 14b1fb7cbb760e00acabbd7cd48e479865ab3e698802bb6e96fb1e3c2cb9c17fd2354249de8cf3f5f14bd4c0e59d51bb6b28ef9bd265db3a32fc7491c74111c5
-  data.tar.gz: a6fb54d21ceac08ecda9cb74e1478ed0fd5993145a34af929d9952d100cd58434513eb6daf004ba7b224c73de03cbd5152f89e7f6ff430fe458849a4530e5148
+  metadata.gz: 4ceeabfe3d023fc8d86b90a64fc101007e8be2446455cc14c248a482ddfe8cbb7b3908896b6eb18fea08c48745fca6fa321425ff7286dc44c8213412da7588ff
+  data.tar.gz: 21958f8b0ff40115fe0df67c6e2d5524c76cb9c891194f07a347b3b25f17983e7c22aadcd2178fb4ca411cdafd1baa909d347c46d644b4664274e4b710b464f9

data/CHANGELOG.md

@@ -1,5 +1,70 @@
 # Changelog
 
+## 0.1.0-alpha.19 (2025-05-13)
+
+Full Changelog: [v0.1.0-alpha.18...v0.1.0-alpha.19](https://github.com/Modern-Treasury/modern-treasury-ruby/compare/v0.1.0-alpha.18...v0.1.0-alpha.19)
+
+### Features
+
+* **api:** only send idempotency headers on PUT / POST requests ([83fd4af](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/83fd4af298abec1b714675e7acc40a276f1283f2))
+* expose base client options as read only attributes ([60a211d](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/60a211d7ae5e60e4a53e90fe22d543b130744de4))
+* expose recursive `#to_h` conversion ([06efb53](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/06efb534c53987cb36ca7ccee45bf50d426ed36b))
+* implement `#hash` for data containers ([d96aea7](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/d96aea756785f1cc2cd327d201424786fd20d5b0))
+* support sorbet aliases at the runtime ([c606bc7](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/c606bc705110611d96dffbe82f4dd53f5bca2679))
+* support specifying content-type with FilePart class ([db20b0a](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/db20b0afeeb1b6db89f454045f55acb39b6f9fa4))
+* support webmock for testing ([4644eaa](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/4644eaa0de6336e235c200158efc2927613f27e2))
+
+
+### Bug Fixes
+
+* always check if current page is empty in `next_page?` ([6efc146](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/6efc146540017fdc0cc7fb0475e1afc4a6d7ecfc))
+* ensure gem release is unaffected by renaming ([606ca8c](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/606ca8cc2e6c40c0abb89bd22ebe99a11c2de4d5))
+* **internal:** ensure formatting always uses c.utf-8 locale ([4303382](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/43033823e1670e0e66970524ad253d56b4e4ceb9))
+* **internal:** fix formatting script for macos ([850b98b](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/850b98b36836357549b7c056fd382027dea014f4))
+* **internal:** update gemspec name ([db69e0e](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/db69e0efc6b4fed197f481336fdb29a4025ae13a))
+* make a typo for `FilePart.content` ([442af9e](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/442af9e1e043f36ceaa0a2dc863ab93dc3fa7c66))
+
+
+### Chores
+
+* accept all nd-json mimetype variants ([d009d1a](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/d009d1a3e63bb3cffe1d77ec6708d4df2e804178))
+* add generator safe directory ([c7c4009](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/c7c4009c059fc4af63c464b5b368d13b821695b5))
+* broadly detect json family of content-type headers ([4e9190f](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/4e9190f728bf54a3d05bd21bc34cb4379d35d683))
+* **ci:** add timeout thresholds for CI jobs ([51098dd](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/51098dde2b1e6a0d5da51579efa6d3222ae0b6e7))
+* **ci:** only use depot for staging repos ([163402a](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/163402af8b04a17a425a72d958d7d9017030d84b))
+* **ci:** run on more branches and use depot runners ([1aaaa6f](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/1aaaa6f569a67f3e33d5d2529d38494f49e4808a))
+* consistently use string in examples, even for enums ([3766f9f](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/3766f9fd246d700b7c1fd936d16a5988267b3030))
+* documentation improvements ([ae02ed8](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/ae02ed86227ef8a2aba567eb8b82400b3a16c16d))
+* explicitly mark apis public under `Internal` module ([6358f72](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/6358f727a0bf1a4841d297a94a535335ee62b57e))
+* fix misc linting / minor issues ([de1286e](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/de1286ec80d18859be5bc2d402d1cef3aa3bd158))
+* **internal:** annotate request options with type aliases in sorbet ([a6d3efa](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/a6d3efa58e61ef821a4b77fde957a086b5ca430a))
+* **internal:** codegen related update ([13f2ea4](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/13f2ea46f28401e2265af8ffc60ebd9b16277bea))
+* **internal:** codegen related update ([a70306b](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/a70306bf04b718b8386bbb5498e5f1a2e103d4bf))
+* **internal:** codegen related update ([320f66e](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/320f66efad24e22c522025127a9ac4f06daf2a99))
+* **internal:** improve response envelope unwrap functionality ([91c54a5](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/91c54a535ab97caa3f0f10f5909803f8fd484a49))
+* **internal:** minor type annotation improvements ([80c7729](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/80c7729b33c9c8ae9f14b5ab2792ad37a7299379))
+* **internal:** remove unnecessary `rbi/lib` folder ([6d6e5ed](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/6d6e5ed2c64f7afd36b0304ce363efb64c13bc5f))
+* loosen rubocop rules that don't always make sense ([a7ecdad](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/a7ecdad7899b6b85ad59c08617740a27544db180))
+* make sorbet enums easier to read ([3dc3765](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/3dc37654a43d57db2c759714933d73efa31837f7))
+* migrate away from deprecated `JSON#fast_generate` ([9cf605d](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/9cf605dd27df53480a369f01677f886809afa69e))
+* more accurate type annotations and aliases ([dd1f15d](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/dd1f15dbf267e6d437b7ed83d1377f8aca17350e))
+* re-export top level models under library namespace ([ac629fe](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/ac629fecccb2b54de95280c575178c48be04416f))
+* refine `#inspect` and `#to_s` for model classes ([786b22a](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/786b22a499a6ba7f923926c42f971af82ce65ac0))
+* remove Gemfile.lock during bootstrap ([08680ae](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/08680ae4ffe4c4caccba19359315a1151a181599))
+* reorganize type aliases ([c28f2b8](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/c28f2b8ca8350ae72b7f5d39b6f5c939a7eb4a17))
+* revert ignoring Gemfile.lock ([6a27e21](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/6a27e21bee317a61e8abf393cd98686787dc970d))
+* show truncated parameter docs in yard ([5df7631](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/5df7631e3e10b14d383e6e38a6d4efc79d0883a4))
+* simplify yard annotations by removing most `@!parse` directives ([5a3e8a7](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/5a3e8a75fe86fb7539a7b0396294eb905f20f58e))
+* update README with recommended editor plugins ([aadf96a](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/aadf96a28e21ea93f09b9db44f7878f00c57c394))
+* use `@!method` instead of `@!parse` for virtual method type definitions ([d23861f](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/d23861f35b0d7a9ff65efa2a9f4ff3f6e962f251))
+* validate request option coercion correctness ([313bbc7](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/313bbc7003e71a20a5268115bfadf2feda148db8))
+
+
+### Documentation
+
+* illustrate environmental defaults for auth variables ([2313757](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/23137570576c7d32b0581f9d4b3b2581b5e563aa))
+* **readme:** fix typo ([90db191](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/90db19112353146360a44a9abb0bdc061d991915))
+
 ## 0.1.0-alpha.18 (2025-04-17)
 
 Full Changelog: [v0.1.0-alpha.17...v0.1.0-alpha.18](https://github.com/Modern-Treasury/modern-treasury-ruby/compare/v0.1.0-alpha.17...v0.1.0-alpha.18)

data/README.md

@@ -1,6 +1,6 @@
 # Modern Treasury Ruby API library
 
-The Modern Treasury Ruby library provides convenient access to the Modern Treasury REST API from any Ruby 3.1.0+ application.
+The Modern Treasury Ruby library provides convenient access to the Modern Treasury REST API from any Ruby 3.2.0+ application.
 
 ## Documentation
 
@@ -15,7 +15,7 @@ To use this gem, install via Bundler by adding the following to your application
 <!-- x-release-please-start-version -->
 
 ```ruby
-gem "modern_treasury", "~> 0.1.0.pre.alpha.18"
+gem "modern_treasury", "~> 0.1.0.pre.alpha.19"
 ```
 
 <!-- x-release-please-end -->
@@ -27,8 +27,8 @@ require "bundler/setup"
 require "modern_treasury"
 
 modern_treasury = ModernTreasury::Client.new(
-  organization_id: "my-organization-ID", # defaults to ENV["MODERN_TREASURY_ORGANIZATION_ID"]
-  api_key: "My API Key" # defaults to ENV["MODERN_TREASURY_API_KEY"]
+  organization_id: ENV["MODERN_TREASURY_ORGANIZATION_ID"], # This is the default and can be omitted
+  api_key: ENV["MODERN_TREASURY_API_KEY"] # This is the default and can be omitted
 )
 
 counterparty = modern_treasury.counterparties.create(name: "my first counterparty")
@@ -36,6 +36,16 @@ counterparty = modern_treasury.counterparties.create(name: "my first counterpart
 puts(counterparty.id)
 ```
 
+## Sorbet
+
+This library is written with [Sorbet type definitions](https://sorbet.org/docs/rbi). However, there is no runtime dependency on the `sorbet-runtime`.
+
+When using sorbet, it is recommended to use model classes as below. This provides stronger type checking and tooling integration.
+
+```ruby
+modern_treasury.counterparties.create(name: "my first counterparty")
+```
+
 ### Pagination
 
 List methods in the Modern Treasury API are paginated.
@@ -57,7 +67,7 @@ end
 
 ### File uploads
 
-Request parameters that correspond to file uploads can be passed as `StringIO`, or a [`Pathname`](https://rubyapi.org/3.1/o/pathname) instance.
+Request parameters that correspond to file uploads can be passed as `StringIO`, or a [`Pathname`](https://rubyapi.org/3.2/o/pathname) instance.
 
 ```ruby
 require "pathname"
@@ -92,7 +102,7 @@ rescue ModernTreasury::Errors::APIError => e
 end
 ```
 
-Error codes are as followed:
+Error codes are as follows:
 
 | Cause            | Error Type                 |
 | ---------------- | -------------------------- |
@@ -144,61 +154,32 @@ modern_treasury = ModernTreasury::Client.new(
 modern_treasury.counterparties.create(name: "my first counterparty", request_options: {timeout: 5})
 ```
 
-## LSP Support
-
-### Solargraph
-
-This library includes [Solargraph](https://solargraph.org) support for both auto completion and go to definition.
-
-```ruby
-gem "solargraph", group: :development
-```
-
-After Solargraph is installed, **you must populate its index** either via the provided editor command, or by running the following in your terminal:
-
-```sh
-bundle exec solargraph gems
-```
-
-Note: if you had installed the gem either using a `git:` or `github:` URL, or had vendored the gem using bundler, you will need to set up your [`.solargraph.yml`](https://solargraph.org/guides/configuration) to include the path to the gem's `lib` directory.
-
-```yaml
-include:
-  - 'vendor/bundle/ruby/*/gems/modern_treasury-*/lib/**/*.rb'
-```
-
-Otherwise Solargraph will not be able to provide type information or auto-completion for any non-indexed libraries.
-
-### Sorbet
-
-This library is written with [Sorbet type definitions](https://sorbet.org/docs/rbi). However, there is no runtime dependency on the `sorbet-runtime`.
+## Model DSL
 
-What this means is that while you can use Sorbet to type check your code statically, and benefit from the [Sorbet Language Server](https://sorbet.org/docs/lsp) in your editor, there is no runtime type checking and execution overhead from Sorbet itself.
+This library uses a simple DSL to represent request parameters and response shapes in `lib/modern_treasury/models`.
 
-Due to limitations with the Sorbet type system, where a method otherwise can take an instance of `ModernTreasury::BaseModel` class, you will need to use the `**` splat operator to pass the arguments:
+With the right [editor plugins](https://shopify.github.io/ruby-lsp), you can ctrl-click on elements of the DSL to navigate around and explore the library.
 
-Please follow Sorbet's [setup guides](https://sorbet.org/docs/adopting) for best experience.
+In all places where a `BaseModel` type is specified, vanilla Ruby `Hash` can also be used. For example, the following are interchangeable as arguments:
 
 ```ruby
+# This has tooling readability, for auto-completion, static analysis, and goto definition with supported language services
 params = ModernTreasury::Models::CounterpartyCreateParams.new(name: "my first counterparty")
 
-modern_treasury.counterparties.create(**params)
+# This also works
+params = {
+  name: "my first counterparty"
+}
 ```
 
-Note: **This library emits an intentional warning under the [`tapioca` toolchain](https://github.com/Shopify/tapioca)**. This is normal, and does not impact functionality.
-
-### Ruby LSP
+## Editor support
 
-The Ruby LSP has [best effort support](https://shopify.github.io/ruby-lsp/#guessed-types) for inferring type information from Ruby code, and as such it may not always be able to provide accurate type information.
+A combination of [Shopify LSP](https://shopify.github.io/ruby-lsp) and [Solargraph](https://solargraph.org/) is recommended for non-[Sorbet](https://sorbet.org) users. The former is especially good at go to definition, while the latter has much better auto-completion support.
 
-## Advanced
+## Advanced concepts
 
 ### Making custom/undocumented requests
 
-This library is typed for convenient access to the documented API.
-
-If you need to access undocumented endpoints, params, or response properties, the library can still be used.
-
 #### Undocumented request params
 
 If you want to explicitly send an extra param, you can do so with the `extra_query`, `extra_body`, and `extra_headers` under the `request_options:` parameter when making a requests as seen in examples above.
@@ -209,15 +190,15 @@ To make requests to undocumented endpoints, you can make requests using `client.
 
 ```ruby
 response = client.request(
-    method: :post,
-    path: '/undocumented/endpoint',
-    query: {"dog": "woof"},
-    headers: {"useful-header": "interesting-value"},
-    body: {"he": "llo"},
-  )
+  method: :post,
+  path: '/undocumented/endpoint',
+  query: {"dog": "woof"},
+  headers: {"useful-header": "interesting-value"},
+  body: {"he": "llo"},
+)
 ```
 
-### Concurrency & Connection Pooling
+### Concurrency & connection pooling
 
 The `ModernTreasury::Client` instances are thread-safe, and should be re-used across multiple threads. By default, each `Client` have their own HTTP connection pool, with a maximum number of connections equal to thread count.
 
@@ -227,6 +208,30 @@ Unless otherwise specified, other classes in the SDK do not have locks protectin
 
 Currently, `ModernTreasury::Client` instances are only fork-safe if there are no in-flight HTTP requests.
 
+### Sorbet
+
+#### Enums
+
+Sorbet's typed enums require sub-classing of the [`T::Enum` class](https://sorbet.org/docs/tenum) from the `sorbet-runtime` gem.
+
+Since this library does not depend on `sorbet-runtime`, it uses a [`T.all` intersection type](https://sorbet.org/docs/intersection-types) with a ruby primitive type to construct a "tagged alias" instead.
+
+```ruby
+module ModernTreasury::AccountsType
+  # This alias aids language service driven navigation.
+  TaggedSymbol = T.type_alias { T.all(Symbol, ModernTreasury::AccountsType) }
+end
+```
+
+#### Argument passing trick
+
+It is possible to pass a compatible model / parameter class to a method that expects keyword arguments by using the `**` splat operator.
+
+```ruby
+params = ModernTreasury::Models::CounterpartyCreateParams.new(name: "my first counterparty")
+modern_treasury.counterparties.create(**params)
+```
+
 ## Versioning
 
 This package follows [SemVer](https://semver.org/spec/v2.0.0.html) conventions. As the library is in initial development and has a major version of `0`, APIs may change at any time.
@@ -235,4 +240,8 @@ This package considers improvements to the (non-runtime) `*.rbi` and `*.rbs` typ
 
 ## Requirements
 
-Ruby 3.1.0 or higher.
+Ruby 3.2.0 or higher.
+
+## Contributing
+
+See [the contributing documentation](https://github.com/Modern-Treasury/modern-treasury-ruby/tree/main/CONTRIBUTING.md).

data/lib/modern_treasury/client.rb

@@ -139,14 +139,14 @@ module ModernTreasury
     #
     # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
     #
-    # @return [ModernTreasury::Models::PingResponse]
+    # @return [ModernTreasury::PingResponse]
     #
     # @see ModernTreasury::Models::ClientPingParams
     def ping(params = {})
       request(
         method: :get,
         path: "api/ping",
-        model: ModernTreasury::Models::PingResponse,
+        model: ModernTreasury::PingResponse,
         options: params[:request_options]
       )
     end
@@ -183,10 +183,10 @@ module ModernTreasury
       api_key: ENV["MODERN_TREASURY_API_KEY"],
       organization_id: ENV["MODERN_TREASURY_ORGANIZATION_ID"],
       base_url: ENV["MODERN_TREASURY_BASE_URL"],
-      max_retries: DEFAULT_MAX_RETRIES,
-      timeout: DEFAULT_TIMEOUT_IN_SECONDS,
-      initial_retry_delay: DEFAULT_INITIAL_RETRY_DELAY,
-      max_retry_delay: DEFAULT_MAX_RETRY_DELAY,
+      max_retries: ModernTreasury::Client::DEFAULT_MAX_RETRIES,
+      timeout: ModernTreasury::Client::DEFAULT_TIMEOUT_IN_SECONDS,
+      initial_retry_delay: ModernTreasury::Client::DEFAULT_INITIAL_RETRY_DELAY,
+      max_retry_delay: ModernTreasury::Client::DEFAULT_MAX_RETRY_DELAY,
       idempotency_header: "Idempotency-Key"
     )
       base_url ||= "https://app.moderntreasury.com"

data/lib/modern_treasury/errors.rb

@@ -3,9 +3,9 @@
 module ModernTreasury
   module Errors
     class Error < StandardError
-      # @!parse
-      #   # @return [StandardError, nil]
-      #   attr_accessor :cause
+      # @!attribute cause
+      #
+      #   @return [StandardError, nil]
     end
 
     class ConversionError < ModernTreasury::Errors::Error
@@ -40,13 +40,13 @@ module ModernTreasury
     end
 
     class APIConnectionError < ModernTreasury::Errors::APIError
-      # @!parse
-      #   # @return [nil]
-      #   attr_accessor :status
+      # @!attribute status
+      #
+      #   @return [nil]
 
-      # @!parse
-      #   # @return [nil]
-      #   attr_accessor :body
+      # @!attribute body
+      #
+      #   @return [nil]
 
       # @api private
       #
@@ -99,7 +99,7 @@ module ModernTreasury
       # @param response [nil]
       # @param message [String, nil]
       #
-      # @return [ModernTreasury::Errors::APIStatusError]
+      # @return [self]
       def self.for(url:, status:, body:, request:, response:, message: nil)
         kwargs = {
           url: url,

data/lib/modern_treasury/file_part.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+module ModernTreasury
+  class FilePart
+    # @return [Pathname, StringIO, IO, String]
+    attr_reader :content
+
+    # @return [String, nil]
+    attr_reader :content_type
+
+    # @return [String, nil]
+    attr_reader :filename
+
+    # @api private
+    #
+    # @return [String]
+    private def read
+      case content
+      in Pathname
+        content.read(binmode: true)
+      in StringIO
+        content.string
+      in IO
+        content.read
+      in String
+        content
+      end
+    end
+
+    # @param a [Object]
+    #
+    # @return [String]
+    def to_json(*a) = read.to_json(*a)
+
+    # @param a [Object]
+    #
+    # @return [String]
+    def to_yaml(*a) = read.to_yaml(*a)
+
+    # @param content [Pathname, StringIO, IO, String]
+    # @param filename [String, nil]
+    # @param content_type [String, nil]
+    def initialize(content, filename: nil, content_type: nil)
+      @content = content
+      @filename =
+        case content
+        in Pathname
+          filename.nil? ? content.basename.to_path : ::File.basename(filename)
+        else
+          filename.nil? ? nil : ::File.basename(filename)
+        end
+      @content_type = content_type
+    end
+  end
+end

data/lib/modern_treasury/internal/page.rb

@@ -24,11 +24,11 @@ module ModernTreasury
 
       # @return [Boolean]
       def next_page?
-        !after_cursor.nil?
+        !empty? && !after_cursor.to_s.empty?
       end
 
       # @raise [ModernTreasury::HTTP::Error]
-      # @return [ModernTreasury::Internal::Page]
+      # @return [self]
       def next_page
         unless next_page?
           message = "No more pages available. Please check #next_page? before calling ##{__method__}"

data/lib/modern_treasury/internal/transport/base_client.rb

@@ -7,6 +7,8 @@ module ModernTreasury
       #
       # @abstract
       class BaseClient
+        extend ModernTreasury::Internal::Util::SorbetRuntimeSupport
+
         # from whatwg fetch spec
         MAX_REDIRECTS = 20
 
@@ -151,9 +153,30 @@ module ModernTreasury
           end
         end
 
+        # @return [URI::Generic]
+        attr_reader :base_url
+
+        # @return [Float]
+        attr_reader :timeout
+
+        # @return [Integer]
+        attr_reader :max_retries
+
+        # @return [Float]
+        attr_reader :initial_retry_delay
+
+        # @return [Float]
+        attr_reader :max_retry_delay
+
+        # @return [Hash{String=>String}]
+        attr_reader :headers
+
+        # @return [String, nil]
+        attr_reader :idempotency_header
+
         # @api private
         # @return [ModernTreasury::Internal::Transport::PooledNetRequester]
-        attr_accessor :requester
+        attr_reader :requester
 
         # @api private
         #
@@ -182,10 +205,11 @@ module ModernTreasury
             },
             headers
           )
-          @base_url = ModernTreasury::Internal::Util.parse_uri(base_url)
+          @base_url_components = ModernTreasury::Internal::Util.parse_uri(base_url)
+          @base_url = ModernTreasury::Internal::Util.unparse_uri(@base_url_components)
           @idempotency_header = idempotency_header&.to_s&.downcase
-          @max_retries = max_retries
           @timeout = timeout
+          @max_retries = max_retries
           @initial_retry_delay = initial_retry_delay
           @max_retry_delay = max_retry_delay
         end
@@ -214,11 +238,11 @@ module ModernTreasury
         #
         #   @option req [Object, nil] :body
         #
-        #   @option req [Symbol, nil] :unwrap
+        #   @option req [Symbol, Integer, Array<Symbol, Integer>, Proc, nil] :unwrap
         #
-        #   @option req [Class, nil] :page
+        #   @option req [Class<ModernTreasury::Internal::Type::BasePage>, nil] :page
         #
-        #   @option req [Class, nil] :stream
+        #   @option req [Class<ModernTreasury::Internal::Type::BaseStream>, nil] :stream
         #
         #   @option req [ModernTreasury::Internal::Type::Converter, Class, nil] :model
         #
@@ -253,7 +277,7 @@ module ModernTreasury
 
           if @idempotency_header &&
              !headers.key?(@idempotency_header) &&
-             (!Net::HTTP::IDEMPOTENT_METHODS_.include?(method.to_s.upcase) || opts.key?(:idempotency_key))
+             (%w[POST PUT].include?(method.to_s.upcase) || opts.key?(:idempotency_key))
             headers[@idempotency_header] = opts.fetch(:idempotency_key) { generate_idempotency_key }
           end
 
@@ -261,7 +285,7 @@ module ModernTreasury
             headers["x-stainless-retry-count"] = "0"
           end
 
-          timeout = opts.fetch(:timeout, @timeout).to_f.clamp((0..))
+          timeout = opts.fetch(:timeout, @timeout).to_f.clamp(0..)
           unless headers.key?("x-stainless-timeout") || timeout.zero?
             headers["x-stainless-timeout"] = timeout.to_s
           end
@@ -276,10 +300,14 @@ module ModernTreasury
               ModernTreasury::Internal::Util.deep_merge(*[req[:body], opts[:extra_body]].compact)
             end
 
+          url = ModernTreasury::Internal::Util.join_parsed_uri(
+            @base_url_components,
+            {**req, path: path, query: query}
+          )
           headers, encoded = ModernTreasury::Internal::Util.encode_content(headers, body)
           {
             method: method,
-            url: ModernTreasury::Internal::Util.join_parsed_uri(@base_url, {**req, path: path, query: query}),
+            url: url,
             headers: headers,
             body: encoded,
             max_retries: opts.fetch(:max_retries, @max_retries),
@@ -422,11 +450,11 @@ module ModernTreasury
         #
         # @param body [Object, nil]
         #
-        # @param unwrap [Symbol, nil]
+        # @param unwrap [Symbol, Integer, Array<Symbol, Integer>, Proc, nil]
         #
-        # @param page [Class, nil]
+        # @param page [Class<ModernTreasury::Internal::Type::BasePage>, nil]
         #
-        # @param stream [Class, nil]
+        # @param stream [Class<ModernTreasury::Internal::Type::BaseStream>, nil]
         #
         # @param model [ModernTreasury::Internal::Type::Converter, Class, nil]
         #
@@ -465,9 +493,9 @@ module ModernTreasury
 
           decoded = ModernTreasury::Internal::Util.decode_content(response, stream: stream)
           case req
-          in { stream: Class => st }
+          in {stream: Class => st}
             st.new(model: model, url: url, status: status, response: response, stream: decoded)
-          in { page: Class => page }
+          in {page: Class => page}
             page.new(client: self, req: req, headers: response, page_data: decoded)
           else
             unwrapped = ModernTreasury::Internal::Util.dig(decoded, req[:unwrap])
@@ -480,10 +508,54 @@ module ModernTreasury
         # @return [String]
         def inspect
           # rubocop:disable Layout/LineLength
-          base_url = ModernTreasury::Internal::Util.unparse_uri(@base_url)
-          "#<#{self.class.name}:0x#{object_id.to_s(16)} base_url=#{base_url} max_retries=#{@max_retries} timeout=#{@timeout}>"
+          "#<#{self.class.name}:0x#{object_id.to_s(16)} base_url=#{@base_url} max_retries=#{@max_retries} timeout=#{@timeout}>"
           # rubocop:enable Layout/LineLength
         end
+
+        define_sorbet_constant!(:RequestComponents) do
+          T.type_alias do
+            {
+              method: Symbol,
+              path: T.any(String, T::Array[String]),
+              query: T.nilable(T::Hash[String, T.nilable(T.any(T::Array[String], String))]),
+              headers: T.nilable(
+                T::Hash[String,
+                        T.nilable(
+                          T.any(
+                            String,
+                            Integer,
+                            T::Array[T.nilable(T.any(String, Integer))]
+                          )
+                        )]
+              ),
+              body: T.nilable(T.anything),
+              unwrap: T.nilable(
+                T.any(
+                  Symbol,
+                  Integer,
+                  T::Array[T.any(Symbol, Integer)],
+                  T.proc.params(arg0: T.anything).returns(T.anything)
+                )
+              ),
+              page: T.nilable(T::Class[ModernTreasury::Internal::Type::BasePage[ModernTreasury::Internal::Type::BaseModel]]),
+              stream: T.nilable(T::Class[T.anything]),
+              model: T.nilable(ModernTreasury::Internal::Type::Converter::Input),
+              options: T.nilable(ModernTreasury::RequestOptions::OrHash)
+            }
+          end
+        end
+        define_sorbet_constant!(:RequestInput) do
+          T.type_alias do
+            {
+              method: Symbol,
+              url: URI::Generic,
+              headers: T::Hash[String, String],
+              body: T.anything,
+              max_retries: Integer,
+              timeout: Float
+            }
+          end
+        end
       end
     end
   end