modern_treasury 0.9.0 → 0.11.0

data/lib/modern_treasury/models.rb

@@ -183,6 +183,14 @@ module ModernTreasury
 
   ForeignExchangeRate = ModernTreasury::Models::ForeignExchangeRate
 
+  HoldCreateParams = ModernTreasury::Models::HoldCreateParams
+
+  HoldListParams = ModernTreasury::Models::HoldListParams
+
+  HoldRetrieveParams = ModernTreasury::Models::HoldRetrieveParams
+
+  HoldUpdateParams = ModernTreasury::Models::HoldUpdateParams
+
   IdentificationCreateRequest = ModernTreasury::Models::IdentificationCreateRequest
 
   IncomingPaymentDetail = ModernTreasury::Models::IncomingPaymentDetail
@@ -201,6 +209,8 @@ module ModernTreasury
 
   InternalAccountListParams = ModernTreasury::Models::InternalAccountListParams
 
+  InternalAccountRequestClosureParams = ModernTreasury::Models::InternalAccountRequestClosureParams
+
   InternalAccountRetrieveParams = ModernTreasury::Models::InternalAccountRetrieveParams
 
   InternalAccounts = ModernTreasury::Models::InternalAccounts
@@ -224,6 +234,16 @@ module ModernTreasury
 
   InvoiceUpdateParams = ModernTreasury::Models::InvoiceUpdateParams
 
+  JournalEntryListParams = ModernTreasury::Models::JournalEntryListParams
+
+  JournalEntryRetrieveParams = ModernTreasury::Models::JournalEntryRetrieveParams
+
+  JournalReportListParams = ModernTreasury::Models::JournalReportListParams
+
+  JournalReportRetrieveParams = ModernTreasury::Models::JournalReportRetrieveParams
+
+  JournalReportUpdateParams = ModernTreasury::Models::JournalReportUpdateParams
+
   Ledger = ModernTreasury::Models::Ledger
 
   LedgerAccount = ModernTreasury::Models::LedgerAccount

data/lib/modern_treasury/resources/counterparties.rb

@@ -8,31 +8,31 @@ module ModernTreasury
       #
       # Create a new counterparty.
       #
-      # @overload create(name:, body_external_id: nil, accounting: nil, accounts: nil, email: nil, ledger_type: nil, legal_entity: nil, legal_entity_id: nil, metadata: nil, send_remittance_advice: nil, taxpayer_identifier: nil, verification_status: nil, request_options: {})
+      # @overload create(name:, accounting: nil, accounts: nil, email: nil, external_id: nil, ledger_type: nil, legal_entity: nil, legal_entity_id: nil, metadata: nil, send_remittance_advice: nil, taxpayer_identifier: nil, verification_status: nil, request_options: {})
       #
-      # @param name [String, nil] Body param: A human friendly name for this counterparty.
+      # @param name [String, nil] A human friendly name for this counterparty.
       #
-      # @param body_external_id [String, nil] Body param: An optional user-defined 180 character unique identifier.
+      # @param accounting [ModernTreasury::Models::CounterpartyCreateParams::Accounting]
       #
-      # @param accounting [ModernTreasury::Models::CounterpartyCreateParams::Accounting] Body param:
+      # @param accounts [Array<ModernTreasury::Models::CounterpartyCreateParams::Account>] The accounts for this counterparty.
       #
-      # @param accounts [Array<ModernTreasury::Models::CounterpartyCreateParams::Account>] Body param: The accounts for this counterparty.
+      # @param email [String, nil] The counterparty's email.
       #
-      # @param email [String, nil] Body param: The counterparty's email.
+      # @param external_id [String, nil] An optional user-defined 180 character unique identifier.
       #
-      # @param ledger_type [Symbol, ModernTreasury::Models::CounterpartyCreateParams::LedgerType] Body param: An optional type to auto-sync the counterparty to your ledger. Eithe
+      # @param ledger_type [Symbol, ModernTreasury::Models::CounterpartyCreateParams::LedgerType] An optional type to auto-sync the counterparty to your ledger. Either `customer`
       #
-      # @param legal_entity [ModernTreasury::Models::CounterpartyCreateParams::LegalEntity] Body param:
+      # @param legal_entity [ModernTreasury::Models::CounterpartyCreateParams::LegalEntity]
       #
-      # @param legal_entity_id [String, nil] Body param: The id of the legal entity.
+      # @param legal_entity_id [String, nil] The id of the legal entity.
       #
-      # @param metadata [Hash{Symbol=>String}] Body param: Additional data represented as key-value pairs. Both the key and val
+      # @param metadata [Hash{Symbol=>String}] Additional data represented as key-value pairs. Both the key and value must be s
       #
-      # @param send_remittance_advice [Boolean] Body param: Send an email to the counterparty whenever an associated payment ord
+      # @param send_remittance_advice [Boolean] Send an email to the counterparty whenever an associated payment order is sent t
       #
-      # @param taxpayer_identifier [String] Body param: Either a valid SSN or EIN.
+      # @param taxpayer_identifier [String] Either a valid SSN or EIN.
       #
-      # @param verification_status [String] Body param: The verification status of the counterparty.
+      # @param verification_status [String] The verification status of the counterparty.
       #
       # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
       #
@@ -41,12 +41,10 @@ module ModernTreasury
       # @see ModernTreasury::Models::CounterpartyCreateParams
       def create(params)
         parsed, options = ModernTreasury::CounterpartyCreateParams.dump_request(params)
-        query_params = [:query_external_id]
         @client.request(
           method: :post,
           path: "api/counterparties",
-          query: parsed.slice(*query_params).transform_keys(query_external_id: "external_id"),
-          body: parsed.except(*query_params),
+          body: parsed,
           model: ModernTreasury::Counterparty,
           options: options
         )

data/lib/modern_treasury/resources/external_accounts.rb

@@ -8,35 +8,35 @@ module ModernTreasury
       #
       # create external account
       #
-      # @overload create(counterparty_id:, body_external_id: nil, account_details: nil, account_type: nil, contact_details: nil, ledger_account: nil, metadata: nil, name: nil, party_address: nil, party_identifier: nil, party_name: nil, party_type: nil, plaid_processor_token: nil, routing_details: nil, request_options: {})
+      # @overload create(counterparty_id:, account_details: nil, account_type: nil, contact_details: nil, external_id: nil, ledger_account: nil, metadata: nil, name: nil, party_address: nil, party_identifier: nil, party_name: nil, party_type: nil, plaid_processor_token: nil, routing_details: nil, request_options: {})
       #
-      # @param counterparty_id [String, nil] Body param:
+      # @param counterparty_id [String, nil]
       #
-      # @param body_external_id [String, nil] Body param: An optional user-defined 180 character unique identifier.
+      # @param account_details [Array<ModernTreasury::Models::ExternalAccountCreateParams::AccountDetail>]
       #
-      # @param account_details [Array<ModernTreasury::Models::ExternalAccountCreateParams::AccountDetail>] Body param:
+      # @param account_type [Symbol, ModernTreasury::Models::ExternalAccountType] Can be `checking`, `savings` or `other`.
       #
-      # @param account_type [Symbol, ModernTreasury::Models::ExternalAccountType] Body param: Can be `checking`, `savings` or `other`.
+      # @param contact_details [Array<ModernTreasury::Models::ContactDetailCreateRequest>]
       #
-      # @param contact_details [Array<ModernTreasury::Models::ContactDetailCreateRequest>] Body param:
+      # @param external_id [String, nil] An optional user-defined 180 character unique identifier.
       #
-      # @param ledger_account [ModernTreasury::Models::LedgerAccountCreateRequest] Body param: Specifies a ledger account object that will be created with the exte
+      # @param ledger_account [ModernTreasury::Models::LedgerAccountCreateRequest] Specifies a ledger account object that will be created with the external account
       #
-      # @param metadata [Hash{Symbol=>String}] Body param: Additional data represented as key-value pairs. Both the key and val
+      # @param metadata [Hash{Symbol=>String}] Additional data represented as key-value pairs. Both the key and value must be s
       #
-      # @param name [String, nil] Body param: A nickname for the external account. This is only for internal usage
+      # @param name [String, nil] A nickname for the external account. This is only for internal usage and won't a
       #
-      # @param party_address [ModernTreasury::Models::AddressRequest] Body param: Required if receiving wire payments.
+      # @param party_address [ModernTreasury::Models::AddressRequest] Required if receiving wire payments.
       #
-      # @param party_identifier [String] Body param:
+      # @param party_identifier [String]
       #
-      # @param party_name [String] Body param: If this value isn't provided, it will be inherited from the counterp
+      # @param party_name [String] If this value isn't provided, it will be inherited from the counterparty's name.
       #
-      # @param party_type [Symbol, ModernTreasury::Models::ExternalAccountCreateParams::PartyType, nil] Body param: Either `individual` or `business`.
+      # @param party_type [Symbol, ModernTreasury::Models::ExternalAccountCreateParams::PartyType, nil] Either `individual` or `business`.
       #
-      # @param plaid_processor_token [String] Body param: If you've enabled the Modern Treasury + Plaid integration in your Pl
+      # @param plaid_processor_token [String] If you've enabled the Modern Treasury + Plaid integration in your Plaid account,
       #
-      # @param routing_details [Array<ModernTreasury::Models::ExternalAccountCreateParams::RoutingDetail>] Body param:
+      # @param routing_details [Array<ModernTreasury::Models::ExternalAccountCreateParams::RoutingDetail>]
       #
       # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
       #
@@ -45,12 +45,10 @@ module ModernTreasury
       # @see ModernTreasury::Models::ExternalAccountCreateParams
       def create(params)
         parsed, options = ModernTreasury::ExternalAccountCreateParams.dump_request(params)
-        query_params = [:query_external_id]
         @client.request(
           method: :post,
           path: "api/external_accounts",
-          query: parsed.slice(*query_params).transform_keys(query_external_id: "external_id"),
-          body: parsed.except(*query_params),
+          body: parsed,
           model: ModernTreasury::ExternalAccount,
           options: options
         )

data/lib/modern_treasury/resources/holds.rb

@@ -0,0 +1,126 @@
+# frozen_string_literal: true
+
+module ModernTreasury
+  module Resources
+    class Holds
+      # Create a new hold
+      #
+      # @overload create(status:, target_id:, target_type:, metadata: nil, reason: nil, request_options: {})
+      #
+      # @param status [Symbol, ModernTreasury::Models::HoldCreateParams::Status] The status of the hold
+      #
+      # @param target_id [String] The ID of the target to hold
+      #
+      # @param target_type [Symbol, ModernTreasury::Models::HoldCreateParams::TargetType] The type of target to hold
+      #
+      # @param metadata [Hash{Symbol=>String}, nil] Additional metadata for the hold
+      #
+      # @param reason [String, nil] The reason for the hold
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [ModernTreasury::Models::HoldCreateResponse]
+      #
+      # @see ModernTreasury::Models::HoldCreateParams
+      def create(params)
+        parsed, options = ModernTreasury::HoldCreateParams.dump_request(params)
+        @client.request(
+          method: :post,
+          path: "api/holds",
+          body: parsed,
+          model: ModernTreasury::Models::HoldCreateResponse,
+          options: options
+        )
+      end
+
+      # Get a specific hold
+      #
+      # @overload retrieve(id, request_options: {})
+      #
+      # @param id [String] hold id
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [ModernTreasury::Models::HoldRetrieveResponse]
+      #
+      # @see ModernTreasury::Models::HoldRetrieveParams
+      def retrieve(id, params = {})
+        @client.request(
+          method: :get,
+          path: ["api/holds/%1$s", id],
+          model: ModernTreasury::Models::HoldRetrieveResponse,
+          options: params[:request_options]
+        )
+      end
+
+      # Update a hold
+      #
+      # @overload update(id, status:, resolution: nil, request_options: {})
+      #
+      # @param id [String] hold id
+      #
+      # @param status [Symbol, ModernTreasury::Models::HoldUpdateParams::Status] The new status of the hold
+      #
+      # @param resolution [String, nil] The resolution of the hold
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [ModernTreasury::Models::HoldUpdateResponse]
+      #
+      # @see ModernTreasury::Models::HoldUpdateParams
+      def update(id, params)
+        parsed, options = ModernTreasury::HoldUpdateParams.dump_request(params)
+        @client.request(
+          method: :patch,
+          path: ["api/holds/%1$s", id],
+          body: parsed,
+          model: ModernTreasury::Models::HoldUpdateResponse,
+          options: options
+        )
+      end
+
+      # Some parameter documentations has been truncated, see
+      # {ModernTreasury::Models::HoldListParams} for more details.
+      #
+      # Get a list of holds.
+      #
+      # @overload list(after_cursor: nil, metadata: nil, per_page: nil, status: nil, target_id: nil, target_type: nil, request_options: {})
+      #
+      # @param after_cursor [String, nil]
+      #
+      # @param metadata [Hash{Symbol=>String}] For example, if you want to query for records with metadata key `Type` and value
+      #
+      # @param per_page [Integer]
+      #
+      # @param status [Symbol, ModernTreasury::Models::HoldListParams::Status, nil] Translation missing: en.openapi.descriptions.payment_order.query_params.status
+      #
+      # @param target_id [String, nil] Translation missing: en.openapi.descriptions.payment_order.query_params.target_i
+      #
+      # @param target_type [Symbol, ModernTreasury::Models::HoldListParams::TargetType, nil] Translation missing: en.openapi.descriptions.payment_order.query_params.target_t
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [ModernTreasury::Internal::Page<ModernTreasury::Models::HoldListResponse>]
+      #
+      # @see ModernTreasury::Models::HoldListParams
+      def list(params = {})
+        parsed, options = ModernTreasury::HoldListParams.dump_request(params)
+        @client.request(
+          method: :get,
+          path: "api/holds",
+          query: parsed,
+          page: ModernTreasury::Internal::Page,
+          model: ModernTreasury::Models::HoldListResponse,
+          options: options
+        )
+      end
+
+      # @api private
+      #
+      # @param client [ModernTreasury::Client]
+      def initialize(client:)
+        @client = client
+      end
+    end
+  end
+end

data/lib/modern_treasury/resources/internal_accounts.rb

@@ -148,6 +148,26 @@ module ModernTreasury
         )
       end
 
+      # request closure of internal account
+      #
+      # @overload request_closure(id, request_options: {})
+      #
+      # @param id [String] Unique identifier for the account.
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [ModernTreasury::Models::InternalAccount]
+      #
+      # @see ModernTreasury::Models::InternalAccountRequestClosureParams
+      def request_closure(id, params = {})
+        @client.request(
+          method: :post,
+          path: ["api/internal_accounts/%1$s/request_closure", id],
+          model: ModernTreasury::InternalAccount,
+          options: params[:request_options]
+        )
+      end
+
       # Some parameter documentations has been truncated, see
       # {ModernTreasury::Models::InternalAccountUpdateAccountCapabilityParams} for more
       # details.

data/lib/modern_treasury/resources/journal_entries.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+module ModernTreasury
+  module Resources
+    class JournalEntries
+      # Retrieve a specific journal entry
+      #
+      # @overload retrieve(id, request_options: {})
+      #
+      # @param id [String] The ID of the journal entry
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [nil]
+      #
+      # @see ModernTreasury::Models::JournalEntryRetrieveParams
+      def retrieve(id, params = {})
+        @client.request(
+          method: :get,
+          path: ["api/journal_entries/%1$s", id],
+          model: NilClass,
+          options: params[:request_options]
+        )
+      end
+
+      # Retrieve a list of journal entries
+      #
+      # @overload list(journal_report_id:, page: nil, per_page: nil, request_options: {})
+      #
+      # @param journal_report_id [String] The ID of the journal report
+      #
+      # @param page [Integer] Page number for pagination
+      #
+      # @param per_page [Integer] Number of items per page
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [nil]
+      #
+      # @see ModernTreasury::Models::JournalEntryListParams
+      def list(params)
+        parsed, options = ModernTreasury::JournalEntryListParams.dump_request(params)
+        @client.request(
+          method: :get,
+          path: "api/journal_entries",
+          query: parsed,
+          model: NilClass,
+          options: options
+        )
+      end
+
+      # @api private
+      #
+      # @param client [ModernTreasury::Client]
+      def initialize(client:)
+        @client = client
+      end
+    end
+  end
+end

data/lib/modern_treasury/resources/journal_reports.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+module ModernTreasury
+  module Resources
+    class JournalReports
+      # Retrieve a specific journal report
+      #
+      # @overload retrieve(id, request_options: {})
+      #
+      # @param id [String] The ID of the journal report
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [nil]
+      #
+      # @see ModernTreasury::Models::JournalReportRetrieveParams
+      def retrieve(id, params = {})
+        @client.request(
+          method: :get,
+          path: ["api/journal_reports/%1$s", id],
+          model: NilClass,
+          options: params[:request_options]
+        )
+      end
+
+      # Update a journal report
+      #
+      # @overload update(id, metadata: nil, status: nil, request_options: {})
+      #
+      # @param id [String] The ID of the journal report
+      #
+      # @param metadata [Object]
+      #
+      # @param status [String]
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [nil]
+      #
+      # @see ModernTreasury::Models::JournalReportUpdateParams
+      def update(id, params = {})
+        parsed, options = ModernTreasury::JournalReportUpdateParams.dump_request(params)
+        @client.request(
+          method: :patch,
+          path: ["api/journal_reports/%1$s", id],
+          body: parsed,
+          model: NilClass,
+          options: options
+        )
+      end
+
+      # Retrieve a list of journal reports
+      #
+      # @overload list(request_options: {})
+      #
+      # @param request_options [ModernTreasury::RequestOptions, Hash{Symbol=>Object}, nil]
+      #
+      # @return [nil]
+      #
+      # @see ModernTreasury::Models::JournalReportListParams
+      def list(params = {})
+        @client.request(
+          method: :get,
+          path: "api/journal_reports",
+          model: NilClass,
+          options: params[:request_options]
+        )
+      end
+
+      # @api private
+      #
+      # @param client [ModernTreasury::Client]
+      def initialize(client:)
+        @client = client
+      end
+    end
+  end
+end

data/lib/modern_treasury/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ModernTreasury
-  VERSION = "0.9.0"
+  VERSION = "0.11.0"
 end

data/lib/modern_treasury.rb

@@ -9,6 +9,7 @@ require "erb"
 require "etc"
 require "json"
 require "net/http"
+require "openssl"
 require "pathname"
 require "rbconfig"
 require "securerandom"
@@ -124,6 +125,14 @@ require_relative "modern_treasury/models/foreign_exchange_quote_create_params"
 require_relative "modern_treasury/models/foreign_exchange_quote_list_params"
 require_relative "modern_treasury/models/foreign_exchange_quote_retrieve_params"
 require_relative "modern_treasury/models/foreign_exchange_rate"
+require_relative "modern_treasury/models/hold_create_params"
+require_relative "modern_treasury/models/hold_create_response"
+require_relative "modern_treasury/models/hold_list_params"
+require_relative "modern_treasury/models/hold_list_response"
+require_relative "modern_treasury/models/hold_retrieve_params"
+require_relative "modern_treasury/models/hold_retrieve_response"
+require_relative "modern_treasury/models/hold_update_params"
+require_relative "modern_treasury/models/hold_update_response"
 require_relative "modern_treasury/models/identification_create_request"
 require_relative "modern_treasury/models/incoming_payment_detail"
 require_relative "modern_treasury/models/incoming_payment_detail_create_async_params"
@@ -133,6 +142,7 @@ require_relative "modern_treasury/models/incoming_payment_detail_update_params"
 require_relative "modern_treasury/models/internal_account"
 require_relative "modern_treasury/models/internal_account_create_params"
 require_relative "modern_treasury/models/internal_account_list_params"
+require_relative "modern_treasury/models/internal_account_request_closure_params"
 require_relative "modern_treasury/models/internal_account_retrieve_params"
 require_relative "modern_treasury/models/internal_accounts/balance_report"
 require_relative "modern_treasury/models/internal_accounts/balance_report_create_params"
@@ -154,6 +164,11 @@ require_relative "modern_treasury/models/invoices/line_item_list_params"
 require_relative "modern_treasury/models/invoices/line_item_retrieve_params"
 require_relative "modern_treasury/models/invoices/line_item_update_params"
 require_relative "modern_treasury/models/invoice_update_params"
+require_relative "modern_treasury/models/journal_entry_list_params"
+require_relative "modern_treasury/models/journal_entry_retrieve_params"
+require_relative "modern_treasury/models/journal_report_list_params"
+require_relative "modern_treasury/models/journal_report_retrieve_params"
+require_relative "modern_treasury/models/journal_report_update_params"
 require_relative "modern_treasury/models/ledger"
 require_relative "modern_treasury/models/ledger_account"
 require_relative "modern_treasury/models/ledger_account_balance_monitor"
@@ -299,11 +314,14 @@ require_relative "modern_treasury/resources/events"
 require_relative "modern_treasury/resources/expected_payments"
 require_relative "modern_treasury/resources/external_accounts"
 require_relative "modern_treasury/resources/foreign_exchange_quotes"
+require_relative "modern_treasury/resources/holds"
 require_relative "modern_treasury/resources/incoming_payment_details"
 require_relative "modern_treasury/resources/internal_accounts"
 require_relative "modern_treasury/resources/internal_accounts/balance_reports"
 require_relative "modern_treasury/resources/invoices"
 require_relative "modern_treasury/resources/invoices/line_items"
+require_relative "modern_treasury/resources/journal_entries"
+require_relative "modern_treasury/resources/journal_reports"
 require_relative "modern_treasury/resources/ledger_account_balance_monitors"
 require_relative "modern_treasury/resources/ledger_account_categories"
 require_relative "modern_treasury/resources/ledger_accounts"

data/manifest.yaml

@@ -6,6 +6,7 @@ dependencies:
   - etc
   - json
   - net/http
+  - openssl
   - pathname
   - rbconfig
   - securerandom

data/rbi/modern_treasury/client.rbi

@@ -121,6 +121,15 @@ module ModernTreasury
     sig { returns(ModernTreasury::Resources::PaymentActions) }
     attr_reader :payment_actions
 
+    sig { returns(ModernTreasury::Resources::JournalEntries) }
+    attr_reader :journal_entries
+
+    sig { returns(ModernTreasury::Resources::JournalReports) }
+    attr_reader :journal_reports
+
+    sig { returns(ModernTreasury::Resources::Holds) }
+    attr_reader :holds
+
     # A test endpoint often used to confirm credentials and headers are being passed
     # in correctly.
     sig do

data/rbi/modern_treasury/internal/transport/base_client.rbi

@@ -182,6 +182,11 @@ module ModernTreasury
         private def auth_headers
         end
 
+        # @api private
+        sig { returns(String) }
+        private def user_agent
+        end
+
         # @api private
         sig { returns(String) }
         private def generate_idempotency_key

data/rbi/modern_treasury/internal/transport/pooled_net_requester.rbi

@@ -26,8 +26,12 @@ module ModernTreasury
 
         class << self
           # @api private
-          sig { params(url: URI::Generic).returns(Net::HTTP) }
-          def connect(url)
+          sig do
+            params(cert_store: OpenSSL::X509::Store, url: URI::Generic).returns(
+              Net::HTTP
+            )
+          end
+          def connect(cert_store:, url:)
           end
 
           # @api private

data/rbi/modern_treasury/internal/type/base_model.rbi

@@ -31,7 +31,7 @@ module ModernTreasury
           #
           # Assumes superclass fields are totally defined before fields are accessed /
           # defined on subclasses.
-          sig { params(child: T.self_type).void }
+          sig { params(child: ModernTreasury::Internal::Type::BaseModel).void }
           def inherited(child)
           end
 
@@ -282,9 +282,13 @@ module ModernTreasury
 
         # Create a new instance of a model.
         sig do
-          params(data: T.any(T::Hash[Symbol, T.anything], T.self_type)).returns(
-            T.attached_class
-          )
+          params(
+            data:
+              T.any(
+                T::Hash[Symbol, T.anything],
+                ModernTreasury::Internal::Type::BaseModel
+              )
+          ).returns(T.attached_class)
         end
         def self.new(data = {})
         end

data/rbi/modern_treasury/models/counterparty_create_params.rbi

@@ -18,10 +18,6 @@ module ModernTreasury
       sig { returns(T.nilable(String)) }
       attr_accessor :name
 
-      # An optional user-defined 180 character unique identifier.
-      sig { returns(T.nilable(String)) }
-      attr_accessor :body_external_id
-
       sig do
         returns(T.nilable(ModernTreasury::CounterpartyCreateParams::Accounting))
       end
@@ -55,6 +51,10 @@ module ModernTreasury
       sig { returns(T.nilable(String)) }
       attr_accessor :email
 
+      # An optional user-defined 180 character unique identifier.
+      sig { returns(T.nilable(String)) }
+      attr_accessor :external_id
+
       # An optional type to auto-sync the counterparty to your ledger. Either `customer`
       # or `vendor`.
       sig do
@@ -126,12 +126,12 @@ module ModernTreasury
       sig do
         params(
           name: T.nilable(String),
-          body_external_id: T.nilable(String),
           accounting:
             ModernTreasury::CounterpartyCreateParams::Accounting::OrHash,
           accounts:
             T::Array[ModernTreasury::CounterpartyCreateParams::Account::OrHash],
           email: T.nilable(String),
+          external_id: T.nilable(String),
           ledger_type:
             ModernTreasury::CounterpartyCreateParams::LedgerType::OrSymbol,
           legal_entity:
@@ -147,13 +147,13 @@ module ModernTreasury
       def self.new(
         # A human friendly name for this counterparty.
         name:,
-        # An optional user-defined 180 character unique identifier.
-        body_external_id: nil,
         accounting: nil,
         # The accounts for this counterparty.
         accounts: nil,
         # The counterparty's email.
         email: nil,
+        # An optional user-defined 180 character unique identifier.
+        external_id: nil,
         # An optional type to auto-sync the counterparty to your ledger. Either `customer`
         # or `vendor`.
         ledger_type: nil,
@@ -178,11 +178,11 @@ module ModernTreasury
         override.returns(
           {
             name: T.nilable(String),
-            body_external_id: T.nilable(String),
             accounting: ModernTreasury::CounterpartyCreateParams::Accounting,
             accounts:
               T::Array[ModernTreasury::CounterpartyCreateParams::Account],
             email: T.nilable(String),
+            external_id: T.nilable(String),
             ledger_type:
               ModernTreasury::CounterpartyCreateParams::LedgerType::OrSymbol,
             legal_entity: ModernTreasury::CounterpartyCreateParams::LegalEntity,