modern_treasury 0.5.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f19540ad554c95c1363daa42455b55b89fb3645d92669ee31de7925afbfb4f31
-  data.tar.gz: 93d1d05462f0d3ff98d499b7e07239c32ef0622a32e9f31fcd7c880bb9aa71d0
+  metadata.gz: '0904ee9dd1992cf68b43a7549deaa4069fea261e495029400aa45bb5b8df4d49'
+  data.tar.gz: 1982a17e4e0b307a9f75086f06920484d0597391b6263eeddc480b67f1c5f4e3
 SHA512:
-  metadata.gz: 03d18a809950a0aefa4dda2d741b68debe4fe701a0fab8e3b57bcbe27b3fdc8c6fcdd1b1b383155cea5fadb4c94f326dda5d0537729b30c9ecfc9200a47a8ba2
-  data.tar.gz: 55bb3d874d986c0f1c2f36a8041410559f5aa2be9cd149e9f60704380a373c3d779aba43755fcfcbabf83f474a399209e88cec8d4c7bf81d11bc7b156d21bf62
+  metadata.gz: c7466008b3f69bda7eb2f3fd5a998407c8037edeab8ad2ba50ef9f239ef5f3a10180cb84d91eed9440f18f9b66b997d45d1b614998c80d55d1ff029f1b76606e
+  data.tar.gz: 0bead40bb0c48e53a10fe5b1baf301a0ccc41b8fbdd63be5220fbf553dcc3ab0ce48bcf441dbff2d8edd5f5a908d97d443b79977d6e8d0b97081eb918325f295

data/CHANGELOG.md

@@ -1,5 +1,54 @@
 # Changelog
 
+## 0.7.0 (2025-10-14)
+
+Full Changelog: [v0.6.0...v0.7.0](https://github.com/Modern-Treasury/modern-treasury-ruby/compare/v0.6.0...v0.7.0)
+
+### Features
+
+* **api:** api update ([f37bdd2](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/f37bdd2eab9164cf67cc01d7ff91eb8b43ff5156))
+* **api:** api update ([0de7b36](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/0de7b367b1ba0798455460af4a1f6f902ced1fe3))
+* **api:** api update ([8be10ad](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/8be10ad6a312243a6f498eae30371e573fbaa153))
+* **api:** api update ([40350f0](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/40350f05ed2bf464e98b2dc71a66d20dc67c510f))
+* **api:** api update ([6254376](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/6254376cd385f807e07f962f8d017a6aba11687c))
+* **api:** api update ([65f533f](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/65f533f6bba9b9a26773181a7a4bc2640b8cd49b))
+* **api:** api update ([84ea477](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/84ea47740ec4a929a2e396909cd300207f176023))
+* **api:** api update ([53c103b](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/53c103b611ac9642c5490172097fd58e49a5415c))
+* **api:** api update ([19f4fc1](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/19f4fc1d0fa8b478d9e1f416994eb3f4d1bf76ec))
+* **api:** api update ([071a9fc](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/071a9fc6611d175138c211b387763ee6a5a88b5d))
+* **api:** api update ([ffc7d79](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/ffc7d79a60947c41ee9d6377045b76e1f4a18c3e))
+* **api:** api update ([14591db](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/14591dba3e463de9bd135c4cfb439e7bfa21b124))
+* expose response headers for both streams and errors ([b2e9b9e](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/b2e9b9e7dda9b5c8e06118465be0711b65d4b209))
+
+
+### Bug Fixes
+
+* always send `filename=...` for multipart requests where a file is expected ([71bddaf](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/71bddaf2e91e843cc24450f3fc41da459dc963a0))
+* coroutine leaks from connection pool ([d75fe60](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/d75fe608595aa1cb6493809e1466af4bb3c235d4))
+* **internal:** use null byte as file separator in the fast formatting script ([cfc916d](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/cfc916de6390536ef027ccc7bae25a247f6602bc))
+* shorten multipart boundary sep to less than RFC specificed max length ([ac1bc6a](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/ac1bc6aecbc03f55fd8e879b7585c1fe0a3a7f48))
+* should not reuse buffers for `IO.copy_stream` interop ([8d4bd02](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/8d4bd02e4771eb7762f2e4ef678b0206f309eded))
+
+
+### Performance Improvements
+
+* faster code formatting ([8cfac52](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/8cfac52d0b5fd4e38d1d0e35c2e6791a160f7ad7))
+
+
+### Chores
+
+* allow fast-format to use bsd sed as well ([02dfec0](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/02dfec098434161efb839a0b9c4e209ff2c718b2))
+* do not install brew dependencies in ./scripts/bootstrap by default ([d743aac](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/d743aac958c1613a4e44aeb09612b9dd42d60452))
+* ignore linter error for tests having large collections ([8d6b26b](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/8d6b26b092354a38b43270e1418d98840e1d2a1f))
+
+## 0.6.0 (2025-09-11)
+
+Full Changelog: [v0.5.0...v0.6.0](https://github.com/Modern-Treasury/modern-treasury-ruby/compare/v0.5.0...v0.6.0)
+
+### Features
+
+* **api:** api update ([3a6356b](https://github.com/Modern-Treasury/modern-treasury-ruby/commit/3a6356b922c0815d7bfa6a4e542b38d13806face))
+
 ## 0.5.0 (2025-09-05)
 
 Full Changelog: [v0.4.0...v0.5.0](https://github.com/Modern-Treasury/modern-treasury-ruby/compare/v0.4.0...v0.5.0)

data/README.md

@@ -15,7 +15,7 @@ To use this gem, install via Bundler by adding the following to your application
 <!-- x-release-please-start-version -->
 
 ```ruby
-gem "modern_treasury", "~> 0.5.0"
+gem "modern_treasury", "~> 0.7.0"
 ```
 
 <!-- x-release-please-end -->
@@ -258,25 +258,25 @@ modern_treasury.counterparties.create(**params)
 Since this library does not depend on `sorbet-runtime`, it cannot provide [`T::Enum`](https://sorbet.org/docs/tenum) instances. Instead, we provide "tagged symbols" instead, which is always a primitive at runtime:
 
 ```ruby
-# :denied
-puts(ModernTreasury::CounterpartyCreateParams::VerificationStatus::DENIED)
+# :credit
+puts(ModernTreasury::TransactionDirection::CREDIT)
 
-# Revealed type: `T.all(ModernTreasury::CounterpartyCreateParams::VerificationStatus, Symbol)`
-T.reveal_type(ModernTreasury::CounterpartyCreateParams::VerificationStatus::DENIED)
+# Revealed type: `T.all(ModernTreasury::TransactionDirection, Symbol)`
+T.reveal_type(ModernTreasury::TransactionDirection::CREDIT)
 ```
 
 Enum parameters have a "relaxed" type, so you can either pass in enum constants or their literal value:
 
 ```ruby
 # Using the enum constants preserves the tagged type information:
-modern_treasury.counterparties.create(
-  verification_status: ModernTreasury::CounterpartyCreateParams::VerificationStatus::DENIED,
+modern_treasury.counterparties.collect_account(
+  direction: ModernTreasury::TransactionDirection::CREDIT,
   # …
 )
 
 # Literal values are also permissible:
-modern_treasury.counterparties.create(
-  verification_status: :denied,
+modern_treasury.counterparties.collect_account(
+  direction: :credit,
   # …
 )
 ```

data/lib/modern_treasury/errors.rb

@@ -40,6 +40,9 @@ module ModernTreasury
       # @return [Integer, nil]
       attr_accessor :status
 
+      # @return [Hash{String=>String}, nil]
+      attr_accessor :headers
+
       # @return [Object, nil]
       attr_accessor :body
 
@@ -47,13 +50,15 @@ module ModernTreasury
       #
       # @param url [URI::Generic]
       # @param status [Integer, nil]
+      # @param headers [Hash{String=>String}, nil]
       # @param body [Object, nil]
       # @param request [nil]
       # @param response [nil]
       # @param message [String, nil]
-      def initialize(url:, status: nil, body: nil, request: nil, response: nil, message: nil)
+      def initialize(url:, status: nil, headers: nil, body: nil, request: nil, response: nil, message: nil)
         @url = url
         @status = status
+        @headers = headers
         @body = body
         @request = request
         @response = response
@@ -74,6 +79,7 @@ module ModernTreasury
       #
       # @param url [URI::Generic]
       # @param status [nil]
+      # @param headers [Hash{String=>String}, nil]
       # @param body [nil]
       # @param request [nil]
       # @param response [nil]
@@ -81,6 +87,7 @@ module ModernTreasury
       def initialize(
         url:,
         status: nil,
+        headers: nil,
         body: nil,
         request: nil,
         response: nil,
@@ -95,6 +102,7 @@ module ModernTreasury
       #
       # @param url [URI::Generic]
       # @param status [nil]
+      # @param headers [Hash{String=>String}, nil]
       # @param body [nil]
       # @param request [nil]
       # @param response [nil]
@@ -102,6 +110,7 @@ module ModernTreasury
       def initialize(
         url:,
         status: nil,
+        headers: nil,
         body: nil,
         request: nil,
         response: nil,
@@ -116,21 +125,24 @@ module ModernTreasury
       #
       # @param url [URI::Generic]
       # @param status [Integer]
+      # @param headers [Hash{String=>String}, nil]
       # @param body [Object, nil]
       # @param request [nil]
       # @param response [nil]
       # @param message [String, nil]
       #
       # @return [self]
-      def self.for(url:, status:, body:, request:, response:, message: nil)
-        kwargs = {
-          url: url,
-          status: status,
-          body: body,
-          request: request,
-          response: response,
-          message: message
-        }
+      def self.for(url:, status:, headers:, body:, request:, response:, message: nil)
+        kwargs =
+          {
+            url: url,
+            status: status,
+            headers: headers,
+            body: body,
+            request: request,
+            response: response,
+            message: message
+          }
 
         case status
         in 400
@@ -162,15 +174,17 @@ module ModernTreasury
       #
       # @param url [URI::Generic]
       # @param status [Integer]
+      # @param headers [Hash{String=>String}, nil]
       # @param body [Object, nil]
       # @param request [nil]
       # @param response [nil]
       # @param message [String, nil]
-      def initialize(url:, status:, body:, request:, response:, message: nil)
+      def initialize(url:, status:, headers:, body:, request:, response:, message: nil)
         message ||= {url: url.to_s, status: status, body: body}
         super(
           url: url,
           status: status,
+          headers: headers,
           body: body,
           request: request,
           response: response,

data/lib/modern_treasury/file_part.rb

@@ -38,18 +38,21 @@ module ModernTreasury
     def to_yaml(*a) = read.to_yaml(*a)
 
     # @param content [Pathname, StringIO, IO, String]
-    # @param filename [String, nil]
+    # @param filename [Pathname, String, nil]
     # @param content_type [String, nil]
     def initialize(content, filename: nil, content_type: nil)
-      @content = content
+      @content_type = content_type
       @filename =
-        case content
-        in Pathname
-          filename.nil? ? content.basename.to_path : ::File.basename(filename)
+        case [filename, (@content = content)]
+        in [String | Pathname, _]
+          ::File.basename(filename)
+        in [nil, Pathname]
+          content.basename.to_path
+        in [nil, IO]
+          content.to_path
         else
-          filename.nil? ? nil : ::File.basename(filename)
+          filename
         end
-      @content_type = content_type
     end
   end
 end

data/lib/modern_treasury/internal/page.rb

@@ -60,7 +60,7 @@ module ModernTreasury
       #
       # @param client [ModernTreasury::Internal::Transport::BaseClient]
       # @param req [Hash{Symbol=>Object}]
-      # @param headers [Hash{String=>String}, Net::HTTPHeader]
+      # @param headers [Hash{String=>String}]
       # @param page_data [Hash{Symbol=>Object}]
       def initialize(client:, req:, headers:, page_data:)
         super
@@ -71,8 +71,8 @@ module ModernTreasury
         else
         end
 
-        @per_page = ModernTreasury::Internal::Util.coerce_integer(headers["X-Per-Page"])
-        @after_cursor = headers["X-After-Cursor"]&.to_s
+        @per_page = ModernTreasury::Internal::Util.coerce_integer(headers["x-per-page"])
+        @after_cursor = headers["x-after-cursor"]&.to_s
       end
 
       # @api private

data/lib/modern_treasury/internal/transport/base_client.rb

@@ -47,7 +47,7 @@ module ModernTreasury
           # @api private
           #
           # @param status [Integer]
-          # @param headers [Hash{String=>String}, Net::HTTPHeader]
+          # @param headers [Hash{String=>String}]
           #
           # @return [Boolean]
           def should_retry?(status, headers:)
@@ -85,7 +85,7 @@ module ModernTreasury
           #
           # @param status [Integer]
           #
-          # @param response_headers [Hash{String=>String}, Net::HTTPHeader]
+          # @param response_headers [Hash{String=>String}]
           #
           # @return [Hash{Symbol=>Object}]
           def follow_redirect(request, status:, response_headers:)
@@ -378,6 +378,7 @@ module ModernTreasury
           rescue ModernTreasury::Errors::APIConnectionError => e
             status = e
           end
+          headers = ModernTreasury::Internal::Util.normalized_headers(response&.each_header&.to_h)
 
           case status
           in ..299
@@ -394,7 +395,7 @@ module ModernTreasury
           in 300..399
             self.class.reap_connection!(status, stream: stream)
 
-            request = self.class.follow_redirect(request, status: status, response_headers: response)
+            request = self.class.follow_redirect(request, status: status, response_headers: headers)
             send_request(
               request,
               redirect_count: redirect_count + 1,
@@ -403,9 +404,9 @@ module ModernTreasury
             )
           in ModernTreasury::Errors::APIConnectionError if retry_count >= max_retries
             raise status
-          in (400..) if retry_count >= max_retries || !self.class.should_retry?(status, headers: response)
+          in (400..) if retry_count >= max_retries || !self.class.should_retry?(status, headers: headers)
             decoded = Kernel.then do
-              ModernTreasury::Internal::Util.decode_content(response, stream: stream, suppress_error: true)
+              ModernTreasury::Internal::Util.decode_content(headers, stream: stream, suppress_error: true)
             ensure
               self.class.reap_connection!(status, stream: stream)
             end
@@ -413,6 +414,7 @@ module ModernTreasury
             raise ModernTreasury::Errors::APIStatusError.for(
               url: url,
               status: status,
+              headers: headers,
               body: decoded,
               request: nil,
               response: response
@@ -489,19 +491,21 @@ module ModernTreasury
             send_retry_header: send_retry_header
           )
 
-          decoded = ModernTreasury::Internal::Util.decode_content(response, stream: stream)
+          headers = ModernTreasury::Internal::Util.normalized_headers(response.each_header.to_h)
+          decoded = ModernTreasury::Internal::Util.decode_content(headers, stream: stream)
           case req
           in {stream: Class => st}
             st.new(
               model: model,
               url: url,
               status: status,
+              headers: headers,
               response: response,
               unwrap: unwrap,
               stream: decoded
             )
           in {page: Class => page}
-            page.new(client: self, req: req, headers: response, page_data: decoded)
+            page.new(client: self, req: req, headers: headers, page_data: decoded)
           else
             unwrapped = ModernTreasury::Internal::Util.dig(decoded, unwrap)
             ModernTreasury::Internal::Type::Converter.coerce(model, unwrapped)

data/lib/modern_treasury/internal/transport/pooled_net_requester.rb

@@ -134,9 +134,9 @@ module ModernTreasury
 
           # rubocop:disable Metrics/BlockLength
           enum = Enumerator.new do |y|
-            with_pool(url, deadline: deadline) do |conn|
-              next if finished
+            next if finished
 
+            with_pool(url, deadline: deadline) do |conn|
               req, closing = self.class.build_request(request) do
                 self.class.calibrate_socket_timeout(conn, deadline)
               end
@@ -149,7 +149,7 @@ module ModernTreasury
 
               self.class.calibrate_socket_timeout(conn, deadline)
               conn.request(req) do |rsp|
-                y << [conn, req, rsp]
+                y << [req, rsp]
                 break if finished
 
                 rsp.read_body do |bytes|
@@ -160,6 +160,8 @@ module ModernTreasury
                 end
                 eof = true
               end
+            ensure
+              conn.finish if !eof && conn&.started?
             end
           rescue Timeout::Error
             raise ModernTreasury::Errors::APITimeoutError.new(url: url, request: req)
@@ -168,16 +170,11 @@ module ModernTreasury
           end
           # rubocop:enable Metrics/BlockLength
 
-          conn, _, response = enum.next
+          _, response = enum.next
           body = ModernTreasury::Internal::Util.fused_enum(enum, external: true) do
             finished = true
-            tap do
-              enum.next
-            rescue StopIteration
-              nil
-            end
+            loop { enum.next }
           ensure
-            conn.finish if !eof && conn&.started?
             closing&.call
           end
           [Integer(response.code), response, body]

data/lib/modern_treasury/internal/type/base_page.rb

@@ -39,7 +39,7 @@ module ModernTreasury
         #
         # @param client [ModernTreasury::Internal::Transport::BaseClient]
         # @param req [Hash{Symbol=>Object}]
-        # @param headers [Hash{String=>String}, Net::HTTPHeader]
+        # @param headers [Hash{String=>String}]
         # @param page_data [Object]
         def initialize(client:, req:, headers:, page_data:)
           @client = client

data/lib/modern_treasury/internal/type/file_input.rb

@@ -82,17 +82,20 @@ module ModernTreasury
           #
           # @return [Pathname, StringIO, IO, String, Object]
           def dump(value, state:)
-            # rubocop:disable Lint/DuplicateBranch
             case value
+            in StringIO | String
+              # https://datatracker.ietf.org/doc/html/rfc7578#section-4.2
+              # while not required, a filename is recommended, and in practice many servers do expect this
+              ModernTreasury::FilePart.new(value, filename: "upload")
             in IO
               state[:can_retry] = false
+              value.to_path.nil? ? ModernTreasury::FilePart.new(value, filename: "upload") : value
             in ModernTreasury::FilePart if value.content.is_a?(IO)
               state[:can_retry] = false
+              value
             else
+              value
             end
-            # rubocop:enable Lint/DuplicateBranch
-
-            value
           end
 
           # @api private

data/lib/modern_treasury/internal/util.rb

@@ -473,10 +473,9 @@ module ModernTreasury
         # @return [Enumerable<String>]
         def writable_enum(&blk)
           Enumerator.new do |y|
-            buf = String.new
             y.define_singleton_method(:write) do
-              self << buf.replace(_1)
-              buf.bytesize
+              self << _1.dup
+              _1.bytesize
             end
 
             blk.call(y)
@@ -566,7 +565,8 @@ module ModernTreasury
         #
         # @return [Array(String, Enumerable<String>)]
         private def encode_multipart_streaming(body)
-          boundary = SecureRandom.urlsafe_base64(60)
+          # RFC 1521 Section 7.2.1 says we should have 70 char maximum for boundary length
+          boundary = SecureRandom.urlsafe_base64(46)
 
           closing = []
           strio = writable_enum do |y|
@@ -647,7 +647,7 @@ module ModernTreasury
         #
         # Assumes each chunk in stream has `Encoding::BINARY`.
         #
-        # @param headers [Hash{String=>String}, Net::HTTPHeader]
+        # @param headers [Hash{String=>String}]
         # @param stream [Enumerable<String>]
         # @param suppress_error [Boolean]
         #