modelish 0.3.0 → 1.0.0.pre.1

data/spec/modelish_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-describe Modelish do
-  it "should have a version" do
-    subject::VERSION.should be
+RSpec.describe Modelish do
+  it 'has a version' do
+    expect(subject::VERSION).to be
   end
 end

data/spec/spec_helper.rb

@@ -1,7 +1,102 @@
-require 'modelish'
+# frozen_string_literal: true
+
+require 'simplecov'
+SimpleCov.start 'test_frameworks'
+
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+
+require 'rspec/its'
 
 Dir[File.join(File.dirname(__FILE__), 'support', '*.rb')].each { |f| require f }
 
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  # config goes here
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  # config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
 end
+
+require 'modelish'

data/spec/support/property_examples.rb

@@ -1,38 +1,41 @@
+# frozen_string_literal: true
+
 # Assumes the following have been defined
 # let(:model) -- with a model initializer that calls init_options
 # let(:property_name)
 # let(:property_value)
 # let(:default_value)
-shared_examples_for 'a modelish property' do
+RSpec.shared_examples_for 'a modelish property' do
   subject { model }
 
-  let(:init_options) { {property_name => property_value} }
+  let(:init_options) { { property_name => property_value } }
 
-  it { should respond_to(property_name) }
+  it { is_expected.to respond_to(property_name) }
 
-  describe "getter" do
+  describe 'getter' do
     subject { model.send(property_name) }
 
-    context "without init options" do
+    context 'without init options' do
       let(:init_options) { nil }
 
-      it { should == default_value }
+      it { is_expected.to eq(default_value) }
     end
 
-    context "with init options" do
-      it { should == property_value }
+    context 'with init options' do
+      it { is_expected.to eq(property_value) }
     end
   end
 
-  it { should respond_to("#{property_name}=".to_sym) }
+  it { is_expected.to respond_to("#{property_name}=".to_sym) }
 
-  describe "setter" do
+  describe 'setter' do
     subject { model.send("#{property_name}=", new_property_value) }
 
     let(:new_property_value) { 'a new value' }
 
-    it "should change the property value" do
-      expect { subject }.to change{model.send(property_name)}.from(property_value).to(new_property_value)
+    it 'changes the property value' do
+      expect { subject }.to change { model.send(property_name) }
+        .from(property_value).to(new_property_value)
     end
   end
 end

data/spec/support/typed_property_examples.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+
 # Assume the following are defined:
 # model - the model on which the property is defined
 # valid_string - a string with a valid value for the property
-# valid_typed_value - an instance of property_type that is valid for the property
+# valid_typed_value - instance of property_type that is valid for the property
 # invalid_value - an object that cannot be translated to the property type
 # default_value - the default value for the property
-shared_examples_for "a typed property" do |prop_name, prop_type|
+# error_type - defaults to ArgumentError
+RSpec.shared_examples_for 'a typed property' do |prop_name, prop_type|
   accessor = prop_name.to_sym
   raw_accessor = "raw_#{prop_name}".to_sym
   bang_accessor = "#{prop_name}!".to_sym
@@ -12,81 +15,82 @@ shared_examples_for "a typed property" do |prop_name, prop_type|
 
   subject { model }
 
-  it { should respond_to(accessor) }
-  its(prop_name) { should == default_value }
+  it { is_expected.to respond_to(accessor) }
+  its(prop_name) { is_expected.to eq(default_value) }
 
-  it { should respond_to(raw_accessor) }
-  its(raw_accessor) { should == default_value }
+  it { is_expected.to respond_to(raw_accessor) }
+  its(raw_accessor) { is_expected.to eq(default_value) }
 
-  it { should respond_to(bang_accessor) }
-  its(bang_accessor) { should == default_value }
+  it { is_expected.to respond_to(bang_accessor) }
+  its(bang_accessor) { is_expected.to eq(default_value) }
 
-  it { should respond_to(mutator) }
+  it { is_expected.to respond_to(mutator) }
 
-  describe "property_type mapping" do
+  describe 'property_type mapping' do
     subject { model.class.property_types }
 
-    it { should be }
-    it { should have_key(prop_name) }
+    it { is_expected.to be }
+    it { is_expected.to have_key(prop_name) }
 
     if prop_type
-      its([prop_name]) { should == prop_type }
+      its([prop_name]) { is_expected.to eq(prop_type) }
     else
-      its([prop_name]) { should be_a Proc }
+      its([prop_name]) { is_expected.to be_a Proc }
     end
   end
 
-  describe "assignment" do
+  describe 'assignment' do
     before { model.send(mutator, property_value) }
 
-    context "with nil" do
+    context 'with nil' do
       let(:property_value) { nil }
 
-      its(accessor) { should be_nil }
-      its(raw_accessor) { should be_nil }
+      its(accessor) { is_expected.to be_nil }
+      its(raw_accessor) { is_expected.to be_nil }
 
-      it "should not raise an error when the bang accessor is invoked" do
+      it 'does not raise an error when the bang accessor is invoked' do
         expect { subject.send(bang_accessor) }.to_not raise_error
       end
 
-      its(bang_accessor) { should be_nil }
+      its(bang_accessor) { is_expected.to be_nil }
     end
 
-    context "with valid string" do
+    context 'with valid string' do
       let(:property_value) { valid_string }
 
-      its(accessor) { should == valid_typed_value }
-      its(raw_accessor) { should == property_value }
+      its(accessor) { is_expected.to eq(valid_typed_value) }
+      its(raw_accessor) { is_expected.to eq(property_value) }
 
-      it "should not raise an error when the bang accessor is invoked" do
+      it 'does not raise an error when the bang accessor is invoked' do
         expect { subject.send(bang_accessor) }.to_not raise_error
       end
 
-      its(bang_accessor) { should == valid_typed_value } 
+      its(bang_accessor) { is_expected.to eq(valid_typed_value) }
     end
 
-    context "with valid typed value" do
+    context 'with valid typed value' do
       let(:property_value) { valid_typed_value }
 
-      its(accessor) { should == property_value }
-      its(raw_accessor) { should == property_value }
+      its(accessor) { is_expected.to eq(property_value) }
+      its(raw_accessor) { is_expected.to eq(property_value) }
 
-      it "should not raise an error when the bang accessor is invoked" do
+      it 'does not raise an error when the bang accessor is invoked' do
         expect { subject.send(bang_accessor) }.to_not raise_error
       end
 
-      its(bang_accessor) { should == valid_typed_value }
+      its(bang_accessor) { is_expected.to eq(valid_typed_value) }
     end
 
     unless [String, Array, Symbol].include?(prop_type)
-      context "with a value that cannot be converted" do
+      context 'with a value that cannot be converted' do
         let(:property_value) { invalid_value }
 
-        its(accessor) { should == property_value }
-        its(raw_accessor) { should == property_value }
+        its(accessor) { is_expected.to eq(property_value) }
+        its(raw_accessor) { is_expected.to eq(property_value) }
 
-        it "should raise an error when the bang accessor is invoked" do
-          expect { subject.send(bang_accessor) } .to raise_error
+        it 'raises an error when the bang accessor is invoked' do
+          error_class = respond_to?(:error_type) ? error_type : ArgumentError
+          expect { subject.send(bang_accessor) }.to raise_error(error_class)
         end
       end
     end

data/spec/support/unknown_property_examples.rb

@@ -1,8 +1,10 @@
-shared_examples_for 'an unknown property handler' do
+# frozen_string_literal: true
+
+RSpec.shared_examples_for 'an unknown property handler' do
   context 'when ignore_unknown_properties is set to false' do
     let(:ignore_unknown_props) { false }
 
-    it 'should raise an error' do
+    it 'raises an error' do
       expect { subject }.to raise_error(NoMethodError)
     end
   end
@@ -10,10 +12,10 @@ shared_examples_for 'an unknown property handler' do
   context 'when ignore_unknown_properties is set to true' do
     let(:ignore_unknown_props) { true }
 
-    it 'should not raise an error' do
+    it 'does not raise an error' do
       expect { subject }.to_not raise_error
     end
 
-    it { should_not respond_to(unknown_prop) }
+    it { is_expected.to_not respond_to(unknown_prop) }
   end
 end

data/spec/support/validation_examples.rb

@@ -1,23 +1,25 @@
+# frozen_string_literal: true
+
 # Assumes that let(:model) has been defined
-shared_examples_for 'a valid model' do
+RSpec.shared_examples_for 'a valid model' do
   subject { model }
 
-  it { should be_valid }
+  it { is_expected.to be_valid }
 
-  it { should respond_to(:validate) }
+  it { is_expected.to respond_to(:validate) }
 
-  describe "validate" do
+  describe '#validate' do
     subject { model.validate }
 
-    it { should be_empty }
+    it { is_expected.to be_empty }
   end
 
-  it { should respond_to(:validate!) }
+  it { is_expected.to respond_to(:validate!) }
 
-  describe "validate!" do
+  describe '#validate!' do
     subject { model.validate! }
 
-    it "should not raise any errors" do
+    it 'does not raise any errors' do
       expect { subject }.to_not raise_error
     end
   end
@@ -27,44 +29,48 @@ end
 # model - the model on which the property has been defined
 # property_name - the name of the property that is invalid
 # error_count - the number of expected errors on the property
-shared_examples_for 'a model with an invalid property' do
+RSpec.shared_examples_for 'a model with an invalid property' do
   subject { model }
 
-  it { should_not be_valid }
+  it { is_expected.to_not be_valid }
 
-  it { should respond_to(:validate) }
+  it { is_expected.to respond_to(:validate) }
 
-  describe "validate" do
+  describe '#validate' do
     subject { errors }
     let(:errors) { model.validate }
 
-    it { should have_key(property_name) }
+    it { is_expected.to have_key(property_name) }
 
-    describe "[property_name]" do
+    describe '[property_name]' do
       subject { prop_errors }
       let(:prop_errors) { errors[property_name] }
 
-      it { should have(error_count).errors }
+      its(:size) { is_expected.to eq(error_count) }
 
-      it "should be a collection of ArgumentErrors" do
-        prop_errors.each { |p| p.should be_an ArgumentError }
+      it 'is a collection of ArgumentErrors' do
+        prop_errors.each { |p| expect(p).to be_an ArgumentError }
       end
 
-      it "should reference the property name in the error message(s)" do
-        prop_errors.each { |p| p.message.should match(/#{property_name}/i) }
+      it 'references the property name in the error message(s)' do
+        prop_errors.each do |p|
+          expect(p.message).to match(/#{property_name}/i)
+        end
       end
     end
   end
 
-  describe "validate!" do
+  describe '#validate!' do
     subject { model.validate! }
 
-    it "should raise an ArgumentError" do
+    it 'raise an ArgumentError' do
       expect { subject }.to raise_error(ArgumentError)
     end
 
-    it "should reference the property name in the error message" do
-      expect { subject }.to raise_error { |e| e.message.should match(/#{property_name}/i) }
+    it 'references the property name in the error message' do
+      expect { subject }.to raise_error do |e|
+        expect(e.message).to match(/#{property_name}/i)
+      end
     end
   end
 end