model_error_messages 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9c90e564f39abb63f5c6832858e7f6962457a3c
-  data.tar.gz: c8b6625297972e405092859761cfb85df5a84a33
+  metadata.gz: 3346cf1d3cc91ec5fa3a8befc871931b1087b33a
+  data.tar.gz: cf709e9fad5263088ae0e3ffba6bac1a8fde6439
 SHA512:
-  metadata.gz: f11e4261a820cb5b2bb25062ab731637b4e2b11b206faae1b2deaddd35d02be8066d8ede47b7b0dea1d92fa9e9c4ba57bdd03ac65a5f1999b02f55cc7b4dfde2
-  data.tar.gz: c3834ad68db48d76afc1d1234aed750fd90304b97986065a649d95dda4e2f060bb63dd5808762b6fda9da378165234b7dbf79d5c3df2ac96b21763bfb67e3e5c
+  metadata.gz: 0d33d97a77439dd700d9afdf0e4ab471dd9f7f4c1ee20bf3c00cc9ae880a488d648c68bb37dd3fd0fc308126ae83415e7c40e9d953c3c3eb30320fb3aecbbbf5
+  data.tar.gz: 1ad227a9061979297a003d05ec3a8de746b5e000a41a887c7cf062b732117a4431811558a05ba1e1532715f7eb2ce39cfbc51d8223e9716c11f50b9f714742d2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    model_error_messages (1.0.1)
+    model_error_messages (1.0.2)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -2,6 +2,7 @@
 
 [![Build Status](https://secure.travis-ci.org/christophemaximin/model_error_messages.png)](https://travis-ci.org/christophemaximin/model_error_messages)
 [![Gem version](https://badge.fury.io/rb/model_error_messages.png)](https://rubygems.org/gems/model_error_messages)
+[![Code Climate](https://codeclimate.com/github/christophemaximin/model_error_messages/badges/gpa.svg)](https://codeclimate.com/github/christophemaximin/model_error_messages)
 
 A simple Rails helper which displays a HTML div with the validation errors attached to a model.
 
@@ -16,6 +17,7 @@ gem 'model_error_messages'
 ## What this gem does / How to use
 
 This gem allows you to use a helper called `model_error_messages`.  
+By default, the wrapper `div` has the [Bootstrap](http://getbootstrap.com)-friendly classes `alert alert-danger`.  
 If you have a typical form, you would want to display `model_error_messages(@model)` next to it, which will render something like:
 
 ```html

data/Rakefile

@@ -2,4 +2,4 @@ require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new('spec')
 
 desc 'Run tests'
-task :default => [:spec]
+task default: [:spec]

data/lib/model_error_messages/helpers.rb

@@ -1,29 +1,31 @@
+require 'cgi'
+
 module ModelErrorMessages
   module Helpers
-    include ActionView::Helpers::TagHelper
-
     def model_error_messages(model, options = {})
       return '' if model.nil?
       return '' if model.errors.full_messages.empty?
-      config = local_config(options)
-      errors_wrapper(model, config)
-    end
 
-    private
+      private_helpers = ModelErrorMessages::PrivateHelpers
+      config = private_helpers.local_config(options)
+      private_helpers.errors_wrapper(model, config)
+    end
+  end
 
-    def errors_wrapper(model, config)
+  module PrivateHelpers
+    def self.errors_wrapper(model, config)
       class_attr = wrapper_class_attr(model, config)
 
-      content_tag(:div, class: class_attr) do
-        [
-          config.prepend_html,
-          errors_list(model, config),
-          config.append_html
-        ].join.html_safe
-      end
+      div_string = [
+        config.prepend_html,
+        errors_list(model, config),
+        config.append_html
+      ].join.html_safe
+
+      tag(:div, div_string, class: class_attr)
     end
 
-    def wrapper_class_attr(model, config)
+    def self.wrapper_class_attr(model, config)
       if config.classes.is_a?(Proc)
         config.classes.call(model)
       else
@@ -31,26 +33,36 @@ module ModelErrorMessages
       end
     end
 
-    def errors_list(model, config)
+    def self.errors_list(model, config)
       messages = model.errors.full_messages
 
       if messages.count == 1 && config.single_error_in_paragraph
-        return content_tag(:p, messages.first)
+        return tag(:p, messages.first)
       end
 
-      content_tag(:ul) do
-        messages.map do |message|
-          content_tag(:li, message)
-        end.join.html_safe
-      end
+      ul_string = messages.map do |message|
+        tag(:li, message)
+      end.join.html_safe
+
+      tag(:ul, ul_string)
     end
 
-    def local_config(options)
+    def self.local_config(options)
       config = ModelErrorMessages.configuration.clone
       options.each_pair do |k, v|
         config.send(k.to_s + '=', v)
       end
       config
     end
+
+    def self.tag(name, value, attributes = {})
+      string_attributes = attributes.inject('') do |attrs, pair|
+        unless pair.last.nil?
+          attrs << %( #{pair.first}="#{CGI.escapeHTML(pair.last.to_s)}")
+        end
+        attrs
+      end
+      "<#{name}#{string_attributes}>#{value}</#{name}>"
+    end
   end
 end

data/lib/model_error_messages/version.rb

@@ -2,7 +2,7 @@ module ModelErrorMessages
   module VERSION
     MAJOR = 1
     MINOR = 0
-    TINY  = 1
+    TINY  = 2
 
     STRING = [MAJOR, MINOR, TINY].compact.join('.')
   end

data/spec/model_error_messages/helpers_spec.rb

@@ -69,8 +69,8 @@ describe 'Helpers' do
       let(:result) { model_error_messages(model, options) }
 
       before do
-        configuration.prepend_html = content_tag(:h1, 'An error occurred')
-        configuration.append_html = content_tag(:p, 'Please try again.')
+        configuration.prepend_html = '<h1>An error occurred</h1>'
+        configuration.append_html = '<p>Please try again.</p>'
         configuration.classes = model.class.model_name.param_key + '-foo bar'
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: model_error_messages
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Christophe Maximin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-25 00:00:00.000000000 Z
+date: 2016-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake