model_driven_api 3.11.0 → 3.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: af8d0733bb1c7ad78521684f1e9cd36879ce8fd2edac11554fae77a8857446a3
-  data.tar.gz: 8d4f390e60a0edc7fbbe8070145768c317524887643ac5afe055dd8675cfe87d
+  metadata.gz: f10db84ebc3b2fbb5b3461fcaa14c879096999fcdef4c90353172ac8313af7eb
+  data.tar.gz: ca43a58797580f249f6b48c80f3be07b607731a6a1973d04dc6d9af64adc654c
 SHA512:
-  metadata.gz: 607eb70c78ea78450ed752a1351c038736a7ad5f6023b969acb560ea59e20b95a3ff54a718b26465e01420ced20131a23d325bc05f34540a7fa77b6df6677c96
-  data.tar.gz: 22704e9424cdba8feb897dafb62710cf41ebe205dd36ca1d0a4356771c8b5419dfc1d823d2e73d03619c3bc9be4bb10c420a8a50829d396982ffac74cc8cfed7
+  metadata.gz: 39ca452f1c60589d6406de607425ce798a84882a366aa42ad648a8dc6b16e05e9535d6db18a8ea578b623ba6fcf1ec2a9c241a667369dd0fc03f505acad1a96f
+  data.tar.gz: 1c2dfe78a0c08f66eaf09bc6550213a988c42295549f0e7ffb23a66d13bea8a134ce52fb06dc60e65e67cca91f3dbe818929ffd5743bbc2cb460318e2551b982

data/app/controllers/api/v2/info_controller.rb

@@ -6,7 +6,7 @@ class Api::V2::InfoController < Api::V2::ApplicationController
 
   # api :GET, '/api/v2/info/version', "Just prints the APPVERSION."
   def version
-    render json: { version: "TODO: Find a Way to Dynamically Obtain It" }.to_json, status: 200
+    render json: { version: ModelDrivenApi.app_version }.to_json, status: 200
   end
 
   # api :GET, '/api/v2/info/roles'

data/lib/concerns/api_exception_management.rb

@@ -3,7 +3,12 @@ module ApiExceptionManagement
     
     included do
         if Rails.env.production?
-            rescue_from NoMethodError, with: :not_found!
+            # ORDER MATTERS: Rails tries rescue_from handlers from the LAST declared to the
+            # first, so the StandardError catch-all must be declared FIRST. Declared last (as it
+            # was until 3.11.0) it shadowed every specific handler below: in production every
+            # AccessDenied (wrong login credentials), RecordNotFound, RecordInvalid, CanCan
+            # denial... answered 500. Covered by spec/lib/concerns/api_exception_management_spec.rb.
+            rescue_from StandardError, with: :fivehundred!
             rescue_from CanCan::AccessDenied, with: :unauthorized!
             rescue_from AuthenticateUser::AccessDenied, with: :unauthenticated!
             rescue_from ActionController::RoutingError, with: :not_found!
@@ -17,8 +22,12 @@ module ApiExceptionManagement
             rescue_from ActiveRecord::RecordNotUnique, with: :invalid!
             # Rescue Stale Object in Optimistick locking with stale!
             rescue_from ActiveRecord::StaleObjectError, with: :stale!
-            rescue_from EndpointValidationError, with: :api_error
-            rescue_from StandardError, with: :fivehundred!
+            rescue_from EndpointValidationError, with: :endpoint_invalid!
+        end
+
+        # api_error takes keywords only, so it can't be a rescue_from handler itself.
+        def endpoint_invalid! exception = EndpointValidationError.new
+            return api_error status: 501, errors: exception.message
         end
 
         def stale! exception = StandardError.new

data/lib/model_driven_api/version.rb

@@ -1,3 +1,3 @@
 module ModelDrivenApi
-  VERSION = "3.11.0".freeze
+  VERSION = "3.11.2".freeze
 end

data/lib/model_driven_api.rb

@@ -28,6 +28,14 @@ require "api/v3/serializer_factory"
 module ModelDrivenApi
   UTC_ZONE_NAMES = %w[UTC Etc/UTC].freeze
 
+  # The host app's deployed version: the `version` file in its root (Thecore release convention —
+  # CI builds and deploys when it changes; the image is `ADD . /app`, so it ships in Rails.root).
+  # nil when the app has no such file. Served by GET /api/v2|v3/info/version.
+  def self.app_version
+    file = Rails.root.join("version")
+    file.file? ? file.read.strip.presence : nil
+  end
+
   # Raises unless the app is UTC-only: +time_zone+ is config.time_zone, +db_zone+ is
   # config.active_record.default_timezone (nil = Rails' default, :utc). Called at boot by
   # ModelDrivenApi::Engine's :enforce_utc_time_zone initializer.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: model_driven_api
 version: !ruby/object:Gem::Version
-  version: 3.11.0
+  version: 3.11.2
 platform: ruby
 authors:
 - Gabriele Tassoni