model_attribute 3.1.1 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c1442469dac9a5931595c49246ee3da3a22e6d9b
-  data.tar.gz: 6b91c22381b05461883e96803bd633dccb543dd7
+  metadata.gz: 46443eebfd6c0b53bb687d38803ffdccfb39562e
+  data.tar.gz: 41f63196c4d17ae538d4e14acd8d2b2aa8bb45be
 SHA512:
-  metadata.gz: bef1314438464ce917392b5c9d7fdaaec78d1a034b2540441ca31b8f1671f5e9d38d684747b43b51ce612f6184532724811d8f93efa6daccbcf77739d5807880
-  data.tar.gz: eb63d59f1982222964bc54db8af7c0c11b40b7718920312418c5b4278b6e7a825f17612eb0dd9f5b71ba1e4d127ddacf417e39174f0ea39c9128c2557f39eb7f
+  metadata.gz: ead02d4451ea6044fdb1e613af619d3dd8b842ec06bd1d7a22785d5c6710e970836bef13c715322b9824efc446d27cc07b326d70adee6be81aef575eacc1196c
+  data.tar.gz: aa4e8541337cf0341799366122be1d772663ebc2f988eae15f14bf821176c389c4538554e8b4322ee6bcbf7c1257b27a3c1e30ecd21b6785a5d22907a0b1a118

data/.travis.yml

@@ -4,6 +4,7 @@ install:
 rvm:
   - "1.9.3"
   - "2.1.10"
-  - "2.2.5"
-  - "2.3.1"
-  - "jruby-9.1.5.0"
+  - "2.2.7"
+  - "2.3.4"
+  - "2.4.1"
+  - "jruby-9.1.10.0"

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to this project will be documented in this file.
 
+## 3.2.0
+
+- Support `Float` type with `:float`.
+- Tested with Ruby 2.4.
+
 ## 3.1.0
 
 - Allow strings 'true' and 'false' to be assigned to boolean attributes and be

data/README.md

@@ -212,6 +212,12 @@ Or install it yourself as:
 
     $ gem install model_attribute
 
+## Testing
+
+Running specs:
+
+    $ rspec
+
 ## Contributing
 
 1. [Fork it](https://github.com/yammer/model_attribute/fork)

data/lib/model_attribute.rb

@@ -4,7 +4,7 @@ require "model_attribute/errors"
 require "time"
 
 module ModelAttribute
-  SUPPORTED_TYPES = [:integer, :boolean, :string, :time, :json]
+  SUPPORTED_TYPES = [:integer, :float, :boolean, :string, :time, :json]
 
   def self.extended(base)
     base.send(:include, InstanceMethods)

data/lib/model_attribute/casts.rb

@@ -10,6 +10,8 @@ module ModelAttribute
           float = Float(value)
           raise ArgumentError, "Can't cast #{value.inspect} to an integer without loss of precision" unless int == float
           int
+        when :float
+          Float(value)
         when :boolean
           if !!value == value
             value

data/lib/model_attribute/version.rb

@@ -1,3 +1,3 @@
 module ModelAttribute
-  VERSION = "3.1.1"
+  VERSION = "3.2.0"
 end

data/spec/model_attributes_spec.rb

@@ -6,6 +6,7 @@ class User
   attribute :created_at,    :time
   attribute :profile,       :json
   attribute :reward_points, :integer, default: 0
+  attribute :win_rate,      :float
 
   def initialize(attributes = {})
     set_attributes(attributes)
@@ -32,14 +33,14 @@ RSpec.describe "a class using ModelAttribute" do
             User.attribute :address, :custom_type
           end.to raise_error(ModelAttribute::UnsupportedTypeError,
                              "Unsupported type :custom_type. " +
-                             "Must be one of :integer, :boolean, :string, :time, :json.")
+                             "Must be one of :integer, :float, :boolean, :string, :time, :json.")
         end
       end
     end
 
     describe ".attributes" do
       it "returns an array of attribute names as symbols" do
-        expect(User.attributes).to eq([:id, :paid, :name, :created_at, :profile, :reward_points])
+        expect(User.attributes).to eq([:id, :paid, :name, :created_at, :profile, :reward_points, :win_rate])
       end
     end
 
@@ -94,6 +95,18 @@ RSpec.describe "a class using ModelAttribute" do
       end
     end
 
+    describe "a float attribute (win_rate)" do
+      it "stores a float" do
+        user.win_rate = 35.62
+        expect(user.win_rate).to eq(35.62)
+      end
+
+      it "parses a float string" do
+        user.win_rate = 35.62
+        expect(user.win_rate).to eq(35.62)
+      end
+    end
+
     describe "a boolean attribute (paid)" do
       it "is nil when unset" do
         expect(user.paid).to be_nil
@@ -212,7 +225,7 @@ RSpec.describe "a class using ModelAttribute" do
 
       it "parses strings to date/times" do
         user.created_at = "2014-12-25 14:00:00 +0100"
-        expect(user.created_at).to eq(Time.new(2014, 12, 25, 13, 00, 00))
+        expect(user.created_at).to eq(Time.new(2014, 12, 25, 13, 00, 00, 0))
       end
 
       it "raises for unparseable strings" do
@@ -226,8 +239,8 @@ RSpec.describe "a class using ModelAttribute" do
       end
 
       it "converts DateTime to Time" do
-        user.created_at = DateTime.parse("2014-12-25 13:00:45")
-        expect(user.created_at).to eq(Time.new(2014, 12, 25, 13, 00, 45))
+        user.created_at = DateTime.parse("2014-12-25 13:00:45 +0000")
+        expect(user.created_at.utc).to eq(Time.new(2014, 12, 25, 13, 00, 45, 0))
       end
 
       it "stores nil" do
@@ -444,7 +457,7 @@ RSpec.describe "a class using ModelAttribute" do
 
       it "serializes time attributes as JSON integer" do
         user.created_at = Time.now
-        expect(changes_for_json).to include("created_at" => instance_of(Fixnum))
+        expect(changes_for_json).to include("created_at" => kind_of(Integer))
       end
     end
 
@@ -496,7 +509,7 @@ RSpec.describe "a class using ModelAttribute" do
       end
 
       it "serializes time attributes as JSON integer" do
-        expect(user.attributes_for_json).to include("created_at" => instance_of(Fixnum))
+        expect(user.attributes_for_json).to include("created_at" => kind_of(Integer))
       end
 
       it "serializes string attributes as JSON string" do
@@ -556,9 +569,10 @@ RSpec.describe "a class using ModelAttribute" do
       let(:user) do
         User.new(id: 1,
                  name: "Fred",
-                 created_at: "2014-12-25 08:00",
+                 created_at: "2014-12-25 08:00 +0000",
                  paid: true,
-                 profile: {'interests' => ['coding', 'social networks'], 'rank' => 15})
+                 profile: {'interests' => ['coding', 'social networks'], 'rank' => 15},
+                 win_rate: 35.62)
       end
 
       it "includes integer attributes as 'name: value'" do
@@ -590,7 +604,7 @@ RSpec.describe "a class using ModelAttribute" do
       end
 
       it "looks like '#<User id: 1, paid: true, name: ..., created_at: ...>'" do
-        expect(user.inspect).to eq("#<User id: 1, paid: true, name: \"Fred\", created_at: 2014-12-25 08:00:00 +0000, profile: {\"interests\"=>[\"coding\", \"social networks\"], \"rank\"=>15}, reward_points: 0>")
+        expect(user.inspect).to eq("#<User id: 1, paid: true, name: \"Fred\", created_at: 2014-12-25 08:00:00 +0000, profile: {\"interests\"=>[\"coding\", \"social networks\"], \"rank\"=>15}, reward_points: 0, win_rate: 35.62>")
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: model_attribute
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.2.0
 platform: ruby
 authors:
 - David Waller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-12 00:00:00.000000000 Z
+date: 2017-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler