model_attribute 3.0.0 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f7732b75fa197e06270fb128e6765d2f6907a11c
-  data.tar.gz: d30224be4128b258304a58b5560dbe63d854fb0e
+  metadata.gz: 50352c846ab8e95216a97c8bb1f75e98e700efcc
+  data.tar.gz: 7db758d0a583b823627949a64ce766a9555a8152
 SHA512:
-  metadata.gz: 90199911d48ea11bcab09b6e993135cf60f5b584ebfbf05192f86c5a39d9d928baea6ceeda4703a03afbc32c8be1cc4e3e3b6cfbcba983ea437f6b51ec5504ff
-  data.tar.gz: 5a87bbf29f4d0c321c764f02ea8a8a77ba9ac255ac9fdcec2f96d0f907f5bf34efb6b63cd7c4950910eee6e0d1a21a05bde8fdc09ba7960f8a7be4def71af6d3
+  metadata.gz: 1126078dd83bc04a5e92c32e397d940458195c68062a17ebeb366670cd56cbe7ecae791efd081d3a1e01a8a1b00725936a02e62813dbb804e1b723609f100f0d
+  data.tar.gz: 46dacb941d9bc0a72ca982fa8f7001a73ac3413e878f07346e2465be7d6e0b874f9922e792e1cc77b13b04c796946594e433aedceb082841e1cfafd1b8283f15

data/.rspec

@@ -1,2 +1,3 @@
 --color
 --require spec_helper
+--warnings

data/.travis.yml

@@ -1,6 +1,9 @@
 language: ruby
+install:
+- bundle install --without interactive
 rvm:
   - "1.9.3"
-  - "2.1.7"
-  - "2.2.3"
-  - "jruby-9.0.0.0"
+  - "2.1.10"
+  - "2.2.5"
+  - "2.3.1"
+  - "jruby-9.1.5.0"

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to this project will be documented in this file.
 
+## 3.1.0
+
+- Allow strings 'true' and 'false' to be assigned to boolean attributes and be
+  cast as expected.
+
 ## 3.0.0
 
 - **Breaking change**: All casting errors raise `ArgumentError`. Previously some

data/Gemfile

@@ -2,3 +2,9 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in model_attribute.gemspec
 gemspec
+
+group 'interactive' do
+  gem 'rspec-nc'
+  gem 'guard'
+  gem 'guard-rspec'
+end

data/README.md

@@ -1,4 +1,4 @@
-# ModelAttribute [![Build Status](https://travis-ci.org/yammer/model_attribute.svg?branch=master)](https://travis-ci.org/yammer/model_attribute)
+# ModelAttribute [![Gem Version](https://badge.fury.io/rb/model_attribute.svg)](http://badge.fury.io/rb/model_attribute) [![Build Status](https://travis-ci.org/yammer/model_attribute.svg?branch=master)](https://travis-ci.org/yammer/model_attribute)
 
 Simple attributes for a non-ActiveRecord model.
 
@@ -75,6 +75,10 @@ user.paid = 'f'
 user.paid # => false
 user.paid = 't'
 user.paid # => true
+user.paid = 'false'
+user.paid # => false
+user.paid = 'true'
+user.paid # => true
 
 # A :time attribute
 user.created_at = Time.now
@@ -215,3 +219,12 @@ Or install it yourself as:
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create a new Pull Request
+
+## Code of Conduct
+
+This project has adopted the [Microsoft Open Source Code of
+Conduct](https://opensource.microsoft.com/codeofconduct/). For more information
+see the [Code of Conduct
+FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact
+[opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional
+questions or comments.

data/lib/model_attribute/casts.rb

@@ -13,9 +13,9 @@ module ModelAttribute
         when :boolean
           if !!value == value
             value
-          elsif value == 't'
+          elsif value == 't' || value == 'true'
             true
-          elsif value == 'f'
+          elsif value == 'f' || value == 'false'
             false
           else
             raise ArgumentError, "Can't cast #{value.inspect} to boolean"

data/lib/model_attribute/version.rb

@@ -1,3 +1,3 @@
 module ModelAttribute
-  VERSION = "3.0.0"
+  VERSION = "3.1.0"
 end

data/model_attribute.gemspec

@@ -24,7 +24,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler",         "~> 1.7"
   spec.add_development_dependency "rake",            "~> 10.0"
   spec.add_development_dependency "rspec",           "~> 3.1"
-  spec.add_development_dependency "rspec-nc",        "~> 0.2"
-  spec.add_development_dependency "guard",           "~> 2.8"
-  spec.add_development_dependency "guard-rspec",     "~> 4.3"
 end

data/spec/model_attributes_spec.rb

@@ -119,6 +119,16 @@ RSpec.describe "a class using ModelAttribute" do
         expect(user.paid).to eq(false)
       end
 
+      it "parses 'false' to false" do
+        user.paid = 'false'
+        expect(user.paid).to eq(false)
+      end
+
+      it "parses 'true' to true" do
+        user.paid = 'true'
+        expect(user.paid).to eq(true)
+      end
+
       it "raises if passed a string it can't parse" do
         expect { user.paid = '3a' }.to raise_error(ArgumentError,
                                                    'Can\'t cast "3a" to boolean')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: model_attribute
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.1.0
 platform: ruby
 authors:
 - David Waller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-28 00:00:00.000000000 Z
+date: 2016-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,48 +52,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
-- !ruby/object:Gem::Dependency
-  name: rspec-nc
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.8'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.8'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.3'
 description: |2
       Attributes for non-ActiveRecord models.
       Smaller and simpler than Virtus, and adds dirty tracking.
@@ -140,7 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Attributes for non-ActiveRecord models