model_attribute 2.1.0 → 3.0.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ZjQzN2Q4YWFiMzRhYTA1NTI0Y2RkNDNjOGZlZjg4Zjk3ZTU1NzlkMQ==
-  data.tar.gz: !binary |-
-    ZTc1NmViMDUxNDhiNmIzMGJiYmNiMzE5ZWM2ZDFjMGVmM2EwNjQxNg==
+SHA1:
+  metadata.gz: f7732b75fa197e06270fb128e6765d2f6907a11c
+  data.tar.gz: d30224be4128b258304a58b5560dbe63d854fb0e
 SHA512:
-  metadata.gz: !binary |-
-    MzM1MDY3M2Q0ZDE4MWViNjcwNjY4ZjI5OTg1ZjJkYjY5N2JlNWM2MmQyMTUx
-    ODRjZWVmNDI2NzIxODk4MmY0YmQ0MTY3NGM0OTk5OGExMTFjY2UwM2Q0MzQ2
-    MzMyY2FlM2M3ZDk5Zjc3YjUzYTY5NmIwNjQ3NjU1NjYxYjMyMWM=
-  data.tar.gz: !binary |-
-    MmE3NmY2MmMyYmU3MmRiNzY5ZGRhNjQ3MzYxMDhlMzdiZjhlZTFiMDVhOTY3
-    MDU0M2Q1OGJjZjRkZGM5YjA3ZGYyY2E0OTBkNDUwMDAxM2Y1NmQ2MTUzOWZi
-    N2VkMmM5MzViMGQ3OWYyODljNTg3Y2E4ZGExZTVhMmQzMzgzODc=
+  metadata.gz: 90199911d48ea11bcab09b6e993135cf60f5b584ebfbf05192f86c5a39d9d928baea6ceeda4703a03afbc32c8be1cc4e3e3b6cfbcba983ea437f6b51ec5504ff
+  data.tar.gz: 5a87bbf29f4d0c321c764f02ea8a8a77ba9ac255ac9fdcec2f96d0f907f5bf34efb6b63cd7c4950910eee6e0d1a21a05bde8fdc09ba7960f8a7be4def71af6d3

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
   - "1.9.3"
-  - "2.1.5"
-  - "2.2.1"
+  - "2.1.7"
+  - "2.2.3"
+  - "jruby-9.0.0.0"

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to this project will be documented in this file.
 
+## 3.0.0
+
+- **Breaking change**: All casting errors raise `ArgumentError`. Previously some
+  errors during casting would raise `RuntimeError`.
+  Thanks to [@gotascii](https://github.com/gotascii) for the report.
+
 ## 2.1.0
 
 - **New feature**: default values.  Allows you to specify a default value like

data/README.md

@@ -12,7 +12,7 @@ Simple attributes for a non-ActiveRecord model.
  - Supports efficient serialization of attributes to JSON.
  - Mass assignment - handy for initializers.
 
-Why not [Virtus][virtus-gem]?  Virtus doesn't provide attribute tracking, and
+Why not [Virtus][virtus-gem]?  Virtus doesn't provide dirty tracking, and
 doesn't integrate with [ActiveModel::Dirty][am-dirty].  So if you're not using
 ActiveRecord, but you need attributes with dirty tracking, ModelAttribute may be
 what you're after.  For example, it works very well for a model that fronts an
@@ -24,7 +24,7 @@ Also in favor of ModelAttribute:
  - It supports efficient serialization and deserialization to/from JSON.
 
 [virtus-gem]:https://github.com/solnic/virtus
-[am-dirty]:https://github.com/rails/rails/blob/v3.0.20/activemodel/lib/active_model/dirty.rb
+[am-dirty]:https://github.com/rails/rails/blob/master/activemodel/lib/active_model/dirty.rb
 [source]:https://github.com/yammer/model_attribute/blob/master/lib/model_attribute.rb
 
 ## Usage
@@ -103,7 +103,7 @@ user.grades # => ["A", "A*", "C"]
 user.grades = 'AAB'
 user.grades # => "AAB"
 user.grades = Time.now
-# => RuntimeError: JSON only supports nil, numeric, string, boolean and arrays and hashes of those.
+# => ArgumentError: JSON only supports nil, numeric, string, boolean and arrays and hashes of those.
 
 # read_attribute and write_attribute methods
 user.read_attribute(:created_at)
@@ -126,8 +126,8 @@ Oj.dump(user.attributes_for_json, mode: :strict)
 # => "{\"id\":5,\"paid\":true,\"name\":\"Fred\",\"created_at\":1421171317762}"
 user2 = User.new(Oj.load(json, strict: true))
 
-# Change tracking.  A much smaller set of function than that provided by
-# ActiveModel::Dity.
+# Change tracking.  A much smaller set of functions than that provided by
+# ActiveModel::Dirty.
 user.changes # => {:id=>[nil, 5], :paid=>[nil, true], :created_at=>[nil, 2015-01-08 15:57:05 +0000], :name=>[nil, "Fred"]}
 user.name_changed?  # => true
 # If you need the new values to send as a PUT to a web service
@@ -137,7 +137,7 @@ user.changes_for_json # => {"id"=>5, "paid"=>true, "name"=>"Fred", "created_at"=
 user.changes.clear
 user.changes # => {}
 
-# Equality of all the attribute values match
+# Equality if all the attribute values match
 another = User.new
 another.id = 5
 another.paid = true
@@ -182,7 +182,7 @@ user.read_attribute(:name) # => "Charlie"
 user.attributes # => {:name=>"Charlie"}
 # attributes_for_json omits defaults to keep the JSON compact
 user.attributes_for_json # => {}
-# you can add them back in if you need them
+# You can add them back in if you need them
 user.attributes_for_json.merge(user.class.attribute_defaults) # => {:name=>"Charlie"}
 # A default isn't a change
 user.changes # => {}
@@ -210,7 +210,7 @@ Or install it yourself as:
 
 ## Contributing
 
-1. Fork it ( https://github.com/[my-github-username]/model_attribute/fork )
+1. [Fork it](https://github.com/yammer/model_attribute/fork)
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/lib/model_attribute/casts.rb

@@ -8,7 +8,7 @@ module ModelAttribute
         when :integer
           int = Integer(value)
           float = Float(value)
-          raise "Can't cast #{value.inspect} to an integer without loss of precision" unless int == float
+          raise ArgumentError, "Can't cast #{value.inspect} to an integer without loss of precision" unless int == float
           int
         when :boolean
           if !!value == value
@@ -18,7 +18,7 @@ module ModelAttribute
           elsif value == 'f'
             false
           else
-            raise "Can't cast #{value.inspect} to boolean"
+            raise ArgumentError, "Can't cast #{value.inspect} to boolean"
           end
         when :time
           case value
@@ -41,7 +41,7 @@ module ModelAttribute
           if valid_json?(value)
             value
           else
-            raise "JSON only supports nil, numeric, string, boolean and arrays and hashes of those."
+            raise ArgumentError, "JSON only supports nil, numeric, string, boolean and arrays and hashes of those."
           end
         else
           raise UnsupportedTypeError.new(type)

data/lib/model_attribute/version.rb

@@ -1,3 +1,3 @@
 module ModelAttribute
-  VERSION = "2.1.0"
+  VERSION = "3.0.0"
 end

data/spec/model_attributes_spec.rb

@@ -69,7 +69,7 @@ RSpec.describe "a class using ModelAttribute" do
       end
 
       it "raises when passed a float with non-zero decimal part" do
-        expect { user.id = 3.3 }.to raise_error
+        expect { user.id = 3.3 }.to raise_error(ArgumentError)
       end
 
       it "parses an integer string" do
@@ -78,7 +78,8 @@ RSpec.describe "a class using ModelAttribute" do
       end
 
       it "raises if passed a string it can't parse" do
-        expect { user.id = '3a' }.to raise_error
+        expect { user.id = '3a' }.to raise_error(ArgumentError,
+                                                 /invalid value for Integer.*: "3a"/)
       end
 
       it "stores nil" do
@@ -119,7 +120,8 @@ RSpec.describe "a class using ModelAttribute" do
       end
 
       it "raises if passed a string it can't parse" do
-        expect { user.paid = '3a' }.to raise_error
+        expect { user.paid = '3a' }.to raise_error(ArgumentError,
+                                                   'Can\'t cast "3a" to boolean')
       end
 
       it "stores nil" do
@@ -204,7 +206,8 @@ RSpec.describe "a class using ModelAttribute" do
       end
 
       it "raises for unparseable strings" do
-        expect { user.created_at = "Today, innit?" }.to raise_error
+        expect { user.created_at = "Today, innit?" }.to raise_error(ArgumentError,
+                                                        'no time information in "Today, innit?"')
       end
 
       it "converts Dates to Time" do
@@ -279,19 +282,23 @@ RSpec.describe "a class using ModelAttribute" do
       end
 
       it "raises when passed an object not supported by JSON" do
-        expect { user.profile = Object.new }.to raise_error
+        expect { user.profile = Object.new }.to raise_error(ArgumentError,
+          "JSON only supports nil, numeric, string, boolean and arrays and hashes of those.")
       end
 
       it "raises when passed a hash with a non-string key" do
-        expect { user.profile = {1 => 'first'} }.to raise_error
+        expect { user.profile = {1 => 'first'} }.to raise_error(ArgumentError,
+          "JSON only supports nil, numeric, string, boolean and arrays and hashes of those.")
       end
 
       it "raises when passed a hash with an unsupported value" do
-        expect { user.profile = {'first' => :symbol} }.to raise_error
+        expect { user.profile = {'first' => :symbol} }.to raise_error(ArgumentError,
+          "JSON only supports nil, numeric, string, boolean and arrays and hashes of those.")
       end
 
       it "raises when passed an array with an unsupported value" do
-        expect { user.profile = [1, 2, nil, :symbol] }.to raise_error
+        expect { user.profile = [1, 2, nil, :symbol] }.to raise_error(ArgumentError,
+          "JSON only supports nil, numeric, string, boolean and arrays and hashes of those.")
       end
 
       it "stores nil" do

metadata

@@ -1,110 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: model_attribute
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 3.0.0
 platform: ruby
 authors:
 - David Waller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-15 00:00:00.000000000 Z
+date: 2015-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rspec-nc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.8'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.3'
-description: ! "    Attributes for non-ActiveRecord models.\n    Smaller and simpler
-  than Virtus, and adds dirty tracking.\n"
+description: |2
+      Attributes for non-ActiveRecord models.
+      Smaller and simpler than Virtus, and adds dirty tracking.
 email:
 - dwaller@yammer-inc.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Guardfile
@@ -129,17 +130,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Attributes for non-ActiveRecord models