mock_redis 0.19.0 → 0.24.0

data/spec/commands/move_spec.rb

@@ -64,7 +64,7 @@ describe '#move(key, db)' do
     end
 
     it 'removes key from srcdb' do
-      @redises.exists(@key).should == false
+      @redises.exists?(@key).should == false
     end
 
     it 'copies key to destdb' do
@@ -81,7 +81,7 @@ describe '#move(key, db)' do
     end
 
     it 'removes key from srcdb' do
-      @redises.exists(@key).should == false
+      @redises.exists?(@key).should == false
     end
 
     it 'copies key to destdb' do
@@ -99,7 +99,7 @@ describe '#move(key, db)' do
     end
 
     it 'removes key from srcdb' do
-      @redises.exists(@key).should == false
+      @redises.exists?(@key).should == false
     end
 
     it 'copies key to destdb' do
@@ -117,7 +117,7 @@ describe '#move(key, db)' do
     end
 
     it 'removes key from srcdb' do
-      @redises.exists(@key).should == false
+      @redises.exists?(@key).should == false
     end
 
     it 'copies key to destdb' do
@@ -135,7 +135,7 @@ describe '#move(key, db)' do
     end
 
     it 'removes key from srcdb' do
-      @redises.exists(@key).should == false
+      @redises.exists?(@key).should == false
     end
 
     it 'copies key to destdb' do

data/spec/commands/mset_spec.rb

@@ -10,6 +10,14 @@ describe '#mset(key, value [, key, value, ...])' do
     @redises.mset(@key1, 1).should == 'OK'
   end
 
+  it "responds with 'OK' for passed Array with 1 item" do
+    @redises.mset([@key1, 1]).should == 'OK'
+  end
+
+  it "responds with 'OK' for passed Array with 2 items" do
+    @redises.mset([@key1, 1, @key2, 2]).should == 'OK'
+  end
+
   it 'sets the values' do
     @redises.mset(@key1, 'value1', @key2, 'value2')
     @redises.mget(@key1, @key2).should == %w[value1 value2]
@@ -26,4 +34,10 @@ describe '#mset(key, value [, key, value, ...])' do
       @redises.mset
     end.should raise_error(Redis::CommandError)
   end
+
+  it 'raises an error if given odd-sized array' do
+    lambda do
+      @redises.mset([@key1, 1, @key2])
+    end.should raise_error(Redis::CommandError)
+  end
 end

data/spec/commands/pipelined_spec.rb

@@ -39,4 +39,76 @@ describe '#pipelined' do
       future.class.should be MockRedis::Future
     end
   end
+
+  context 'with pipelined operations returning array replies' do
+    let(:key1) { 'colors' }
+    let(:key2) { 'seasons' }
+    let(:value1) { %w[blue yellow] }
+    let(:value2) { %w[summer winter] }
+
+    before do
+      @redises.rpush(key1, value1)
+      @redises.rpush(key2, value2)
+    end
+
+    after do
+      @redises.del key1
+      @redises.del key2
+    end
+
+    it 'returns an array of the array replies' do
+      results = @redises.pipelined do |_redis|
+        @redises.lrange(key1, 0, -1)
+        @redises.lrange(key2, 0, -1)
+      end
+
+      results.should == [value1, value2]
+    end
+  end
+
+  context 'with redis time return value' do
+    let(:time_stub) { double 'Time', :now => Time.new(2019, 1, 2, 3, 4, 6, '+00:00') }
+    let(:options)   { { :time_class => time_stub } }
+
+    subject { MockRedis.new(options) }
+
+    it 'returns the time value' do
+      subject.set('foo', 'bar')
+
+      results = subject.pipelined do
+        subject.get('foo')
+        subject.host # defined on MockRedis, so not captured
+        subject.time
+        subject.echo('baz')
+      end
+
+      expect(results).to eq(['bar', [1_546_398_246, 0], 'baz'])
+    end
+  end
+
+  context 'with nested pipelines' do
+    let(:key1)   { 'hello' }
+    let(:key2)   { 'world' }
+    let(:value1) { 'foo' }
+    let(:value2) { 'bar' }
+
+    before do
+      @redises.set key1, value1
+      @redises.set key2, value2
+    end
+
+    it 'returns results of the nested pipelines' do
+      results = @redises.pipelined do |pr1|
+        pr1.pipelined do |pr2|
+          pr2.get key1
+        end
+
+        pr1.pipelined do |pr2|
+          pr2.get key2
+        end
+      end
+
+      results.should == [value1, value2]
+    end
+  end
 end

data/spec/commands/restore_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe '#restore(key, ttl, value)' do
+  before do
+    @key = 'mock-redis-test:45794'
+    @src = MockRedis.new
+    @src.set(@key, '123')
+    @dumped_value = @src.dump(@key)
+    @dst = MockRedis.new
+    @now = Time.now.round
+    Time.stub(:now).and_return(@now)
+  end
+
+  it 'allows dump/restoring values between two redis instances' do
+    expect(@dst.restore(@key, 0, @dumped_value)).to eq('OK')
+    expect(@dst.get(@key)).to eq('123')
+    expect(@dst.pttl(@key)).to eq(-1)
+  end
+
+  context 'when the key being restored to already exists' do
+    before do
+      @dst.set(@key, '456')
+    end
+
+    it 'raises an error by default' do
+      expect { @dst.restore(@key, 0, @dumped_value) }.to raise_error(Redis::CommandError)
+      expect(@dst.get(@key)).to eq('456')
+    end
+
+    it 'allows replacing the key if replace==true' do
+      expect(@dst.restore(@key, 0, @dumped_value, replace: true)).to eq('OK')
+      expect(@dst.get(@key)).to eq('123')
+    end
+  end
+
+  it 'sets ttl in ms' do
+    @dst.restore(@key, 500, @dumped_value)
+    expect(@dst.pttl(@key)).to eq(500)
+  end
+
+  it 'can dump/restore more complex data types' do
+    key = 'a_hash'
+    @src.mapped_hmset(key, foo: 'bar')
+    @dst.restore(key, 0, @src.dump(key))
+    expect(@dst.hgetall(key)).to eq('foo' => 'bar')
+  end
+end

data/spec/commands/scan_spec.rb

@@ -42,6 +42,15 @@ describe '#scan' do
       end
     end
 
+    context 'when cursor is greater than collection size' do
+      let(:collection) { Array.new(count) { |i| "mock:key#{i}" } }
+      let(:expected) { ['0', []] }
+
+      it 'returns a 0 cursor and empty collection' do
+        expect(subject.scan(20, count: count, match: match)).to eq(expected)
+      end
+    end
+
     context 'when giving a custom match filter' do
       let(:match) { 'mock:key*' }
       let(:collection) { %w[mock:key mock:key2 mock:otherkey] }

data/spec/commands/set_spec.rb

@@ -33,6 +33,14 @@ describe '#set(key, value)' do
       @redises.set(key, 1, xx: true).should == true
     end
 
+    it 'raises on unknown options' do
+      key = 'mock-redis-test'
+      @redises.del(key)
+      expect do
+        @redises.set(key, 1, logger: :something)
+      end.to raise_error(ArgumentError, 'unknown keyword: logger')
+    end
+
     context '[mock only]' do
       before(:all) do
         @mock = @redises.mock
@@ -53,9 +61,11 @@ describe '#set(key, value)' do
 
       it 'accepts PX milliseconds' do
         key = 'mock-redis-test'
-        @mock.set(key, 1, px: 1000).should == 'OK'
+        @mock.set(key, 1, px: 500).should == 'OK'
         @mock.get(key).should_not be_nil
-        Time.stub(:now).and_return(@now + 2)
+        Time.stub(:now).and_return(@now + 300 / 1000.to_f)
+        @mock.get(key).should_not be_nil
+        Time.stub(:now).and_return(@now + 600 / 1000.to_f)
         @mock.get(key).should be_nil
       end
     end

data/spec/commands/setbit_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 
 describe '#setbit(key, offset)' do
   before do
+    Encoding.default_external = 'UTF-8'
     @key = 'mock-redis-test:setbit'
     @redises.set(@key, 'h') # ASCII 0x68
   end

data/spec/commands/setex_spec.rb

@@ -19,4 +19,20 @@ describe '#setex(key, seconds, value)' do
     @redises.real.ttl(@key).should > 0
     @redises.mock.ttl(@key).should > 0
   end
+
+  context 'when expiration time is zero' do
+    it 'raises Redis::CommandError' do
+      expect do
+        @redises.setex(@key, 0, 'value')
+      end.to raise_error(Redis::CommandError, 'ERR invalid expire time in setex')
+    end
+  end
+
+  context 'when expiration time is negative' do
+    it 'raises Redis::CommandError' do
+      expect do
+        @redises.setex(@key, -2, 'value')
+      end.to raise_error(Redis::CommandError, 'ERR invalid expire time in setex')
+    end
+  end
 end

data/spec/commands/spop_spec.rb

@@ -21,5 +21,20 @@ describe '#spop(key)' do
     @redises.spop(@key).should be_nil
   end
 
+  it 'returns an array if count is not nil' do
+    @redises.sadd(@key, 'value2')
+    @redises.spop(@key, 2).should == %w[value value2]
+  end
+
+  it 'returns only whats in the set' do
+    @redises.spop(@key, 2).should == ['value']
+    @redises.smembers(@key).should == []
+  end
+
+  it 'returns an empty array if count is not nil and the set it empty' do
+    @redises.spop(@key)
+    @redises.spop(@key, 100).should == []
+  end
+
   it_should_behave_like 'a set-only command'
 end

data/spec/commands/srandmember_spec.rb

@@ -37,7 +37,7 @@ describe '#srandmember(key)' do
       @redises.send_without_checking(:srandmember, @key, 2).size.should == 2
     end
 
-    it 'returns random members up to count from the set when count is negative even if count.abs is greater than the set size' do # rubocop:disable Metrics/LineLength
+    it 'returns random members up to count from the set when count is negative even if count.abs is greater than the set size' do # rubocop:disable Layout/LineLength
       @redises.send_without_checking(:srandmember, @key, -5).size.should == 5
     end
 

data/spec/commands/srem_spec.rb

@@ -36,5 +36,10 @@ describe '#srem(key, member)' do
     @redises.get(@key).should be_nil
   end
 
+  it 'allow passing an array of integers as argument' do
+    @redises.sadd(@key, %w[1 2])
+    @redises.srem(@key, [1, 2]).should == 2
+  end
+
   it_should_behave_like 'a set-only command'
 end

data/spec/commands/watch_spec.rb

@@ -1,12 +1,17 @@
 require 'spec_helper'
 
-describe '#watch(key)' do
+describe '#watch(key [, key, ...)' do
+  before do
+    @key1 = 'mock-redis-test-watch1'
+    @key2 = 'mock-redis-test-watch2'
+  end
+
   it "returns 'OK'" do
-    @redises.watch('mock-redis-test').should == 'OK'
+    @redises.watch(@key1, @key2).should == 'OK'
   end
 
   it 'EXECs its MULTI on successes' do
-    @redises.watch 'foo' do
+    @redises.watch @key1, @key2 do
       @redises.multi do |multi|
         multi.set 'bar', 'baz'
       end

data/spec/commands/xadd_spec.rb

@@ -0,0 +1,104 @@
+require 'spec_helper'
+
+describe '#xadd("mystream", { f1: "v1", f2: "v2" }, id: "0-0", maxlen: 1000, approximate: true)' do
+  before :all do
+    sleep 1 - (Time.now.to_f % 1)
+    @key = 'mock-redis-test:xadd'
+  end
+
+  before :each do
+    @redises._gsub(/\d{3}-\d/, '...-.')
+  end
+
+  it 'returns an id based on the timestamp' do
+    t = Time.now.to_i
+    expect(@redises.xadd(@key, key: 'value')).to match(/#{t}\d{3}-0/)
+  end
+
+  it 'adds data with symbols' do
+    @redises.xadd(@key, symbol_key: :symbol_value)
+    expect(@redises.xrange(@key, '-', '+').last[1])
+      .to eq('symbol_key' => 'symbol_value')
+  end
+
+  it 'increments the sequence number with the same timestamp' do
+    Timecop.freeze do
+      @redises.xadd(@key, key: 'value')
+      expect(@redises.xadd(@key, key: 'value')).to match(/\d+-1/)
+    end
+  end
+
+  it 'sets the id if it is given' do
+    expect(@redises.xadd(@key, { key: 'value' }, id: '1234567891234-2'))
+      .to eq '1234567891234-2'
+  end
+
+  it 'accepts is as an integer' do
+    expect(@redises.xadd(@key, { key: 'value' }, id: 1_234_567_891_234))
+      .to eq '1234567891234-0'
+  end
+
+  it 'raises exception if id is less that stream top item' do
+    @redises.xadd(@key, { key: 'value' }, id: '1234567891234-0')
+    expect { @redises.xadd(@key, { key: 'value' }, id: '1234567891233-0') }
+      .to raise_error(
+        Redis::CommandError,
+        'ERR The ID specified in XADD is equal or smaller than the target ' \
+        'stream top item'
+      )
+  end
+
+  it 'raises exception if id of 0 is added to an empty stream' do
+    expect { @redises.xadd('mock-redis-test:unknown-stream', { key: 'value' }, id: '0') }
+      .to raise_error(
+        Redis::CommandError,
+        'ERR The ID specified in XADD is equal or smaller than the target ' \
+        'stream top item'
+        # TOOD: Redis version 6.0.4, w redis 4.2.1 generates the following error message:
+        # 'ERR The ID specified in XADD must be greater than 0-0'
+      )
+  end
+
+  it 'does not raise exception on empty stream with id of 0 and positive sequence number' do
+    expect { @redises.xadd('mock-redis-test:unknown-stream', { key: 'value' }, id: '0-1') }
+      .to_not raise_error
+  end
+
+  it 'caters for the current time being before the last time' do
+    t = (Time.now.to_f * 1000).to_i + 2000
+    @redises.xadd(@key, { key: 'value' }, id: "#{t}-0")
+    expect(@redises.xadd(@key, key: 'value')).to match(/#{t}-1/)
+  end
+
+  it 'appends a sequence number if it is missing' do
+    expect(@redises.xadd(@key, { key: 'value' }, id: '1234567891234'))
+      .to eq '1234567891234-0'
+  end
+
+  it 'raises an invalid stream id error' do
+    expect { @redises.xadd(@key, { key: 'value' }, id: 'X') }
+      .to raise_error(
+        Redis::CommandError,
+        'ERR Invalid stream ID specified as stream command argument'
+      )
+  end
+
+  it 'caps the stream to 5 elements' do
+    @redises.xadd(@key, { key1: 'value1' }, id: '1234567891234-0')
+    @redises.xadd(@key, { key2: 'value2' }, id: '1234567891245-0')
+    @redises.xadd(@key, { key3: 'value3' }, id: '1234567891245-1')
+    @redises.xadd(@key, { key4: 'value4' }, id: '1234567891278-0')
+    @redises.xadd(@key, { key5: 'value5' }, id: '1234567891278-1')
+    @redises.xadd(@key, { key6: 'value6' }, id: '1234567891299-0')
+    @redises.xadd(@key, { key7: 'value7' }, id: '1234567891300-0', maxlen: 5)
+    expect(@redises.xrange(@key, '-', '+')).to eq(
+      [
+        ['1234567891245-1', { 'key3' => 'value3' }],
+        ['1234567891278-0', { 'key4' => 'value4' }],
+        ['1234567891278-1', { 'key5' => 'value5' }],
+        ['1234567891299-0', { 'key6' => 'value6' }],
+        ['1234567891300-0', { 'key7' => 'value7' }]
+      ]
+    )
+  end
+end

data/spec/commands/xlen_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe '#xlen(key)' do
+  before :all do
+    sleep 1 - (Time.now.to_f % 1)
+    @key = 'mock-redis-test:xlen'
+  end
+
+  before :each do
+    @redises._gsub(/\d{3}-\d/, '...-.')
+  end
+
+  it 'returns the number of items in the stream' do
+    expect(@redises.xlen(@key)).to eq 0
+    @redises.xadd(@key, key: 'value')
+    expect(@redises.xlen(@key)).to eq 1
+    3.times { @redises.xadd(@key, key: 'value') }
+    expect(@redises.xlen(@key)).to eq 4
+  end
+end