mock_redis 0.17.1 → 0.17.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a55e7d747d39e4c40aedd4b13974ea1ba8fb78a3
-  data.tar.gz: b5efc0805cac7734fa78403f18b4ee4253866197
+  metadata.gz: 293ef8fd1bbce6f4a890edc7dbf7afa1235eb885
+  data.tar.gz: 2339b903a136416a24d6630c06dde8ffcde8eee1
 SHA512:
-  metadata.gz: a0c1277f32ded504822a15d589c0c262d872593afe6a98e100cdc05e06ff5e04a39e5b8899089656de0f061dc197d632ce954550bae4fb61095df359f27bccef
-  data.tar.gz: 33183c7e84dc6d0ebc9990b44bb0ada35bbaca1a90a0ee801f94e8d240419cdcf108b9c1bf861a27f4efbc1e03a9f83052ddd3fe3c6da8a66849f71212d9e677
+  metadata.gz: ec8caa7328b7365c9b120837acd873bf535ccee1364590045d8be55989e20e4a53d00fd5952cda910826ba506d61b2a509b06e139deff5f8bd79029475c9b28c
+  data.tar.gz: 68fcb5906a717d679f2d8f3278226a0a213dc4250e314e97fdba647aaf2b3bcd9dec0640ca8db4b916dea9278d4737fce17d3b6f6de8d6288947a83c93128881

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # MockRedis Changelog
 
+### 0.17.3
+
+* Fix `zrange` behavior with negative stop argument
+
+### 0.17.2
+
+* Allow negative out-of-bounds start and stop in `zrange`
+
 ### 0.17.1
 
 * Flatten args list passed to `hmset`

data/lib/mock_redis/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 class MockRedis
-  VERSION = '0.17.1'.freeze
+  VERSION = '0.17.3'
 end

data/lib/mock_redis/zset_methods.rb

@@ -118,7 +118,9 @@ class MockRedis
 
     def zrange(key, start, stop, options = {})
       with_zset_at(key) do |z|
-        to_response(z.sorted[start.to_i..stop.to_i] || [], options)
+        start = [start.to_i, -z.sorted.size].max
+        stop = stop.to_i
+        to_response(z.sorted[start..stop] || [], options)
       end
     end
 

data/spec/commands/zrange_spec.rb

@@ -46,6 +46,26 @@ describe '#zrange(key, start, stop [, :with_scores => true])' do
     @redises.zrange(@key, 5, -1).should == []
   end
 
+  it 'returns entire list when start is out of bounds with negative end in bounds' do
+    @redises.zrange(@key, -5, -1).should == %w[Washington Adams Jefferson Madison]
+  end
+
+  it 'returns correct subset when start is out of bounds with positive end in bounds' do
+    @redises.zrange(@key, -5, 1).should == %w[Washington Adams]
+  end
+
+  it 'returns empty list when start is in bounds with negative end out of bounds' do
+    @redises.zrange(@key, 1, -5).should == []
+  end
+
+  it 'returns empty list when start is 0 with negative end out of bounds' do
+    @redises.zrange(@key, 0, -5).should == []
+  end
+
+  it 'returns correct subset when start is in bounds with negative end in bounds' do
+    @redises.zrange(@key, 1, -1).should == %w[Adams Jefferson Madison]
+  end
+
   it 'returns the scores when :with_scores is specified' do
     @redises.zrange(@key, 0, 1, :with_scores => true).
       should == [['Washington', 1.0], ['Adams', 2.0]]

data/spec/spec_helper.rb

@@ -26,6 +26,7 @@ module TypeCheckingHelper
   end
 
   def args_for_method(method)
+    return [] if method.to_s == 'spop'
     method_arity = @redises.real.method(method).arity
     if method_arity < 0 # -1 comes from def foo(*args)
       [1, 2] # probably good enough

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mock_redis
 version: !ruby/object:Gem::Version
-  version: 0.17.1
+  version: 0.17.3
 platform: ruby
 authors:
 - Brigade Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-16 00:00:00.000000000 Z
+date: 2017-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -281,7 +281,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Redis mock that just lives in memory; useful for testing.