mocha 1.0.0.alpha → 1.10.0.alpha

data/test/assertions.rb

@@ -1,6 +1,8 @@
+require 'mocha/ruby_version'
+
 module Assertions
-  def assert_method_visiblity(object, method_name, visiblity)
-    method_key = RUBY_VERSION < '1.9' ? method_name.to_s : method_name.to_sym
-    assert object.send("#{visiblity}_methods", false).include?(method_key)
+  def assert_method_visibility(object, method_name, visiblity)
+    method_key = Mocha::PRE_RUBY_V19 ? method_name.to_s : method_name.to_sym
+    assert object.send("#{visiblity}_methods").include?(method_key), "#{method_name} is not #{visiblity}"
   end
-end
+end

data/test/deprecation_disabler.rb

@@ -1,7 +1,6 @@
 require 'mocha/deprecation'
 
 module DeprecationDisabler
-
   def disable_deprecations
     original_mode = Mocha::Deprecation.mode
     Mocha::Deprecation.mode = :disabled
@@ -12,4 +11,5 @@ module DeprecationDisabler
     end
   end
 
+  module_function :disable_deprecations
 end

data/test/execution_point.rb

@@ -1,5 +1,4 @@
 class ExecutionPoint
-
   attr_reader :backtrace
 
   def self.current
@@ -10,19 +9,21 @@ class ExecutionPoint
     @backtrace = backtrace
   end
 
+  def first_relevant_line_of_backtrace
+    @backtrace && (@backtrace.reject { |l| %r{\Aorg/jruby/}.match(l) }.first || 'unknown:0')
+  end
+
   def file_name
-    return "unknown" unless @backtrace && @backtrace.first
-    /\A(.*?):\d+/.match(@backtrace.first)[1]
+    /\A(.*?):\d+/.match(first_relevant_line_of_backtrace)[1]
   end
 
   def line_number
-    return "unknown" unless @backtrace && @backtrace.first
-    Integer(/\A.*?:(\d+)/.match(@backtrace.first)[1])
+    Integer(/\A.*?:(\d+)/.match(first_relevant_line_of_backtrace)[1])
   end
 
   def ==(other)
     return false unless other.is_a?(ExecutionPoint)
-    (file_name == other.file_name) and (line_number == other.line_number)
+    (file_name == other.file_name) && (line_number == other.line_number)
   end
 
   def to_s
@@ -32,5 +33,4 @@ class ExecutionPoint
   def inspect
     to_s
   end
-
 end

data/test/integration/mini_test_test.rb

@@ -1,7 +1,7 @@
 require File.expand_path('../../test_helper', __FILE__)
 
-require "mocha/mini_test"
-require "integration/shared_tests"
+require 'mocha/minitest'
+require 'integration/shared_tests'
 
 class MiniTestTest < Mocha::TestCase
   include SharedTests

data/test/integration/shared_tests.rb

@@ -1,6 +1,7 @@
 require 'test_runner'
 require 'execution_point'
 
+# rubocop:disable Metrics/ModuleLength
 module SharedTests
   include TestRunner
 
@@ -11,6 +12,7 @@ module SharedTests
     assert_passed(test_result)
   end
 
+  # rubocop:disable Style/Semicolon
   def test_assertion_unsatisfied
     execution_point = nil
     test_result = run_as_test do
@@ -24,19 +26,19 @@ module SharedTests
   def test_mock_object_unexpected_invocation
     execution_point = nil
     test_result = run_as_test do
-      mock = mock("not expecting invocation")
+      mock = mock('not expecting invocation')
       execution_point = ExecutionPoint.current; mock.unexpected
     end
     assert_failed(test_result)
     failure = test_result.failures.first
     assert_equal execution_point, ExecutionPoint.new(failure.location)
-    assert_equal ["unexpected invocation: #<Mock:not expecting invocation>.unexpected()"], test_result.failure_message_lines
+    assert_equal ['unexpected invocation: #<Mock:not expecting invocation>.unexpected()'], test_result.failure_message_lines
   end
 
   def test_mock_object_explicitly_unexpected_invocation
     execution_point = nil
     test_result = run_as_test do
-      mock = mock("not expecting invocation")
+      mock = mock('not expecting invocation')
       mock.expects(:unexpected).never
       execution_point = ExecutionPoint.current; mock.unexpected
     end
@@ -44,25 +46,25 @@ module SharedTests
     failure = test_result.failures.first
     assert_equal execution_point, ExecutionPoint.new(failure.location)
     assert_equal [
-      "unexpected invocation: #<Mock:not expecting invocation>.unexpected()",
-      "unsatisfied expectations:",
-      "- expected never, invoked once: #<Mock:not expecting invocation>.unexpected(any_parameters)"
+      'unexpected invocation: #<Mock:not expecting invocation>.unexpected()',
+      'unsatisfied expectations:',
+      '- expected never, invoked once: #<Mock:not expecting invocation>.unexpected(any_parameters)'
     ], test_result.failure_message_lines
   end
 
   def test_mock_object_unsatisfied_expectation
     execution_point = nil
     test_result = run_as_test do
-      mock = mock("expecting invocation")
+      mock = mock('expecting invocation')
       execution_point = ExecutionPoint.current; mock.expects(:expected)
     end
     assert_failed(test_result)
     failure = test_result.failures.first
     assert_equal execution_point, ExecutionPoint.new(failure.location)
     assert_equal [
-      "not all expectations were satisfied",
-      "unsatisfied expectations:",
-      "- expected exactly once, not yet invoked: #<Mock:expecting invocation>.expected(any_parameters)"
+      'not all expectations were satisfied',
+      'unsatisfied expectations:',
+      '- expected exactly once, invoked never: #<Mock:expecting invocation>.expected(any_parameters)'
     ], test_result.failure_message_lines
   end
 
@@ -70,7 +72,7 @@ module SharedTests
     execution_point = nil
     test_result = run_as_tests(
       :setup => lambda {
-        mock = mock("not expecting invocation")
+        mock = mock('not expecting invocation')
         execution_point = ExecutionPoint.current; mock.unexpected
       },
       :test_me => lambda {
@@ -80,14 +82,14 @@ module SharedTests
     assert_failed(test_result)
     failure = test_result.failures.first
     assert_equal execution_point, ExecutionPoint.new(failure.location)
-    assert_equal ["unexpected invocation: #<Mock:not expecting invocation>.unexpected()"], test_result.failure_message_lines
+    assert_equal ['unexpected invocation: #<Mock:not expecting invocation>.unexpected()'], test_result.failure_message_lines
   end
 
   def test_mock_object_unsatisfied_expectation_in_setup
     execution_point = nil
     test_result = run_as_tests(
       :setup => lambda {
-        mock = mock("expecting invocation")
+        mock = mock('expecting invocation')
         execution_point = ExecutionPoint.current; mock.expects(:expected)
       },
       :test_me => lambda {
@@ -98,9 +100,9 @@ module SharedTests
     failure = test_result.failures.first
     assert_equal execution_point, ExecutionPoint.new(failure.location)
     assert_equal [
-      "not all expectations were satisfied",
-      "unsatisfied expectations:",
-      "- expected exactly once, not yet invoked: #<Mock:expecting invocation>.expected(any_parameters)"
+      'not all expectations were satisfied',
+      'unsatisfied expectations:',
+      '- expected exactly once, invoked never: #<Mock:expecting invocation>.expected(any_parameters)'
     ], test_result.failure_message_lines
   end
 
@@ -111,14 +113,14 @@ module SharedTests
         assert true
       },
       :teardown => lambda {
-        mock = mock("not expecting invocation")
+        mock = mock('not expecting invocation')
         execution_point = ExecutionPoint.current; mock.unexpected
       }
     )
     assert_failed(test_result)
     failure = test_result.failures.first
     assert_equal execution_point, ExecutionPoint.new(failure.location)
-    assert_equal ["unexpected invocation: #<Mock:not expecting invocation>.unexpected()"], test_result.failure_message_lines
+    assert_equal ['unexpected invocation: #<Mock:not expecting invocation>.unexpected()'], test_result.failure_message_lines
   end
 
   def test_real_object_explicitly_unexpected_invocation
@@ -133,7 +135,7 @@ module SharedTests
     assert_equal execution_point, ExecutionPoint.new(failure.location)
     assert_equal [
       "unexpected invocation: #{object.mocha_inspect}.unexpected()",
-      "unsatisfied expectations:",
+      'unsatisfied expectations:',
       "- expected never, invoked once: #{object.mocha_inspect}.unexpected(any_parameters)"
     ], test_result.failure_message_lines
   end
@@ -148,9 +150,9 @@ module SharedTests
     failure = test_result.failures.first
     assert_equal execution_point, ExecutionPoint.new(failure.location)
     assert_equal [
-      "not all expectations were satisfied",
-      "unsatisfied expectations:",
-      "- expected exactly once, not yet invoked: #{object.mocha_inspect}.expected(any_parameters)"
+      'not all expectations were satisfied',
+      'unsatisfied expectations:',
+      "- expected exactly once, invoked never: #{object.mocha_inspect}.expected(any_parameters)"
     ], test_result.failure_message_lines
   end
 
@@ -169,6 +171,8 @@ module SharedTests
     assert_failed(test_result)
     exception = test_result.errors.first.exception
     assert_equal execution_point, ExecutionPoint.new(exception.backtrace)
-    assert_match %r{undefined method `foo'}, exception.message
+    assert_match(/undefined method `foo'/, exception.message)
   end
+  # rubocop:enable Style/Semicolon
 end
+# rubocop:enable Metrics/ModuleLength

data/test/integration/test_unit_test.rb

@@ -1,7 +1,7 @@
 require File.expand_path('../../test_helper', __FILE__)
 
-require "mocha/test_unit"
-require "integration/shared_tests"
+require 'mocha/test_unit'
+require 'integration/shared_tests'
 
 class TestUnitTest < Mocha::TestCase
   include SharedTests

data/test/method_definer.rb

@@ -1,24 +1,16 @@
-require 'metaclass'
+require 'mocha/singleton_class'
 
-module Mocha
-
-  module ObjectMethods
-    def define_instance_method(method_symbol, &block)
-      __metaclass__.send(:define_method, method_symbol, block)
-    end
-
-    def replace_instance_method(method_symbol, &block)
-      raise "Cannot replace #{method_symbol} as #{self} does not respond to it." unless self.respond_to?(method_symbol)
-      define_instance_method(method_symbol, &block)
-    end
-
-    def define_instance_accessor(*symbols)
-      symbols.each { |symbol| __metaclass__.send(:attr_accessor, symbol) }
-    end
+module MethodDefiner
+  def define_instance_method(object, method_symbol, &block)
+    object.singleton_class.send(:define_method, method_symbol, block)
   end
 
-end
+  def replace_instance_method(object, method_symbol, &block)
+    raise "Cannot replace #{method_symbol} as #{self} does not respond to it." unless object.respond_to?(method_symbol)
+    define_instance_method(object, method_symbol, &block)
+  end
 
-class Object
-  include Mocha::ObjectMethods
+  def define_instance_accessor(object, *symbols)
+    symbols.each { |symbol| object.singleton_class.send(:attr_accessor, symbol) }
+  end
 end

data/test/mini_test_result.rb

@@ -2,16 +2,15 @@ require 'stringio'
 require 'minitest/unit'
 
 class MiniTestResult
-
   minitest_version = Gem::Version.new(::MiniTest::Unit::VERSION)
   if Gem::Requirement.new('<= 4.6.1').satisfied_by?(minitest_version)
-    FAILURE_PATTERN = %r{(Failure)\:\n([^\(]+)\(([^\)]+)\) \[([^\]]+)\]\:\n(.*)\n}m
-    ERROR_PATTERN   = %r{(Error)\:\n([^\(]+)\(([^\)]+)\)\:\n(.+?)\n}m
-    PATTERN_INDICES = { :method => 2, :testcase => 3 }
+    FAILURE_PATTERN = /(Failure)\:\n([^\(]+)\(([^\)]+)\) \[([^\]]+)\]\:\n(.*)\n/m
+    ERROR_PATTERN   = /(Error)\:\n([^\(]+)\(([^\)]+)\)\:\n(.+?)\n/m
+    PATTERN_INDICES = { :method => 2, :testcase => 3 }.freeze
   else
-    FAILURE_PATTERN = %r{(Failure)\:\n.([^#]+)\#([^ ]+) \[([^\]]+)\]\:\n(.*)\n}m
-    ERROR_PATTERN   = %r{(Error)\:\n.([^#]+)\#([^ ]+)\:\n(.+?)\n}m
-    PATTERN_INDICES = { :method => 3, :testcase => 2 }
+    FAILURE_PATTERN = /(Failure)\:\n.([^#]+)\#([^ ]+) \[([^\]]+)\]\:\n(.*)\n/m
+    ERROR_PATTERN   = /(Error)\:\n.([^#]+)\#([^ ]+)\:\n(.+?)\n/m
+    PATTERN_INDICES = { :method => 3, :testcase => 2 }.freeze
   end
 
   def self.parse_failure(raw)
@@ -30,7 +29,10 @@ class MiniTestResult
   class Failure
     attr_reader :method, :test_case, :location, :message
     def initialize(method, test_case, location, message)
-      @method, @test_case, @location, @message = method, test_case, location, message
+      @method = method
+      @test_case = test_case
+      @location = location
+      @message = message
     end
   end
 
@@ -38,18 +40,22 @@ class MiniTestResult
     class Exception
       attr_reader :message, :backtrace
       def initialize(message, location)
-        @message, @backtrace = message, location
+        @message = message
+        @backtrace = location
       end
     end
 
     attr_reader :method, :test_case, :exception
     def initialize(method, test_case, message, backtrace)
-      @method, @test_case, @exception = method, test_case, Exception.new(message, backtrace)
+      @method = method
+      @test_case = test_case
+      @exception = Exception.new(message, backtrace)
     end
   end
 
   def initialize(runner, tests)
-    @runner, @tests = runner, tests
+    @runner = runner
+    @tests = tests
   end
 
   def failure_count

data/test/minitest_result.rb

@@ -1,7 +1,6 @@
 require 'forwardable'
 
 class MinitestResult
-
   class Failure
     extend Forwardable
     def_delegators :@failure, :message, :backtrace
@@ -20,7 +19,7 @@ class MinitestResult
   end
 
   def failures
-    @tests.map(&:failures).flatten.select { |r| Minitest::Assertion === r }.map { |f| Failure.new(f) }
+    @tests.map(&:failures).flatten.select { |r| r.instance_of?(Minitest::Assertion) }.map { |f| Failure.new(f) }
   end
 
   def failure_count
@@ -32,7 +31,7 @@ class MinitestResult
   end
 
   def errors
-    @tests.map(&:failures).flatten.select { |r| Minitest::UnexpectedError === r }
+    @tests.map(&:failures).flatten.select { |r| r.instance_of?(Minitest::UnexpectedError) }
   end
 
   def error_count

data/test/simple_counter.rb

@@ -1,5 +1,4 @@
 class SimpleCounter
-
   attr_reader :count
 
   def initialize
@@ -9,5 +8,4 @@ class SimpleCounter
   def increment
     @count += 1
   end
-
 end

data/test/test_helper.rb

@@ -2,22 +2,26 @@ unless defined?(STANDARD_OBJECT_PUBLIC_INSTANCE_METHODS)
   STANDARD_OBJECT_PUBLIC_INSTANCE_METHODS = Object.instance_methods + Object.private_instance_methods
 end
 
-$:.unshift File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
-$:.unshift File.expand_path(File.join(File.dirname(__FILE__)))
-$:.unshift File.expand_path(File.join(File.dirname(__FILE__), 'unit'))
-$:.unshift File.expand_path(File.join(File.dirname(__FILE__), 'unit', 'parameter_matchers'))
-$:.unshift File.expand_path(File.join(File.dirname(__FILE__), 'acceptance'))
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__)))
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), 'unit'))
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), 'unit', 'parameter_matchers'))
+$LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), 'acceptance'))
 
 require 'mocha/detection/mini_test'
 
 begin
   require 'minitest'
+# rubocop:disable Lint/HandleExceptions
 rescue LoadError
 end
+# rubocop:enable Lint/HandleExceptions
 begin
   require 'minitest/unit'
+# rubocop:disable Lint/HandleExceptions
 rescue LoadError
 end
+# rubocop:enable Lint/HandleExceptions
 
 module Mocha; end
 
@@ -27,6 +31,7 @@ if (minitest_testcase = Mocha::Detection::MiniTest.testcase) && (ENV['MOCHA_RUN_
   rescue LoadError
     MiniTest::Unit.autorun
   end
+  # rubocop:disable Style/ClassAndModuleChildren
   class Mocha::TestCase < minitest_testcase
     def assert_nothing_raised(exception = StandardError)
       yield
@@ -39,12 +44,15 @@ if (minitest_testcase = Mocha::Detection::MiniTest.testcase) && (ENV['MOCHA_RUN_
     alias_method :assert_not_same, :refute_same
     alias_method :assert_no_match, :refute_match
   end
+  # rubocop:enable Style/ClassAndModuleChildren
 else
   require 'test/unit'
+  # rubocop:disable Style/ClassAndModuleChildren
   class Mocha::TestCase < Test::Unit::TestCase
     def test_dummy
       # Some versions (?) of Test::Unit try to run this base class as a test case
       # and it fails because it has no test methods, so I'm adding a dummy test.
     end
   end
+  # rubocop:enable Style/ClassAndModuleChildren
 end

data/test/test_runner.rb

@@ -7,6 +7,7 @@ module TestRunner
     run_as_tests(:test_me => block)
   end
 
+  # rubocop:disable Metrics/AbcSize
   def run_as_tests(methods = {})
     base_class = Mocha::TestCase
     test_class = Class.new(base_class) do
@@ -23,9 +24,7 @@ module TestRunner
       minitest_version = Gem::Version.new(Mocha::Detection::MiniTest.version)
       if Gem::Requirement.new('>= 5.0.0').satisfied_by?(minitest_version)
         require File.expand_path('../minitest_result', __FILE__)
-        tests.each do |test|
-          test.run
-        end
+        tests.each(&:run)
         Minitest::Runnable.runnables.delete(test_class)
         test_result = MinitestResult.new(tests)
       elsif Gem::Requirement.new('> 0.0.0', '< 5.0.0').satisfied_by?(minitest_version)
@@ -46,13 +45,14 @@ module TestRunner
 
     test_result
   end
+  # rubocop:enable Metrics/AbcSize
 
   def assert_passed(test_result)
     flunk "Test failed unexpectedly with message: #{test_result.failures}" if test_result.failure_count > 0
-    flunk "Test failed unexpectedly with message: #{test_result.errors}" if test_result.error_count > 0
+    flunk "Test failed unexpectedly with message: #{test_result.errors.map(&:exception)}" if test_result.error_count > 0
   end
 
   def assert_failed(test_result)
-    flunk "Test passed unexpectedly" unless test_result.failure_count + test_result.error_count > 0
+    flunk 'Test passed unexpectedly' unless test_result.failure_count + test_result.error_count > 0
   end
 end