mobius-client 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: f26fccdb1893d53cbb280832a4fe527a98f17c9d62bb4350cc07629caea51251
-  data.tar.gz: c2b3d55a4c15c334617d3571d1e1ad0ac1a8436685f5e965dcf1854d55d59f64
+SHA1:
+  metadata.gz: bb3a779d514fea2f8482f7843d4c2e78ce01902a
+  data.tar.gz: bf92f3da028fc789bb158f81318239d66ee84add
 SHA512:
-  metadata.gz: 62078725168f732c21c720471ab26780dce72fd19869d0177715ff69caa49aee7e29eb815b0f44e91777c48d15a0473dd6976f5b38ee335af4aa0cc346e0d664
-  data.tar.gz: fadbdb441858930947ccf18895505fd5c5c44525acb99fe365f2212bbaeced1cf15e26426215a7ad3520e1caf792963704c25d5c16930141afd0ce031c72e548
+  metadata.gz: 7f6a32e7302f77b8530e6b8f79ef84091cf69ff1902721f928bbb1392227fef2a18d9563250fb178062359e0788f97d082de26d670aa7edf485c0d476afa9794
+  data.tar.gz: b6af2c669c2a6311fe6a5ddadf55a78a9eb98d33938dd720cbdbb5d0f715b1de4320fd02a5bc7a9496e98e9921b9a7e13acadcee72fc82cba8e410540a633ed8

data/.travis.yml

@@ -9,14 +9,14 @@ rvm:
   - 2.5
 cache: bundler
 before_install:
-  - gem update --system && gem install bundler
-before_script:
+  - gem update --system && gem install --no-document bundler
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
   - chmod +x ./cc-test-reporter
+before_script:
   - ./cc-test-reporter before-build
 after_script:
   - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
 script:
   - bundle exec rake
-  - bundle exec bundle-audit update && bundle exec bundle-audit check  
+  - bundle exec bundle-audit check --update --ignore CVE-2016-10545
   - bundle exec rubocop

data/README.md

@@ -1,6 +1,7 @@
 [![Gem Version](https://badge.fury.io/rb/mobius-client.svg)](https://badge.fury.io/rb/mobius-client)
 [![Build Status](https://travis-ci.org/mobius-network/mobius-client-ruby.svg?branch=master)](https://travis-ci.org/mobius-network/mobius-client-ruby)
-[![Maintainability](https://api.codeclimate.com/v1/badges/a99a88d28ad37a79dbf6/maintainability)](https://codeclimate.com/github/codeclimate/codeclimate/maintainability)
+[![Maintainability](https://api.codeclimate.com/v1/badges/f6810e8244fc0dceb5bd/maintainability)](https://codeclimate.com/github/mobius-network/mobius-client-ruby/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/f6810e8244fc0dceb5bd/test_coverage)](https://codeclimate.com/github/mobius-network/mobius-client-ruby/test_coverage)
 
 # Mobius DApp Store Ruby SDK
 

data/lib/mobius/client/app.rb

@@ -1,4 +1,5 @@
 # Interface to user balance in application.
+# rubocop:disable Metrics/ClassLength
 class Mobius::Client::App
   extend Dry::Initializer
 
@@ -15,9 +16,18 @@ class Mobius::Client::App
     user_account.authorized?(app_keypair)
   end
 
+  # @deprecated use {#user_balance} instead
+  def balance
+    warn <<~MSG
+      [DEPRECATED] method Mobius::Client::App#balance is deprecated and will be removed,
+      use Mobius::Client::App#user_balance instead"
+    MSG
+    user_balance
+  end
+
   # Returns user balance.
   # @return [Float] User balance.
-  def balance
+  def user_balance
     validate!
     user_account.balance
   end
@@ -33,7 +43,10 @@ class Mobius::Client::App
   # @param target_address [String] Optional: third party receiver address.
   # @deprecated use {#charge} instead
   def pay(amount, target_address: nil)
-    warn "[DEPRECATED] method Mobius::Client::App#pay is deprecated and will be removed, use Mobius::Client::App#charge instead"
+    warn <<~MSG
+      [DEPRECATED] method Mobius::Client::App#pay is deprecated and will be removed,
+      use Mobius::Client::App#charge instead"
+    MSG
     charge(amount, target_address)
   end
 
@@ -77,6 +90,30 @@ class Mobius::Client::App
     handle(err)
   end
 
+  # Returns application keypair
+  # @return [Stellar::KeyPair] Application KeyPair
+  def app_keypair
+    @app_keypair ||= Mobius::Client.to_keypair(seed)
+  end
+
+  # Returns user keypair
+  # @return [Stellar::KeyPair] User KeyPair
+  def user_keypair
+    @user_keypair ||= Mobius::Client.to_keypair(address)
+  end
+
+  # Returns application account
+  # @return [Mobius::Client::Blockchain::Account] Application Account
+  def app_account
+    @app_account ||= Mobius::Client::Blockchain::Account.new(app_keypair)
+  end
+
+  # Returns user account
+  # @return [Mobius::Client::Blockchain::Account] User Account
+  def user_account
+    @user_account ||= Mobius::Client::Blockchain::Account.new(user_keypair)
+  end
+
   private
 
   def submit_tx
@@ -84,17 +121,24 @@ class Mobius::Client::App
 
     tx = Stellar::Transaction.for_account(
       account: user_keypair,
-      sequence: user_account.next_sequence_value,
+      sequence: user_account.next_sequence_value
     )
 
     yield(tx.operations)
+    calc_fee(tx)
+    txe = base64(tx)
 
-    tx.fee = FEE * tx.operations.size
-
-    txe = tx.to_envelope(app_keypair).to_xdr(:base64)
     post_txe(txe).tap { [app_account, user_account].each(&:reload!) }
   end
 
+  def calc_fee(txn)
+    txn.fee = FEE * txn.operations.size
+  end
+
+  def base64(txn)
+    txn.to_envelope(app_keypair).to_xdr(:base64)
+  end
+
   def post_txe(txe)
     Mobius::Client.horizon_client.horizon.transactions._post(tx: txe)
   end
@@ -112,22 +156,6 @@ class Mobius::Client::App
     raise Mobius::Client::Error::TrustlineMissing unless user_account.trustline_exists?
   end
 
-  def app_keypair
-    @app_keypair ||= Mobius::Client.to_keypair(seed)
-  end
-
-  def user_keypair
-    @user_keypair ||= Mobius::Client.to_keypair(address)
-  end
-
-  def app_account
-    @app_account ||= Mobius::Client::Blockchain::Account.new(app_keypair)
-  end
-
-  def user_account
-    @user_account ||= Mobius::Client::Blockchain::Account.new(user_keypair)
-  end
-
   def handle(err)
     ops = err.response.dig(:body, "extras", "result_codes", "operations")
     raise Mobius::Client::Error::AccountMissing if ops.include?("op_no_destination")
@@ -143,3 +171,4 @@ class Mobius::Client::App
 
   FEE = 100
 end
+# rubocop:enable Metrics/ClassLength

data/lib/mobius/client/blockchain/account.rb

@@ -20,7 +20,8 @@ class Mobius::Client::Blockchain::Account
   # @return [Float] Balance value.
   def balance(asset = Mobius::Client.stellar_asset)
     balance = find_balance(asset)
-    balance && balance.dig("balance").to_d
+    balance = balance&.dig("balance")
+    return balance.to_d if balance
   end
 
   # Returns true if given keypair is added as cosigner to current account.

data/lib/mobius/client/version.rb

@@ -1,5 +1,5 @@
 module Mobius
   module Client
-    VERSION = "0.3.0".freeze
+    VERSION = "0.4.0".freeze
   end
 end

data/lib/mobius/client.rb

@@ -9,10 +9,7 @@ require "jwt"
 
 require "mobius/client/version"
 
-begin
-  require "pry-byebug"
-rescue LoadError
-end
+require "pry-byebug" rescue LoadError
 
 module Mobius
   module Cli

data/mobius-client.gemspec

@@ -28,11 +28,11 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.16"
   spec.add_development_dependency "bundler-audit", "~> 0.6.0"
   spec.add_development_dependency "httplog", "~> 1.0", ">= 1.0.2"
+  spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "rake", "~> 12.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rubocop", "~> 0.53"
   spec.add_development_dependency "rubocop-rspec", "~> 1.23"
-  spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "simplecov", ">= 0.16.1"
   spec.add_development_dependency "simplecov-console", ">= 0.4.2"
   spec.add_development_dependency "timecop", "~> 0.9", ">= 0.9.1"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mobius-client
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Viktor Sokolov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-06-15 00:00:00.000000000 Z
+date: 2018-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,6 +58,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.2
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -114,20 +128,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.23'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -406,7 +406,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Mobius Ruby Client