mobility_active_storage 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4544d367fbdc080f61260f4706289e6fa009088ab73399ee5ee4efbe1597f2f
-  data.tar.gz: cb31f79f1ba41e277fe74bd2a707e3a861a756b1e6c4659434ae5dac4312a19c
+  metadata.gz: 7ed33baa135ecd69527c111652956b1420c0bce45052b3725cc5d4e55715257e
+  data.tar.gz: ff07c4fd501a56b1b57008d7f294517c5159d27ef4c7844984012251b9b49343
 SHA512:
-  metadata.gz: 260385aedbb5bf84fa7c244a669b108fa3b6a7671d48228e70f617fa2656c53bf03fc90ee1993ee3d9513b26701226dad5572afdcea6be1dd53e00253eb8c941
-  data.tar.gz: 8ffb358c2898f8ae304c43f135e97ad4105e9fa97ba419b1c6af823e8afe26f621c85f343b2f092273441f777a1f1bc50d84089ddb440283dc7283005d2337bf
+  metadata.gz: 776fef9bd8b7dffb06b3e1b4c9955bb3b5acebec0e601d265df4793dfcb98e5e7f5a12d9aeec8992cfed204b832201cbc38a7bdd5f8894edb8bcd0db418508f7
+  data.tar.gz: b62a6b3ae3dad73be4f415f1753fd3af573efb2c0e72b87fd57b09820a8a651f80e041587b95a91c7be3c0756dd3dfe9d605f282a106df4a10702d7cd2813254

data/CHANGELOG.md

@@ -1,8 +1,30 @@
 # Changelog
 
-## [Unreleased]
+## [0.1.2] - 2026-08-11
 
-Pre-release fixes from a security review of the initial commit.
+- `#{attribute}_locales` now answers in one query instead of one per configured locale. It probed
+  each locale's attachment proxy in turn, so a model declared for 73 locales issued 73 statements
+  every time it was asked -- and any caller that reads it per row (a serializer, a validation) paid
+  that per row. Pending attachment changes still take precedence over the stored rows, so a staged
+  attach counts before it is saved and a staged purge stops counting straight away.
+
+## [0.1.1] - 2026-08-10
+
+- No user-facing changes. Released to verify the trusted-publishing workflow; the packaged files
+  are identical to 0.1.0.
+
+## [0.1.0] - 2026-08-10
+
+- Initial release.
+- `has_one_translated_attached` and `has_many_translated_attached` macros on Active Record models.
+- `Mobility::Backends` registrations for `:active_storage` and `:active_storage_many`.
+- Per-locale attachments stored under locale-suffixed Active Storage attachment names
+  (`document_en`, `document_fr`), requiring no migration.
+- Opt-in per-attribute fallbacks, where reads resolve through the fallback chain while writes
+  stay in the current locale.
+- `#{attribute}_locales` and a current-locale `with_attached_#{attribute}` scope.
+
+Fixes from a security review of the initial commit, all included in this release:
 
 - A `fallback:` read option is now honoured only where the attribute actually configures
   fallbacks. Previously `document(fallback: :ja)` cross-read another locale even on an attribute
@@ -28,14 +50,3 @@ Pre-release fixes from a security review of the initial commit.
 - CI runs a Rails 7.2/8.0/latest matrix on Ruby 3.2 through 4.0, plus `bundler-audit`. Actions are
   pinned by SHA.
 - README: strong-parameters guidance for the per-locale writers, and Rails version security notes.
-
-## [0.1.0] - 2026-08-07
-
-- Initial release.
-- `has_one_translated_attached` and `has_many_translated_attached` macros on Active Record models.
-- `Mobility::Backends` registrations for `:active_storage` and `:active_storage_many`.
-- Per-locale attachments stored under locale-suffixed Active Storage attachment names
-  (`document_en`, `document_fr`), requiring no migration.
-- Opt-in per-attribute fallbacks, where reads resolve through the fallback chain while writes
-  stay in the current locale.
-- `#{attribute}_locales` and a current-locale `with_attached_#{attribute}` scope.

data/README.md

@@ -94,6 +94,10 @@ For `has_one_translated_attached :document`:
 
 `has_many_translated_attached :photos` mirrors these with `ActiveStorage::Attached::Many`.
 
+`document_locales` costs one query however many locales the attribute declares, and counts pending
+changes the way `attached?` does: a staged attach is included before it is saved, a staged purge
+excluded straight away. It does not memoize, so hold the result if you need it more than once.
+
 ### Fallbacks
 
 Off by default. Enable per attribute:

data/lib/mobility_active_storage/backend_methods.rb

@@ -50,6 +50,13 @@ module MobilityActiveStorage
         normalized_locales.include?(Mobility.normalize_locale(locale))
       end
 
+      # Every configured locale's attachment name. Memoized per attribute: the locale set is
+      # fixed when the class body runs.
+      def attachment_names(attribute)
+        @attachment_names ||= {}
+        @attachment_names[attribute] ||= normalized_locales.map { |locale| "#{attribute}_#{locale}" }
+      end
+
       # Mobility's query plugin asks the backend for an Arel node so it can build a predicate.
       # An attachment is a row in active_storage_attachments, not a comparable column value, so
       # there is nothing meaningful to compare. Fail with an explanation rather than the
@@ -136,8 +143,24 @@ module MobilityActiveStorage
     end
 
     # Yields each configured locale that actually has an attachment.
+    #
+    # One query for the whole locale set, not one per locale: every locale is a row in
+    # active_storage_attachments under a suffixed name, so which locales are present is a single
+    # pluck on that table. Probing each proxy instead costs a query per configured locale, and a
+    # model declared for a large locale set pays that on every read -- 73 statements to answer a
+    # question one statement answers.
+    #
+    # Pending changes win over the stored rows, as Active Storage's own +attached?+ does: an
+    # attach counts before it is saved, a purge stops counting straight away.
     def each_locale
-      options[:locales].each { |locale| yield locale if attached(locale).attached? }
+      persisted = persisted_attachment_names
+
+      options[:locales].each do |locale|
+        name = attachment_name(locale)
+        # attached? reads the staged change without touching the database.
+        present = model.attachment_changes.key?(name) ? attached(locale).attached? : persisted.include?(name)
+        yield locale if present
+      end
     end
 
     # The Active Storage proxy for +locale+, without any fallback handling.
@@ -149,6 +172,20 @@ module MobilityActiveStorage
 
     private
 
+    # Which of this attribute's attachment names have rows. distinct because a collection
+    # attachment repeats its name once per file, and polymorphic_name so an STI subclass looks
+    # itself up under the type Active Storage actually stored.
+    def persisted_attachment_names
+      return Set.new if model.new_record?
+
+      ActiveStorage::Attachment
+        .where(record_type: model.class.polymorphic_name, record_id: model.id,
+               name: self.class.attachment_names(attribute))
+        .distinct
+        .pluck(:name)
+        .to_set
+    end
+
     def attachment_name(locale)
       self.class.attachment_name_for(attribute, locale)
     end

data/lib/mobility_active_storage/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MobilityActiveStorage
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mobility_active_storage
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Glen Barnes
@@ -103,7 +103,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.17
+rubygems_version: 4.0.16
 specification_version: 4
 summary: Translated Active Storage attachments for Mobility.
 test_files: []