mobility 1.0.0 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d927c413815d0bd56b1f75e5b0a352d2f5832415c4e1f8c50a98fde44d973e92
-  data.tar.gz: 72d484c61b6b17b9d99e1061444d209ce66a4de70f904d68d1ce612b24656ae0
+  metadata.gz: 64a3453a8f28396a24b95987a4df6fb0fabfd3d90b03fccc47f6b82d72e77d8d
+  data.tar.gz: 81ebec57acc6a48596d826716b37239549c01b68db59572d8bf6224b0d276831
 SHA512:
-  metadata.gz: 1167adec126a34ff482d01beaa38e18e4188a79aa1be9e5031f8786d86629724984f7597c29d947ae11ad77d72c7538ecc84ed7474c70c87a3da226e81b1f59c
-  data.tar.gz: d64f21cab45ffa292e9980962d38c7f76fcaacdcac48b7d83b25fbcc0856b49b6814cefdc78e39382d7c12b944ef27ebedb23c14bffb6f819c972e8c9176cb43
+  metadata.gz: 63c3046ddce27b50708b73d78119b79b2e554bee7b92f8db843a3ea275acb91694da9c88c473e11c4ad07147bb7d9448229f44d7eb581f8d433313b7e6ecc34a
+  data.tar.gz: 56ea4ab41a4984e54c5cb3ccf75fa13f42a4afbb3248463e65235fcdf879100bef6cdf34a29a482e5e790bb043bddf0dc6cb398a5fe24682a886882c6ace1bbb

checksums.yaml.gz.sig

@@ -1,2 +1,3 @@
-Z���y�yWy��=���T�R?��6�Jl����-��a���q
��te����������&�r��Ş�I�8��KJ���@FS�I�CĔm�z��1y�/�qDIe�~:�!�/��_�8�
-Σ��U�π�Y��>�)��)�"0�_k�L���N6~#���o��P��^��5К%��\ M9�$�/)t����uԋ�^�t�ʎ@
+|�sx8qQ�/Ρ��w�ҭ|AHr<�R�n�P���j��˓)��fD	Ť\A"���'��2)��9�l�h�=���GK�X4v3���]M���_x���6�mׯ\.r�}Q��is����x�-���
���+^�xzF0����
+C��b��ɍ%�fe�I
+cl��E�&��t,�A�t����"��֡b��#S�����4ɇS'����5#�l�cIm�fvӽ=����n�L�-Ȓ

data/CHANGELOG.md

@@ -1,31 +1,73 @@
 # Mobility Changelog
 
+### Unreleased
+- Remove `Mobility::Plugins::Attributes#each`
+  ([#475](https://github.com/shioyama/mobility/pull/475))
+- Add public method `Mobility::Plugins::ActiveRecord::Query.build_query`
+  ([#471](https://github.com/shioyama/mobility/pull/471))
+- Allow setting locale per node in query block
+  ([#479](https://github.com/shioyama/mobility/pull/479))
+- Add `Mobility.validate_locale!`
+  ([#479](https://github.com/shioyama/mobility/pull/479))
+- Call after_destroy in setup block to delete associated translations
+  ([#487](https://github.com/shioyama/mobility/pull/487))
+- Add key, value and belongs_to options to key-value backend
+  ([#488](https://github.com/shioyama/mobility/pull/488)) thanks
+  [sedubois](https://github.com/sedubois)!
+
 ## 1.0
 
-1.0 is a rewrite of many internals of the gem. Please see the [wiki page on v1.0](https://github.com/shioyama/mobility/wiki/Introduction-to-Mobility-v1.0) for more details on how to upgrade.
+1.0 is a rewrite of many internals of the gem. Please see the [wiki page on
+v1.0](https://github.com/shioyama/mobility/wiki/Introduction-to-Mobility-v1.0)
+for more details on how to upgrade.
+
+### 1.0.5
+- Fix duping with AR Table backend, fixes
+  [#490](https://github.com/shioyama/mobility/issues/490)
+  ([#499](https://github.com/shioyama/mobility/pull/499) and
+  [#501](https://github.com/shioyama/mobility/pull/501))
+
+### 1.0.4
+- Correctly override default backend options, fixes
+  [#492](https://github.com/shioyama/mobility/issues/492)
+  ([#495](https://github.com/shioyama/mobility/pull/495))
+
+### 1.0.3
+- Fix `Mobility.default_backend`
+  ([#497](https://github.com/shioyama/mobility/pull/497))
+
+### 1.0.2
+
+### 1.0.1
+
+- Make `Mobility::Plugins::ActiveRecord::Query::VirtualRow` and
+  `Mobility::Plugins::ActiveRecord::Query::QueryExtension`
+  ([#471](https://github.com/shioyama/mobility/pull/471)) public
+- Fix typo in initializer template
+  ([#474](https://github.com/shioyama/mobility/pull/474))
 
-## 1.0.0
+### 1.0.0
 
 - Fix setting a locale from Rails config
 	([#468](https://github.com/shioyama/mobility/pull/468)) thanks
 	[sergey-alekseev](https://github.com/sergey-alekseev)!
 - Fixes validations with validates_uniqueness_of
   ([#470](https://github.com/shioyama/mobility/pull/470)) thanks
-  [artplan1](https://github.com/shioyama/mobility/pull/470)!
+  [artplan1](https://github.com/artplan1)!
 
-## 1.0.0.rc1 (pre-release)
+### 1.0.0.rc1 (pre-release)
 
 - Remove `Mobility::ActiveRecord`, `Mobility::Sequel` and `Mobility::Arel`, and
   general cleanup ([#464](https://github.com/shioyama/mobility/pull/464))
 
-## 1.0.0.beta2 (pre-release)
+### 1.0.0.beta2 (pre-release)
 
 - Refactor attributes & backend plugins and make `mobility_attributes` public
   ([#462](https://github.com/shioyama/mobility/pull/462))
 - Make attribute_methods plugin depend on attributes
   ([#461](https://github.com/shioyama/mobility/pull/461))
 
-## 1.0.0.beta1 (pre-release)
+### 1.0.0.beta1 (pre-release)
 
 - Remove `Mobility::Backend#apply_plugin`
   ([#454](https://github.com/shioyama/mobility/pull/454))
@@ -36,7 +78,7 @@
 - Fix Ruby 2.7 deprecation warnings
   ([#460](https://github.com/shioyama/mobility/pull/460))
 
-## 1.0.0.alpha (pre-release)
+### 1.0.0.alpha (pre-release)
 
 - Default fallbacks plugin to `true` when enabled
   ([#447](https://github.com/shioyama/mobility/pull/447))

data/Gemfile

@@ -8,20 +8,11 @@ orm, orm_version = ENV['ORM'], ENV['ORM_VERSION']
 group :development, :test do
   case orm
   when 'active_record'
-    orm_version ||= '6.0'
+    orm_version ||= '6.1'
     case orm_version
-    when '4.2'
-      gem 'activerecord', '>= 4.2.6', '< 5.0'
-    when '5.0'
-      gem 'activerecord', '>= 5.0', '< 5.1'
-    when '5.1'
-      gem 'activerecord', '>= 5.1', '< 5.2'
-    when '5.2'
-      gem 'activerecord', '>= 5.2.0', '< 5.3'
-      gem 'railties', '>= 5.2.0.rc2', '< 5.3'
-    when '6.0'
-      gem 'activerecord', '>= 6.0.0', '< 6.1'
-    when '6.1'
+    when '4.2', '5.0', '5.1', '5.2', '6.0', '6.1'
+      gem 'activerecord', "~> #{orm_version}.0"
+    when '6.2'
       git 'https://github.com/rails/rails.git' do
         gem 'activerecord'
         gem 'activesupport'
@@ -32,10 +23,8 @@ group :development, :test do
   when 'sequel'
     orm_version ||= '5'
     case orm_version
-    when '4'
-      gem 'sequel', '>= 4.46.0', '< 5.0'
     when '5'
-      gem 'sequel', '>= 5.0.0', '< 6.0.0'
+      gem 'sequel', "~> #{orm_version}.0"
     else
       raise ArgumentError, 'Invalid Sequel version'
     end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mobility (1.0.0.rc1)
+    mobility (1.0.4)
       i18n (>= 0.6.10, < 2)
       request_store (~> 1.0)
 
@@ -48,7 +48,7 @@ GEM
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.8)
     method_source (1.0.0)
-    minitest (5.14.2)
+    minitest (5.14.3)
     nenv (0.3.0)
     notiffany (0.1.3)
       nenv (~> 0.1)
@@ -83,16 +83,16 @@ GEM
     shellany (0.0.1)
     thor (1.0.1)
     thread_safe (0.3.6)
-    tzinfo (1.2.8)
+    tzinfo (1.2.9)
       thread_safe (~> 0.1)
     yard (0.9.25)
-    zeitwerk (2.4.1)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord (>= 6.0.0, < 6.1)
+  activerecord (~> 6.0.0)
   benchmark-ips
   database_cleaner (~> 1.5, >= 1.5.3)
   guard-rspec

data/README.md

@@ -13,8 +13,8 @@ Mobility
 [wiki]: https://github.com/shioyama/mobility/wiki
 
 **This is the readme for version 1.0 of Mobility. If you are using an earlier
-version (0.8.x or earlier), you probably want the readme on the [0-8-stable
-branch](https://github.com/shioyama/mobility/tree/0-8-stable).**
+version (0.8.x or earlier), you probably want the readme on the [0-8
+branch](https://github.com/shioyama/mobility/tree/0-8).**
 
 Mobility is a gem for storing and retrieving translations as attributes on a
 class. These translations could be the content of blog posts, captions on
@@ -56,12 +56,9 @@ To use the latest pre-version of Mobility 1.0, add this line to your
 application's Gemfile:
 
 ```ruby
-gem 'mobility', '~> 1.0.0'
+gem 'mobility', '~> 1.0.5'
 ```
 
-For the latest stable version of Mobility, see the readme on the
-[0-8-stable](https://github.com/shioyama/mobility/tree/0-8-stable) branch.
-
 ### ActiveRecord (Rails)
 
 Requirements:

data/lib/mobility.rb

@@ -107,7 +107,7 @@ module Mobility
     # Alias to default backend defined on *translations_class+.
     # @return [Symbol,Class]
     def default_backend
-      translations_class.defaults[:backend]
+      translations_class.defaults[:backend]&.first
     end
 
     # Configure Mobility

data/lib/mobility/backends/active_record/table.rb

@@ -274,6 +274,12 @@ columns to that table.
             define_method :initialize_dup do |source|
               super(source)
               self.send("#{association_name}=", source.send(association_name).map(&:dup))
+
+              # for cache
+              # FIXME: do this better
+              if options[:cache]
+                instance_variable_set(:"@__mobility_#{association_name}_cache", {})
+              end
             end
           end
           include const_set(module_name, dupable)

data/lib/mobility/plugin.rb

@@ -121,8 +121,8 @@ Also includes a +configure+ class method to apply plugins to a pluggable
     # Does this class include all plugins this plugin depends (directly) on?
     # @param [Class] klass Pluggable class
     def dependencies_satisfied?(klass)
-      required_plugins = dependencies.keys.map { |name| Plugins.load_plugin(name) }
-      (required_plugins - klass.included_modules).none?
+      plugin_keys = klass.included_plugins.map { |plugin| Plugins.lookup_name(plugin) }
+      (dependencies.keys - plugin_keys).none?
     end
 
     # Specifies a dependency of this plugin.

data/lib/mobility/plugins/active_record/query.rb

@@ -67,9 +67,9 @@ enabled for any one attribute on the model.
           end
         end
 
-        # Internal class to create a "clean room" for manipulating translated
-        # attribute nodes in an instance-eval'ed block. Inspired by Sequel's
-        # (much more sophisticated) virtual rows.
+        # Creates a "clean room" for manipulating translated attribute nodes in
+        # an instance-eval'ed block. Inspired by Sequel's (much more
+        # sophisticated) virtual rows.
         class VirtualRow < BasicObject
           attr_reader :__backends
 
@@ -108,7 +108,7 @@ enabled for any one attribute on the model.
             end
           end
         end
-        private_constant :QueryMethod, :VirtualRow
+        private_constant :QueryMethod
 
         module QueryExtension
           def where!(opts, *rest)
@@ -273,7 +273,7 @@ enabled for any one attribute on the model.
           end
         end
 
-        private_constant :QueryExtension, :FindByMethods
+        private_constant :FindByMethods
       end
 
       class MissingBackend < Mobility::Error; end

data/lib/mobility/plugins/backend.rb

@@ -33,13 +33,6 @@ Defines:
       def initialize(*args, **original_options)
         super
 
-        # Validate that the default backend from config has valid keys
-        if (default = self.class.defaults[:backend])
-          name, backend_options = default
-          extra_keys = backend_options.keys - backend.valid_keys
-          raise InvalidOptionKey, "These are not valid #{name} backend keys: #{extra_keys.join(', ')}." unless extra_keys.empty?
-        end
-
         include InstanceMethods
       end
 
@@ -87,7 +80,7 @@ Defines:
 
         case options[:backend]
         when String, Symbol, Class
-          @backend, @backend_options = options[:backend], options
+          @backend, @backend_options = options[:backend], options.dup
         when Array
           @backend, @backend_options = options[:backend]
           @backend_options = @backend_options.merge(original_options)
@@ -105,6 +98,14 @@ Defines:
       def validate_options(options)
         return super unless backend
         super(options.slice(*(options.keys - backend.valid_keys)))
+
+        # Validate that the default backend from config has valid keys, or if
+        # it is overridden by an array input that the array has valid keys.
+        if options[:backend].is_a?(Array)
+          name, backend_options = options[:backend]
+          extra_keys = backend_options.keys - backend.valid_keys
+          raise InvalidOptionKey, "These are not valid #{name} backend keys: #{extra_keys.join(', ')}." unless extra_keys.empty?
+        end
       end
 
       # Override default argument-handling in DSL to store kwargs passed along

data/lib/mobility/version.rb

@@ -8,7 +8,7 @@ module Mobility
   module VERSION
     MAJOR = 1
     MINOR = 0
-    TINY = 0
+    TINY = 5
     PRE = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")

data/lib/rails/generators/mobility/templates/initializer.rb

@@ -108,7 +108,7 @@ Mobility.configure do
     #
     # Adds translated attributes to +attributes+ hash, and defines methods
     # +translated_attributes+ and +untranslated_attributes+ which return hashes
-    # with translatd and untranslated attributes, respectively. Be aware that
+    # with translated and untranslated attributes, respectively. Be aware that
     # this plugin can create conflicts with other gems.
     #
     # attribute_methods

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mobility
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.5
 platform: ruby
 authors:
 - Chris Salzberg
@@ -34,7 +34,7 @@ cert_chain:
   gSQml7TqcC6dZRsZRwYqzD9kUwdAJoCqno2CBUKs2l0yQAjFT36lRrVJznb7uWwa
   xpPFnsrtyaZW6Dty8TSG3qzmeGpmpIotA8x1VA==
   -----END CERTIFICATE-----
-date: 2020-12-12 00:00:00.000000000 Z
+date: 2021-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: request_store