mobility 0.8.13 → 1.0.0.alpha

data/lib/mobility/backends/active_record/hstore.rb

@@ -32,5 +32,7 @@ Implements the {Mobility::Backends::Hstore} backend for ActiveRecord models.
         end
       end
     end
+
+    register_backend(:active_record_hstore, ActiveRecord::Hstore)
   end
 end

data/lib/mobility/backends/active_record/json.rb

@@ -40,5 +40,7 @@ Implements the {Mobility::Backends::Json} backend for ActiveRecord models.
         end
       end
     end
+
+    register_backend(:active_record_json, ActiveRecord::Json)
   end
 end

data/lib/mobility/backends/active_record/jsonb.rb

@@ -40,5 +40,7 @@ Implements the {Mobility::Backends::Jsonb} backend for ActiveRecord models.
         end
       end
     end
+
+    register_backend(:active_record_jsonb, ActiveRecord::Jsonb)
   end
 end

data/lib/mobility/backends/active_record/key_value.rb

@@ -39,7 +39,7 @@ Implements the {Mobility::Backends::KeyValue} backend for ActiveRecord models.
             options[:association_name] ||= :"#{options[:type]}_translations"
             options[:class_name]       ||= Mobility::ActiveRecord.const_get("#{type.capitalize}Translation")
           end
-          options[:table_alias_affix] = "#{options[:model_class]}_%s_#{options[:association_name]}"
+          options[:table_alias_affix] = "#{model_class}_%s_#{options[:association_name]}"
         rescue NameError
           raise ArgumentError, "You must define a Mobility::ActiveRecord::#{type.capitalize}Translation class."
         end
@@ -119,7 +119,7 @@ Implements the {Mobility::Backends::KeyValue} backend for ActiveRecord models.
       # The title predicate has a non-nil value, so we can use an INNER JOIN,
       # whereas we are searching for nil content, which requires an OUTER JOIN.
       #
-      class Visitor < Arel::Visitor
+      class Visitor < ::Mobility::Arel::Visitor
         private
 
         def visit_Arel_Nodes_Equality(object)
@@ -137,7 +137,7 @@ Implements the {Mobility::Backends::KeyValue} backend for ActiveRecord models.
         alias :visit_Array :visit_collection
 
         def visit_Arel_Nodes_Or(object)
-          [object.left, object.right].map(&method(:visit)).compact.inject(&:merge).
+          [object.left, object.right].map(&method(:visit)).compact.inject(:merge).
             transform_values { OUTER_JOIN }
         end
 
@@ -212,5 +212,7 @@ Implements the {Mobility::Backends::KeyValue} backend for ActiveRecord models.
         end
       end
     end
+
+    register_backend(:active_record_key_value, ActiveRecord::KeyValue)
   end
 end

data/lib/mobility/backends/active_record/pg_hash.rb

@@ -30,7 +30,7 @@ Internal class used by ActiveRecord backends backed by a Postgres data type
 
         class Coder
           def self.dump(obj)
-            if obj.is_a? Hash
+            if obj.is_a? ::Hash
               obj.inject({}) do |translations, (locale, value)|
                 translations[locale] = value if value.present?
                 translations

data/lib/mobility/backends/active_record/serialized.rb

@@ -72,5 +72,7 @@ Implements {Mobility::Backends::Serialized} backend for ActiveRecord models.
         EOM
       end
     end
+
+    register_backend(:active_record_serialized, ActiveRecord::Serialized)
   end
 end

data/lib/mobility/backends/active_record/table.rb

@@ -101,7 +101,7 @@ columns to that table.
         # @option options [Symbol] subclass_name (:Translation) Name of subclass
         #   to append to model class to generate translation class
         def configure(options)
-          table_name = options[:model_class].table_name
+          table_name = model_class.table_name
           options[:table_name]  ||= "#{table_name.singularize}_translations"
           options[:foreign_key] ||= table_name.downcase.singularize.camelize.foreign_key
           if (association_name = options[:association_name]).present?
@@ -153,7 +153,7 @@ columns to that table.
         def already_joined?(relation, locale, join_type)
           if join = get_join(relation, locale)
             return true if (join_type == Visitor::OUTER_JOIN) || (Visitor::INNER_JOIN === join)
-            relation.joins_values = relation.joins_values - [join]
+            relation.joins_values -= [join]
           end
           false
         end
@@ -265,7 +265,7 @@ columns to that table.
           touch: true
 
         before_save do
-          required_attributes = self.class.mobility_attributes & translation_class.attribute_names
+          required_attributes = translation_class.attribute_names.select { |name| self.class.mobility_attribute?(name) }
           send(association_name).destroy_empty_translations(required_attributes)
         end
 
@@ -304,5 +304,7 @@ columns to that table.
         end
       end
     end
+
+    register_backend(:active_record_table, ActiveRecord::Table)
   end
 end

data/lib/mobility/backends/column.rb

@@ -27,8 +27,6 @@ be ignored if set, since it would cause a conflict with column accessors.
 
 =end
     module Column
-      extend Backend::OrmDelegator
-
       # Returns name of column where translated attribute is stored
       # @param [Symbol] locale
       # @return [String]
@@ -44,10 +42,6 @@ be ignored if set, since it would cause a conflict with column accessors.
         normalized_locale = Mobility.normalize_locale(locale)
         "#{attribute}_#{normalized_locale}".to_sym
       end
-
-      def self.included(base)
-        base.extend Backend::OrmDelegator
-      end
     end
   end
 end

data/lib/mobility/backends/container.rb

@@ -19,7 +19,8 @@ stored).
 
 =end
     module Container
-      extend Backend::OrmDelegator
     end
+
+    register_backend(:container, Container)
   end
 end

data/lib/mobility/backends/hash.rb

@@ -0,0 +1,39 @@
+module Mobility
+  module Backends
+=begin
+
+Backend which stores translations in an in-memory hash.
+
+=end
+    class Hash
+      include Backend
+
+      # @!group Backend Accessors
+      # @!macro backend_reader
+      # @return [Object]
+      def read(locale, _ = {})
+        translations[locale]
+      end
+
+      # @!macro backend_writer
+      # @return [Object]
+      def write(locale, value, _ = {})
+        translations[locale] = value
+      end
+      # @!endgroup
+
+      # @!macro backend_iterator
+      def each_locale
+        translations.each { |l, _| yield l }
+      end
+
+      private
+
+      def translations
+        @translations ||= {}
+      end
+    end
+
+    register_backend(:hash, Hash)
+  end
+end

data/lib/mobility/backends/hstore.rb

@@ -17,7 +17,6 @@ Prefix and suffix to add to attribute name to generate hstore column name.
 
 =end
     module Hstore
-      extend Backend::OrmDelegator
     end
   end
 end

data/lib/mobility/backends/json.rb

@@ -16,7 +16,6 @@ Prefix and suffix to add to attribute name to generate json column name.
 
 =end
     module Json
-      extend Backend::OrmDelegator
     end
   end
 end

data/lib/mobility/backends/jsonb.rb

@@ -16,7 +16,6 @@ Prefix and suffix to add to attribute name to generate jsonb column name.
 
 =end
     module Jsonb
-      extend Backend::OrmDelegator
     end
   end
 end

data/lib/mobility/backends/key_value.rb

@@ -44,8 +44,6 @@ other backends on model (otherwise one will overwrite the other).
 
 =end
     module KeyValue
-      extend Backend::OrmDelegator
-
       # @!method association_name
       #   Returns the name of the polymorphic association.
       #   @return [Symbol] Name of the association
@@ -87,7 +85,7 @@ other backends on model (otherwise one will overwrite the other).
       module ClassMethods
         # @!group Backend Configuration
         # @option options [Symbol,String] type Column type to use
-        # @option options [Symbol] associaiton_name (:<type>_translations) Name
+        # @option options [Symbol] association_name (:<type>_translations) Name
         #   of association method, defaults to +<type>_translations+
         # @option options [Symbol] class_name Translation class, defaults to
         #   +Mobility::<ORM>::<type>Translation+
@@ -98,20 +96,13 @@ other backends on model (otherwise one will overwrite the other).
           options[:association_name] &&= options[:association_name].to_sym
           options[:class_name]       &&= Util.constantize(options[:class_name])
           if !(options[:type] || (options[:class_name] && options[:association_name]))
-            # TODO: Remove warning and raise ArgumentError in v1.0
-            warn %{
-WARNING: In previous versions, the Mobility KeyValue backend defaulted to a
-text type column, but this behavior is now deprecated and will be removed in
-the next release. Either explicitly specify the type by passing type: :text in
-each translated model, or set a default option in your configuration.
-  }
-            options[:type] = :text
+            raise ArgumentError, "KeyValue backend requires an explicit type option, either text or string."
           end
         end
 
         # Apply custom processing for plugin
-        # @param (see Backend::Setup#apply_plugin)
-        # @return (see Backend::Setup#apply_plugin)
+        # @param (see Backend::ClassMethods#apply_plugin)
+        # @return (see Backend::ClassMethods#apply_plugin)
         def apply_plugin(name)
           if name == :cache
             include self::Cache
@@ -127,7 +118,24 @@ each translated model, or set a default option in your configuration.
       end
 
       module Cache
-        include Plugins::Cache::TranslationCacher.new(:translation_for)
+        def translation_for(locale, **options)
+          return super(locale, options) if options.delete(:cache) == false
+          if cache.has_key?(locale)
+            cache[locale]
+          else
+            cache[locale] = super(locale, options)
+          end
+        end
+
+        def clear_cache
+          @cache = {}
+        end
+
+        private
+
+        def cache
+          @cache ||= {}
+        end
       end
     end
   end

data/lib/mobility/backends/null.rb

@@ -20,5 +20,7 @@ Backend which does absolutely nothing. Mostly for testing purposes.
       def self.configure(_); end
       # @!endgroup
     end
+
+    register_backend(:null, Null)
   end
 end

data/lib/mobility/backends/sequel.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+require "mobility/backend"
+
 module Mobility
   module Backends
     module Sequel

data/lib/mobility/backends/sequel/column.rb

@@ -50,5 +50,7 @@ Implements the {Mobility::Backends::Column} backend for Sequel models.
         end.compact
       end
     end
+
+    register_backend(:sequel_column, Sequel::Column)
   end
 end

data/lib/mobility/backends/sequel/container.rb

@@ -44,7 +44,7 @@ Implements the {Mobility::Backends::Container} backend for Sequel models.
       def self.configure(options)
         options[:column_name] ||= :translations
         options[:column_name] = options[:column_name].to_sym
-        column_name, db_schema = options[:column_name], options[:model_class].db_schema
+        column_name, db_schema = options[:column_name], model_class.db_schema
         options[:column_type] = db_schema[column_name] && (db_schema[column_name][:db_type]).to_sym
         unless %i[json jsonb].include?(options[:column_type])
           raise InvalidColumnType, "#{options[:column_name]} must be a column of type json or jsonb"
@@ -114,5 +114,7 @@ Implements the {Mobility::Backends::Container} backend for Sequel models.
         end
       end
     end
+
+    register_backend(:sequel_container, Sequel::Container)
   end
 end

data/lib/mobility/backends/sequel/hstore.rb

@@ -35,5 +35,7 @@ Implements the {Mobility::Backends::Hstore} backend for Sequel models.
         class HStoreOp < ::Sequel::Postgres::HStoreOp; end
       end
     end
+
+    register_backend(:sequel_hstore, Sequel::Hstore)
   end
 end

data/lib/mobility/backends/sequel/json.rb

@@ -42,5 +42,7 @@ Implements the {Mobility::Backends::Json} backend for Sequel models.
         class JSONOp < ::Sequel::Postgres::JSONOp; end
       end
     end
+
+    register_backend(:sequel_json, Sequel::Json)
   end
 end

data/lib/mobility/backends/sequel/jsonb.rb

@@ -55,7 +55,7 @@ Implements the {Mobility::Backends::Jsonb} backend for Sequel models.
 
           def =~(other)
             case other
-            when Integer, Hash
+            when Integer, ::Hash
               to_dash_arrow =~ other.to_json
             when NilClass
               ~to_question
@@ -66,5 +66,7 @@ Implements the {Mobility::Backends::Jsonb} backend for Sequel models.
         end
       end
     end
+
+    register_backend(:sequel_jsonb, Sequel::Jsonb)
   end
 end

data/lib/mobility/backends/sequel/key_value.rb

@@ -36,7 +36,7 @@ Implements the {Mobility::Backends::KeyValue} backend for Sequel models.
             options[:association_name] ||= :"#{options[:type]}_translations"
             options[:class_name]       ||= Mobility::Sequel.const_get("#{type.capitalize}Translation")
           end
-          options[:table_alias_affix] = "#{options[:model_class]}_%s_#{options[:association_name]}"
+          options[:table_alias_affix] = "#{model_class}_%s_#{options[:association_name]}"
         rescue NameError
           raise ArgumentError, "You must define a Mobility::Sequel::#{type.capitalize}Translation class."
         end
@@ -93,7 +93,7 @@ Implements the {Mobility::Backends::KeyValue} backend for Sequel models.
               join_type = nils.empty? ? :inner : :left_outer
               # TODO: simplify to hash.transform_values { join_type } when
               #   support for Ruby 2.3 is deprecated
-              Hash[hash.keys.map { |key| [key, join_type] }]
+              ::Hash[hash.keys.map { |key| [key, join_type] }]
             else
               {}
             end
@@ -101,13 +101,13 @@ Implements the {Mobility::Backends::KeyValue} backend for Sequel models.
             hash = visit(boolean.args, locale)
             # TODO: simplify to hash.transform_values { :inner } when
             #   support for Ruby 2.3 is deprecated
-            Hash[hash.keys.map { |key| [key, :inner] }]
+            ::Hash[hash.keys.map { |key| [key, :inner] }]
           elsif boolean.op == :OR
             hash = boolean.args.map { |op| visit(op, locale) }.
-              compact.inject(&:merge)
+              compact.inject(:merge)
             # TODO: simplify to hash.transform_values { :left_outer } when
             #   support for Ruby 2.3 is deprecated
-            Hash[hash.keys.map { |key| [key, :left_outer] }]
+            ::Hash[hash.keys.map { |key| [key, :left_outer] }]
           else
             visit(boolean.args, locale)
           end
@@ -153,7 +153,7 @@ Implements the {Mobility::Backends::KeyValue} backend for Sequel models.
           end
           define_method :after_save do
             super()
-            attributes.each { |attribute| public_send(Backend.method_name(attribute)).save_translations }
+            attributes.each { |attribute| mobility_backends[attribute].save_translations }
           end
         end
         include callback_methods
@@ -202,5 +202,7 @@ Implements the {Mobility::Backends::KeyValue} backend for Sequel models.
         end
       end
     end
+
+    register_backend(:sequel_key_value, Sequel::KeyValue)
   end
 end

data/lib/mobility/backends/sequel/serialized.rb

@@ -110,5 +110,7 @@ Sequel serialization plugin.
         super.to_sym
       end
     end
+
+    register_backend(:sequel_serialized, Sequel::Serialized)
   end
 end

data/lib/mobility/backends/sequel/table.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 require "mobility/util"
 require "mobility/backends/sequel"
-require "mobility/backends/key_value"
+require "mobility/backends/table"
+require "mobility/sequel/column_changes"
 require "mobility/sequel/model_translation"
 require "mobility/sequel/sql"
 
@@ -34,7 +35,7 @@ Implements the {Mobility::Backends::Table} backend for Sequel models.
         # @raise [CacheRequired] if cache option is false
         def configure(options)
           raise CacheRequired, "Cache required for Sequel::Table backend" if options[:cache] == false
-          table_name = Util.singularize(options[:model_class].table_name)
+          table_name = Util.singularize(model_class.table_name)
           options[:table_name]  ||= :"#{table_name}_translations"
           options[:foreign_key] ||= Util.foreign_key(Util.camelize(table_name.downcase))
           if association_name = options[:association_name]
@@ -175,5 +176,7 @@ Implements the {Mobility::Backends::Table} backend for Sequel models.
 
       class CacheRequired < ::StandardError; end
     end
+
+    register_backend(:sequel_table, Sequel::Table)
   end
 end

data/lib/mobility/backends/serialized.rb

@@ -23,8 +23,6 @@ Format for serialization. Either +:yaml+ (default) or +:json+.
 
 =end
     module Serialized
-      extend Backend::OrmDelegator
-
       class << self
 
         # @!group Backend Configuration
@@ -40,7 +38,7 @@ Format for serialization. Either +:yaml+ (default) or +:json+.
         def serializer_for(format)
           lambda do |obj|
             return if obj.nil?
-            if obj.is_a? Hash
+            if obj.is_a? ::Hash
               obj = obj.inject({}) do |translations, (locale, value)|
                 translations[locale] = value.to_s if Util.present?(value)
                 translations