mobility 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7758652b17c028026785aab433d317fa8508b3b1
-  data.tar.gz: 359c5dd578fe9f7d2f1cb3aef187aacbf3a12246
+  metadata.gz: c42bb66ac64ed65434f7550515f60ab7907001d6
+  data.tar.gz: 8a977f61b918d4ff6f0f23f6accb810b15c4d3d5
 SHA512:
-  metadata.gz: 42dc9e922f1da3baccad99b8acaff68b7ff7f69623b700ba71b698337c2d21dd78ec53b07d533d7c3cfb732d4f44b999506e31103ab2027e591146ddb65556be
-  data.tar.gz: ce8545687458395b0817ef6f478262664478afcc6a3b9d22441d1eae61268f8d705deacef2ba30f01e2573bafc688f4d51d813cf62bfe444bf5bce3cfb93c9c7
+  metadata.gz: 3974c3e07c18c765342863943d098eed06ff944ff8339029bf3e24c27d81c0462688798706e771595a83ebc7fc36c99f156f65de35d27a68aab9bfe56e87103a
+  data.tar.gz: 2105d1889d4c54dafdcf41f98c2a76ee7e09773df1166caa86d31b7e320495a7e080757a9c8ec061472d341b86a35bb6059f8f981a6efe787fc7c5d39d388921

data/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## 0.3
 
+### 0.3.2 (December 1, 2017)
+* Fix issue with querying on translated attributes with Sequel Table backend ([#121](https://github.com/shioyama/mobility/pull/121))
+
 ### 0.3.1 (December 1, 2017)
 * Disable AR::Dirty method overrides for AR >= 5.2 (and < 5.1 for `has_attribute`) ([#120](https://github.com/shioyama/mobility/pull/120))
 

data/Gemfile

@@ -10,8 +10,8 @@ group :development, :test do
     elsif ENV['RAILS_VERSION'] == '4.2'
       gem 'activerecord', '>= 4.2.6', '< 5.0'
     elsif ENV['RAILS_VERSION'] == '5.2'
-      gem 'activerecord', '>= 5.2.0.beta1'
-      gem 'railties', '>= 5.2.0.beta1'
+      gem 'activerecord', '>= 5.2.0.beta1', '< 5.3'
+      gem 'railties', '>= 5.2.0.beta1', '< 5.3'
     else
       gem 'activerecord', '>= 5.1', '< 5.2'
     end
@@ -19,8 +19,8 @@ group :development, :test do
   elsif ENV['ORM'] == 'sequel'
     if ENV['SEQUEL_VERSION'] == '4.41'
       gem 'sequel', '>= 4.41.0', '< 4.46.0'
-    elsif ENV['SEQUEL_VERSION'] == 'latest'
-      gem 'sequel', '>= 5.0.0'
+    elsif ENV['SEQUEL_VERSION'] == '5.0'
+      gem 'sequel', '>= 5.0.0', '< 6.0.0'
     else
       gem 'sequel', '>= 4.46.0', '< 5.0'
     end

data/Gemfile.lock

@@ -1,51 +1,20 @@
 PATH
   remote: .
   specs:
-    mobility (0.3.0)
+    mobility (0.3.1)
       i18n (>= 0.6.10, < 0.10)
       request_store (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (5.1.4)
-      actionview (= 5.1.4)
-      activesupport (= 5.1.4)
-      rack (~> 2.0)
-      rack-test (>= 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.1.4)
-      activesupport (= 5.1.4)
-      builder (~> 3.1)
-      erubi (~> 1.4)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activemodel (5.1.4)
-      activesupport (= 5.1.4)
-    activerecord (5.1.4)
-      activemodel (= 5.1.4)
-      activesupport (= 5.1.4)
-      arel (~> 8.0)
-    activesupport (5.1.4)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    arel (8.0.0)
-    builder (3.2.3)
     byebug (9.1.0)
     coderay (1.1.2)
     concurrent-ruby (1.0.5)
-    crass (1.0.3)
     database_cleaner (1.6.2)
     diff-lcs (1.3)
-    erubi (1.7.0)
     ffi (1.9.18)
     formatador (0.2.5)
-    generator_spec (0.9.4)
-      activesupport (>= 3.0.0)
-      railties (>= 3.0.0)
     guard (2.14.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
@@ -66,17 +35,10 @@ GEM
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
       ruby_dep (~> 1.2)
-    loofah (2.1.1)
-      crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
     lumberjack (1.0.12)
     method_source (0.9.0)
-    mini_portile2 (2.3.0)
-    minitest (5.10.3)
     mysql2 (0.4.10)
     nenv (0.3.0)
-    nokogiri (1.8.1)
-      mini_portile2 (~> 2.3.0)
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
@@ -87,20 +49,6 @@ GEM
     pry-byebug (3.5.1)
       byebug (~> 9.1)
       pry (~> 0.10)
-    rack (2.0.3)
-    rack-test (0.8.2)
-      rack (>= 1.0, < 3)
-    rails-dom-testing (2.0.3)
-      activesupport (>= 4.2.0)
-      nokogiri (>= 1.6)
-    rails-html-sanitizer (1.0.3)
-      loofah (~> 2.0)
-    railties (5.1.4)
-      actionpack (= 5.1.4)
-      activesupport (= 5.1.4)
-      method_source
-      rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
     rake (12.3.0)
     rb-fsevent (0.10.2)
     rb-inotify (0.9.10)
@@ -120,22 +68,18 @@ GEM
       rspec-support (~> 3.7.0)
     rspec-support (3.7.0)
     ruby_dep (1.5.0)
+    sequel (5.2.0)
     shellany (0.0.1)
     sqlite3 (1.3.13)
     thor (0.20.0)
-    thread_safe (0.3.6)
-    tzinfo (1.2.4)
-      thread_safe (~> 0.1)
     yard (0.9.12)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord (>= 5.1, < 5.2)
   bundler (~> 1.12)
   database_cleaner (~> 1.5, >= 1.5.3)
-  generator_spec (~> 0.9.4)
   guard-rspec
   mobility!
   mysql2 (~> 0.4.9)
@@ -143,6 +87,7 @@ DEPENDENCIES
   pry-byebug
   rake (~> 12, >= 12.2.1)
   rspec (~> 3.0)
+  sequel (>= 5.0.0, < 6.0.0)
   sqlite3
   yard (~> 0.9.0)
 

data/README.md

@@ -52,7 +52,7 @@ Installation
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'mobility', '~> 0.3.1'
+gem 'mobility', '~> 0.3.2'
 ```
 
 Mobility is cryptographically signed. To be sure the gem you install hasn't

data/Rakefile

@@ -37,7 +37,13 @@ namespace :db do
 
   desc "Set up the database schema"
   task up: :setup do
-    require "spec_helper"
+    orm = ENV['ORM']
+    return unless orm
+
+    require orm
+    require "database"
+    require "#{orm}/schema"
+    DB = Mobility::Test::Database.connect(orm)
     Mobility::Test::Schema.up
   end
 

data/lib/mobility/backends/sequel/table/query_methods.rb

@@ -19,8 +19,11 @@ module Mobility
 
       def define_join_method(association_name, translation_class, table_name: nil, foreign_key: nil, **)
         define_method :"join_#{association_name}" do |**options|
-          return self if (@__mobility_table_joined || []).include?(table_name)
-          (@__mobility_table_joined ||= []) << table_name
+          if joins = @opts[:join]
+            # Return self if we've already joined this table
+            return self if joins.find { |clause| clause.table_expr == table_name }
+          end
+
           join_type = options[:outer_join] ? :left_outer : :inner
           join_table(join_type,
                      translation_class.table_name,

data/lib/mobility/version.rb

@@ -1,3 +1,3 @@
 module Mobility
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mobility
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Chris Salzberg