mobile_workflow 0.7.2 → 0.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a72db383d64200fbddcb0c8f342efd48aa8ddb78ef6508d80fe5a0b15f76ac8
-  data.tar.gz: d012d60e72823b8b44522d18fa714015fcdcc8ad4d177a6876f535af98a63788
+  metadata.gz: 0d2de8e8e58abbf48c61361f6e1f29743fb4503ea9903c2b8a262e1e8c5419f0
+  data.tar.gz: 7f4021ded5e08c6f4f1a66cc69556c47d6dc57b6f099c206dc9bdb3f892a7135
 SHA512:
-  metadata.gz: '099e9983d4bcf1c6d3d1597ea2a100f37bed39479e9310db5ae3522004af62ee9632bf68696ed7719212c136da5ad5f6618c855ff7317fd501608c7e972e567e'
-  data.tar.gz: fdc5298cb5bdee746c241a3fd5b114b34d2fb17a8234f7810d3cf0fc1c302ab9070817ff34814afc897994a4e9e700cec84e60decc0f5148c286ba7b43c9a986
+  metadata.gz: 071d242cfba279223971ff929acaba7285e017b5c836be68ba5f02ad46a4571d39c98ea25de67d4b6ea586b4bdded534f6fae1cac27ebc53e3f8ba642ec01c33
+  data.tar.gz: 8d4ce06b17e4b3d4cd327c5d65f6035065e098456e39d10e420f287b5c545d8524899870c00bb893587ef4c4c72587e98193b8fdf78dde74671f32d0cf0d7083

data/app/controllers/concerns/mobile_workflow/s3_storable.rb

@@ -4,16 +4,17 @@ module MobileWorkflow
       extend ActiveSupport::Concern
       
       def binary_urls(object)
-        return unless params["binaries"]
+        return unless params[:binaries]
     
-        params["binaries"].map do |binary|
-          object_attribute = binary["identifier"]
-          extension = binary["mimetype"].split('/')[1] # i.e. image/jpg --> jpg, video/mp4 --> mp4
+        params[:binaries].map do |binary|
+          identifier = binary[:identifier]
+          object_attribute = identifier.split(".")[0] # ensure extension doesnt get added here
+          extension = binary[:mimetype].split('/')[1] # i.e. image/jpg --> jpg, video/mp4 --> mp4
       
           {
-            "identifier" => binary["identifier"],
-            "url" => presigned_url("#{object.class.name.underscore}/#{object.id}/#{object_attribute}/#{s3_object_uuid}.#{extension}"),
-            "method" => "PUT"
+            identifier: identifier,
+            url: presigned_url("#{object.class.name.underscore}/#{object.id}/#{object_attribute}/#{s3_object_uuid}.#{extension}"),
+            method: "PUT"
           }
         end
       end

data/app/models/concerns/mobile_workflow/displayable.rb

@@ -140,9 +140,9 @@ module MobileWorkflow
       return nil unless attachment.attached?
 
       if attachment.image?
-        Rails.application.routes.url_helpers.rails_representation_url(attachment.variant(options), host: attachment_host)
+        Rails.application.routes.url_helpers.rails_representation_url(attachment.variant(options), host: heroku_attachment_host)
       elsif attachment.previewable?
-        Rails.application.routes.url_helpers.rails_representation_url(attachment.preview(options), host: attachment_host)
+        Rails.application.routes.url_helpers.rails_representation_url(attachment.preview(options), host: heroku_attachment_host)
       else
         return nil
       end
@@ -151,11 +151,13 @@ module MobileWorkflow
     def attachment_url(attachment)
       return nil unless attachment.attached?
     
-      Rails.application.routes.url_helpers.rails_blob_url(attachment, host: attachment_host)
+      Rails.application.routes.url_helpers.rails_blob_url(attachment, host: heroku_attachment_host)
     end
 
-    def attachment_host
-      "https://#{ENV.fetch('HEROKU_APP_NAME')}.herokuapp.com"
+    def heroku_attachment_host
+      # TODO: MBS - move this to a configuration property
+      app_name = Rails.env.test? ? 'test-app' : ENV.fetch('HEROKU_APP_NAME')
+      "https://#{app_name}.herokuapp.com"
     end
   end
 end

data/lib/mobile_workflow/version.rb

@@ -1,5 +1,5 @@
 module MobileWorkflow
-  VERSION = '0.7.2'
+  VERSION = '0.7.6'
   RUBY_VERSION = '2.7.3'
   RAILS_VERSION = '6.1.3.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mobile_workflow
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.6
 platform: ruby
 authors:
 - Matt Brooke-Smith
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-01 00:00:00.000000000 Z
+date: 2021-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails