mobile_number_normalizer 0.0.1 → 0.1.0

data/lib/mobile_number_normalizer.rb

@@ -16,7 +16,7 @@ class MobileNumberNormalizer
   # Array of String of International Area Codes
   #
   # @author dmasur
-  VALID_INTERNATIONAL_AREA_CODE = [ '001', '001809', '0020', '00212', '00213', '00216', '00218',
+  @@valid_area_codes = [ '001', '001809', '0020', '00212', '00213', '00216', '00218',
                                     '00220', '00221', '00222', '00223', '00224', '00225', '00226',
                                     '00227', '00228', '00229', '00230', '00231', '00232', '00233',
                                     '00234', '00235', '00236', '00237', '00238', '00239', '00240',
@@ -43,7 +43,15 @@ class MobileNumberNormalizer
                                     '00962', '00963', '00964', '00965', '00966', '00967', '00968',
                                     '00971', '00972', '00973', '00974', '00975', '00976', '00977',
                                     '0098', '00994' ]
-  def initialize(mobile_number)
+  def self.valid_area_codes=(new_valid_area_codes)
+    @@valid_area_codes = new_valid_area_codes
+  end
+
+  def self.valid_area_codes
+    @@valid_area_codes
+  end
+
+  def initialize(mobile_number, valid_area_codes = [])
     @mobile_number = mobile_number
   end
 
@@ -52,7 +60,6 @@ class MobileNumberNormalizer
   #
   # @author dmasur
   def self.get_number number
-    $delete_mobile_numbers ||= []
     number = new(number).get_number
     return number
   end
@@ -71,7 +78,6 @@ class MobileNumberNormalizer
     clean_mobile_number
     #puts "After clean: #{@mobile_number}"
     mobile_number = "" unless has_valid_area_code?
-    $delete_mobile_numbers << org_num if @mobile_number.blank? && !org_num.blank?
     return @mobile_number
   end
 
@@ -166,7 +172,7 @@ class MobileNumberNormalizer
   end
 
   def has_valid_area_code?
-    VALID_INTERNATIONAL_AREA_CODE.any? do |area_code|
+    self.class.valid_area_codes.any? do |area_code|
       Regexp.new("^#{area_code}") =~ @mobile_number
     end
   end
@@ -180,7 +186,7 @@ class MobileNumberNormalizer
     mobile_number = "0#{mobile_number}" if /^1/ =~ mobile_number
     mobile_number.sub!(/^49/, '0049')
     mobile_number.sub!(/\+/, '00')
-    VALID_INTERNATIONAL_AREA_CODE.each do |area_code|
+    valid_area_codes.each do |area_code|
       if mobile_number.start_with?(area_code[2..-1])
         mobile_number = "00#{mobile_number}"
       end

data/lib/mobile_number_normalizer/version.rb

@@ -1,3 +1,3 @@
 class MobileNumberNormalizer
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/spec/lib/mobile_number_normalizer_spec.rb

@@ -166,6 +166,10 @@ describe MobileNumberNormalizer do
       MobileNumberNormalizer.get_number("0049 176 12345678; 0043 6712345678").
         should == "004917612345678"
     end
+    it "give number for 123456" do
+      MobileNumberNormalizer.get_number("123456").
+        should be_blank
+    end
   end
   describe "area codes" do
     it "should accept right area code" do

metadata

@@ -1,74 +1,71 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: mobile_number_normalizer
-version: !ruby/object:Gem::Version 
-  hash: 29
+version: !ruby/object:Gem::Version
+  version: 0.1.0
   prerelease: 
-  segments: 
-  - 0
-  - 0
-  - 1
-  version: 0.0.1
 platform: ruby
-authors: 
+authors:
 - Dominik Masur
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-04-29 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-10-22 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rspec
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: active_support
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: active_support
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: rake
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Normalize mobile Phone Numbers
-email: 
+email:
 - dominik.masur@googlemail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .rspec
 - .travis.yml
@@ -84,37 +81,34 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/TBAA/mobile_number_normalizer
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+      hash: 34214004847796006
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
       - 0
-      version: "0"
+      hash: 34214004847796006
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Normalize mobile Phone Numbers
-test_files: 
+test_files:
 - spec/lib/mobile_number_normalizer_spec.rb
 - spec/spec_helper.rb