mobile_devices 0.3.0 → 0.5.0

data/lib/android.rb

@@ -11,7 +11,7 @@ module MobileDevices
 
     def initialize(file)
       @_lookup = {}
-      JSON.parse(File.read(file)).each do |row|
+      JSON.parse(File.read(file, encoding: Encoding::UTF_8)).each do |row|
         name = row[1]
         codename = row[2]
         @_lookup[codename] = name

data/mobile_devices.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name          = 'mobile_devices'
-  s.version       = '0.3.0'
+  s.version       = '0.5.0'
   s.licenses      = ['MIT']
   s.summary       = "Lookup iOS devices from device type, Android from Build.PRODUCT"
   s.description   = "Turn names like iPhone6,2 and zerofltespr into iPhone 5S and Galaxy S6"
@@ -10,5 +10,7 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files -z`.split("\x0")
   s.require_paths = ['.']
 
-  s.add_runtime_dependency 'ios-devices', '~> 0.3.0'
+  s.add_runtime_dependency 'ios-devices', '~> 0.4.0'
+  s.add_development_dependency 'minitest', '~> 5.0'
+  s.required_ruby_version = '>= 3.1'
 end

data/test/test_mobile_devices.rb

@@ -0,0 +1,39 @@
+require 'minitest/autorun'
+require_relative '../mobile_devices'
+
+class TestMobileDevices < Minitest::Test
+  def test_ios_lookup
+    assert_equal 'iPhone 5s', MobileDevices.get_name('iPhone6,2')
+    assert_equal 'iPhone 16 Pro Max', MobileDevices.get_name('iPhone17,2')
+    assert_equal 'iPad mini 6', MobileDevices.get_name('iPad14,1')
+  end
+
+  def test_android_lookup
+    assert_equal 'Galaxy S6', MobileDevices.get_name('zerofltespr')
+    assert_equal 'Pixel 9 Pro', MobileDevices.get_name('caiman')
+    assert_equal 'Galaxy S24 Ultra', MobileDevices.get_name('e3q')
+  end
+
+  def test_unknown_android_returns_nil
+    assert_nil MobileDevices.get_name('notarealdevice')
+  end
+
+  def test_android_names_are_utf8
+    name = MobileDevices.get_name('U380AA')
+    assert_equal 'AT&T Calypso® 4', name
+    assert_equal Encoding::UTF_8, name.encoding
+  end
+
+  # The data file contains non-ASCII bytes; loading must not depend on the
+  # process locale (LANG may be unset on servers and in containers).
+  def test_loads_under_ascii_default_external_encoding
+    original = Encoding.default_external
+    verbose, $VERBOSE = $VERBOSE, nil
+    Encoding.default_external = Encoding::US_ASCII
+    android = MobileDevices::Android.new(DEFAULT_DATA_FILE)
+    assert_equal 'Pixel 8 Pro', android.name('husky')
+  ensure
+    Encoding.default_external = original
+    $VERBOSE = verbose
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mobile_devices
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Matt Sanford
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-15 00:00:00.000000000 Z
+date: 2026-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ios-devices
@@ -16,14 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.4.0
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
 description: Turn names like iPhone6,2 and zerofltespr into iPhone 5S and Galaxy S6
 email: matt@mzsanford.com
 executables: []
@@ -38,6 +52,7 @@ files:
 - lib/ios.rb
 - mobile_devices.gemspec
 - mobile_devices.rb
+- test/test_mobile_devices.rb
 homepage: https://github.com/mzsanford/mobile_devices
 licenses:
 - MIT
@@ -50,14 +65,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: Lookup iOS devices from device type, Android from Build.PRODUCT