mobile-subscriber 1.0.0.alpha2 → 1.0.0.alpha3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80a1f00c8af97774375ce292825d1ccd16125ea2
-  data.tar.gz: 53b1c2b1cf5fa8d65665abd9c59be800d71d702e
+  metadata.gz: dff021ce9f98d8b6f5b708e5b5b923371a73ae3e
+  data.tar.gz: 6943c7b168217442a6f83cef0b439e71fee48874
 SHA512:
-  metadata.gz: 72ef14f604142edb0243bb764e09ab3da9bc36a938175dd10dae93c9be72977bd7f68a5db57db4c076efd0150fedc28ab5f5ef1a83ef8bcc93315bd3a0b650a4
-  data.tar.gz: 00eee445ece94fa6445e270ba1902645669cc0e8d096a57199e9dc501be9eac3bb60f119093f43a9e4c5233d2fa9463b6d38300ed08d224269dcea7feb0ddcdd
+  metadata.gz: da95e3e0d4d5fd5f9b7d251a08e368b667782e10d59622fb0c42ae42808a77e1900a8c3f30d86f226a4889d2c052f9d74394f6d702aba5633c55f6ad5482cb27
+  data.tar.gz: 8c54ae67aae2b5056834831cadef35704e36f6e017cd7f318c25c4a9f4b5485cbbaeab90fb4139e5dcb050445f84e1026013314c981fd614d781f0493b99c3a8

data/lib/mobile_subscriber/detection/from_x_nokia_msisdn_http_request_header.rb

@@ -6,6 +6,7 @@ module MobileSubscriber::Detection
   # - Telcel México
   # - Claro Argentina
   # - Claro Costa Rica
+  # - Claro Puerto Rico
   # - Claro Guatemala
   # - Claro Honduras
   # - Claro Nicaragua
@@ -17,26 +18,29 @@ module MobileSubscriber::Detection
 
         country_code = (
           MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]] ||
-          MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,3]]
+          MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,3]] || # Dominican 3-digit needed
+          MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,1]]    # Puerto Rico 1-digit country code of "1"
         )
 
         # Determine the Network Operator tuple (MCC + MNC):
         # TODO: Validate IP ranges, additional headers, etc.
         network_id_tuple = case country_code
+        when 'PR' # Claro Puerto Rico:
+          { mcc: "330", mnc: "110" }
         when 'MX' # Telcel México:
-          { mcc: "334", mnc: "020"  }
+          { mcc: "334", mnc: "020" }
         when 'GT' # Claro Guatemala:
-          { mcc: "704", mnc: "01"   }
+          { mcc: "704", mnc: "01"  }
         when 'SV' # Claro El Salvador:
           { mcc: "706", mnc: "01"  }
         when 'HN' # Claro Honduras:
-          { mcc: "708", mnc: "001"  }
+          { mcc: "708", mnc: "001" }
         when 'NI' # Claro Nicaragua:
           { mcc: "710", mnc: "21"  }
         when 'CR' # Claro Costa Rica
           { mcc: "712", mnc: "03"  }
         when 'AR' # Claro Argentina:
-          { mcc: "722", mnc: "330"  }
+          { mcc: "722", mnc: "330" }
         end
 
         # Return only if we identified the network:

data/lib/mobile_subscriber/detection/http_request_info.rb

@@ -41,6 +41,7 @@ module MobileSubscriber::Detection
         'X-Wap-Msisdn',
         'X-Wap-Sesiones3g-Mdn',     # Not in referenced literature
         'X-Wsb-Cli',
+        'X-Ztgo-Beareraddress',     # Not in referenced literature
 
         # Headers that contain bearer information:
         # http://www.mulliner.org/collin/academic/publications/mobile_web_privacy_icin10_mulliner.pdf

data/lib/mobile_subscriber/dictionaries/dialing_and_country_codes.rb

@@ -2,6 +2,9 @@ module MobileSubscriber
   # See: http://countrycode.org/
   # Diccionario de Dialing Country Codes => ISO country codes:
   DIALING_COUNTRY_CODES = {
+    # WTF???
+    '1' => 'PR', # Puerto Rico "1" country code...
+
     # Caribbean Islands' country codes are a mess!
     '1809' => 'DO', # Dominican Republic
     '1829' => 'DO', # Dominican Republic Overlay 1

data/lib/mobile_subscriber/version.rb

@@ -1,3 +1,3 @@
 module MobileSubscriber
-  VERSION = "1.0.0.alpha2"
+  VERSION = "1.0.0.alpha3"
 end

data/spec/detection/from_x_nokia_msisdn_http_request_header_spec.rb

@@ -45,6 +45,16 @@ describe MobileSubscriber::Detection::FromXNokiaMsisdnHttpRequestHeader do
       end
     end
 
+    context "when given a request made from Claro Puerto Rico" do
+      let(:test_request) { build :mobile_request_from_claro_puerto_rico }
+
+      include_examples "of detection of msisdn from a valid puerto rican mobile network http request"
+
+      it "has a :mobile_network_code value of '110'" do
+        expect(subject[:mobile_network_code]).to eq '110'
+      end
+    end
+
     context "when given a request made from Claro Guatemala" do
       let(:test_request) { build :mobile_request_from_claro_guatemala }
 

data/spec/factories/requests.rb

@@ -100,6 +100,16 @@ FactoryGirl.define do
       end
     end
 
+    # TODO: Replace with a real example request:
+    factory :mobile_request_from_claro_puerto_rico do
+      initialize_with do
+        new build(:common_mobile_request_env).merge(
+          "REMOTE_ADDR" =>  "64.237.130.12",
+          "HTTP_X_NOKIA_MSISDN" =>  "17872889401" # 1-787-XXXXXXXX
+        )
+      end
+    end
+
     # http://myip.ms/view/ip_owners/80612/Conecel.html
     factory :mobile_request_from_claro_ecuador do
       initialize_with do

data/spec/shared_examples/of_msisdn_detection_from_http_request.rb

@@ -114,6 +114,17 @@ shared_examples "of detection of msisdn from a valid costa rican mobile network
   end
 end
 
+shared_examples "of detection of msisdn from a valid puerto rican mobile network http request" do
+  include_examples "of detection of msisdn from a valid mobile network http request"
+  it "has an :id value that starts with '1'" do
+    expect(subject[:id]).to match /\A1/
+  end
+
+  it "has a :mobile_country_code value of '330'" do
+    expect(subject[:mobile_country_code]).to eq '330'
+  end
+end
+
 shared_examples "of detection of msisdn from a valid colombian mobile network http request" do
   include_examples "of detection of msisdn from a valid mobile network http request"
   it "has an :id value that starts with '57'" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mobile-subscriber
 version: !ruby/object:Gem::Version
-  version: 1.0.0.alpha2
+  version: 1.0.0.alpha3
 platform: ruby
 authors:
 - Roberto Quintanilla
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-12 00:00:00.000000000 Z
+date: 2015-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport