mobile-subscriber 0.0.1.beta1 → 1.0.0.alpha1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b57bb989e630712c7b4a06d051a7038006b426c1
-  data.tar.gz: 00d70b45ea77d7e0ebeae56c47c3fb19960c5ebc
+  metadata.gz: ae67ac6282a540faba3e4b5212070bf6032ff29b
+  data.tar.gz: 25145806d895c4a019f788672f7034de4647695c
 SHA512:
-  metadata.gz: df5e3a68907f3c6a33350a16be66e20ed2d385d133ee2547e1848613ae179a5231c8a145ccf4ed46ae1a2f41c785c2c816c612c4c62a50381ba4140a8b4fface
-  data.tar.gz: 2e4a5f0151692218c8cf90d20de3288f31aa91ebaba3533dbb67607176272acc940caee34ca243c617af9697c70168aeccd5f0438cd8eb5a54e267d0ae392989
+  metadata.gz: 7ec68823ec387842a9b55a03d635c4207052a60f04545184fc19ee2ecf01287b59de2d5b724dd282bbc0f36a806634ec0717c6f75a45d347b3dfc4d6db90da54
+  data.tar.gz: 60122de6fe24bd0e9375574ff1bbe28b26d48e43eab85a3291798f2473ebeeaec59a853929a12fe73c8bde4e2ddb3b320c85e683acbb528fc52d38d3a4048163

data/.travis.yml

@@ -1,3 +1,5 @@
 language: ruby
 rvm:
+  - 2.0.0-p598
   - 2.1.5
+  - 2.2.0

data/Gemfile

@@ -4,7 +4,11 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'activesupport', "~> 4.0"
-gem 'guard-rspec',  require: false
-gem 'byebug',       require: true
-gem 'thor'
-gem 'nokogiri'
+
+group :development, :test do
+  gem "rake"
+  gem 'guard-rspec',  require: false
+  gem 'byebug',       require: true
+  gem 'thor'
+  gem 'nokogiri'
+end

data/README.md

@@ -1,5 +1,7 @@
 # MobileSubscriber Gem
 
+[![Build Status](https://travis-ci.org/vovimayhem/mobile-subscriber-gem.svg?branch=master)](https://travis-ci.org/vovimayhem/mobile-subscriber-gem)
+
 It's a fact that the Mobile network providers (carriers, operators & such) share
 subscriber identity data to approved 3rd parties when users navigate via Web to
 the 3rd parties' websites.

data/lib/mobile_subscriber/detection/from_msisdn_http_request_header.rb

@@ -11,7 +11,6 @@ module MobileSubscriber::Detection
   # - Claro República Dominicana
   # - Claro Ecuador
   # - Claro El Salvador
-  # - Claro Guatemala
   # - Claro Nicaragua
   # - Claro Panamá
   # - Claro Paraguay
@@ -22,7 +21,8 @@ module MobileSubscriber::Detection
 
         country_code = (
           MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]] ||
-          MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,3]]
+          MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,3]] ||
+          MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,4]]     # Dominican Republic
         )
 
         # Determine the Network Operator (MCC + MNC tuple):
@@ -43,10 +43,6 @@ module MobileSubscriber::Detection
           { mcc: "740", mnc: "01"   }
         when 'SV' # Claro El Salvador:
           { mcc: "706", mnc: "01"   }
-        when 'GT' # Claro Guatemala:
-          { mcc: "704", mnc: "01"   }
-        when 'HN' # Claro Honduras:
-          { mcc: "708", mnc: "001"  }
         when 'NI' # Claro Nicaragua:
           { mcc: "710", mnc: "21"   }
         when 'PA' # Claro Panamá:

data/lib/mobile_subscriber/detection/from_x_nokia_msisdn_http_request_header.rb

@@ -4,6 +4,8 @@ module MobileSubscriber::Detection
   # Módulo que provee métodos de deteccion y validacion para MSISDN's de:
   # - Telcel México
   # - Claro Argentina
+  # - Claro Guatemala
+  # - Claro Honduras
   module FromXNokiaMsisdnHttpRequestHeader
 
     def extract_from_x_nokia_msisdn_http_request_header(http_request_info)
@@ -19,7 +21,10 @@ module MobileSubscriber::Detection
         network_id_tuple = case country_code
         when 'MX' # Telcel México:
           { mcc: "334", mnc: "020"  }
-
+        when 'GT' # Claro Guatemala:
+          { mcc: "704", mnc: "01"   }
+        when 'HN' # Claro Honduras:
+          { mcc: "708", mnc: "001"  }
         when 'AR' # Claro Argentina:
           { mcc: "722", mnc: "330"  }
         end

data/lib/mobile_subscriber/dictionaries/dialing_and_country_codes.rb

@@ -1,6 +1,11 @@
 module MobileSubscriber
-  # Diccionario de Mobile Country Codes => ISO country codes:
+  # Diccionario de Dialing Country Codes => ISO country codes:
   DIALING_COUNTRY_CODES = {
+    # Caribbean Islands' country codes are a mess!
+    '1809' => 'DO', # Dominican Republic
+    '1829' => 'DO', # Dominican Republic Overlay 1
+    '1849' => 'DO', # Dominican Republic Overlay 2
+
     '501'	=> 'BZ',	# Belize
     '502'	=> 'GT',	# Guatemala
     '503'	=> 'SV',	# El Salvador

data/lib/mobile_subscriber/version.rb

@@ -1,3 +1,3 @@
 module MobileSubscriber
-  VERSION = "0.0.1.beta1"
+  VERSION = "1.0.0.alpha1"
 end

data/spec/detection/from_x_nokia_msisdn_http_request_header_spec.rb

@@ -34,6 +34,26 @@ describe MobileSubscriber::Detection::FromXNokiaMsisdnHttpRequestHeader do
         expect(subject[:mobile_network_code]).to match /310|320|330/
       end
     end
+
+    context "when given a request made from Claro Guatemala" do
+      let(:test_request) { build :mobile_request_from_claro_guatemala }
+
+      include_examples "of detection of msisdn from a valid guatemalan mobile network http request"
+
+      it "has a :mobile_network_code value of '01'" do
+        expect(subject[:mobile_network_code]).to eq '01'
+      end
+    end
+
+    context "when given a request made from Claro Honduras" do
+      let(:test_request) { build :mobile_request_from_claro_honduras }
+
+      include_examples "of detection of msisdn from a valid honduran mobile network http request"
+
+      it "has a :mobile_network_code value of '001'" do
+        expect(subject[:mobile_network_code]).to eq '001'
+      end
+    end
   end
 
 end

data/spec/detection/from_x_wap_sesiones3g_mdn_http_request_header_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe MobileSubscriber::Detection::FromXWapSesiones3gMdnHttpRequestHeader, focus: true do
+describe MobileSubscriber::Detection::FromXWapSesiones3gMdnHttpRequestHeader do
 
   include described_class
 

data/spec/factories/requests.rb

@@ -90,6 +90,29 @@ FactoryGirl.define do
       end
     end
 
+    # Request from a client through Claro Guatemala network:
+    # (Built from an actual ATP test)
+    factory :mobile_request_from_claro_guatemala do
+      initialize_with do
+        new build(:common_mobile_request_env).merge(
+          "REMOTE_ADDR" =>  "216.230.152.158",
+          "HTTP_X_NOKIA_MSISDN" => "50241865146",
+          "HTTP_X_NOKIA_IMSI" => "704012013128442",
+          "HTTP_X_FORWARDED_FOR" => "190.212.233.218, 204.0.3.199"
+        )
+      end
+    end
+
+    # TODO: Replace with a real example:
+    factory :mobile_request_from_claro_honduras do
+      initialize_with do
+        new build(:common_mobile_request_env).merge(
+          "REMOTE_ADDR" =>  "190.107.157.31",
+          "HTTP_X_NOKIA_MSISDN" => "50430000000"
+        )
+      end
+    end
+
     # http://myip.ms/view/ip_owners/90291/America_Movil_Peru_S_a_c.html
     factory :mobile_request_from_claro_peru do
       initialize_with do

data/spec/shared_examples/of_msisdn_detection_from_http_request.rb

@@ -50,6 +50,26 @@ shared_examples "of detection of msisdn from a valid mexican mobile network http
   end
 end
 
+shared_examples "of detection of msisdn from a valid guatemalan mobile network http request" do
+  include_examples "of detection of msisdn from a valid mobile network http request"
+  it "has an :id value that starts with '502'" do
+    expect(subject[:id]).to match /\A502/
+  end
+  it "has a :mobile_country_code value of '704'" do
+    expect(subject[:mobile_country_code]).to eq '704'
+  end
+end
+
+shared_examples "of detection of msisdn from a valid honduran mobile network http request" do
+  include_examples "of detection of msisdn from a valid mobile network http request"
+  it "has an :id value that starts with '504'" do
+    expect(subject[:id]).to match /\A504/
+  end
+  it "has a :mobile_country_code value of '708'" do
+    expect(subject[:mobile_country_code]).to eq '708'
+  end
+end
+
 shared_examples "of detection of msisdn from a valid brazilian mobile network http request" do
   include_examples "of detection of msisdn from a valid mobile network http request"
   it "has an :id value that starts with '55'" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mobile-subscriber
 version: !ruby/object:Gem::Version
-  version: 0.0.1.beta1
+  version: 1.0.0.alpha1
 platform: ruby
 authors:
 - Roberto Quintanilla
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-08 00:00:00.000000000 Z
+date: 2015-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -158,7 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Mobile MSISDN detection & validation.