mobile-subscriber 0.0.1.alpha4 → 0.0.1.alpha5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae7f7ff2ab99759a49beef779711360052c0cc85
-  data.tar.gz: daa60ed245a79d3161c29f142244866c4afb2016
+  metadata.gz: 0f3d86284c8cd6a42a0fdab25eba82cb6c1ba05b
+  data.tar.gz: fbcf9b5f54072d1a6f9580da21bc6afbd4314d51
 SHA512:
-  metadata.gz: 4781b295edb467703313ed06d9167998d457a5418445b52a31915563eea46e53561a0ec144cff37eaceba3ab0b264eae875d0445579ef644a87b0cc0b6747b67
-  data.tar.gz: f237cdbbc072af9ad6f4389fbcab25052982041727086a4a422035317b29842e43393fa33e08988a636e9598d2135b03123fb668afc066b134c5c60d44c2a357
+  metadata.gz: 0acdb66c244b26c2360958eeaf0a392b3786d59e73946348e5abfc1f249ea47e978576711b76e3a2f4a960c60e1ad4ca546e879c085a2821be8223c8ad2317ab
+  data.tar.gz: d7f91b0655d285b3f9ce75993ee7702088b35e17887590c77cd54df922703fd421000a49e08ddf6d1dc45b9e6c3d630039c8b0652048d4f0a60a527e60b98a7c

data/lib/mobile_subscriber/detection/from_msisdn_http_request_header.rb

@@ -34,7 +34,7 @@ module MobileSubscriber
               http_request_headers: { 'Msisdn' => msisdn }
             }
 
-            country_code = MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]]
+            country_code = MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]] || MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,3]]
 
             # Determinar la procedencia del MSISDN
             # TODO: Validar por IP, etc.

data/lib/mobile_subscriber/detection/from_x_nokia_msisdn_http_request_header.rb

@@ -22,7 +22,7 @@ module MobileSubscriber
               http_request_headers: { 'X-Nokia-Msisdn' => msisdn }
             }
 
-            country_code = MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]]
+            country_code = MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]] || MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,3]]
 
             # Determinar la procedencia del MSISDN
             # TODO: Validar por IP, etc.

data/lib/mobile_subscriber/detection/from_x_up_ch_msisdn_http_request_header.rb

@@ -20,7 +20,7 @@ module MobileSubscriber
               http_request_headers: { 'X-Up-Ch-Msisdn' => msisdn }
             }
 
-            country_code = MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]]
+            country_code = MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]] || MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,3]]
 
             # Determinar la procedencia del MSISDN
             # TODO: Validar por IP, etc.

data/lib/mobile_subscriber/detection/from_x_up_subno_http_request_header.rb

@@ -23,7 +23,7 @@ module MobileSubscriber
               http_request_headers: { header_name => msisdn }
             }
 
-            country_code = MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]]
+            country_code = MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,2]] || MobileSubscriber::DIALING_COUNTRY_CODES[msisdn[0,3]]
 
             # Determinar la procedencia del MSISDN
             # TODO: Validar por IP, etc.

data/lib/mobile_subscriber/version.rb

@@ -1,3 +1,3 @@
 module MobileSubscriber
-  VERSION = "0.0.1.alpha4"
+  VERSION = "0.0.1.alpha5"
 end

data/spec/detection/from_msisdn_http_request_header_spec.rb

@@ -34,7 +34,7 @@ describe MobileSubscriber::Detection::FromMsisdnHttpRequestHeader do
       end
     end
 
-    context "when given a request made from Claro Colomobia" do
+    context "when given a request made from Claro Colombia" do
       let(:test_request) { build :mobile_request_from_claro_colombia }
 
       include_examples "of detection of msisdn from a valid colombian mobile network http request"
@@ -43,6 +43,17 @@ describe MobileSubscriber::Detection::FromMsisdnHttpRequestHeader do
         expect(subject[:mobile_network_code]).to eq '101'
       end
     end
+
+    context "when given a request made from Claro Ecuador" do
+      let(:test_request) { build :mobile_request_from_claro_ecuador }
+
+      include_examples "of detection of msisdn from a valid ecuadorian mobile network http request"
+
+      it "has a :mobile_network_code value of '01'" do
+        expect(subject[:mobile_network_code]).to eq '01'
+      end
+    end
+    
   end
 
 end

data/spec/detection/from_x_up_calling_line_id_http_request_header_spec.rb

@@ -0,0 +1,35 @@
+require "spec_helper"
+
+describe MobileSubscriber::Detection::FromXUpCallingLineIdHttpRequestHeader do
+
+  include described_class::ClassMethods
+
+  describe "the returned object of self.extract_from_msisdn_http_request_header" do
+
+    subject do
+      extract_from_x_up_calling_line_id_http_request_header test_request
+    end
+
+    context "when given a request made from Claro Perú" do
+      let(:test_request) { build :mobile_request_from_claro_peru }
+
+      include_examples "of detection of msisdn from a valid peruvian mobile network http request"
+
+      it "has a :mobile_network_code value of '10'" do
+        expect(subject[:mobile_network_code]).to eq '10'
+      end
+    end
+
+    context "when given a request made from Movistar Perú" do
+      let(:test_request) { build :mobile_request_from_movistar_peru }
+
+      include_examples "of detection of msisdn from a valid peruvian mobile network http request"
+
+      it "has a :mobile_network_code value of '06'" do
+        expect(subject[:mobile_network_code]).to eq '06'
+      end
+    end
+
+  end
+
+end

data/spec/factories/requests.rb

@@ -21,8 +21,7 @@ FactoryGirl.define do
 
     initialize_with do
       new build(:common_mobile_request_env).merge(
-        "REMOTE_ADDR"           =>  "201.144.162.4",
-        "REMOTE_HOST"           =>  "201.144.162.4"
+        "REMOTE_ADDR"           =>  "201.144.162.4"
       )
     end
 
@@ -30,7 +29,6 @@ FactoryGirl.define do
       initialize_with do
         new build(:common_mobile_request_env).merge(
           "REMOTE_ADDR"           =>  "201.144.162.4",
-          "REMOTE_HOST"           =>  "201.144.162.4",
           "HTTP_X_NOKIA_MSISDN"   =>  "528110000000"
         )
       end
@@ -40,8 +38,7 @@ FactoryGirl.define do
       initialize_with do
         new build(:common_mobile_request_env).merge(
           "REMOTE_ADDR"           =>  "170.51.255.240",
-          "REMOTE_HOST"           =>  "170.51.255.240",
-          "HTTP_X_NOKIA_MSISDN"   =>  "5491141098443"
+          "HTTP_X_NOKIA_MSISDN"   =>  "5491141090000"
         )
       end
     end
@@ -50,7 +47,6 @@ FactoryGirl.define do
       initialize_with do
         new build(:common_mobile_request_env).merge(
           "REMOTE_ADDR" =>  "201.23.176.202",
-          "REMOTE_HOST" =>  "201.23.176.202",
           "HTTP_MSISDN" =>  "5500000000000"
         )
       end
@@ -61,8 +57,7 @@ FactoryGirl.define do
       initialize_with do
         new build(:common_mobile_request_env).merge(
           "REMOTE_ADDR" =>  "191.116.39.114",
-          "REMOTE_HOST" =>  "191.116.39.114",
-          "HTTP_MSISDN" =>  "56024445202"
+          "HTTP_MSISDN" =>  "56024440000"
         )
       end
     end
@@ -71,18 +66,27 @@ FactoryGirl.define do
       initialize_with do
         new build(:common_mobile_request_env).merge(
           "REMOTE_ADDR" =>  "200.26.137.100",
-          "REMOTE_HOST" =>  "200.26.137.100",
           "HTTP_MSISDN" =>  "57000000000"
         )
       end
     end
 
+    # http://myip.ms/view/ip_owners/80612/Conecel.html
+    factory :mobile_request_from_claro_ecuador do
+      initialize_with do
+        new build(:common_mobile_request_env).merge(
+          "REMOTE_ADDR" =>  "190.63.1.10",
+          "HTTP_MSISDN" =>  "59342690000"
+        )
+      end
+    end
+
+    # http://myip.ms/view/ip_owners/90291/America_Movil_Peru_S_a_c.html
     factory :mobile_request_from_claro_peru do
       initialize_with do
         new build(:common_mobile_request_env).merge(
-          "REMOTE_ADDR"               => "190.113.192.9",
-          "REMOTE_HOST"               => "190.113.192.9",
-          "HTTP_X_UP_CALLING_LINE_ID" => "5100000000000",
+          "REMOTE_ADDR"               => "200.108.96.5",
+          "HTTP_X_UP_CALLING_LINE_ID" => "5116130000",
           "HTTP_VIA"                  => "aa Comverse aaa"
         )
       end
@@ -92,12 +96,21 @@ FactoryGirl.define do
       initialize_with do
         new build(:common_mobile_request_env).merge(
           "REMOTE_ADDR"           =>  "187.26.59.4",
-          "REMOTE_HOST"           =>  "187.26.59.4",
           "HTTP_X_UP_CH_MSISDN"   =>  "5500000000000"
         )
       end
     end
 
+    # http://myip.ms/view/ip_owners/7424/Telefonica_Del_Peru_Saa.html
+    factory :mobile_request_from_movistar_peru do
+      initialize_with do
+        new build(:common_mobile_request_env).merge(
+          "REMOTE_ADDR"               => "190.42.165.87",
+          "HTTP_X_UP_CALLING_LINE_ID" => "5112100000"
+        )
+      end
+    end
+
 
   end
 end

data/spec/shared_examples/of_msisdn_detection_from_http_request.rb

@@ -82,3 +82,25 @@ shared_examples "of detection of msisdn from a valid colombian mobile network ht
     expect(subject[:mobile_country_code]).to eq '732'
   end
 end
+
+shared_examples "of detection of msisdn from a valid ecuadorian mobile network http request" do
+  include_examples "of detection of msisdn from a valid mobile network http request"
+  it "has an :id value that starts with '593'" do
+    expect(subject[:id]).to match /\A593/
+  end
+
+  it "has a :mobile_country_code value of '740'" do
+    expect(subject[:mobile_country_code]).to eq '740'
+  end
+end
+
+shared_examples "of detection of msisdn from a valid peruvian mobile network http request" do
+  include_examples "of detection of msisdn from a valid mobile network http request"
+  it "has an :id value that starts with '51'" do
+    expect(subject[:id]).to match /\A51/
+  end
+
+  it "has a :mobile_country_code value of '716'" do
+    expect(subject[:mobile_country_code]).to eq '716'
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mobile-subscriber
 version: !ruby/object:Gem::Version
-  version: 0.0.1.alpha4
+  version: 0.0.1.alpha5
 platform: ruby
 authors:
 - Roberto Quintanilla
@@ -127,6 +127,7 @@ files:
 - mobile_subscriber.thor
 - spec/detection/from_msisdn_http_request_header_spec.rb
 - spec/detection/from_x_nokia_msisdn_http_request_header_spec.rb
+- spec/detection/from_x_up_calling_line_id_http_request_header_spec.rb
 - spec/factories/requests.rb
 - spec/mobile_subscriber_spec.rb
 - spec/models/isdn_spec.rb
@@ -161,6 +162,7 @@ summary: Mobile MSISDN detection & validation.
 test_files:
 - spec/detection/from_msisdn_http_request_header_spec.rb
 - spec/detection/from_x_nokia_msisdn_http_request_header_spec.rb
+- spec/detection/from_x_up_calling_line_id_http_request_header_spec.rb
 - spec/factories/requests.rb
 - spec/mobile_subscriber_spec.rb
 - spec/models/isdn_spec.rb