mno-enterprise-api 3.3.3 → 3.4.0

data/spec/controllers/mno_enterprise/jpi/v1/admin/impac/kpis_controller_spec.rb

@@ -1,12 +1,9 @@
 require 'rails_helper'
+require 'mno_enterprise/testing_support/shared_contexts/jpi_v1_admin_controller'
 
 module MnoEnterprise
   describe Jpi::V1::Admin::Impac::KpisController, type: :controller do
-    # include MnoEnterprise::TestingSupport::JpiV1TestHelper
-    include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
-    render_views
-    routes { MnoEnterprise::Engine.routes }
-    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+    include_context MnoEnterprise::Jpi::V1::Admin::BaseResourceController
 
     let(:user) { build(:user, :admin, :with_organizations) }
     let(:org) { build(:organization, users: [user]) }
@@ -23,11 +20,6 @@ module MnoEnterprise
       }
     end
 
-    before do
-      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
-      sign_in user
-    end
-
     describe '#create' do
       let(:kpi_params) do
         {
@@ -42,34 +34,46 @@ module MnoEnterprise
       end
 
       subject { post :create, dashboard_template_id: template.id, kpi: kpi_params }
-      
-      before do
-        api_stub_for(
-          get: "/dashboards/#{template.id}",
-          params: { filter: { 'dashboard_type' => 'template' } },
-          response: from_api(template)
-        )
-        api_stub_for(
-          post: "dashboards/#{template.id}/kpis",
-          response: from_api(kpi)
-        )
-        # Why is Her doing a GET /kpis after doing a POST /kpis?
-        api_stub_for(
-          get: "dashboards/#{template.id}/kpis",
-          response: from_api([kpi])
-        )
-      end
-
-      it_behaves_like "a jpi v1 admin action"
 
-      it 'returns a kpi' do
-        subject
-        expect(JSON.parse(response.body)).to eq(hash_for_kpi)
+      context 'when the template exists' do
+        before do
+          api_stub_for(
+            get: "/dashboards/#{template.id}",
+            params: { filter: { 'dashboard_type' => 'template' } },
+            response: from_api(template)
+          )
+          api_stub_for(
+            post: "dashboards/#{template.id}/kpis",
+            response: from_api(kpi)
+          )
+          # Why is Her doing a GET /kpis after doing a POST /kpis?
+          api_stub_for(
+            get: "dashboards/#{template.id}/kpis",
+            response: from_api([kpi])
+          )
+        end
+
+        it_behaves_like "a jpi v1 admin action"
+
+        it 'returns a kpi' do
+          subject
+          expect(JSON.parse(response.body)).to eq(hash_for_kpi)
+        end
       end
 
-      # api_stub should be modified to allow this case to be stubbed
-      context 'when the template cannot be found' do
-        xit 'spec to be described'
+      context 'when the template does not exist' do
+        before do
+          api_stub_for(
+            get: "/dashboards/#{template.id}",
+            params: { filter: { 'dashboard_type' => 'template' } },
+            code: 404
+          )
+        end
+
+        it 'returns an error message' do
+          subject
+          expect(JSON.parse(response.body)).to eq({ 'errors' => { 'message' => 'Dashboard template not found' } })
+        end
       end
     end
 
@@ -84,50 +88,72 @@ module MnoEnterprise
       end
 
       subject { put :update, id: kpi.id, kpi: kpi_params }
-      
-      before do
-        api_stub_for(
-          get: "kpis/#{kpi.id}",
-          response: from_api(kpi)
-        )
-        api_stub_for(
-          put: "/kpis/#{kpi.id}",
-          response: from_api(kpi)
-        )
-      end
-
-      it_behaves_like "a jpi v1 admin action"
 
-      it 'returns a kpi' do
-        subject
-        expect(JSON.parse(response.body)).to eq(hash_for_kpi)
+      context 'when the kpi exists' do
+        before do
+          api_stub_for(
+            get: "kpis/#{kpi.id}",
+            response: from_api(kpi)
+          )
+          api_stub_for(
+            put: "/kpis/#{kpi.id}",
+            response: from_api(kpi)
+          )
+        end
+
+        it_behaves_like "a jpi v1 admin action"
+
+        it 'returns a kpi' do
+          subject
+          expect(JSON.parse(response.body)).to eq(hash_for_kpi)
+        end
       end
 
-      # api_stub should be modified to allow this case to be stubbed
-      context 'when the kpi update is unsuccessful' do
-        xit 'spec to be described'
+      context 'when the kpi does not exist' do
+        before do
+          api_stub_for(
+            get: "kpis/#{kpi.id}",
+            code: 404
+          )
+        end
+
+        it 'returns an error message' do
+          subject
+          expect(JSON.parse(response.body)).to eq({ 'errors' => 'Cannot update kpi' })
+        end
       end
     end
 
     describe '#destroy' do
       subject { delete :destroy, id: kpi.id }
-      
-      before do
-        api_stub_for(
-          get: "kpis/#{kpi.id}",
-          response: from_api(kpi)
-        )
-        api_stub_for(
-          delete: "/kpis/#{kpi.id}",
-          response: from_api(nil)
-        )
-      end
 
-      it_behaves_like "a jpi v1 admin action"
+      context 'when the kpi exists' do
+        before do
+          api_stub_for(
+            get: "kpis/#{kpi.id}",
+            response: from_api(kpi)
+          )
+          api_stub_for(
+            delete: "/kpis/#{kpi.id}",
+            response: from_api(nil)
+          )
+        end
+
+        it_behaves_like "a jpi v1 admin action"
+      end
 
-      # api_stub should be modified to allow this case to be stubbed
-      context 'when the kpi destruction is unsuccessful' do
-        xit 'spec to be described'
+      context 'when the kpi does not exist' do
+        before do
+          api_stub_for(
+            get: "kpis/#{kpi.id}",
+            code: 404
+          )
+        end
+
+        it 'returns an error message' do
+          subject
+          expect(JSON.parse(response.body)).to eq({ 'errors' => 'Cannot delete kpi' })
+        end
       end
     end
   end

data/spec/controllers/mno_enterprise/jpi/v1/admin/impac/widgets_controller_spec.rb

@@ -1,18 +1,15 @@
 require 'rails_helper'
+require 'mno_enterprise/testing_support/shared_contexts/jpi_v1_admin_controller'
 
 module MnoEnterprise
   describe Jpi::V1::Admin::Impac::WidgetsController, type: :controller do
-    # include MnoEnterprise::TestingSupport::JpiV1TestHelper
-    include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
-    render_views
-    routes { MnoEnterprise::Engine.routes }
-    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+    include_context MnoEnterprise::Jpi::V1::Admin::BaseResourceController
 
     let(:user) { build(:user, :admin, :with_organizations) }
     let(:org) { build(:organization, users: [user]) }
     let(:template) { build(:impac_dashboard, dashboard_type: 'template') }
     let(:metadata) { { hist_parameters: { from: '2015-01-01', to: '2015-03-31', period: 'MONTHLY' } } }
-    let(:widget) { build(:impac_widget, dashboard: template, settings: metadata) }
+    let(:widget) { build(:impac_widget, dashboard: template, settings: metadata, layouts: ['figure', 'highcharts']) }
     let(:kpi) { build(:impac_kpi, widget: widget) }
 
     let(:hash_for_kpi) do
@@ -29,15 +26,11 @@ module MnoEnterprise
         'metadata' => metadata.deep_stringify_keys,
         "endpoint" => widget.widget_category,
         "width" => widget.width,
-        "kpis" => [hash_for_kpi]
+        "kpis" => [hash_for_kpi],
+        "layouts" => widget.layouts
       }
     end
 
-    before do
-      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
-      sign_in user
-    end
-
     describe '#create' do
       let(:widget_params) do
         {
@@ -45,43 +38,116 @@ module MnoEnterprise
           name: widget.name,
           width: widget.width,
           metadata: metadata,
+          layouts: widget.layouts,
           forbidden: 'param'
         }
       end
 
-      subject { post :create, dashboard_template_id: template.id, widget: widget_params }
-      
-      before do
-        api_stub_for(
-          get: "/dashboards/#{template.id}",
-          params: { filter: { 'dashboard_type' => 'template' } },
-          response: from_api(template)
-        )
-        api_stub_for(
-          post: "dashboards/#{template.id}/widgets",
-          response: from_api(widget)
-        )
-        # Why is Her doing a GET /widgets after doing a POST /widgets?
-        api_stub_for(
-          get: "dashboards/#{template.id}/widgets",
-          response: from_api([widget])
-        )
-        api_stub_for(
-          get: "/widgets/#{widget.id}/kpis",
-          response: from_api([kpi])
-        )
-      end
-
-      it_behaves_like "a jpi v1 admin action"
-
-      it 'returns a widget' do
-        subject
-        expect(JSON.parse(response.body)).to eq(hash_for_widget)
+      context 'with a dashboard' do
+        subject { post :create, dashboard_id: dashboard.id, widget: widget_params }
+
+        let(:dashboard) { build(:impac_dashboard) }
+
+        context 'when the dashboard exists' do
+          before do
+            api_stub_for(
+              get: "/dashboards",
+              params: {
+                filter: { 'id' => dashboard.id, 'owner_id' => user.id, 'owner_type' => 'User' },
+                limit: 1
+              },
+              response: from_api([dashboard])
+            )
+            api_stub_for(
+              post: "dashboards/#{dashboard.id}/widgets",
+              response: from_api(widget)
+            )
+            # Why is Her doing a GET /widgets after doing a POST /widgets?
+            api_stub_for(
+              get: "dashboards/#{dashboard.id}/widgets",
+              response: from_api([widget])
+            )
+            api_stub_for(
+              get: "/widgets/#{widget.id}/kpis",
+              response: from_api([kpi])
+            )
+          end
+
+          it_behaves_like "a jpi v1 admin action"
+
+          it 'returns a widget' do
+            subject
+            expect(JSON.parse(response.body)).to eq(hash_for_widget)
+          end
+        end
+
+        context 'when the dashboard does not exist' do
+          before do
+            api_stub_for(
+              get: "/dashboards",
+              params: {
+                filter: { 'id' => dashboard.id, 'owner_id' => user.id, 'owner_type' => 'User' },
+                limit: 1
+              },
+              response: from_api([])
+            )
+          end
+
+          it 'returns an error message' do
+            subject
+            expect(response).to have_http_status(:not_found)
+            expect(JSON.parse(response.body)).to eq({ 'errors' => { 'message' => 'Dashboard not found' } })
+          end
+        end
       end
 
-      # api_stub should be modified to allow this case to be stubbed
-      context 'when the template cannot be found' do
-        xit 'spec to be described'
+      context 'with a dashboard template' do
+        subject { post :create, dashboard_template_id: template.id, widget: widget_params }
+
+        context 'when the template exists' do
+          before do
+            api_stub_for(
+              get: "/dashboards/#{template.id}",
+              params: { filter: { 'dashboard_type' => 'template' } },
+              response: from_api(template)
+            )
+            api_stub_for(
+              post: "dashboards/#{template.id}/widgets",
+              response: from_api(widget)
+            )
+            # Why is Her doing a GET /widgets after doing a POST /widgets?
+            api_stub_for(
+              get: "dashboards/#{template.id}/widgets",
+              response: from_api([widget])
+            )
+            api_stub_for(
+              get: "/widgets/#{widget.id}/kpis",
+              response: from_api([kpi])
+            )
+          end
+
+          it_behaves_like "a jpi v1 admin action"
+
+          it 'returns a widget' do
+            subject
+            expect(JSON.parse(response.body)).to eq(hash_for_widget)
+          end
+        end
+
+        context 'when the template does not exist' do
+          before do
+            api_stub_for(
+              get: "/dashboards/#{template.id}",
+              params: { filter: { 'dashboard_type' => 'template' } },
+              code: 404
+            )
+          end
+
+          it 'returns an error message' do
+            subject
+            expect(JSON.parse(response.body)).to eq({ 'errors' => { 'message' => 'Dashboard template not found' } })
+          end
+        end
       end
     end
 
@@ -96,54 +162,76 @@ module MnoEnterprise
       end
 
       subject { put :update, id: widget.id, widget: widget_params }
-      
-      before do
-        api_stub_for(
-          get: "widgets/#{widget.id}",
-          response: from_api(widget)
-        )
-        api_stub_for(
-          put: "/widgets/#{widget.id}",
-          response: from_api(widget)
-        )
-        api_stub_for(
-          get: "/widgets/#{widget.id}/kpis",
-          response: from_api([kpi])
-        )
-      end
-
-      it_behaves_like "a jpi v1 admin action"
 
-      it 'returns a widget' do
-        subject
-        expect(JSON.parse(response.body)).to eq(hash_for_widget)
+      context 'when the widget exists' do
+        before do
+          api_stub_for(
+            get: "widgets/#{widget.id}",
+            response: from_api(widget)
+          )
+          api_stub_for(
+            put: "/widgets/#{widget.id}",
+            response: from_api(widget)
+          )
+          api_stub_for(
+            get: "/widgets/#{widget.id}/kpis",
+            response: from_api([kpi])
+          )
+        end
+
+        it_behaves_like "a jpi v1 admin action"
+
+        it 'returns a widget' do
+          subject
+          expect(JSON.parse(response.body)).to eq(hash_for_widget)
+        end
       end
 
-      # api_stub should be modified to allow this case to be stubbed
-      context 'when the widget update is unsuccessful' do
-        xit 'spec to be described'
+      context 'when the widget does not exist' do
+        before do
+          api_stub_for(
+            get: "widgets/#{widget.id}",
+            code: 404
+          )
+        end
+
+        it 'returns an error message' do
+          subject
+          expect(JSON.parse(response.body)).to eq({ 'errors' => 'Cannot update widget' })
+        end
       end
     end
 
     describe '#destroy' do
       subject { delete :destroy, id: widget.id }
-      
-      before do
-        api_stub_for(
-          get: "widgets/#{widget.id}",
-          response: from_api(widget)
-        )
-        api_stub_for(
-          delete: "/widgets/#{widget.id}",
-          response: from_api(nil)
-        )
-      end
 
-      it_behaves_like "a jpi v1 admin action"
+      context 'when the widget exists' do
+        before do
+          api_stub_for(
+            get: "widgets/#{widget.id}",
+            response: from_api(widget)
+          )
+          api_stub_for(
+            delete: "/widgets/#{widget.id}",
+            response: from_api(nil)
+          )
+        end
+
+        it_behaves_like "a jpi v1 admin action"
+      end
 
-      # api_stub should be modified to allow this case to be stubbed
-      context 'when the widget destruction is invalidunsuccessful' do
-        xit 'spec to be described'
+      context 'when the widget does not exist' do
+        before do
+          api_stub_for(
+            get: "widgets/#{widget.id}",
+            code: 404
+          )
+        end
+
+        it 'returns an error message' do
+          subject
+          expect(JSON.parse(response.body)).to eq({ 'errors' => 'Cannot delete widget' })
+        end
       end
     end
   end