mno-enterprise-api 3.3.1 → 3.3.2

data/spec/controllers/mno_enterprise/jpi/v1/admin/impac/widgets_controller_spec.rb

@@ -0,0 +1,150 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  describe Jpi::V1::Admin::Impac::WidgetsController, type: :controller do
+    # include MnoEnterprise::TestingSupport::JpiV1TestHelper
+    include MnoEnterprise::TestingSupport::SharedExamples::JpiV1Admin
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+
+    let(:user) { build(:user, :admin, :with_organizations) }
+    let(:org) { build(:organization, users: [user]) }
+    let(:template) { build(:impac_dashboard, dashboard_type: 'template') }
+    let(:metadata) { { hist_parameters: { from: '2015-01-01', to: '2015-03-31', period: 'MONTHLY' } } }
+    let(:widget) { build(:impac_widget, dashboard: template, settings: metadata) }
+    let(:kpi) { build(:impac_kpi, widget: widget) }
+
+    let(:hash_for_kpi) do
+      {
+        "id" => kpi.id,
+        "element_watched" => kpi.element_watched,
+        "endpoint" => kpi.endpoint
+      }
+    end
+    let(:hash_for_widget) do
+      {
+        "id" => widget.id,
+        "name" => widget.name,
+        'metadata' => metadata.deep_stringify_keys,
+        "endpoint" => widget.widget_category,
+        "width" => widget.width,
+        "kpis" => [hash_for_kpi]
+      }
+    end
+
+    before do
+      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
+      sign_in user
+    end
+
+    describe '#create' do
+      let(:widget_params) do
+        {
+          endpoint: widget.endpoint,
+          name: widget.name,
+          width: widget.width,
+          metadata: metadata,
+          forbidden: 'param'
+        }
+      end
+
+      subject { post :create, dashboard_template_id: template.id, widget: widget_params }
+      
+      before do
+        api_stub_for(
+          get: "/dashboards/#{template.id}",
+          params: { filter: { 'dashboard_type' => 'template' } },
+          response: from_api(template)
+        )
+        api_stub_for(
+          post: "dashboards/#{template.id}/widgets",
+          response: from_api(widget)
+        )
+        # Why is Her doing a GET /widgets after doing a POST /widgets?
+        api_stub_for(
+          get: "dashboards/#{template.id}/widgets",
+          response: from_api([widget])
+        )
+        api_stub_for(
+          get: "/widgets/#{widget.id}/kpis",
+          response: from_api([kpi])
+        )
+      end
+
+      it_behaves_like "a jpi v1 admin action"
+
+      it 'returns a widget' do
+        subject
+        expect(JSON.parse(response.body)).to eq(hash_for_widget)
+      end
+
+      # api_stub should be modified to allow this case to be stubbed
+      context 'when the template cannot be found' do
+        xit 'spec to be described'
+      end
+    end
+
+    describe '#update' do
+      let(:widget_params) do
+        {
+          name: widget.name,
+          width: widget.width,
+          metadata: metadata,
+          forbidden: 'param'
+        }
+      end
+
+      subject { put :update, id: widget.id, widget: widget_params }
+      
+      before do
+        api_stub_for(
+          get: "widgets/#{widget.id}",
+          response: from_api(widget)
+        )
+        api_stub_for(
+          put: "/widgets/#{widget.id}",
+          response: from_api(widget)
+        )
+        api_stub_for(
+          get: "/widgets/#{widget.id}/kpis",
+          response: from_api([kpi])
+        )
+      end
+
+      it_behaves_like "a jpi v1 admin action"
+
+      it 'returns a widget' do
+        subject
+        expect(JSON.parse(response.body)).to eq(hash_for_widget)
+      end
+
+      # api_stub should be modified to allow this case to be stubbed
+      context 'when the widget update is unsuccessful' do
+        xit 'spec to be described'
+      end
+    end
+
+    describe '#destroy' do
+      subject { delete :destroy, id: widget.id }
+      
+      before do
+        api_stub_for(
+          get: "widgets/#{widget.id}",
+          response: from_api(widget)
+        )
+        api_stub_for(
+          delete: "/widgets/#{widget.id}",
+          response: from_api(nil)
+        )
+      end
+
+      it_behaves_like "a jpi v1 admin action"
+
+      # api_stub should be modified to allow this case to be stubbed
+      context 'when the widget destruction is invalidunsuccessful' do
+        xit 'spec to be described'
+      end
+    end
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/app_feedbacks_controller_spec.rb

@@ -18,7 +18,8 @@ module MnoEnterprise
     let(:app) { build(:app) }
     let(:feedback_comment_1) { build(:app_comment) }
     let(:feedback_comment_2) { build(:app_comment) }
-    let(:app_feedback) { build(:app_feedback, comments: [feedback_comment_1, feedback_comment_2]) }
+    let(:rejected_feedback_comment) { build(:app_comment, status: 'rejected') }
+    let(:app_feedback) { build(:app_feedback, comments: [feedback_comment_1, feedback_comment_2, rejected_feedback_comment]) }
     let(:expected_hash_for_comment_1) do
       attrs = %w(id description status user_id user_name organization_id organization_name app_id feedback_id app_name user_admin_role edited edited_by_name edited_by_admin_role edited_by_id)
       feedback_comment_1.attributes.slice(*attrs).merge({'created_at' => feedback_comment_1.created_at.as_json, 'updated_at' => feedback_comment_1.updated_at.as_json})

data/spec/controllers/mno_enterprise/jpi/v1/app_questions_controller_spec.rb

@@ -18,7 +18,8 @@ module MnoEnterprise
     let(:app) { build(:app) }
     let(:question_answer_1) { build(:app_answer) }
     let(:question_answer_2) { build(:app_answer) }
-    let(:app_question) { build(:app_question, answers: [question_answer_1, question_answer_2]) }
+    let(:rejected_answer) { build(:app_answer, status: 'rejected') }
+    let(:app_question) { build(:app_question, answers: [question_answer_1, question_answer_2, rejected_answer]) }
     let(:expected_hash_for_answer_1) do
       attrs = %w(id description status user_id user_name organization_id organization_name app_id question_id app_name user_admin_role edited edited_by_name edited_by_admin_role edited_by_id)
       question_answer_1.attributes.slice(*attrs).merge({'created_at' => question_answer_1.created_at.as_json, 'updated_at' => question_answer_1.updated_at.as_json})

data/spec/controllers/mno_enterprise/jpi/v1/impac/dashboard_templates_controller_spec.rb

@@ -0,0 +1,97 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  describe MnoEnterprise::Jpi::V1::Impac::DashboardTemplatesController, type: :controller do
+    include MnoEnterprise::TestingSupport::JpiV1TestHelper
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+    before { Rails.cache.clear }
+
+    let(:user) { build(:user, :with_organizations) }
+    let(:org) { build(:organization, users: [user]) }
+    let(:metadata) { { hist_parameters: { from: '2015-01-01', to: '2015-03-31', period: 'MONTHLY' } } }
+    let(:template) { build(:impac_dashboard, dashboard_type: 'template', organization_ids: [org.uid], currency: 'EUR', settings: metadata) }
+    let(:widget) { build(:impac_widget, dashboard: template, owner: user) }
+    let(:d_kpi) { build(:impac_kpi, dashboard: template) }
+    let(:w_kpi) { build(:impac_kpi, widget: widget) }
+
+    def hash_for_kpi(kpi)
+      {
+        "id" => kpi.id,
+        "element_watched" => kpi.element_watched,
+        "endpoint" => kpi.endpoint
+      }
+    end
+    let(:hash_for_widget) do
+      {
+        "id" => widget.id,
+        "name" => widget.name,
+        "endpoint" => widget.widget_category,
+        "width" => widget.width,
+        "kpis" => [hash_for_kpi(w_kpi)],
+        'owner' => from_api(user)[:data]
+      }
+    end
+    let(:hash_for_template) do
+      {
+        "id" => template.id,
+        "name" => template.name,
+        "full_name" => template.full_name,
+        "currency" => 'EUR',
+        "metadata" => metadata.deep_stringify_keys,
+        "data_sources" => [{ "id" => org.id, "uid" => org.uid, "label" => org.name}],
+        "kpis" => [hash_for_kpi(d_kpi)],
+        "widgets" => [hash_for_widget]
+      }
+    end
+
+    before do
+      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
+      sign_in user
+    end
+
+    describe 'GET #index' do
+      subject { get :index }
+      
+      before do
+        api_stub_for(
+          get: '/dashboards',
+          params: { filter: { 'dashboard_type' => 'template', 'published' => true } },
+          response: from_api([template])
+        )
+        api_stub_for(
+          get: "/users/#{user.id}/organizations",
+          response: from_api([org])
+        )
+        api_stub_for(
+          get: "/dashboards/#{template.id}/widgets",
+          response: from_api([widget])
+        )
+        api_stub_for(
+          get: "/dashboards/#{template.id}/kpis",
+          response: from_api([d_kpi])
+        )
+        api_stub_for(
+          get: "/widgets/#{widget.id}/kpis",
+          response: from_api([w_kpi])
+        )
+        api_stub_for(
+          get: "/kpis/#{w_kpi.id}/alerts",
+          response: from_api([])
+        )
+        api_stub_for(
+          get: "/kpis/#{d_kpi.id}/alerts",
+          response: from_api([])
+        )
+      end
+
+      it_behaves_like "jpi v1 protected action"
+
+      it 'returns a list of dashboard templates' do
+        subject
+        expect(JSON.parse(response.body)).to eq([hash_for_template])
+      end
+    end
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/impac/dashboards_controller_spec.rb

@@ -0,0 +1,223 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  describe MnoEnterprise::Jpi::V1::Impac::DashboardsController, type: :controller do
+    include MnoEnterprise::TestingSupport::JpiV1TestHelper
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+    before { Rails.cache.clear }
+
+    RSpec.shared_context "#{described_class}: dashboard dependencies stubs" do
+      before do
+        api_stub_for(
+          get: "/users/#{user.id}/organizations",
+          response: from_api([org])
+        )
+        api_stub_for(
+          get: "/dashboards/#{dashboard.id}/widgets",
+          response: from_api([widget])
+        )
+        api_stub_for(
+          get: "/dashboards/#{dashboard.id}/kpis",
+          response: from_api([d_kpi])
+        )
+        api_stub_for(
+          get: "/widgets/#{widget.id}/kpis",
+          response: from_api([w_kpi])
+        )
+        api_stub_for(
+          get: "/kpis/#{w_kpi.id}/alerts",
+          response: from_api([])
+        )
+        api_stub_for(
+          get: "/kpis/#{d_kpi.id}/alerts",
+          response: from_api([])
+        )
+      end
+    end
+
+    let(:user) { build(:user, :with_organizations) }
+    let(:org) { build(:organization, users: [user]) }
+    let(:metadata) { { hist_parameters: { from: '2015-01-01', to: '2015-03-31', period: 'MONTHLY' } } }
+    let(:dashboard) { build(:impac_dashboard, dashboard_type: 'dashboard', organization_ids: [org.uid], currency: 'EUR', settings: metadata) }
+    let(:widget) { build(:impac_widget, dashboard: dashboard, owner: user) }
+    let(:d_kpi) { build(:impac_kpi, dashboard: dashboard) }
+    let(:w_kpi) { build(:impac_kpi, widget: widget) }
+
+    let(:dashboard_params) do
+      {
+        name: dashboard.name,
+        currency: dashboard.currency,
+        widgets_order: [3, 2, 1],
+        organization_ids: [4, 5],
+        metadata: metadata,
+        forbidden: 'param'
+      }
+    end
+
+    def hash_for_kpi(kpi)
+      {
+        "id" => kpi.id,
+        "element_watched" => kpi.element_watched,
+        "endpoint" => kpi.endpoint
+      }
+    end
+    let(:hash_for_widget) do
+      {
+        "id" => widget.id,
+        "name" => widget.name,
+        "endpoint" => widget.widget_category,
+        "width" => widget.width,
+        "kpis" => [hash_for_kpi(w_kpi)],
+        'owner' => from_api(user)[:data]
+      }
+    end
+    let(:hash_for_dashboard) do
+      {
+        "id" => dashboard.id,
+        "name" => dashboard.name,
+        "full_name" => dashboard.full_name,
+        "currency" => 'EUR',
+        "metadata" => metadata.deep_stringify_keys,
+        "data_sources" => [{ "id" => org.id, "uid" => org.uid, "label" => org.name}],
+        "kpis" => [hash_for_kpi(d_kpi)],
+        "widgets" => [hash_for_widget]
+      }
+    end
+
+    before do
+      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
+      sign_in user
+    end
+
+    describe 'GET #index' do
+      subject { get :index }
+      
+      before do
+        api_stub_for(
+          get: "users/#{user.id}/dashboards",
+          response: from_api([dashboard])
+        )
+      end
+      include_context "#{described_class}: dashboard dependencies stubs"
+
+      it_behaves_like "jpi v1 protected action"
+
+      it 'returns a list of dashboards' do
+        subject
+        expect(JSON.parse(response.body)).to eq([hash_for_dashboard])
+      end
+    end
+
+    describe 'GET #show' do
+      before do
+        api_stub_for(
+          get: "users/#{user.id}/dashboards/#{dashboard.id}",
+          response: from_api(dashboard)
+        )
+      end
+      include_context "#{described_class}: dashboard dependencies stubs"
+
+      subject { get :show, id: dashboard.id }
+
+      it_behaves_like "jpi v1 protected action"
+
+      it 'returns a dashboard' do
+        subject
+        expect(JSON.parse(response.body)).to eq(hash_for_dashboard)
+      end
+    end
+
+    describe 'POST #create' do
+      before do
+        api_stub_for(
+          post: "users/#{user.id}/dashboards",
+          response: from_api(dashboard)
+        )
+        # Her calling GET /dashboards after a POST...
+        api_stub_for(
+          get: "users/#{user.id}/dashboards",
+          response: from_api([dashboard])
+        )
+      end
+      include_context "#{described_class}: dashboard dependencies stubs"
+
+      subject { post :create, user_id: user.id, dashboard: dashboard_params }
+
+      it_behaves_like "jpi v1 protected action"
+
+      it 'returns a dashboard' do
+        subject
+        expect(JSON.parse(response.body)).to eq(hash_for_dashboard)
+      end
+    end
+
+    describe 'PUT #update' do
+      before do
+        api_stub_for(
+          get: "users/#{user.id}/dashboards/#{dashboard.id}",
+          response: from_api(dashboard)
+        )
+        api_stub_for(
+          put: "dashboards/#{dashboard.id}",
+          response: from_api(dashboard)
+        )
+      end
+      include_context "#{described_class}: dashboard dependencies stubs"
+
+      subject { put :update, id: dashboard.id, dashboard: dashboard_params }
+
+      it_behaves_like "jpi v1 protected action"
+
+      it 'returns a dashboard' do
+        subject
+        expect(JSON.parse(response.body)).to eq(hash_for_dashboard)
+      end
+    end
+
+    describe "DELETE destroy" do
+      before do
+        api_stub_for(
+          get: "users/#{user.id}/dashboards/#{dashboard.id}",
+          response: from_api(dashboard)
+        )
+        api_stub_for(
+          delete: "dashboards/#{dashboard.id}",
+          response: from_api(dashboard)
+        )
+      end
+      include_context "#{described_class}: dashboard dependencies stubs"
+
+      subject { delete :destroy, id: dashboard.id }
+      
+      it_behaves_like "jpi v1 protected action"
+    end
+
+    describe 'POST copy' do
+      let(:template) { build(:impac_dashboard, dashboard_type: 'template') }
+
+      before do
+        api_stub_for(
+          get: "/dashboards/#{template.id}",
+          params: { filter: { 'dashboard_type' => 'template' } },
+          response: from_api(template)
+        )
+        api_stub_for(
+          post: "/dashboards/#{template.id}/copy",
+          response: from_api(dashboard)
+        )
+      end
+      include_context "#{described_class}: dashboard dependencies stubs"
+
+      subject { post :copy, id: template.id, dashboard: dashboard_params }
+
+      it_behaves_like "jpi v1 protected action"
+
+      it 'returns a dashboard' do
+        subject
+        expect(JSON.parse(response.body)).to eq(hash_for_dashboard)
+      end
+    end
+  end
+end