mno-enterprise-api 2.0.0

data/spec/controllers/mno_enterprise/jpi/v1/admin/tenant_invoices_controller_spec.rb

@@ -0,0 +1,92 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  describe Jpi::V1::Admin::TenantInvoicesController, type: :controller do
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+
+    def partial_hash_for_tenant_invoices(tenant_invoice)
+      {
+          'id' => tenant_invoice.id,
+          'started_at' => tenant_invoice.started_at,
+          'ended_at' => tenant_invoice.ended_at,
+          'created_at' => tenant_invoice.created_at,
+          'updated_at' => tenant_invoice.updated_at,
+          'slug' => tenant_invoice.slug,
+          'paid_at' => tenant_invoice.paid_at,
+          'total_portfolio_amount' => AccountingjsSerializer.serialize(tenant_invoice.total_portfolio_amount),
+          'total_commission_amount' => AccountingjsSerializer.serialize(tenant_invoice.total_commission_amount),
+          'non_commissionable_amount' => AccountingjsSerializer.serialize(tenant_invoice.non_commissionable_amount)
+      }
+    end
+
+    def partial_hash_for_tenant_invoice(tenant_invoice)
+      {
+          'id' => tenant_invoice.id,
+          'started_at' => tenant_invoice.started_at,
+          'created_at' => tenant_invoice.created_at,
+          'ended_at' => tenant_invoice.ended_at,
+          'updated_at' => tenant_invoice.updated_at,
+          'paid_at' => tenant_invoice.paid_at,
+          'slug' => tenant_invoice.slug
+      }
+    end
+
+    def hash_for_tenant_invoices(tenant_invoices)
+      {
+          'tenant_invoices' => tenant_invoices.map { |o| partial_hash_for_tenant_invoices(o) }
+      }
+
+    end
+
+    def hash_for_tenant_invoice(tenant_invoice)
+      {
+          'tenant_invoice' => partial_hash_for_tenant_invoice(tenant_invoice)
+      }
+    end
+
+    #===============================================
+    # Assignments
+    #===============================================
+    # Stub tenant_invoice and tenant_invoice call
+    let!(:tenant_invoice) { build(:tenant_invoice) }
+    let!(:user) { build(:user, :admin) }
+    before do
+      api_stub_for(get: "/tenant_invoices", response: from_api([tenant_invoice]))
+      api_stub_for(get: "/tenant_invoices/#{tenant_invoice.id}", response: from_api(tenant_invoice))
+      api_stub_for(get: "/users", response: from_api([user]))
+      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
+      sign_in user
+    end
+
+    #===============================================
+    # Specs
+    #===============================================
+    describe '#index' do
+      subject { get :index }
+
+      context 'success' do
+        before { subject }
+
+        it 'returns a list of tenant_invoices' do
+          expect(response).to be_success
+          expect(JSON.parse(response.body)).to eq(JSON.parse(hash_for_tenant_invoices([tenant_invoice]).to_json))
+        end
+      end
+    end
+
+    describe 'GET #show' do
+      subject { get :show, id: tenant_invoice.id }
+
+      context 'success' do
+        before { subject }
+
+        it 'returns a complete description of the tenant_invoice' do
+          expect(response).to be_success
+          expect(JSON.parse(response.body)).to eq(JSON.parse(hash_for_tenant_invoice(tenant_invoice).to_json))
+        end
+      end
+    end
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/admin/users_controller_spec.rb

@@ -0,0 +1,136 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  describe Jpi::V1::Admin::UsersController, type: :controller do
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+
+    def partial_hash_for_organization(user)
+      user.organizations.map do |org|
+        {
+            'id' => org.id,
+            'uid' => org.uid,
+            'name' => org.name,
+            'created_at' => org.created_at
+        }
+      end
+    end
+
+    def partial_hash_for_user(user)
+      {
+          'id' => user.id,
+          'uid' => user.uid,
+          'email' => user.email,
+          'phone' => user.phone,
+          'name' => user.name,
+          'surname' => user.surname,
+          'admin_role' => user.admin_role,
+          'created_at' => user.created_at,
+          'last_sign_in_at' => user.last_sign_in_at,
+          'confirmed_at' => user.confirmed_at,
+          'organizations' => partial_hash_for_organization(user)
+      }
+    end
+
+    def partial_hash_for_users(user)
+      {
+          'id' => user.id,
+          'uid' => user.uid,
+          'email' => user.email,
+          'name' => user.name,
+          'surname' => user.surname,
+          'admin_role' => user.admin_role,
+          'created_at' => user.created_at
+      }
+    end
+
+    def hash_for_users(users)
+      {
+          'users' => users.map { |o| partial_hash_for_users(o) },
+          'metadata' => {'pagination' => {'count' => users.count}}
+      }
+    end
+
+    def hash_for_user(user)
+      hash = {
+          'user' => partial_hash_for_user(user)
+      }
+
+      return hash
+    end
+
+    #===============================================
+    # Assignments
+    #===============================================
+    # Stub user and user call
+    let(:user) { build(:user, :admin, :with_organizations) }
+    before do
+      api_stub_for(get: "/users", response: from_api([user]))
+      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
+      api_stub_for(get: "/users/#{user.id}/organizations", response: from_api(user))
+      sign_in user
+    end
+
+    #==========================
+    # =====================
+    # Specs
+    #===============================================
+    describe '#index' do
+      subject { get :index }
+
+      context 'success' do
+        before { subject }
+
+        it 'returns a list of users' do
+          expect(response).to be_success
+          expect(JSON.parse(response.body)).to eq(JSON.parse(hash_for_users([user]).to_json))
+        end
+      end
+    end
+
+    describe 'GET #show' do
+      subject { get :show, id: user.id }
+
+      context 'success' do
+        before { subject }
+
+        it 'returns a complete description of the user' do
+          expect(response).to be_success
+          expect(JSON.parse(response.body)).to eq(JSON.parse(hash_for_user(user).to_json))
+        end
+      end
+    end
+
+    describe 'PUT #update' do
+      subject { put :update, id: user.id, user: {admin_role: 'staff'} }
+
+      before do
+        api_stub_for(put: "/users/#{user.id}", response: ->{ user.admin_role = 'staff'; from_api(user) })
+        subject
+      end
+
+      it { expect(response).to be_success }
+
+      # Test that the user is updated by testing the api endpoint was called
+      it { expect(user.admin_role).to eq('staff') }
+    end
+
+    describe 'DELETE #destroy' do
+      let(:user_to_delete) { build(:user) }
+      subject { delete :destroy, id: user_to_delete.id }
+
+      before do
+        api_stub_for(get: "/users/#{user_to_delete.id}", respond_with: user_to_delete)
+        api_stub_for(delete: "/users/#{user_to_delete.id}", response: ->{ user_to_delete.name = 'deleted'; from_api(user_to_delete) })
+        subject
+      end
+
+      it { expect(response).to be_success }
+
+      # Test that the user is deleted by testing the api endpoint was called
+      it { expect(user_to_delete.name).to eq('deleted') }
+
+    end
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/app_instances_controller_spec.rb

@@ -0,0 +1,76 @@
+require 'rails_helper'
+
+# TODO: spec AppInstance response
+module MnoEnterprise
+  describe Jpi::V1::AppInstancesController, type: :controller do
+    include MnoEnterprise::TestingSupport::JpiV1TestHelper
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+
+    # Stub ability
+    let!(:ability) { stub_ability }
+    before { allow(ability).to receive(:can?).with(any_args).and_return(true) }
+
+    # Stub user and user call
+    let(:user) { build(:user) }
+    before { api_stub_for(get: "/users/#{user.id}", response: from_api(user)) }
+
+    # Stub organization/app_instance + associations
+    let(:organization) { build(:organization) }
+    let(:app_instance) { build(:app_instance, status: "running") }
+    before { allow_any_instance_of(MnoEnterprise::User).to receive(:organizations).and_return([organization]) }
+    before { allow(organization).to receive(:app_instances).and_return([app_instance]) }
+
+    describe 'GET #index' do
+      before { sign_in user }
+      let(:timestamp) { nil }
+      subject { get :index, organization_id: organization.id, timestamp: timestamp }
+
+      it_behaves_like "jpi v1 protected action"
+
+      describe 'all' do
+        before { subject }
+        it { expect(assigns(:app_instances)).to eq([app_instance]) }
+      end
+
+      describe 'with inactive app_instances' do
+        let(:app_instance) { build(:app_instance, status: "terminated", terminated_at: 10.minutes.ago) }
+        before { subject }
+        it { expect(assigns(:app_instances)).to be_empty }
+      end
+
+      describe 'with no access to the app_instance' do
+        before { allow(ability).to receive(:can?).with(any_args).and_return(false) }
+        before { subject }
+        it { expect(assigns(:app_instances)).to be_empty }
+      end
+
+      describe 'with timestamp' do
+        describe 'before instance updated_at' do
+          let(:timestamp) { (app_instance.updated_at - 2.minutes).to_i }
+          before { subject }
+          it { expect(assigns(:app_instances)).to eq([app_instance]) }
+        end
+
+        describe 'after instance updated_at' do
+          let(:timestamp) { (app_instance.updated_at + 2.minutes).to_i }
+          before { subject }
+          it { expect(assigns(:app_instances)).to be_empty }
+        end
+      end
+    end
+
+    describe 'DELETE #destroy' do
+      let(:app_instance) { build(:app_instance) }
+      before { api_stub_for(get: "/app_instances/#{app_instance.id}", respond_with: app_instance)}
+      before { api_stub_for(delete: "/app_instances/#{app_instance.id}", response: ->{ app_instance.status = 'terminated'; from_api(app_instance) }) }
+      before { sign_in user }
+      subject { delete :destroy, id: app_instance.id }
+
+      it_behaves_like "jpi v1 protected action"
+
+      it { subject; expect(app_instance.status).to eq('terminated')}
+    end
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/app_instances_sync_controller_spec.rb

@@ -0,0 +1,94 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  describe Jpi::V1::AppInstancesSyncController, type: :controller do
+    include MnoEnterprise::TestingSupport::JpiV1TestHelper
+    # include MnoEnterprise::TestingSupport::OrganizationsSharedHelpers
+
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+    
+
+    #===============================================
+    # Assignments
+    #===============================================
+    # Stub controller ability
+    let!(:ability) { stub_ability }
+    before { allow(ability).to receive(:can?).with(any_args).and_return(true) }
+    
+    # Stub user and user call
+    let(:user) { build(:user) }
+    before do
+      api_stub_for(get: "/users/#{user.id}", response: from_api(user))
+      api_stub_for(put: "/users/#{user.id}", response: from_api(user))
+    end
+    before { sign_in user }
+    
+    # Stub organization
+    let(:organization) { build(:organization) }
+    before { allow_any_instance_of(MnoEnterprise::User).to receive(:organizations).and_return([organization]) }
+
+        
+    #===============================================
+    # Specs
+    #===============================================
+    describe 'GET #index' do
+      # App instances
+      let(:app1) { build(:app_instance, owner: organization, status: 'running') }
+      let(:app2) { build(:app_instance, owner: organization, status: 'running') }
+      before { api_stub_for(put: "/app_instances/#{app1.id}", response: from_api(app1)) }
+      before { api_stub_for(put: "/app_instances/#{app2.id}", response: from_api(app2)) }
+      before { app1.save ; app2.save }
+
+      # Apps sync
+      let(:progress_results) { { connectors: [
+        HashWithIndifferentAccess.new({name: 'a_name', status: 'RUNNING', date: nil}),
+        HashWithIndifferentAccess.new({name: 'a_name', status: 'FAILED', date: nil})
+      ] } }
+      before { api_stub_for(get: "/organizations/#{organization.id}/app_instances_sync/anything", response: from_api(progress_results)) }
+
+      subject { get :index, organization_id: organization.uid }
+      
+      it_behaves_like "jpi v1 protected action"
+
+      it "verifies the user's rights" do
+        expect(ability).to receive(:can?).with(:check_apps_sync, organization)
+        subject
+      end
+
+      it "returns the fetched connectors" do
+        subject
+        expect(JSON.parse(response.body)['connectors']).to eq(progress_results[:connectors])
+      end
+
+      context "when a connector is still syncing" do
+        before { subject }
+        it { expect(JSON.parse(response.body)['is_syncing']).to be_truthy }
+      end
+
+      context "when no connector is syncing" do
+        let(:progress_results) { { connectors: [
+          HashWithIndifferentAccess.new({name: 'a_name', status: 'FAILED', date: nil})
+        ] } }
+        before { subject }
+        it { expect(JSON.parse(response.body)['is_syncing']).to be_falsey }
+      end
+    end
+
+    describe "POST #create" do
+      xit "to spec: cannot stub 'post /app_instances_syncs data%5Bmode%5D=a_mode'"
+
+      # # Apps sync
+      # let(:sync_results) { [] }
+      # before { api_stub_for(post: "/app_instances_sync", response: from_api(sync_results)) }
+
+      # subject { post :create, organization_id: organization.uid, mode: 'a_mode', return_url: 'a/random/url' }
+
+      # it "verifies the user's rights" do
+      #   expect(ability).to receive(:can?).with(:sync_apps, organization)
+      #   subject
+      # end
+    end
+  end
+end

data/spec/controllers/mno_enterprise/jpi/v1/current_users_controller_spec.rb

@@ -0,0 +1,128 @@
+require 'rails_helper'
+
+module MnoEnterprise
+  describe Jpi::V1::CurrentUsersController, type: :controller do
+    render_views
+    routes { MnoEnterprise::Engine.routes }
+    before { request.env["HTTP_ACCEPT"] = 'application/json' }
+
+    def json_for(res)
+      json_hash_for(res).to_json
+    end
+
+    def json_hash_for(res)
+      {'current_user' => hash_for(res)}
+    end
+
+    def hash_for(res)
+      hash = {
+          'id' => res.id,
+          'name' => res.name,
+          'surname' => res.surname,
+          'email' => res.email,
+          'logged_in' => !!res.id,
+          'created_at' => res.created_at ? res.created_at.iso8601 : nil,
+          'company' => res.company,
+          'phone' => res.phone,
+          'phone_country_code' => res.phone_country_code,
+          'country_code' => res.geo_country_code || 'US',
+          'website' => res.website,
+          'sso_session' => res.sso_session
+      }
+
+      if res.id
+        hash['admin_role'] = res.admin_role
+        hash['organizations'] = (res.organizations || []).map do |o|
+          {
+              'id' => o.id,
+              'uid' => o.uid,
+              'name' => o.name,
+              'currency' => 'AUD',
+              'current_user_role' => o.role,
+              'has_myob_essentials_only' => o.has_myob_essentials_only?
+          }
+        end
+
+        if res.deletion_request.present?
+          hash['deletion_request'] = {
+              'id' => res.deletion_request.id,
+              'token' => res.deletion_request.token
+          }
+        end
+      end
+
+      hash
+    end
+
+    # Stub user retrieval
+    let!(:user) { build(:user, :with_deletion_request, :with_organizations) }
+    before { api_stub_for(get: "/users/#{user.id}", response: from_api(user)) }
+
+    describe "GET #show" do
+      subject { get :show }
+
+      describe 'guest' do
+        it 'is successful' do
+          subject
+          expect(response).to be_success
+        end
+
+        it 'returns the right response' do
+          subject
+          expect(response.body).to eq(json_for(MnoEnterprise::User.new))
+        end
+      end
+
+      describe 'logged in' do
+        before { sign_in user }
+
+        it 'is successful' do
+          subject
+          expect(response).to be_success
+        end
+
+        it 'returns the right response' do
+          subject
+          expect(response.body).to eq(json_for(user))
+        end
+      end
+    end
+
+    describe 'PUT #update' do
+      let(:attrs) { {name: user.name + 'aaa'} }
+      before { api_stub_for(put: "/users/#{user.id}", response: -> { user.assign_attributes(attrs); from_api(user) }) }
+
+      subject { put :update, user: attrs }
+
+      describe 'guest' do
+        before { subject }
+        it { expect(response).to_not be_success }
+      end
+
+      describe 'logged in' do
+        before { sign_in user }
+        before { subject }
+        it { expect(user.name).to eq(attrs[:name]) }
+      end
+    end
+
+    describe 'PUT #update_password' do
+      let(:attrs) { {current_password: 'password', password: 'blablabla', password_confirmation: 'blablabla'} }
+      before { api_stub_for(put: "/users/#{user.id}", response: from_api(user)) }
+
+      subject { put :update_password, user: attrs }
+
+      describe 'guest' do
+        before { subject }
+        it { expect(response).to_not be_success }
+      end
+
+      describe 'logged in' do
+        before { sign_in user }
+        before { subject }
+        it { expect(response).to be_success }
+        it { expect(controller.current_user).to eq(user) } # check user is re-signed in
+      end
+    end
+  end
+end