mnemosyne-ruby 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 619bd5e8b0c8d56d2d0dd8e2634997f65fd25312
-  data.tar.gz: 501700e283258d8642f1381f1a3a0194ab1e2b43
+  metadata.gz: 3be644845f56d638f37c5bbaab9e17a10cadc24b
+  data.tar.gz: abffc04c98a65ee9e6b24fc3d57fd2d1c53e943a
 SHA512:
-  metadata.gz: 972cc7a4654172aae0196180f011fbbea7dfb94b8e023d39467347122203fae099d64b4bf117c9407100b99a103c48bd73d9ca253b88ef06c5e7f5f288dcddc1
-  data.tar.gz: bd18c3daa03b4e70449c55943be7a62a0a0f16cd354022b52c6002b86d32f25436c5b6ddd22a9e71935337fc7f39977c97e83bbcfd3248cf51593b23bce66914
+  metadata.gz: d242c0b3f668a17253aa1c153f19d902dd0681c49bb4f001390ec6690e72a539a362c45a6f283d0260a8e10a0dc85ce7a2d7d4a230a4d86a659e328da66d7cbb
+  data.tar.gz: 41a21abe608d7ca68c0493ff80929addb7d85c45687b5b24861cfb4295c9b75ce91349957b17c6bc221eaec78df8f218b7f328fddfc04b821a9a3cbf23ca0a82

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.0.1
+
+* Fix issue with `enabled` configuration flag (#1)
+
 ## 1.0.0
 
 * Use semantic versioning

data/lib/mnemosyne.rb

@@ -2,6 +2,7 @@
 require 'mnemosyne/version'
 
 require 'active_support'
+require 'active_support/core_ext/object/blank'
 require 'active_support/notifications'
 
 module Mnemosyne
@@ -12,7 +13,7 @@ module Mnemosyne
   require 'mnemosyne/span'
   require 'mnemosyne/trace'
 
-  require 'mnemosyne/config'
+  require 'mnemosyne/configuration'
   require 'mnemosyne/client'
   require 'mnemosyne/instrumenter'
 

data/lib/mnemosyne/{config.rb → configuration.rb}

@@ -4,7 +4,7 @@ require 'uri'
 require 'cgi'
 
 module Mnemosyne
-  class Config
+  class Configuration
     attr_reader :application
     attr_reader :hostname
     attr_reader :platform
@@ -15,19 +15,19 @@ module Mnemosyne
 
     # rubocop:disable Metrics/AbcSize
     def initialize(config)
-      @platform    = config.fetch('platform', 'default').freeze
-      @application = config.fetch('application').freeze
+      @platform    = config.fetch('platform', 'default').to_s.strip.freeze
+      @application = config.fetch('application', nil).to_s.strip.freeze
       @enabled     = config.fetch('enabled', true)
-      @hostname    = config.fetch('hostname') { default_hostname }.freeze
-      @exchange    = config.fetch('exchange', 'mnemosyne').freeze
+      @hostname    = config.fetch('hostname') { default_hostname }.to_s.strip.freeze
+      @exchange    = config.fetch('exchange', 'mnemosyne').to_s.freeze
       @logger      = config.fetch('logger') { Logger.new($stdout) }
 
       server       = config.fetch('server', 'amqp://localhost')
       @amqp        = AMQ::Settings.configure(server).freeze
-      @server      = make_amqp_uri(@amqp).freeze
+      @server      = make_amqp_uri(@amqp).to_s.freeze
 
-      raise 'Application must be configured' unless application.present?
-      raise 'Hostname must be configured' unless hostname.present?
+      raise ArgumentError.new('Application is required') if application.blank?
+      raise ArgumentError.new('Hostname is required') if hostname.blank?
     end
 
     def enabled?

data/lib/mnemosyne/railtie.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'rails'
 
 module Mnemosyne
@@ -7,11 +8,12 @@ module Mnemosyne
       config = app.config_for('mnemosyne')
 
       config['application'] ||= app.class.name.underscore.titleize
+      config['logger']      ||= Rails.logger
 
-      config['logger']  ||= Rails.logger
-      config['enabled'] ||= config.key?('server')
+      # If server is configured mnemosyne should be enabled by default
+      config['enabled'] = config.key?('server') unless config.key?('enabled')
 
-      config = ::Mnemosyne::Config.new(config)
+      config = ::Mnemosyne::Configuration.new(config)
 
       if config.enabled?
         ::Mnemosyne::Instrumenter.start!(config)

data/lib/mnemosyne/version.rb

@@ -4,7 +4,7 @@ module Mnemosyne
   module VERSION
     MAJOR = 1
     MINOR = 0
-    PATCH = 0
+    PATCH = 1
     STAGE = nil
 
     STRING = [MAJOR, MINOR, PATCH, STAGE].reject(&:nil?).join('.')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mnemosyne-ruby
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Jan Graichen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-03 00:00:00.000000000 Z
+date: 2017-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny
@@ -128,7 +128,7 @@ files:
 - lib/mnemosyne.rb
 - lib/mnemosyne/client.rb
 - lib/mnemosyne/clock.rb
-- lib/mnemosyne/config.rb
+- lib/mnemosyne/configuration.rb
 - lib/mnemosyne/global.rb
 - lib/mnemosyne/instrumenter.rb
 - lib/mnemosyne/middleware/acfs.rb