mms2r 1.0.3 → 1.0.4

data/History.txt

@@ -1,3 +1,11 @@
+== 1.0.4 / 2007-04-09 (Metalocalypse)
+
+* fix teardown in test_mms2r_sprint.rb (shanesbrain.net)
+* clean up Net::HTTP in MMS2R::SprintMedia (shanesbrain.net)
+* added accessor MMS2R::Media.media_dir 
+* fixed a nil issue with underlying tmp working dir
+* added exception handling around Net::HTTP in MMS2R::SprintMedia
+
 == 1.0.3 / 2007-04-05 (Paper Cut)
 
 * Cleaned up packaging and errors in example found by Shane V. http://shanesbrain.net/

data/lib/mms2r/media.rb

@@ -68,7 +68,6 @@ module MMS2R
   }
 
   class MMS2R::Media
-
     ##
     # TMail object that the media files were derived from.
     attr_reader :mail
@@ -86,6 +85,12 @@ module MMS2R
 
     attr_reader :carrier
 
+    ##
+    # Base working dir where media for a unique mms message are
+    # dropped
+
+    attr_reader :media_dir
+
     ##
     # Creates a new Media comprised of a mail
     # a logger.  Logger is an instance attribute allowing
@@ -289,7 +294,7 @@ module MMS2R
         "#{Time.now.to_i}.#{self.class.default_ext(self.class.part_type?(part))}"
     end
 
-    @@tmp_dir = File.join(Dir.tmpdir, ENV['USER'],'mms2r')
+    @@tmp_dir = File.join(Dir.tmpdir, (ENV['USER'].nil? ? '':ENV['USER']), 'mms2r')
 
     ##
     # Get the temporary directory where media files are written to.

data/lib/mms2r/sprint_media.rb

@@ -19,7 +19,6 @@ module MMS2R
     # the URL to the media on Sprint's content server.
 
     def process_media(part)
-      part.base64_decode
       if self.class.part_type?(part).eql?('text/plain')
         file_name = filename?(part)
         type, content = transform_text(part)
@@ -30,19 +29,22 @@ module MMS2R
         img = imgs[2].attributes['src']
         #here's where the content is, now download it
         url = URI.parse(img)
-        req = Net::HTTP::Get.new(url.path)
-        res = Net::HTTP.start(url.host, url.port) {|http|
-          http.request(req)
+        begin
+          res = Net::HTTP.get_response(url)
+          file_name ="#{img.match(/\/RECIPIENT\/([^\/]+)\//)[1]}.#{self.class.default_ext(res.content_type)}"
+          type = res.content_type
+          content = res.body
+        rescue
+          @logger.error("#{self.class} processing error, #{$!}") unless @logger.nil?
+        end
+      end
+      unless type.nil?
+        file = File.join(msg_tmp_dir(),file_name)
+        @logger.info("#{self.class} writing file #{file}") unless @logger.nil?
+        File.open(file,'w'){ |f|
+          f.write(content)
         }
-        file_name ="#{img.match(/\/RECIPIENT\/([^\/]+)\//)[1]}.#{self.class.default_ext(res.content_type)}"
-        type = res.content_type
-        content = res.body
       end
-      file = File.join(msg_tmp_dir(),file_name)
-      @logger.info("#{self.class} writing file #{file}") unless @logger.nil?
-      File.open(file,'w'){ |f|
-        f.write(content)
-      }
       return type, file
     end
   end

data/lib/mms2r/version.rb

@@ -6,7 +6,7 @@ module MMS2R
     ##
     # MMS2R Library version
 
-    VERSION = '1.0.3'
+    VERSION = '1.0.4'
 
   end
 end

data/test/test_mms2r_sprint.rb

@@ -95,7 +95,7 @@ class MMS2RSprintTest < Test::Unit::TestCase
     @log.datetime_format = "%H:%M:%S"
   end
 
-  def teadown; end
+  def teardown; end
 
   def test_simple_video
     mail = TMail::Mail.parse(load_mail('sprint-video-01.mail').join)

metadata

@@ -1,10 +1,10 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.0
+rubygems_version: 0.9.2
 specification_version: 1
 name: mms2r
 version: !ruby/object:Gem::Version 
-  version: 1.0.3
-date: 2007-04-05 00:00:00 -07:00
+  version: 1.0.4
+date: 2007-04-10 00:00:00 -07:00
 summary: Extract media from MMS
 require_paths: 
 - lib