mlist 0.1.17 → 0.1.18

data/CHANGELOG

@@ -1,3 +1,7 @@
+*0.1.18 [Enhancement] (2010-06-11)
+
+* Moving mail that has no rfc822 content into a settings[:failure_folder], if that setting is provided. [aiwilliams]
+
 *0.1.17 [Bug Fix] (2010-05-04)
 
 * Fixed bug where rfc822 was missing. [mikehale]

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
+:patch: 18
 :major: 0
 :build: 
 :minor: 1
-:patch: 17

data/lib/mlist/email_server/imap.rb

@@ -58,6 +58,13 @@ module MList
         if rfc822 = @imap.fetch(id, 'RFC822')
           content = rfc822[0].attr['RFC822']
           process_message(content)
+        elsif settings[:failure_folder]
+          begin
+            @imap.move(id, settings[:failure_folder])
+          rescue Net::IMAP::NoResponseError
+            @imap.create(settings[:failure_folder])
+            retry
+          end
         end
       end
 

data/spec/integration/imap_email_server_spec.rb

@@ -26,11 +26,14 @@ end
 describe MList::EmailServer::Imap, 'processing' do
   before do
     @imap_server = 'mock_imap_server'
-    @imap = MList::EmailServer::Imap.new({:archive_folder => 'Archive'})
+    @imap = MList::EmailServer::Imap.new({
+      :archive_folder => 'Archive',
+      :failure_folder => 'Failures'
+    })
     @imap.instance_variable_set('@imap', @imap_server)
   end
 
-  it 'should process the provided folders' do
+  it 'should process the provided source folders' do
     imap = MList::EmailServer::Imap.new(:source_folders => ['Inbox', 'Spam'])
     mock(imap).process_folder('Inbox')
     mock(imap).process_folder('Spam')
@@ -55,9 +58,10 @@ describe MList::EmailServer::Imap, 'processing' do
     @imap.process_message_id(1)
   end
 
-  it 'should not blow up if an RFC822 does not exist' do
+  it 'should not receive messages with no RFC822 content, moving them to the failure folder' do
     mock(@imap_server).fetch(1, 'RFC822') { nil }
-    lambda { @imap.process_message_id(1) }.should_not raise_error
+    mock(@imap_server).move(1, 'Failures')
+    @imap.process_message_id(1)
   end
 
   it 'should wrap up RFC822 content in a TMail::Mail object' do

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 17
-  version: 0.1.17
+  - 18
+  version: 0.1.18
 platform: ruby
 authors: 
 - Adam Williams
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-05-04 00:00:00 -04:00
+date: 2010-06-11 00:00:00 -04:00
 default_executable: 
 dependencies: []